Re: [PR] [VL] Use MemConfig to replace MemConfigMutable, which makes the code cleaner and may also lead to some performance improvements. [incubator-gluten]

2024-05-17 Thread via GitHub
kecookier commented on PR #5784: URL: https://github.com/apache/incubator-gluten/pull/5784#issuecomment-2117088979 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Use MemConfig to replace MemConfigMutable, which makes the code cleaner and may also lead to some performance improvements. [incubator-gluten]

2024-05-17 Thread via GitHub
kecookier commented on PR #5784: URL: https://github.com/apache/incubator-gluten/pull/5784#issuecomment-2117085647 Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] Use MemConfig to replace MemConfigMutable, which makes the code cleaner and may also lead to some performance improvements. [incubator-gluten]

2024-05-17 Thread via GitHub
zhztheplayer merged PR #5784: URL: https://github.com/apache/incubator-gluten/pull/5784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Use MemConfig to replace MemConfigMutable, which makes the code cleaner and may also lead to some performance improvements. [incubator-gluten]

2024-05-16 Thread via GitHub
kecookier commented on PR #5784: URL: https://github.com/apache/incubator-gluten/pull/5784#issuecomment-2116574343 @zuochunwei @zhztheplayer @Yohahaha Could you help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Use MemConfig to replace MemConfigMutable, which makes the code cleaner and may also lead to some performance improvements. [incubator-gluten]

2024-05-16 Thread via GitHub
github-actions[bot] commented on PR #5784: URL: https://github.com/apache/incubator-gluten/pull/5784#issuecomment-2116541000 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Use MemConfig to replace MemConfigMutable, which makes the code cleaner and may also lead to some performance improvements. [incubator-gluten]

2024-05-16 Thread via GitHub
kecookier opened a new pull request, #5784: URL: https://github.com/apache/incubator-gluten/pull/5784 ## What changes were proposed in this pull request? Currently, in the Gluten code, once `velox::core::MemConfigMutable` is initialized, the key-value pairs are not modified anymore. This