Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
GlutenPerfBot commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1996250303 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
ulysses-you merged PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1994023507 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
ulysses-you commented on code in PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522917510 ## .github/workflows/velox_be.yml: ## @@ -670,3 +673,12 @@ jobs: if: ${{ always() }} run: |

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
zwangsheng commented on code in PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522894498 ## .github/workflows/velox_be.yml: ## @@ -670,3 +673,12 @@ jobs: if: ${{ always() }} run: |

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
zwangsheng commented on code in PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522886017 ## .github/workflows/velox_be.yml: ## @@ -670,3 +673,12 @@ jobs: if: ${{ always() }} run: |

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
zwangsheng commented on code in PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522886017 ## .github/workflows/velox_be.yml: ## @@ -670,3 +673,12 @@ jobs: if: ${{ always() }} run: |

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
ulysses-you commented on code in PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1522880119 ## .github/workflows/velox_be.yml: ## @@ -670,3 +673,12 @@ jobs: if: ${{ always() }} run: |

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-13 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993745024 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub
zwangsheng commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993329577 Thanks for both @ulysses-you @PHILO-HE, i will revert this commit to focus on Spark 34 Golden Files, after some test, will turn this PR ready. -- This is an automated

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993323947 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub
ulysses-you commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993313046 I'm fine to seperate pr. @PHILO-HE IIUC the current action should work, just some code cleanup leave to another pr. -- This is an automated message from the Apache

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub
PHILO-HE commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993302181 > > @zwangsheng is there any block on this pr ? > > I'm still testing merge upload step. But IMO, we can leave merge step job in the following PR. WDYT @ulysses-you

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub
zwangsheng commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993232921 > @zwangsheng is there any block on this pr ? I'm still testing merge upload step. But IMO, we can leave merge step job in the following PR. WDYT @ulysses-you

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-12 Thread via GitHub
ulysses-you commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1993175055 @zwangsheng is there any block on this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987985713 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987974001 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987746116 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-10 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987668681 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-10 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987580373 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-10 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1987498140 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-08 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1985442505 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-08 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1985439736 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1985214696 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub
zwangsheng commented on code in PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1517189310 ## .github/workflows/velox_be.yml: ## @@ -631,3 +616,17 @@ jobs: if: ${{ always() }} run: |

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1985071173 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub
ulysses-you commented on code in PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1517122862 ## .github/workflows/velox_be.yml: ## @@ -631,3 +616,17 @@ jobs: if: ${{ always() }} run: |

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub
ulysses-you commented on code in PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#discussion_r1517122717 ## .github/workflows/velox_be.yml: ## @@ -631,3 +616,17 @@ jobs: if: ${{ always() }} run: |

Re: [PR] [GLUTEN-4827][UT] Add Golden Files for TPC-H Spark34 + Gluten Execution Plan [incubator-gluten]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #4828: URL: https://github.com/apache/incubator-gluten/pull/4828#issuecomment-1984956120 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to