Re: [PR] Move memory off-heap conf checks to driver plugin [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5128: URL: https://github.com/apache/incubator-gluten/pull/5128#issuecomment-2020010712 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Move memory off-heap conf checks to driver plugin [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5128: URL: https://github.com/apache/incubator-gluten/pull/5128#issuecomment-2020010044 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538964666 ## .github/workflows/velox_docker.yml: ## @@ -155,32 +146,39 @@ jobs: name: velox-native-lib-${{github.sha}} path:

[PR] [VL](WIP) Support native UDAF [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma opened a new pull request, #5130: URL: https://github.com/apache/incubator-gluten/pull/5130 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL](WIP) Support native UDAF [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5130: URL: https://github.com/apache/incubator-gluten/pull/5130#issuecomment-2020090416 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-4884][VL] Call getPartitions once in WholeStageTransformer [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #4885: URL: https://github.com/apache/incubator-gluten/pull/4885#issuecomment-2019916469 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_26) [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma merged PR #5115: URL: https://github.com/apache/incubator-gluten/pull/5115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538961770 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven

Re: [PR] [CORE] Move BackendBuildInfo case class from GlutenPlugin to Backend class file [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5129: URL: https://github.com/apache/incubator-gluten/pull/5129#issuecomment-2020078075 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5127: URL: https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2019848724 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer opened a new pull request, #5127: URL: https://github.com/apache/incubator-gluten/pull/5127 For the background of this, please refer to https://github.com/apache/incubator-gluten/blob/main/docs/velox-backend-troubleshooting.md#fatal-error-after-native-exception-is-thrown

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019885042 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019918106 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Supports register udf with different signatures [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma merged PR #5104: URL: https://github.com/apache/incubator-gluten/pull/5104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated (8aefd875e -> eb047b0f6)

2024-03-26 Thread marong
This is an automated email from the ASF dual-hosted git repository. marong pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 8aefd875e [VL] Daily Update Velox Version (2024_03_26) (#5115) add eb047b0f6 [VL] Supports register udf

Re: [PR] [CORE] Move BackendBuildInfo case class from GlutenPlugin to Backend class file [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5129: URL: https://github.com/apache/incubator-gluten/pull/5129#issuecomment-2020078525 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [CORE] Move BackendBuildInfo case class from GlutenPlugin to Backend class file [incubator-gluten]

2024-03-26 Thread via GitHub
wForget opened a new pull request, #5129: URL: https://github.com/apache/incubator-gluten/pull/5129 ## What changes were proposed in this pull request? The `BackendBuildInfo` case class seemed more appropriate in `Backend` class file, so I moved it. ## How was this patch

(incubator-gluten) branch main updated: [MINOR] Remove redundant string format (#5126)

2024-03-26 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new dba4bcd3c [MINOR] Remove redundant

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2020149678 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2020149985 cc @zhztheplayer @zhouyuan @PHILO-HE if you have other comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2019889392 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2020007086 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [MINOR] Remove redundant string format [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you merged PR #5126: URL: https://github.com/apache/incubator-gluten/pull/5126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-26 Thread via GitHub
zzcclp commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2020336897 It seems there are some `SPARK-36830: Support reading and writing ANSI intervals` which are not disable for the spark 3.3 -- This is an automated message from the Apache Git

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020372832 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020388375 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1539216963 ## .github/workflows/velox_docker.yml: ## @@ -73,6 +73,17 @@ jobs: matrix: os: ["ubuntu:20.04", "ubuntu:22.04"] spark: ["spark-3.2",

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2020416623 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL][MINOR] Refactor operator/function validation tests (#5037)

2024-03-26 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new adf0566a2 [VL][MINOR] Refactor

Re: [PR] [VL][MINOR] Refactor operator/function tests [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE merged PR #5037: URL: https://github.com/apache/incubator-gluten/pull/5037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL][CI] Enable Celeborn tests & Gluten CPP tests [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5114: URL: https://github.com/apache/incubator-gluten/pull/5114#issuecomment-2020420744 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]

2024-03-26 Thread via GitHub
rui-mo commented on code in PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#discussion_r1539108319 ## ep/build-velox/src/get_velox.sh: ## @@ -16,8 +16,8 @@ set -exu -VELOX_REPO=https://github.com/oap-project/velox.git -VELOX_BRANCH=2024_03_25

Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#issuecomment-2020340206 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1539159436 ## .github/workflows/velox_docker.yml: ## @@ -84,69 +95,49 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven run: |

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020371865 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020391322 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] spark.read.csv("/tmp/test.csv") throws Exception [incubator-gluten]

2024-03-26 Thread via GitHub
xumingming commented on issue #5044: URL: https://github.com/apache/incubator-gluten/issues/5044#issuecomment-2020579428 @PHILO-HE Thanks for the information! I tried with parquet data(nation table in TPCH), the details are the following: ``` == Fallback Summary == (4)

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2020688726 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-03-26 Thread via GitHub
supermem613 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2020700016 I'd like to pick up base64 and unbase64, please. (FYI, looks like there was a PR above for unbase64, but it seems to have been closed without committing ~45-55

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020597809 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

<    1   2