Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533286761 ## gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboGroup.scala: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533285973 ## gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboConfig.scala: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533285973 ## gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboConfig.scala: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [VL] spark url_decode function support [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2011275255 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533284131 ## gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [GLUTEN-4917][VL] Refactor CI to build spark.test.home when running UTs [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-2011273742 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533284131 ## gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533282556 ## gluten-cbo/common/src/main/scala/io/glutenproject/cbo/Cbo.scala: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [VL] spark url_decode function support [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2011270366 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533281959 ## gluten-cbo/common/src/main/scala/io/glutenproject/cbo/Cbo.scala: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [VL] spark url decode function support [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2011270148 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533281959 ## gluten-cbo/common/src/main/scala/io/glutenproject/cbo/Cbo.scala: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on code in PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533281350 ## .github/workflows/velox_be.yml: ## @@ -450,6 +450,16 @@ jobs: --local --preset=velox --benchmark-type=h --error-on-memleak

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011266413 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2011262778 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4675][CH] Support write mergetree to s3 [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4676: URL: https://github.com/apache/incubator-gluten/pull/4676#issuecomment-2011261106 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011252200 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2011248745 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Enable bit_length Spark function [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5069: URL: https://github.com/apache/incubator-gluten/pull/5069#issuecomment-2011246737 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Enable bit_length Spark function [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5069: URL: https://github.com/apache/incubator-gluten/pull/5069#issuecomment-2011244293 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix bug where session config is lost when benchmark is enabled [incubator-gluten]

2024-03-20 Thread via GitHub
GlutenPerfBot commented on PR #5054: URL: https://github.com/apache/incubator-gluten/pull/5054#issuecomment-2011244056 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Enable bit_length Spark function [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5069: URL: https://github.com/apache/incubator-gluten/pull/5069#issuecomment-2011244100 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Enable bit_length Spark function [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE opened a new pull request, #5069: URL: https://github.com/apache/incubator-gluten/pull/5069 ## How was this patch tested? A test added & the imported Spark tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5061][CH] Fix assert error when writing mergetree data with select * from table limit n [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5068: URL: https://github.com/apache/incubator-gluten/pull/5068#issuecomment-2011240455 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5061][CH] Fix assert error when writing mergetree data with select * from table limit n [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5068: URL: https://github.com/apache/incubator-gluten/pull/5068#issuecomment-2011240227 https://github.com/apache/incubator-gluten/issues/5061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5061][CH] Fix assert error when writing mergetree data with select * from table limit n [incubator-gluten]

2024-03-20 Thread via GitHub
zzcclp opened a new pull request, #5068: URL: https://github.com/apache/incubator-gluten/pull/5068 ## What changes were proposed in this pull request? The below writing mergetree data sql will throw the assert error: ``` insert into table lineitem_mergetree select * from

Re: [PR] [VL] Not fallback for function spark_partition_id and monotonically_increasing_id [incubator-gluten]

2024-03-20 Thread via GitHub
gaoyangxiaozhu commented on PR #5046: URL: https://github.com/apache/incubator-gluten/pull/5046#issuecomment-2011235388 > Can you also help to add input_file_name() function? It's very useful for debug purpose. acked -- This is an automated message from the Apache Git Service. To

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2011229184 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2011228457 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011228018 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2011225244 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011222339 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2011220260 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2011215694 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011209005 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011206379 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix bug where session config is lost when benchmark is enabled [incubator-gluten]

2024-03-20 Thread via GitHub
FelixYBW merged PR #5054: URL: https://github.com/apache/incubator-gluten/pull/5054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Fix bug where session config is lost when benchmark is enabled (#5054)

2024-03-20 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new e317e4d5d [VL] Fix bug where session

Re: [PR] [GLUTEN-5060][CH] Remove unnecessary FilterExec execution when querying from MergeTree with the prewhere [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5067: URL: https://github.com/apache/incubator-gluten/pull/5067#issuecomment-2011188528 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5060][CH] Remove unnecessary FilterExec execution when querying from MergeTree with the prewhere [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5067: URL: https://github.com/apache/incubator-gluten/pull/5067#issuecomment-2011188407 https://github.com/apache/incubator-gluten/issues/5060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-4675][CH] Support write mergetree to s3 [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4676: URL: https://github.com/apache/incubator-gluten/pull/4676#issuecomment-2011184700 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2011182191 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240321) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5055: URL: https://github.com/apache/incubator-gluten/pull/5055#issuecomment-2011181892 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [CH][Minor] Fix build due to Clickhouse Refactor (#5059)

2024-03-20 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new e621e52a2 [CH][Minor] Fix build due to

Re: [PR] [CH][Minor] Fix build due to Clickhouse Refactor [incubator-gluten]

2024-03-20 Thread via GitHub
baibaichen merged PR #5059: URL: https://github.com/apache/incubator-gluten/pull/5059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Pullout pre-project for ExpandExec [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5066: URL: https://github.com/apache/incubator-gluten/pull/5066#issuecomment-2011175332 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Pullout pre-project for ExpandExec [incubator-gluten]

2024-03-20 Thread via GitHub
liujiayi771 opened a new pull request, #5066: URL: https://github.com/apache/incubator-gluten/pull/5066 ## What changes were proposed in this pull request? Support pullout pre-project for ExpandExec. ## How was this patch tested? N/A -- This is an automated

Re: [PR] [CORE] Pullout pre-project for ExpandExec [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5066: URL: https://github.com/apache/incubator-gluten/pull/5066#issuecomment-2011175501 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DOC] Remove arrow version setting with 11.0.0-gluten [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on PR #5065: URL: https://github.com/apache/incubator-gluten/pull/5065#issuecomment-2011173131 Assuming Gluten's dependency on 11.0.0-gluten was depreciated long time ago, this pr is simply removing it. @zhztheplayer, could you help review? Thanks! -- This is an

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011169296 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [DOC] Remove 11.0.0-gluten set for arrow version [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE opened a new pull request, #5065: URL: https://github.com/apache/incubator-gluten/pull/5065 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [DOC] Remove 11.0.0-gluten set for arrow version [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5065: URL: https://github.com/apache/incubator-gluten/pull/5065#issuecomment-2011168904 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2011163819 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4956][CH] Fix parsing string with blank prefix/suffix to number [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5022: URL: https://github.com/apache/incubator-gluten/pull/5022#issuecomment-2011163630 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011163149 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_21) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5064: URL: https://github.com/apache/incubator-gluten/pull/5064#issuecomment-2011161632 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_03_21) [incubator-gluten]

2024-03-20 Thread via GitHub
GlutenPerfBot opened a new pull request, #5064: URL: https://github.com/apache/incubator-gluten/pull/5064 Upstream Velox's New Commits: ```txt 64f9618c3 by Wei He, Fix exception thrown in custom result verifier in WindowFuzzer (9189) 3db2a9ad8 by Nicholas Ormrod, Deshim

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2011158227 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2011158088 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-5049][CH] Clean code in substring function parser and fix s3 building issue(#5050)

2024-03-20 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 171601b97 [GLUTEN-5049][CH] Clean code

Re: [I] [CH] Remove useless codes in substring function parser and fix s3 building issue [incubator-gluten]

2024-03-20 Thread via GitHub
baibaichen closed issue #5049: [CH] Remove useless codes in substring function parser and fix s3 building issue URL: https://github.com/apache/incubator-gluten/issues/5049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [GLUTEN-5049][CH] Clean code in substring function parser and fix s3 building issue [incubator-gluten]

2024-03-20 Thread via GitHub
baibaichen merged PR #5050: URL: https://github.com/apache/incubator-gluten/pull/5050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL][DNM]Test Q95 post probe spill [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5063: URL: https://github.com/apache/incubator-gluten/pull/5063#issuecomment-2011098667 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][DNM]Test Q95 post probe spill [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5063: URL: https://github.com/apache/incubator-gluten/pull/5063#issuecomment-2011098530 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][DNM]Test Q95 post probe spill [incubator-gluten]

2024-03-20 Thread via GitHub
JkSelf opened a new pull request, #5063: URL: https://github.com/apache/incubator-gluten/pull/5063 ## What changes were proposed in this pull request? Test whether post probe join spill work with velox newly spill related commits. ## How was this patch tested? Turn on

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2011097856 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011095509 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH][Minor] Fix build due to Clickhouse Refactor [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5059: URL: https://github.com/apache/incubator-gluten/pull/5059#issuecomment-2011045236 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [CH] Remove unnecessary FilterExec execution when querying from MergeTree with the prewhere [incubator-gluten]

2024-03-20 Thread via GitHub
zzcclp opened a new issue, #5060: URL: https://github.com/apache/incubator-gluten/issues/5060 ### Backend CH (ClickHouse) ### Bug description When querying from MergeTree with the prewhere, all the filters will be pushdowned to the ScanExec, so it does not need to

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

2024-03-20 Thread via GitHub
WangGuangxin commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2011045153 > this yes, we should merge to upsteam first before merge this PR -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [WIP] Upload build library [incubator-gluten]

2024-03-20 Thread via GitHub
wangyum commented on PR #5056: URL: https://github.com/apache/incubator-gluten/pull/5056#issuecomment-2011043112 ``` Error: Failed to CreateArtifact: Unable to make request: ECONNRESET If you are using self-hosted runners, please make sure your runner has access to all GitHub

Re: [PR] [CORE] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
ulysses-you commented on code in PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#discussion_r1533139052 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -659,4 +659,14 @@ class SparkPlanExecApiImpl extends

Re: [PR] [GLUTEN-4213][CORE] Refactoring insertion process of pre/post projection [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] closed pull request #4245: [GLUTEN-4213][CORE] Refactoring insertion process of pre/post projection URL: https://github.com/apache/incubator-gluten/pull/4245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [GLUTEN-4213][CORE] Refactoring insertion process of pre/post projection [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4245: URL: https://github.com/apache/incubator-gluten/pull/4245#issuecomment-2011032871 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [GLUTEN-4483][CH]Improve divide [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] closed pull request #4484: [GLUTEN-4483][CH]Improve divide URL: https://github.com/apache/incubator-gluten/pull/4484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-4483][CH]Improve divide [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4484: URL: https://github.com/apache/incubator-gluten/pull/4484#issuecomment-2011032836 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240125) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] closed pull request #4511: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240125) URL: https://github.com/apache/incubator-gluten/pull/4511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240125) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4511: URL: https://github.com/apache/incubator-gluten/pull/4511#issuecomment-2011032819 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2011029672 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM] Velox test [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929#issuecomment-2011023998 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) [incubator-gluten]

2024-03-20 Thread via GitHub
baibaichen closed pull request #5040: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240320) URL: https://github.com/apache/incubator-gluten/pull/5040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
loudongfeng commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2011022082 CI failures unrelated. Ready for review. @zzcclp thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011021726 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011020568 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH][Minor] Fix build due to Clickhouse Refactor [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5059: URL: https://github.com/apache/incubator-gluten/pull/5059#issuecomment-2011020352 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH][Minor] Fix build due to https://github.com/ClickHouse/ClickHouse/pull/61604 [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5059: URL: https://github.com/apache/incubator-gluten/pull/5059#issuecomment-2011020211 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
liujiayi771 commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2011019082 @marin-ma LGTM. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240321) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5055: URL: https://github.com/apache/incubator-gluten/pull/5055#issuecomment-2011012709 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011012096 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011010259 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011010109 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer opened a new pull request, #5058: URL: https://github.com/apache/incubator-gluten/pull/5058 See proposal https://github.com/apache/incubator-gluten/issues/5057 This is the first runnable version of ACBO with TPCH SF 1.0 and TPCDS 10.0 passed. After this patch, one

Re: [PR] [WIP] Pullout pre/post project for generate [incubator-gluten]

2024-03-20 Thread via GitHub
ulysses-you commented on PR #4952: URL: https://github.com/apache/incubator-gluten/pull/4952#issuecomment-2011006314 It seems the failed tests are irrelevant, I tried to re-run the failed tests. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-4889][VL] Support approx_percentile [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on PR #5007: URL: https://github.com/apache/incubator-gluten/pull/5007#issuecomment-2010990615 Hi @WangGuangxin so the current plan is to merge https://github.com/WangGuangxin/gluten/commit/97db869a56e8d42c0782e4e8218e1937e40682ce to upstream Velox before this ? Am

Re: [PR] [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to run single step [incubator-gluten]

2024-03-20 Thread via GitHub
zhztheplayer commented on PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010986896 Thanks @xumingming for the enhancement. > can you add one flag like -Dfetch_velox=ON/OFF which can fetch velox or not before build? by default let's set it ON.

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on code in PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#discussion_r1533098874 ## cpp/velox/substrait/VeloxSubstraitSignature.cc: ## @@ -159,16 +151,43 @@ TypePtr VeloxSubstraitSignature::fromSubstraitSignature(const std::string& signa

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2010974653 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2010964281 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2010956869 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-4933][VL] Update iceberg version to 1.4.3 for Spark 3.4 and above (#4967)

2024-03-20 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 0f5716f91 [GLUTEN-4933][VL] Update

  1   2   3   >