Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2014402300 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-03-21 Thread via GitHub
yma11 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2014391482 @PHILO-HE I would like to take `map_filter`. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-2014385108 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-21 Thread via GitHub
zhztheplayer commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2014381419 Verified locally with Celeborn 0.4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-21 Thread via GitHub
zhouyuan commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2014379672 @zhztheplayer @baibaichen do we still need this "preferColumnar" rule? can we remove this feature? Thanks, -yuan -- This is an automated message from the Apache

(incubator-gluten) branch main updated: [GLUTEN-5016][CH] fix simple aggregation sql exchange fallback (#5042)

2024-03-21 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 0702eb8f7 [GLUTEN-5016][CH] fix simple

Re: [I] [CH] Exchange fallback in simple aggregation sql [incubator-gluten]

2024-03-21 Thread via GitHub
baibaichen closed issue #5016: [CH] Exchange fallback in simple aggregation sql URL: https://github.com/apache/incubator-gluten/issues/5016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-21 Thread via GitHub
baibaichen merged PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-03-21 Thread via GitHub
mskapilks commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2014344838 > I would like to work on `bool_and`, `bool_or` These are already supported it seems. All `bool_and`, `bool_or`, `every`, `some` get converted to min, max of bool

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2014328245 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
zhouyuan commented on code in PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#discussion_r1535019822 ## .github/workflows/velox_docker.yml: ## @@ -0,0 +1,314 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2014307347 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2014305650 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
marin-ma commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1534994137 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { // Get

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
kecookier commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1534992522 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { //

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
kecookier commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1534992690 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { //

Re: [PR] [GLUTEN-4997][CH]Fix year diff [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5079: URL: https://github.com/apache/incubator-gluten/pull/5079#issuecomment-2014271903 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
marin-ma commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1534990803 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { // Get

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
marin-ma commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1534990188 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { // Get

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE commented on code in PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#discussion_r1534985823 ## backends-velox/src/test/scala/io/glutenproject/execution/VeloxFunctionsValidateSuite.scala: ## @@ -513,6 +513,31 @@ class VeloxFunctionsValidateSuite

Re: [PR] [GLUTEN-4997][CH]Fix year diff [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5079: URL: https://github.com/apache/incubator-gluten/pull/5079#issuecomment-2014265940 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5039][VL] Add support for AppleClang compiler [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5053: URL: https://github.com/apache/incubator-gluten/pull/5053#issuecomment-2014255075 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4997][CH]Fix year diff [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5079: URL: https://github.com/apache/incubator-gluten/pull/5079#issuecomment-2014254297 https://github.com/apache/incubator-gluten/issues/4997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4997][CH]Fix year diff [incubator-gluten]

2024-03-21 Thread via GitHub
KevinyhZou opened a new pull request, #5079: URL: https://github.com/apache/incubator-gluten/pull/5079 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) (Fixes: \#4997) ## How was this patch tested? TEST BY UIT --

Re: [PR] [GLUTEN-4997][CH]Fix year diff [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5079: URL: https://github.com/apache/incubator-gluten/pull/5079#issuecomment-2014254774 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL] Remove docs about threshold-based spill

2024-03-21 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 201f322b0 [VL] Remove docs about

Re: [PR] [VL] Remove docs about threshold-based spill [incubator-gluten]

2024-03-21 Thread via GitHub
zhztheplayer merged PR #5078: URL: https://github.com/apache/incubator-gluten/pull/5078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2014214672 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add support for Spark url_decode function [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2014214223 cc @jackylee-ch to note this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [VL] spark url_decode function support [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE commented on code in PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#discussion_r1534966031 ## gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala: ## @@ -115,6 +116,16 @@ object ExpressionConverter extends SQLConfHelper

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2014196489 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4675][CH] Support write mergetree to s3 [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4676: URL: https://github.com/apache/incubator-gluten/pull/4676#issuecomment-2014193600 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] spark url_decode function support [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2014192706 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5016][CH] Fix exchange fallback in simple aggregation sql if spark.gluten.sql.columnar.preferColumnar=false [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5042: URL: https://github.com/apache/incubator-gluten/pull/5042#issuecomment-2014191909 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Remove docs about threshold-based spill [incubator-gluten]

2024-03-21 Thread via GitHub
zhztheplayer commented on PR #5078: URL: https://github.com/apache/incubator-gluten/pull/5078#issuecomment-2014179114 @yma11 thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Remove docs about threshold-based spill [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5078: URL: https://github.com/apache/incubator-gluten/pull/5078#issuecomment-2014179054 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Remove docs about threshold-based spill [incubator-gluten]

2024-03-21 Thread via GitHub
zhztheplayer opened a new pull request, #5078: URL: https://github.com/apache/incubator-gluten/pull/5078 Since Velox has removed these options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2014177120 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-21 Thread via GitHub
zhztheplayer commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2014174950 Guys, since the change is not affecting current code path unless `spark.gluten.sql.advanced.cbo.enabled=true` I am preparing to merge this after CI passed, to ease the

Re: [PR] [VL] spark url_decode function support [incubator-gluten]

2024-03-21 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#discussion_r1534942703 ## backends-velox/src/test/scala/io/glutenproject/execution/VeloxFunctionsValidateSuite.scala: ## @@ -458,6 +458,21 @@ class

Re: [I] [VL] Boost.Stacktrace requires `_Unwind_Backtrace` function [incubator-gluten]

2024-03-21 Thread via GitHub
xumingming closed issue #5028: [VL] Boost.Stacktrace requires `_Unwind_Backtrace` function URL: https://github.com/apache/incubator-gluten/issues/5028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [VL] Boost.Stacktrace requires `_Unwind_Backtrace` function [incubator-gluten]

2024-03-21 Thread via GitHub
xumingming commented on issue #5028: URL: https://github.com/apache/incubator-gluten/issues/5028#issuecomment-2014172623 Closing this, it is fixed by https://github.com/apache/incubator-gluten/pull/5053 -- This is an automated message from the Apache Git Service. To respond to the

(incubator-gluten) branch main updated (f203fd84e -> 00082b2ed)

2024-03-21 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from f203fd84e [CORE] Enable bit_length Spark function (#5069) add 00082b2ed [GLUTEN-5039][VL] Add support for

Re: [I] [VL] Support using AppleClang to build [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE closed issue #5039: [VL] Support using AppleClang to build URL: https://github.com/apache/incubator-gluten/issues/5039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [GLUTEN-5039][VL] Add support for AppleClang compiler [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE merged PR #5053: URL: https://github.com/apache/incubator-gluten/pull/5053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [CORE] Enable bit_length Spark function (#5069)

2024-03-21 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new f203fd84e [CORE] Enable bit_length Spark

Re: [PR] [CORE] Enable bit_length Spark function [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE merged PR #5069: URL: https://github.com/apache/incubator-gluten/pull/5069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2014137197 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5077: URL: https://github.com/apache/incubator-gluten/pull/5077#issuecomment-2014103809 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot opened a new pull request, #5077: URL: https://github.com/apache/incubator-gluten/pull/5077 Upstream Velox's New Commits: ```txt 79df29c3b by Jialiang Tan, Enable arbitrator in OperatorTestBase by default (9141) dc561a358 by rexan, Handle ShortDecimal correctly

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2014064864 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to run single step [incubator-gluten]

2024-03-21 Thread via GitHub
xumingming commented on PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2014063223 > Let's fix this issue at least. It's really not good experience to run `git commit --amend` each time > > @xumingming would you like to take a look? @FelixYBW

Re: [I] [VL] spark.read.csv("/tmp/test.csv") throws Exception [incubator-gluten]

2024-03-21 Thread via GitHub
xumingming commented on issue #5044: URL: https://github.com/apache/incubator-gluten/issues/5044#issuecomment-2014061708 @zhztheplayer The result is correct, just a simple select. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240322) [incubator-gluten]

2024-03-21 Thread via GitHub
lwz9103 opened a new pull request, #5076: URL: https://github.com/apache/incubator-gluten/pull/5076 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240322) [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5076: URL: https://github.com/apache/incubator-gluten/pull/5076#issuecomment-2014002144 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240322) [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5076: URL: https://github.com/apache/incubator-gluten/pull/5076#issuecomment-2014001145 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to run single step [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2013994909 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to run single step [incubator-gluten]

2024-03-21 Thread via GitHub
FelixYBW merged PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Enhance buildbundle-veloxbe.sh to have the ability to run only one specific step [incubator-gluten]

2024-03-21 Thread via GitHub
FelixYBW closed issue #5024: [VL] Enhance buildbundle-veloxbe.sh to have the ability to run only one specific step URL: https://github.com/apache/incubator-gluten/issues/5024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(incubator-gluten) branch main updated: [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to have the ability to run only one specific step (#5032)

2024-03-21 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 9d859d8e4 [GLUTEN-5024][VL] Enhance

Re: [PR] [GLUTEN-5024][VL] Enhance buildbundle-veloxbe.sh to run single step [incubator-gluten]

2024-03-21 Thread via GitHub
FelixYBW commented on PR #5032: URL: https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2013432783 >Another issue is that currently script skip the velox build even if we modified some file in velox because it check the commit id to continue. So we need a git commit --amend

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#issuecomment-2013017698 https://github.com/apache/incubator-gluten/issues/5074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Hadoop file system options doesn't work [incubator-gluten]

2024-03-21 Thread via GitHub
felipepessoto commented on issue #4963: URL: https://github.com/apache/incubator-gluten/issues/4963#issuecomment-2012933683 @PHILO-HE ``` [info] - test123 *** FAILED *** (4 seconds, 837 milliseconds) [info] org.apache.spark.SparkException: Job aborted due to[info] - test123 ***

Re: [PR] [VL] Fix UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#issuecomment-2012919686 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
kecookier opened a new pull request, #5075: URL: https://github.com/apache/incubator-gluten/pull/5075 ## What changes were proposed in this pull request? (Fixes: \#5074) ## How was this patch tested? (Please explain how this patch was tested. E.g. unit tests,

[I] [VL] UDF load failed in yarn-cluster mode [incubator-gluten]

2024-03-21 Thread via GitHub
kecookier opened a new issue, #5074: URL: https://github.com/apache/incubator-gluten/issues/5074 ### Backend VL (Velox) ### Bug description Based on my tests, some bugs have caused this issue: 1. Currently, `VeloxBackend::initUdf()` is called before

Re: [PR] [VL] spark url_decode function support [incubator-gluten]

2024-03-21 Thread via GitHub
Surbhi-Vijay commented on code in PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#discussion_r1534228365 ## backends-velox/src/test/scala/io/glutenproject/execution/VeloxFunctionsValidateSuite.scala: ## @@ -458,6 +458,21 @@ class VeloxFunctionsValidateSuite

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2012741140 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2012726908 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2012691325 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Support uuid function [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014#issuecomment-2012523835 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2012485801 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2012480688 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-4830][VL] Support MapType substrait signature (#4833)

2024-03-21 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 998bce144 [GLUTEN-4830][VL] Support

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE merged PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Support MapType signature [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE closed issue #4830: [VL] Support MapType signature URL: https://github.com/apache/incubator-gluten/issues/4830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_03_21) (#5064)

2024-03-21 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new f51b7ab23 [VL] Daily Update Velox

Re: [PR] [VL] Daily Update Velox Version (2024_03_21) [incubator-gluten]

2024-03-21 Thread via GitHub
zhouyuan merged PR #5064: URL: https://github.com/apache/incubator-gluten/pull/5064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Replace "git clone" by downloading tar package for boost in setup-ubuntu.sh [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5071: URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2012409524 = Performance report for TPCH SF2000 with Velox backend, for reference only query

(incubator-gluten) branch main updated: [VL] Support uuid function (#5014)

2024-03-21 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 42c6be838 [VL] Support uuid function

Re: [PR] [VL] Support uuid function [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE merged PR #5014: URL: https://github.com/apache/incubator-gluten/pull/5014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Replace "git clone" by downloading tar package for boost in setup-ubuntu.sh (#5071)

2024-03-21 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b8fa9dbe6 [VL] Replace "git clone" by

Re: [PR] [VL] Replace "git clone" by downloading tar package for boost in setup-ubuntu.sh [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE merged PR #5071: URL: https://github.com/apache/incubator-gluten/pull/5071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2012297803 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Download boost source code directly in setup-ubuntu.sh [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE commented on PR #5071: URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2012287196 > @PHILO-HE It seems that downloading thrift-0.16.0 often fails in CI. Yes, it blocks building arrow. Let's dismiss the irrelevant failure. -- This is an automated

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2012286389 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_21) [incubator-gluten]

2024-03-21 Thread via GitHub
zhouyuan commented on PR #5064: URL: https://github.com/apache/incubator-gluten/pull/5064#issuecomment-2012257053 note: the cap based spill is removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_21) [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5064: URL: https://github.com/apache/incubator-gluten/pull/5064#issuecomment-2012239746 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Download boost source code directly in setup-ubuntu.sh [incubator-gluten]

2024-03-21 Thread via GitHub
liujiayi771 commented on PR #5071: URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2012208343 @PHILO-HE It seems that downloading thrift-0.16.0 often fails in CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [CORE] Enable bit_length Spark function [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5069: URL: https://github.com/apache/incubator-gluten/pull/5069#issuecomment-2012202277 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_21) [incubator-gluten]

2024-03-21 Thread via GitHub
yma11 commented on PR #5064: URL: https://github.com/apache/incubator-gluten/pull/5064#issuecomment-2012191863 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [VL] Casting integer to binary type produces inconsistent result with Spark [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE commented on issue #5073: URL: https://github.com/apache/incubator-gluten/issues/5073#issuecomment-2012174464 @rui-mo, could you take a look? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] [VL] Casting integer to binary type produces inconsistent result with Spark [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE opened a new issue, #5073: URL: https://github.com/apache/incubator-gluten/issues/5073 ### Backend VL (Velox) ### Bug description ```sql SELECT a, cast(a as binary) from tbl; ``` Spark result: ``` +---+-+ | a|a|

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2012124906 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Download boost source code directly in setup-ubuntu.sh [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE commented on PR #5071: URL: https://github.com/apache/incubator-gluten/pull/5071#issuecomment-2012110675 Hi @liujiayi771, thanks for your work! Seems these changes can be accepted by upstream velox? If so, maybe you can also propose a pr there. Anyway, I think it's OK to firstly

Re: [PR] [CORE] Pullout pre-project for ExpandExec [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #5066: URL: https://github.com/apache/incubator-gluten/pull/5066#issuecomment-2012099741 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] spark url_decode function support [incubator-gluten]

2024-03-21 Thread via GitHub
gaoyangxiaozhu commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2012098417 could you help re-trigger for the build fail task ? @yma11 / @zhouyuan

Re: [PR] [CORE] Enable bit_length Spark function [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5069: URL: https://github.com/apache/incubator-gluten/pull/5069#issuecomment-2012062020 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_21) [incubator-gluten]

2024-03-21 Thread via GitHub
yma11 commented on PR #5064: URL: https://github.com/apache/incubator-gluten/pull/5064#issuecomment-2012056370 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [CH] Add a UT to ensure that IN filtering can apply on CH primary key [incubator-gluten]

2024-03-21 Thread via GitHub
zzcclp closed issue #5062: [CH] Add a UT to ensure that IN filtering can apply on CH primary key URL: https://github.com/apache/incubator-gluten/issues/5062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

  1   2   >