Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2016348921 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2016343681 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-03-22 Thread via GitHub
yma11 commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2016338628 > > 3. max_by function return wrong result > > @yma11 Did you submit a fix to the issue? Not yet. Only have pushed to golden branch and will submit one in Velox

Re: [PR] [VL][CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-201636 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-2016305720 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2016234404 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240323) [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5089: URL: https://github.com/apache/incubator-gluten/pull/5089#issuecomment-2016063005 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240323) [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5089: URL: https://github.com/apache/incubator-gluten/pull/5089#issuecomment-2016063587 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240323) [incubator-gluten]

2024-03-22 Thread via GitHub
lwz9103 opened a new pull request, #5089: URL: https://github.com/apache/incubator-gluten/pull/5089 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [VL] Remove lead/lag ignoreNulls workaround [incubator-gluten]

2024-03-22 Thread via GitHub
GlutenPerfBot commented on PR #5084: URL: https://github.com/apache/incubator-gluten/pull/5084#issuecomment-2016048051 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Add 3 configs of spill [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5088: URL: https://github.com/apache/incubator-gluten/pull/5088#issuecomment-2016026986 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add 3 configs of spill [incubator-gluten]

2024-03-22 Thread via GitHub
FelixYBW commented on PR #5088: URL: https://github.com/apache/incubator-gluten/pull/5088#issuecomment-2016011624 To bypass the result mismatch issue of https://github.com/facebookincubator/velox/issues/9219, you may set a very large MaxSpillRunRows and maxSpillFileSize -- This is an

Re: [PR] [VL] Add 3 configs of spill [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5088: URL: https://github.com/apache/incubator-gluten/pull/5088#issuecomment-201600 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add 3 configs of spill [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5088: URL: https://github.com/apache/incubator-gluten/pull/5088#issuecomment-2016010950 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Add 3 configs of spill [incubator-gluten]

2024-03-22 Thread via GitHub
FelixYBW opened a new pull request, #5088: URL: https://github.com/apache/incubator-gluten/pull/5088 The 3 configs are missing in Gluten. ``` val COLUMNAR_VELOX_MAX_SPILL_RUN_ROWS = buildConf("spark.gluten.sql.columnar.backend.velox.MaxSpillRunRows") .internal()

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-03-22 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2015872030 > No, it's tested from main branch. A new issue https://github.com/facebookincubator/velox/issues/9219 -- This is an automated message from the Apache Git

Re: [I] [VL] result mismatch on hash aggregate [incubator-gluten]

2024-03-22 Thread via GitHub
FelixYBW commented on issue #4678: URL: https://github.com/apache/incubator-gluten/issues/4678#issuecomment-2015873768 the root cause is here https://github.com/facebookincubator/velox/issues/9219 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-03-22 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2015872912 > 3. max_by function return wrong result @yma11 Did you submit a fix to the issue? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-22 Thread via GitHub
Surbhi-Vijay commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2015481845 This is very big feature and the PR. Will go into detail in `gluten-cbo` module later. Appreciate your work @zhztheplayer!! -- This is an automated message from the

Re: [PR] [VL] Remove lead/lag ignoreNulls workaround [incubator-gluten]

2024-03-22 Thread via GitHub
GlutenPerfBot commented on PR #5084: URL: https://github.com/apache/incubator-gluten/pull/5084#issuecomment-2015361980 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Remove lead/lag ignoreNulls workaround [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE merged PR #5084: URL: https://github.com/apache/incubator-gluten/pull/5084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Remove a workaround fix for ignoreNulls of lead/lag function (#5084)

2024-03-22 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new dafb3715e [VL] Remove a workaround fix for

Re: [PR] [VL][CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-2015213419 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-2015175880 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2015158432 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add support for Spark url_decode function [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE merged PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [CORE] Add support for Spark url_decode function (#5070)

2024-03-22 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 63e83bd30 [CORE] Add support for Spark

(incubator-gluten) branch main updated: [GLUTEN-5085][VL] Fix get_velox.sh on macOS (#5086)

2024-03-22 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 01c981390 [GLUTEN-5085][VL] Fix

Re: [PR] [GLUTEN-5085] [VL] Fix get_velox.sh on macOS [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE merged PR #5086: URL: https://github.com/apache/incubator-gluten/pull/5086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] buildbundle-veloxbe.sh fails on macOS [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE closed issue #5085: [VL] buildbundle-veloxbe.sh fails on macOS URL: https://github.com/apache/incubator-gluten/issues/5085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2015011941 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Remove lead/lag ignoreNulls workaround [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE commented on PR #5084: URL: https://github.com/apache/incubator-gluten/pull/5084#issuecomment-2015009857 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2015008387 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][CI] Use pre-installed celeborn to avoid download failure [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE merged PR #5082: URL: https://github.com/apache/incubator-gluten/pull/5082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL][CI] Use pre-installed celeborn to avoid download failure (#5082)

2024-03-22 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 21a41c08f [VL][CI] Use pre-installed

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-22 Thread via GitHub
rui-mo commented on code in PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#discussion_r1535496509 ## shims/common/src/main/scala/io/glutenproject/GlutenConfig.scala: ## @@ -1691,4 +1693,10 @@ object GlutenConfig { .doc("Force fallback for orc char

Re: [PR] [VL] Remove unused openssl setup script change for centos8 [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5087: URL: https://github.com/apache/incubator-gluten/pull/5087#issuecomment-2014863548 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Remove unused openssl setup script change for centos8 [incubator-gluten]

2024-03-22 Thread via GitHub
yma11 opened a new pull request, #5087: URL: https://github.com/apache/incubator-gluten/pull/5087 ## What changes were proposed in this pull request? function `install_openssl` is not actually used as `openssl-devel` is already installed in previous step in the script. ##

Re: [PR] [GLUTEN-4993][CH] Support mergetree on object storage [incubator-gluten]

2024-03-22 Thread via GitHub
liuneng1994 closed pull request #4992: [GLUTEN-4993][CH] Support mergetree on object storage URL: https://github.com/apache/incubator-gluten/pull/4992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Support MergeTree Write On HDFS and S3 [incubator-gluten]

2024-03-22 Thread via GitHub
liuneng1994 closed issue #4993: Support MergeTree Write On HDFS and S3 URL: https://github.com/apache/incubator-gluten/issues/4993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [GLUTEN-5085] [VL] Fix get_velox.sh on macOS [incubator-gluten]

2024-03-22 Thread via GitHub
xumingming opened a new pull request, #5086: URL: https://github.com/apache/incubator-gluten/pull/5086 ## What changes were proposed in this pull request? sed's `-i` param is different on macOS than on Linux, we need to use `-i ''` rather than `-i` to make it work. Fixes:

Re: [PR] [GLUTEN-5085] [VL] Fix get_velox.sh on macOS [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5086: URL: https://github.com/apache/incubator-gluten/pull/5086#issuecomment-2014824110 https://github.com/apache/incubator-gluten/issues/5085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] [VL] buildbundle-veloxbe.sh fails on macOS [incubator-gluten]

2024-03-22 Thread via GitHub
xumingming opened a new issue, #5085: URL: https://github.com/apache/incubator-gluten/issues/5085 ### Problem description Build command: ```bash ./dev/buildbundle-veloxbe.sh --build_type=RelWithDebInfo ``` Error message: ```bash + sed -i

Re: [I] Support MergeTree Write On HDFS and S3 [incubator-gluten]

2024-03-22 Thread via GitHub
loneylee commented on issue #4993: URL: https://github.com/apache/incubator-gluten/issues/4993#issuecomment-2014811495 https://github.com/apache/incubator-gluten/issues/4675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [CH] Support write mergetree to s3 [incubator-gluten]

2024-03-22 Thread via GitHub
loneylee closed issue #4675: [CH] Support write mergetree to s3 URL: https://github.com/apache/incubator-gluten/issues/4675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-4675][CH] Support write mergetree to s3 [incubator-gluten]

2024-03-22 Thread via GitHub
liuneng1994 merged PR #4676: URL: https://github.com/apache/incubator-gluten/pull/4676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-4675][CH] Support write mergetree to s3 (#4676)

2024-03-22 Thread liuneng
This is an automated email from the ASF dual-hosted git repository. liuneng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 4855a4d7d [GLUTEN-4675][CH] Support

Re: [PR] [Gluten-4912][CH] fix bug when a query has no shuffle [incubator-gluten]

2024-03-22 Thread via GitHub
binmahone merged PR #5081: URL: https://github.com/apache/incubator-gluten/pull/5081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [Gluten-4912][CH] fix bug when a query has no shuffle (#5081)

2024-03-22 Thread mahongbin
This is an automated email from the ASF dual-hosted git repository. mahongbin pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 4a953a222 [Gluten-4912][CH] fix bug

Re: [PR] [VL] Remove lead/lag ignoreNulls workaround [incubator-gluten]

2024-03-22 Thread via GitHub
ulysses-you commented on PR #5084: URL: https://github.com/apache/incubator-gluten/pull/5084#issuecomment-2014769341 cc @PHILO-HE thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Remove lead/lag ignoreNulls workaround [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5084: URL: https://github.com/apache/incubator-gluten/pull/5084#issuecomment-2014767189 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Remove lead/lag ignoreNulls workaround [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5084: URL: https://github.com/apache/incubator-gluten/pull/5084#issuecomment-2014766708 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Add support for Spark url_decode function [incubator-gluten]

2024-03-22 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#discussion_r1535345027 ## gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala: ## @@ -115,6 +116,16 @@ object ExpressionConverter extends

Re: [PR] [CORE] Add support for Spark url_decode function [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5070: URL: https://github.com/apache/incubator-gluten/pull/5070#issuecomment-2014758778 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [CH] Invalid result with `mergeTwoPhasesHashBaseAggregateIfNeed` enable [incubator-gluten]

2024-03-22 Thread via GitHub
lgbo-ustc opened a new issue, #5083: URL: https://github.com/apache/incubator-gluten/issues/5083 ### Backend CH (ClickHouse) ### Bug description [Expected behavior] and [actual behavior]. ### vanilla spark

Re: [PR] [VL][CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-2014724625 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-4997][CH]Fix year diff (#5079)

2024-03-22 Thread liuneng
This is an automated email from the ASF dual-hosted git repository. liuneng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 33f1c905f [GLUTEN-4997][CH]Fix year diff

Re: [PR] [GLUTEN-4997][CH]Fix year diff [incubator-gluten]

2024-03-22 Thread via GitHub
liuneng1994 merged PR #5079: URL: https://github.com/apache/incubator-gluten/pull/5079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] diff result for year function [incubator-gluten]

2024-03-22 Thread via GitHub
liuneng1994 closed issue #4997: [CH] diff result for year function URL: https://github.com/apache/incubator-gluten/issues/4997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL][CI] Use pre-installed celeborn to avoid download failure [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE commented on code in PR #5082: URL: https://github.com/apache/incubator-gluten/pull/5082#discussion_r1535307629 ## .github/workflows/velox_be.yml: ## @@ -453,8 +453,8 @@ jobs: - name: TPC-H SF1.0 && TPC-DS SF10.0 Parquet local spark3.2 with Celeborn 0.4.0

Re: [PR] [VL][CI] Use pre-installed celeborn to avoid download failure [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5082: URL: https://github.com/apache/incubator-gluten/pull/5082#issuecomment-2014709980 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2014705748 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][CI] Use pre-installed celeborn to avoid download failure [incubator-gluten]

2024-03-22 Thread via GitHub
kerwin-zk commented on code in PR #5082: URL: https://github.com/apache/incubator-gluten/pull/5082#discussion_r1535293616 ## .github/workflows/velox_be.yml: ## @@ -453,8 +453,8 @@ jobs: - name: TPC-H SF1.0 && TPC-DS SF10.0 Parquet local spark3.2 with Celeborn 0.4.0

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-22 Thread via GitHub
marin-ma commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1535293176 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { // Get

Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]

2024-03-22 Thread via GitHub
GlutenPerfBot commented on PR #5077: URL: https://github.com/apache/incubator-gluten/pull/5077#issuecomment-2014691896 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL][CI] Use pre-installed celeborn to avoid download failure [incubator-gluten]

2024-03-22 Thread via GitHub
kerwin-zk commented on PR #5082: URL: https://github.com/apache/incubator-gluten/pull/5082#issuecomment-2014672808 LGTM. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL][CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-2014644593 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] spark.read.csv("/tmp/test.csv") throws Exception [incubator-gluten]

2024-03-22 Thread via GitHub
xumingming commented on issue #5044: URL: https://github.com/apache/incubator-gluten/issues/5044#issuecomment-2014638253 Full log: ``` scala> val path = "/tmp/person.csv" path: String = /tmp/person.csv scala> val person = spark.read.csv(path); E20240322

Re: [PR] [GLUTEN-4844] [CH] support native write csv file [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #4846: URL: https://github.com/apache/incubator-gluten/pull/4846#issuecomment-2014630760 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][CI] Use pre-installed celeborn to avoid download failure [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE commented on PR #5082: URL: https://github.com/apache/incubator-gluten/pull/5082#issuecomment-2014627758 @kerwin-zk, could you take a review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-22 Thread via GitHub
kecookier commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1535237040 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { //

Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]

2024-03-22 Thread via GitHub
ulysses-you commented on PR #5077: URL: https://github.com/apache/incubator-gluten/pull/5077#issuecomment-2014621797 @PHILO-HE thank you for the reminder, I will send a pr later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_03_22) (#5077)

2024-03-22 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 6ea2c4e22 [VL] Daily Update Velox Version

Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE merged PR #5077: URL: https://github.com/apache/incubator-gluten/pull/5077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE commented on PR #5077: URL: https://github.com/apache/incubator-gluten/pull/5077#issuecomment-2014614301 Hi @ulysses-you, I note you have one PR merged to Velox. Should the below gluten code be removed? If yes, please help do that in a separate PR. Thanks!

Re: [PR] [VL][CI] Pre-install celeborn to fix occasional download failure [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5082: URL: https://github.com/apache/incubator-gluten/pull/5082#issuecomment-2014590305 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][CI] Pre-install celeborn to fix occasional download failure [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5082: URL: https://github.com/apache/incubator-gluten/pull/5082#issuecomment-2014590021 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][CI] Pre-install celeborn to fix occasional download failure [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE opened a new pull request, #5082: URL: https://github.com/apache/incubator-gluten/pull/5082 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-22 Thread via GitHub
kecookier commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1535181373 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { //

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-22 Thread via GitHub
marin-ma commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1535176984 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { // Get

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-22 Thread via GitHub
PHILO-HE commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2014530751 @taiyang-li, CH CI is red, could you give us some clues to fix? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [Gluten-4912][CH] fix bug when a query has no shuffle [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5081: URL: https://github.com/apache/incubator-gluten/pull/5081#issuecomment-2014528714 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Gluten-4912][CH] fix bug when a query has no shuffle [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5081: URL: https://github.com/apache/incubator-gluten/pull/5081#issuecomment-2014528380 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5074][VL] fix: UDF load error in yarn-cluster mode [incubator-gluten]

2024-03-22 Thread via GitHub
kecookier commented on code in PR #5075: URL: https://github.com/apache/incubator-gluten/pull/5075#discussion_r1535162020 ## backends-velox/src/main/scala/org/apache/spark/sql/expression/UDFResolver.scala: ## @@ -152,34 +143,39 @@ object UDFResolver extends Logging { //

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2014490557 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-2014474813 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL] GHA with pre-built docker image and github runner [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-2014468054 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CI] Fix thrift download link for arrow [incubator-gluten]

2024-03-22 Thread via GitHub
github-actions[bot] commented on PR #5080: URL: https://github.com/apache/incubator-gluten/pull/5080#issuecomment-2014434853 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to