(incubator-gluten) branch main updated: [GLUTEN-5142][CELEBORN] Remove Incubating of Celeborn from reference (#5143)

2024-03-26 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 3bc5387c0 [GLUTEN-5142][CELEBORN]

Re: [I] Remove Incubating of Celeborn from reference [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you closed issue #5142: Remove Incubating of Celeborn from reference URL: https://github.com/apache/incubator-gluten/issues/5142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5142][CELEBORN] Remove Incubating of Celeborn from reference [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you merged PR #5143: URL: https://github.com/apache/incubator-gluten/pull/5143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE commented on PR #5127: URL: https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2021997304 Sorry for late response. Looks good! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-5142][CELEBORN] Remove Incubating of Celeborn from reference [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5143: URL: https://github.com/apache/incubator-gluten/pull/5143#issuecomment-2021995102 https://github.com/apache/incubator-gluten/issues/5142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5136][VL] Duplicated output from Spark-to-Velox broadcast relation conversion [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on PR #5141: URL: https://github.com/apache/incubator-gluten/pull/5141#issuecomment-2021974259 I see, thank you for the explaination! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] Remove Incubating of Celeborn from reference [incubator-gluten]

2024-03-26 Thread via GitHub
SteNicholas opened a new issue, #5142: URL: https://github.com/apache/incubator-gluten/issues/5142 ### Description The ASF board has approved a resolution to graduate Celeborn into a full Top Level Project. Incubating of Celeborn should be removed from reference. -- This is an

Re: [PR] [GLUTEN-4964][CORE]Fallback complex data type in parquet write for Spark32 & Spark33 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5107: URL: https://github.com/apache/incubator-gluten/pull/5107#issuecomment-2021963550 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5136][VL] Duplicated output from Spark-to-Velox broadcast relation conversion [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer commented on PR #5141: URL: https://github.com/apache/incubator-gluten/pull/5141#issuecomment-2021963407 > Thank you @zhztheplayer for the quick fix. After this pr if there is no c2r, the duplicate keys issue is still existed right ? After the fix is applied we should

Re: [PR] [GLUTEN-5136][VL] Duplicated output from Spark-to-Velox broadcast relation conversion [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on PR #5141: URL: https://github.com/apache/incubator-gluten/pull/5141#issuecomment-2021947563 Thank you @zhztheplayer for the quick fix. After this pr if there is no c2r, the duplicate keys issue is still existed right ? -- This is an automated message from the

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2021943260 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
zhouyuan commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2021938997 The feature itself looks good to me CC @PHILO-HE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2021937111 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-5136][VL] Duplicated output from Spark-to-Velox broadcast relation conversion (#5141)

2024-03-26 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new e4fe9baec [GLUTEN-5136][VL] Duplicated

Re: [PR] [GLUTEN-5136][VL] Duplicated output from Spark-to-Velox broadcast relation conversion [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer merged PR #5141: URL: https://github.com/apache/incubator-gluten/pull/5141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5136][VL] Duplicated output from Spark-to-Velox broadcast relation conversion [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer commented on PR #5141: URL: https://github.com/apache/incubator-gluten/pull/5141#issuecomment-2021931432 cc @ulysses-you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
zhouyuan commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2021930759 Hi @dcoliversun This patch seems trying to generate package for each OS, the package built from centos7 should be to work on other platforms as it's using static packaging

Re: [I] [VL] Vanilla Spark broadcast exchange + R2C is slow sometimes [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer commented on issue #5136: URL: https://github.com/apache/incubator-gluten/issues/5136#issuecomment-2021919347 The major issue I have found is that the `flatMap` approach would cause `UnsafeHashedRelation` to produce duplicated rows in my case (TPCDS q14a with current version

Re: [I] [VL] Vanilla Spark broadcast exchange + R2C is slow sometimes [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer commented on issue #5136: URL: https://github.com/apache/incubator-gluten/issues/5136#issuecomment-2021916024 I don't have dedicated UTs for it so it was incorporated into the other PR. Still I can open one for it if you think it's needed:

Re: [PR] [CORE] Enable from_utc_timestamp Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5140: URL: https://github.com/apache/incubator-gluten/pull/5140#issuecomment-2021909505 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5136][VL] Duplicated output from Spark-to-Velox broadcast relation conversion [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5141: URL: https://github.com/apache/incubator-gluten/pull/5141#issuecomment-2021911803 https://github.com/apache/incubator-gluten/issues/5136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CORE] Enable from_utc_timestamp Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5140: URL: https://github.com/apache/incubator-gluten/pull/5140#issuecomment-2021909730 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [CORE] Enable from_utc_timestamp Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
acvictor opened a new pull request, #5140: URL: https://github.com/apache/incubator-gluten/pull/5140 ## What changes were proposed in this pull request? Enable from_utc_timestamp Spark function ## How was this patch tested? Added UT -- This is an automated

Re: [PR] [CORE] Enable to_utc_timestamp Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5139: URL: https://github.com/apache/incubator-gluten/pull/5139#issuecomment-2021897306 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Enable to_utc_timestamp Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
acvictor commented on PR #5139: URL: https://github.com/apache/incubator-gluten/pull/5139#issuecomment-2021894818 @PHILO-HE can you please review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [CORE] Enable to_utc_timestamp Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
acvictor opened a new pull request, #5139: URL: https://github.com/apache/incubator-gluten/pull/5139 ## What changes were proposed in this pull request? Enable to_utc_timestamp ## How was this patch tested? Added a UT. -- This is an automated message from the

Re: [PR] [CORE] Enable to_utc_timestamp Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5139: URL: https://github.com/apache/incubator-gluten/pull/5139#issuecomment-2021894673 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Enable to_utc_timestamp Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5139: URL: https://github.com/apache/incubator-gluten/pull/5139#issuecomment-2021894438 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [DNM] Velox test [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929#issuecomment-2021890936 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Vanilla Spark broadcast exchange + R2C is slow sometimes [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on issue #5136: URL: https://github.com/apache/incubator-gluten/issues/5136#issuecomment-2021873724 Thank you @zhztheplayer It's a good point, columnar broadcast would broadcast the origin binary data but vanilla Spark would broadcast hash relation. So I think this

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2021856789 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-5083][CH] Invalid result with mergeTwoPhasesHashBaseAggregateIfNeed enable (#5137)

2024-03-26 Thread zhangzc
This is an automated email from the ASF dual-hosted git repository. zhangzc pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new d3e4f2e4d [GLUTEN-5083][CH] Invalid

Re: [PR] [GLUTEN-5083][CH] Invalid result with `mergeTwoPhasesHashBaseAggregateIfNeed` enable [incubator-gluten]

2024-03-26 Thread via GitHub
zzcclp merged PR #5137: URL: https://github.com/apache/incubator-gluten/pull/5137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Invalid result with `mergeTwoPhasesHashBaseAggregateIfNeed` enable [incubator-gluten]

2024-03-26 Thread via GitHub
zzcclp closed issue #5083: [CH] Invalid result with `mergeTwoPhasesHashBaseAggregateIfNeed` enable URL: https://github.com/apache/incubator-gluten/issues/5083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(incubator-gluten) branch main updated: [CORE] Support JDK17 (#5120)

2024-03-26 Thread yao
This is an automated email from the ASF dual-hosted git repository. yao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 7942701c3 [CORE] Support JDK17 (#5120)

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2021843842 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
yaooqinn merged PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DNM] Velox test [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929#issuecomment-2021800771 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL] Daily Update Velox Version (2024_03_27) [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma opened a new pull request, #5138: URL: https://github.com/apache/incubator-gluten/pull/5138 ``` 7fc09667d (upstream/main) Add estimateSerializedSize to BatchVectorSerializer (#8712) c354c31f1 Reuse result vector in Alpha reader (#9226) 3fbb4754f Create UnitLoader (#9259)

Re: [PR] [VL] Daily Update Velox Version (2024_03_27) [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5138: URL: https://github.com/apache/incubator-gluten/pull/5138#issuecomment-2021777264 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
dcoliversun commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2021764604 @zhouyuan @wangyum please review this PR if have time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(incubator-gluten) branch main updated: [Gluten-5018][CH] support minmax/bloomfilter/set skip index (#5019)

2024-03-26 Thread mahongbin
This is an automated email from the ASF dual-hosted git repository. mahongbin pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 972597184 [Gluten-5018][CH] support

Re: [I] [CH] basically support set/bloomfilter/minmax index for clickhouse tables [incubator-gluten]

2024-03-26 Thread via GitHub
binmahone closed issue #5018: [CH] basically support set/bloomfilter/minmax index for clickhouse tables URL: https://github.com/apache/incubator-gluten/issues/5018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [CH] Issue 5018 [incubator-gluten]

2024-03-26 Thread via GitHub
binmahone merged PR #5019: URL: https://github.com/apache/incubator-gluten/pull/5019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Enable SPARK-10634 timestamp test case (#5090)

2024-03-26 Thread rui
This is an automated email from the ASF dual-hosted git repository. rui pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b962e7cc7 [VL] Enable SPARK-10634 timestamp

Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]

2024-03-26 Thread via GitHub
rui-mo merged PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2021758296 @zzcclp CH CI passed. Could you help to review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [DNM] Velox test [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929#issuecomment-2021752956 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [CORE] Move BackendBuildInfo case class from GlutenPlugin to Backend class file (#5129)

2024-03-26 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 6dc7885f6 [CORE] Move

(incubator-gluten) branch main updated: [GLUTEN-5133]Modify the prompt information for TakeOrderedAndProjectExecTransformer (#5134)

2024-03-26 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 5b8b96e25 [GLUTEN-5133]Modify the

Re: [I] [GLUTEN-5133]Modify the prompt information for TakeOrderedAndProjectExecTransformer [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you closed issue #5133: [GLUTEN-5133]Modify the prompt information for TakeOrderedAndProjectExecTransformer URL: https://github.com/apache/incubator-gluten/issues/5133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GLUTEN-5133]Modify the prompt information for TakeOrderedAndProjectE… [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you merged PR #5134: URL: https://github.com/apache/incubator-gluten/pull/5134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Move BackendBuildInfo case class from GlutenPlugin to Backend class file [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you merged PR #5129: URL: https://github.com/apache/incubator-gluten/pull/5129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL][DNM]Test Q95 post probe spill [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5063: URL: https://github.com/apache/incubator-gluten/pull/5063#issuecomment-2021746292 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5083][CH] Invalid result with `mergeTwoPhasesHashBaseAggregateIfNeed` enable [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5137: URL: https://github.com/apache/incubator-gluten/pull/5137#issuecomment-2021735086 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5083][CH] Invalid result with `mergeTwoPhasesHashBaseAggregateIfNeed` enable [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5137: URL: https://github.com/apache/incubator-gluten/pull/5137#issuecomment-2021734843 https://github.com/apache/incubator-gluten/issues/5083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1540297481 ## docs/get-started/Velox.md: ## @@ -5,28 +5,34 @@ nav_order: 1 parent: Getting-Started --- # Supported Version -| Type | Version

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2021727351 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [VL] Vanilla Spark broadcast exchange + C2R is slow sometimes [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer opened a new issue, #5136: URL: https://github.com/apache/incubator-gluten/issues/5136 ### Backend VL (Velox) ### Bug description This is because the code to convert vanilla Spark's hashed relation to Gluten's sometimes produced duplicated rows. The

Re: [PR] [CORE] Basic runnable version of ACBO (Advanced CBO) [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5058: URL: https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2021706928 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL] Velox patch to avoid installing libunwind-dev no longer works (#5127)

2024-03-26 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 2aa60d0ea [VL] Velox patch to avoid

Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer merged PR #5127: URL: https://github.com/apache/incubator-gluten/pull/5127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer commented on PR #5127: URL: https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2021704715 cc @PHILO-HE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL][MINOR] Refactor operator/function tests [incubator-gluten]

2024-03-26 Thread via GitHub
GlutenPerfBot commented on PR #5037: URL: https://github.com/apache/incubator-gluten/pull/5037#issuecomment-2021667403 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240327) [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5135: URL: https://github.com/apache/incubator-gluten/pull/5135#issuecomment-2021611455 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240327) [incubator-gluten]

2024-03-26 Thread via GitHub
lwz9103 opened a new pull request, #5135: URL: https://github.com/apache/incubator-gluten/pull/5135 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240327) [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5135: URL: https://github.com/apache/incubator-gluten/pull/5135#issuecomment-2021611241 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Crash when writing an array of struct [incubator-gluten]

2024-03-26 Thread via GitHub
clee704 commented on issue #4964: URL: https://github.com/apache/incubator-gluten/issues/4964#issuecomment-2021599373 @JkSelf Actually it crashes on Spark 3.4 too. # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at

Re: [PR] [GLUTEN-5133]Modify the prompt information for TakeOrderedAndProjectE… [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5134: URL: https://github.com/apache/incubator-gluten/pull/5134#issuecomment-2020923742 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5133]Modify the prompt information for TakeOrderedAndProjectE… [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5134: URL: https://github.com/apache/incubator-gluten/pull/5134#issuecomment-2020922735 https://github.com/apache/incubator-gluten/issues/5133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5133]Modify the prompt information for TakeOrderedAndProjectE… [incubator-gluten]

2024-03-26 Thread via GitHub
guixiaowen opened a new pull request, #5134: URL: https://github.com/apache/incubator-gluten/pull/5134 …xecTransformer #5133 ## What changes were proposed in this pull request? In TakeOrderedAndProjectExecTransformer, the prompt information is different from others. For

[I] Modify the prompt information for TakeOrderedAndProjectExecTransformer [incubator-gluten]

2024-03-26 Thread via GitHub
guixiaowen opened a new issue, #5133: URL: https://github.com/apache/incubator-gluten/issues/5133 ### Description In TakeOrderedAndProjectExecTransformer, the prompt information is different from others. For example: spark-sql>explain select a from test.tablea order

[I] Modify the prompt information for TakeOrderedAndProjectExecTransformer's simpleString [incubator-gluten]

2024-03-26 Thread via GitHub
guixiaowen opened a new issue, #5132: URL: https://github.com/apache/incubator-gluten/issues/5132 ### Description In TakeOrderedAndProjectExecTransformer, the prompt information is different from others. For example: spark-sql>explain select a from test.tablea order

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2020860684 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-03-26 Thread via GitHub
supermem613 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2020700016 I'd like to pick up base64 and unbase64, please. (FYI, looks like there was a PR above for unbase64, but it seems to have been closed without committing ~45-55

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2020688726 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020597809 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] spark.read.csv("/tmp/test.csv") throws Exception [incubator-gluten]

2024-03-26 Thread via GitHub
xumingming commented on issue #5044: URL: https://github.com/apache/incubator-gluten/issues/5044#issuecomment-2020579428 @PHILO-HE Thanks for the information! I tried with parquet data(nation table in TPCH), the details are the following: ``` == Fallback Summary == (4)

Re: [PR] [VL][CI] Enable Celeborn tests & Gluten CPP tests [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5114: URL: https://github.com/apache/incubator-gluten/pull/5114#issuecomment-2020420744 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2020416623 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1539216963 ## .github/workflows/velox_docker.yml: ## @@ -73,6 +73,17 @@ jobs: matrix: os: ["ubuntu:20.04", "ubuntu:22.04"] spark: ["spark-3.2",

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020391322 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020388375 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020371865 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1539159436 ## .github/workflows/velox_docker.yml: ## @@ -84,69 +95,49 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven run: |

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2020372832 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#issuecomment-2020340206 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-26 Thread via GitHub
zzcclp commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2020336897 It seems there are some `SPARK-36830: Support reading and writing ANSI intervals` which are not disable for the spark 3.3 -- This is an automated message from the Apache Git

Re: [PR] [VL] Enable SPARK-10634 timestamp test case [incubator-gluten]

2024-03-26 Thread via GitHub
rui-mo commented on code in PR #5090: URL: https://github.com/apache/incubator-gluten/pull/5090#discussion_r1539108319 ## ep/build-velox/src/get_velox.sh: ## @@ -16,8 +16,8 @@ set -exu -VELOX_REPO=https://github.com/oap-project/velox.git -VELOX_BRANCH=2024_03_25

Re: [PR] [VL][MINOR] Refactor operator/function tests [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE merged PR #5037: URL: https://github.com/apache/incubator-gluten/pull/5037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL][MINOR] Refactor operator/function validation tests (#5037)

2024-03-26 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new adf0566a2 [VL][MINOR] Refactor

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2020149985 cc @zhztheplayer @zhouyuan @PHILO-HE if you have other comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2020149678 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [MINOR] Remove redundant string format [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you merged PR #5126: URL: https://github.com/apache/incubator-gluten/pull/5126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [MINOR] Remove redundant string format (#5126)

2024-03-26 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new dba4bcd3c [MINOR] Remove redundant

Re: [PR] [VL](WIP) Support native UDAF [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5130: URL: https://github.com/apache/incubator-gluten/pull/5130#issuecomment-2020090416 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL](WIP) Support native UDAF [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma opened a new pull request, #5130: URL: https://github.com/apache/incubator-gluten/pull/5130 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CORE] Move BackendBuildInfo case class from GlutenPlugin to Backend class file [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5129: URL: https://github.com/apache/incubator-gluten/pull/5129#issuecomment-2020078075 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Move BackendBuildInfo case class from GlutenPlugin to Backend class file [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5129: URL: https://github.com/apache/incubator-gluten/pull/5129#issuecomment-2020078525 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [CORE] Move BackendBuildInfo case class from GlutenPlugin to Backend class file [incubator-gluten]

2024-03-26 Thread via GitHub
wForget opened a new pull request, #5129: URL: https://github.com/apache/incubator-gluten/pull/5129 ## What changes were proposed in this pull request? The `BackendBuildInfo` case class seemed more appropriate in `Backend` class file, so I moved it. ## How was this patch

  1   2   >