[PR] [VL] Daily Update Velox Version (2024_04_10) [incubator-gluten]

2024-04-09 Thread via GitHub
GlutenPerfBot opened a new pull request, #5347: URL: https://github.com/apache/incubator-gluten/pull/5347 Upstream Velox's New Commits: ```txt 54a7fe839 by xiaoxmeng, Add metrics to track initial memory capacity and growth (9416) 845f13ca7 by Jialiang Tan, Add per-test memory

Re: [PR] [VL] Daily Update Velox Version (2024_04_10) [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5347: URL: https://github.com/apache/incubator-gluten/pull/5347#issuecomment-2046226805 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2046240429 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL](WIP) Allow hash on map for round robin repartitioning [incubator-gluten]

2024-04-09 Thread via GitHub
marin-ma opened a new pull request, #5349: URL: https://github.com/apache/incubator-gluten/pull/5349 fixes #5206 Pick up velox upstream PR to enable hashing complex types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL](WIP) Allow hash on map for round robin repartitioning [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5349: URL: https://github.com/apache/incubator-gluten/pull/5349#issuecomment-2046331878 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [DNM] Test a patch [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5354: URL: https://github.com/apache/incubator-gluten/pull/5354#issuecomment-2046674273 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [DNM] Test a patch [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5354: URL: https://github.com/apache/incubator-gluten/pull/5354#issuecomment-2046674781 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] UT failures for Spark3.5 [incubator-gluten]

2024-04-09 Thread via GitHub
yma11 commented on issue #5341: URL: https://github.com/apache/incubator-gluten/issues/5341#issuecomment-2046230774 > does it cover all the UT failures of 3.5? If so let's pin to top Not quite, there should some Spark3.5 specific UTs(newly added in Spark3.5) we haven't ported yet.

Re: [PR] [VL] Enable Window oom in ci job [incubator-gluten]

2024-04-09 Thread via GitHub
JkSelf merged PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-04-09 Thread via GitHub
PHILO-HE commented on code in PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#discussion_r1558784873 ## gluten-uniffle/velox/src/main/java/org/apache/spark/shuffle/writer/VeloxUniffleColumnarShuffleWriter.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the

Re: [PR] [VL] Daily Update Velox Version (2024_04_10) [incubator-gluten]

2024-04-09 Thread via GitHub
zhztheplayer merged PR #5347: URL: https://github.com/apache/incubator-gluten/pull/5347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] [CH] Diff result of year function [incubator-gluten]

2024-04-10 Thread via GitHub
exmy opened a new issue, #5352: URL: https://github.com/apache/incubator-gluten/issues/5352 ### Backend CH (ClickHouse) ### Bug description ``` select year('1899-12-31'); ``` spark result: `1899` gluten result: `1900` ### Spark version

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240409) [incubator-gluten]

2024-04-09 Thread via GitHub
GlutenPerfBot commented on PR #5329: URL: https://github.com/apache/incubator-gluten/pull/5329#issuecomment-2046143740 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240410) [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5346: URL: https://github.com/apache/incubator-gluten/pull/5346#issuecomment-2046175551 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-09 Thread via GitHub
FelixYBW commented on PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345#issuecomment-2046239070 > > Can they pass on current Gluten? > > The `test-file-with-no-column-indexes-1.parquet` can't be read by Velox so I exclude it in test for the time being. There should be

Re: [PR] [GLUTEN-4241][VL] Add plan node to convert Vanilla spark columnar format data to Velox columnar format data [incubator-gluten]

2024-04-09 Thread via GitHub
zhztheplayer commented on PR #4818: URL: https://github.com/apache/incubator-gluten/pull/4818#issuecomment-2046333655 I think it's OK to have it disabled by default. @boneanxs Can you add a CI case for the feature to run TPC-H / TPC-DS tests? Example:

Re: [PR] [WIP][DNM][VL] Support Row Index Metadata Column [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5351: URL: https://github.com/apache/incubator-gluten/pull/5351#issuecomment-2046488538 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240410) [incubator-gluten]

2024-04-09 Thread via GitHub
kyligence-git opened a new pull request, #5346: URL: https://github.com/apache/incubator-gluten/pull/5346 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240410) [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5346: URL: https://github.com/apache/incubator-gluten/pull/5346#issuecomment-2046175396 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5336]update the doc of the velox of build_parameters #5336 #5338 [incubator-gluten]

2024-04-09 Thread via GitHub
PHILO-HE commented on code in PR #5340: URL: https://github.com/apache/incubator-gluten/pull/5340#discussion_r1558643039 ## docs/get-started/build-guide.md: ## @@ -56,14 +56,15 @@ The below parameters can be set via `-P` for mvn. | Parameters | Description

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2046296890 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Join support pull out pre-project [incubator-gluten]

2024-04-09 Thread via GitHub
zhouyuan commented on issue #5350: URL: https://github.com/apache/incubator-gluten/issues/5350#issuecomment-2046478821 CC @JkSelf @PHILO-HE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2046622820 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4241][VL] Add plan node to convert Vanilla spark columnar format data to Velox columnar format data [incubator-gluten]

2024-04-10 Thread via GitHub
boneanxs commented on PR #4818: URL: https://github.com/apache/incubator-gluten/pull/4818#issuecomment-2046651045 Hey @FelixYBW @zhztheplayer, yea, I'm willing to continue this pr. After last comment, I actually have run some benchmarks in my local environment, and found there's no

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-09 Thread via GitHub
yma11 commented on PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345#issuecomment-2046338908 > > > Can they pass on current Gluten? > > > The `test-file-with-no-column-indexes-1.parquet` can't be read by Velox so I exclude it in test for the time being. There should be

Re: [PR] [VL] Enable Spark3.4 linear-regression.sql test case in GlutenSQLQueryTestSuite [incubator-gluten]

2024-04-09 Thread via GitHub
Yohahaha commented on code in PR #5306: URL: https://github.com/apache/incubator-gluten/pull/5306#discussion_r1558744103 ## gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxSQLQueryTestSettings.scala: ## @@ -240,6 +240,8 @@ object VeloxSQLQueryTestSettings

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2046461003 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][DNM][VL] Support Row Index Metadata Column [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5351: URL: https://github.com/apache/incubator-gluten/pull/5351#issuecomment-2046488665 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Include aggregate transformation into enumerated transform, and add TPC-H golden checks for RAS [incubator-gluten]

2024-04-09 Thread via GitHub
zhztheplayer merged PR #5333: URL: https://github.com/apache/incubator-gluten/pull/5333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Build failed in macOs M1 [incubator-gluten]

2024-04-09 Thread via GitHub
zml1206 commented on issue #5343: URL: https://github.com/apache/incubator-gluten/issues/5343#issuecomment-2046458541 cc @ulysses-you @xumingming Could you help to check it? I tried it on multiple macOs and got the same error, MacOSX12 and MacOSX13. Thanks. -- This is an automated

Re: [I] Join support pull out pre-project [incubator-gluten]

2024-04-09 Thread via GitHub
liujiayi771 commented on issue #5350: URL: https://github.com/apache/incubator-gluten/issues/5350#issuecomment-2046470116 cc @zhouyuan @zhztheplayer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] Join support pull out pre-project [incubator-gluten]

2024-04-09 Thread via GitHub
liujiayi771 opened a new issue, #5350: URL: https://github.com/apache/incubator-gluten/issues/5350 ### Description The problem encountered in developing join support pull-out pre-project. * If we handle the join in the physical plan, there are mainly two problems. *

Re: [PR] [VL] Enable Spark3.4 linear-regression.sql test case in GlutenSQLQueryTestSuite [incubator-gluten]

2024-04-09 Thread via GitHub
Yohahaha merged PR #5306: URL: https://github.com/apache/incubator-gluten/pull/5306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5225][CH] Add mergetree index filter on driver [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5308: URL: https://github.com/apache/incubator-gluten/pull/5308#issuecomment-2046507858 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Upgrade Arrow to 15.0.0 [incubator-gluten]

2024-04-09 Thread via GitHub
PHILO-HE commented on PR #5174: URL: https://github.com/apache/incubator-gluten/pull/5174#issuecomment-2046590630 Hi @Yohahaha, could you rebase this pr? I note we need this upgrade to avoid an invalid pointer issue. Thanks! -- This is an automated message from the Apache Git Service.

Re: [PR] [DNM] Fix invalid pointer issue for branch-1.1.1 [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5353: URL: https://github.com/apache/incubator-gluten/pull/5353#issuecomment-2046657835 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues

[PR] [DNM] Fix invalid pointer issue for branch-1.1.1 [incubator-gluten]

2024-04-10 Thread via GitHub
PHILO-HE opened a new pull request, #5353: URL: https://github.com/apache/incubator-gluten/pull/5353 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[I] spillRun.rows.empty() Error [incubator-gluten]

2024-04-09 Thread via GitHub
weiting-chen opened a new issue, #5348: URL: https://github.com/apache/incubator-gluten/issues/5348 ### Backend VL (Velox) ### Bug description Reproduce Steps: Step 1. Generate data.txt via below python script `To generate fileļ¼šgen_spill_data.py` # -*- coding:

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-204671 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-09 Thread via GitHub
yma11 commented on PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345#issuecomment-2046232490 > Can they pass on current Gluten? The `test-file-with-no-column-indexes-1.parquet` can't be read by Velox so I exclude it in test for the time being. There should be a bug.

Re: [PR] [GLUTEN-5215][CH]stable precision in statistical aggregation functions [incubator-gluten]

2024-04-09 Thread via GitHub
lgbo-ustc commented on code in PR #5311: URL: https://github.com/apache/incubator-gluten/pull/5311#discussion_r1558508629 ## backends-clickhouse/src/main/scala/org/apache/gluten/execution/CHHashAggregateExecTransformer.scala: ## @@ -349,13 +349,18 @@ case class

Re: [PR] [VL] Enable Spark3.4 linear-regression.sql test case in GlutenSQLQueryTestSuite [incubator-gluten]

2024-04-09 Thread via GitHub
liujiayi771 commented on code in PR #5306: URL: https://github.com/apache/incubator-gluten/pull/5306#discussion_r1558754276 ## gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxSQLQueryTestSettings.scala: ## @@ -240,6 +240,8 @@ object VeloxSQLQueryTestSettings

Re: [PR] [GLUTEN-4241][VL] Add plan node to convert Vanilla spark columnar format data to Velox columnar format data [incubator-gluten]

2024-04-09 Thread via GitHub
FelixYBW commented on PR #4818: URL: https://github.com/apache/incubator-gluten/pull/4818#issuecomment-2046335776 Oh, just noted the PR is still open and have many conflict. @boneanxs would you like to continue? -- This is an automated message from the Apache Git Service. To respond

Re: [I] Join support pull out pre-project [incubator-gluten]

2024-04-09 Thread via GitHub
zhztheplayer commented on issue #5350: URL: https://github.com/apache/incubator-gluten/issues/5350#issuecomment-2046553137 > (Unresolved) Handling BroadcastHashJoin's BroadcastExchange is tricky. If the child of the pre-project is a BroadcastExchange, it needs to implement the

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-11 Thread via GitHub
supermem613 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2049850094 Hey, @PHILO-HE , what's the plan with concat_ws ? It says "PR Ready" and I see that you have committed an implementation to this branch:

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2049791908 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] VeloxTPCHIcebergSuite is failing [incubator-gluten]

2024-04-11 Thread via GitHub
liujiayi771 commented on issue #5362: URL: https://github.com/apache/incubator-gluten/issues/5362#issuecomment-2049878832 https://github.com/facebookincubator/velox/pull/9450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345#issuecomment-204919 @FelixYBW okay to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-04-11 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2050122134 > #5366 UPdated desc. thank you. do you know which function (cast, avg, round ) caused the issue? -- This is an automated message from the Apache Git

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
liujiayi771 commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2049958234 @zhztheplayer This is another way to fix it, and it won't affect reading partitioned tables. We can use this method to restore the ability to read partitioned tables with

Re: [I] [GLUTEN-5336]update the doc of the velox of build_parameters [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha closed issue #5336: [GLUTEN-5336]update the doc of the velox of build_parameters URL: https://github.com/apache/incubator-gluten/issues/5336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2049920760 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
liujiayi771 opened a new pull request, #5373: URL: https://github.com/apache/incubator-gluten/pull/5373 ## What changes were proposed in this pull request? Fix #5362. ## How was this patch tested? N/A -- This is an automated message from the Apache Git

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-11 Thread via GitHub
FelixYBW commented on PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345#issuecomment-2050136502 > @FelixYBW okay to merge this PR? Yes, let's merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [GLUTEN-5336][DOC] Update build parameters #5338 [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha merged PR #5340: URL: https://github.com/apache/incubator-gluten/pull/5340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-2050691934 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-2050692068 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-11 Thread via GitHub
GlutenPerfBot opened a new pull request, #5375: URL: https://github.com/apache/incubator-gluten/pull/5375 Upstream Velox's New Commits: ```txt 0643556a7 by duanmeng, Add pool name regex in TestScopedSpillInjection (9413) efb0213a4 by Masha Basmanova, Optimize cast(JSON as ROW)

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2050764207 @liujiayi771 Thanks for trying fix but seems don't cover all the cases. Your fix at velox makes more sense. -- This is an automated message from the Apache Git Service. To

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2050767148 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Issues related to Timestamp type [incubator-gluten]

2024-04-11 Thread via GitHub
zhouyuan commented on issue #5364: URL: https://github.com/apache/incubator-gluten/issues/5364#issuecomment-2050786937 CC @boneanxs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-04-11 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2050366675 #5372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5336][DOC] Update build parameters #5338 [incubator-gluten]

2024-04-11 Thread via GitHub
GlutenPerfBot commented on PR #5340: URL: https://github.com/apache/incubator-gluten/pull/5340#issuecomment-2050662530 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
zhouyuan merged PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-11 Thread via GitHub
kyligence-git opened a new pull request, #5374: URL: https://github.com/apache/incubator-gluten/pull/5374 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2050744701 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
zhztheplayer commented on code in PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#discussion_r1561884835 ## .gitattributes: ## @@ -0,0 +1 @@ +backends-velox/src/test/resources/tpch-approved-plan/** linguist-generated Review Comment: But sadly by

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-11 Thread via GitHub
PHILO-HE merged PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2050783108 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] fix wrong result for try_add [incubator-gluten]

2024-04-10 Thread via GitHub
zhli1142015 commented on PR #5356: URL: https://github.com/apache/incubator-gluten/pull/5356#issuecomment-2046823211 cc @PHILO-HE and @rui-mo , thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [DNM] Uniformly use arrow-14.0.1 for branch-1.1.1 [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5353: URL: https://github.com/apache/incubator-gluten/pull/5353#issuecomment-2046891794 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5225][CH] Add mergetree index filter on driver [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5308: URL: https://github.com/apache/incubator-gluten/pull/5308#issuecomment-2047064116 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] fix restore meta bug for s3 [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5282: URL: https://github.com/apache/incubator-gluten/pull/5282#issuecomment-2047158538 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix wrong result caused by missing metadata in hash registration [incubator-gluten]

2024-04-10 Thread via GitHub
marin-ma merged PR #5355: URL: https://github.com/apache/incubator-gluten/pull/5355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CH] fix restore meta bug for s3 [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5282: URL: https://github.com/apache/incubator-gluten/pull/5282#issuecomment-2047398093 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-10 Thread via GitHub
zzcclp commented on code in PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#discussion_r1558982580 ## gluten-ut/spark32/src/test/scala/org/apache/spark/sql/hive/execution/GlutenHiveSQLQueryCHSuite.scala: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache

Re: [PR] [DNM] Uniformly use arrow-14.0.1 for branch-1.1.1 [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5353: URL: https://github.com/apache/incubator-gluten/pull/5353#issuecomment-2046753477 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix wrong result caused by missing metadata in hash registration [incubator-gluten]

2024-04-10 Thread via GitHub
marin-ma commented on code in PR #5355: URL: https://github.com/apache/incubator-gluten/pull/5355#discussion_r1559084969 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -39,12 +39,14 @@ void registerFunctionOverwrite() {

Re: [PR] [CORE] Enhance gluten config parsing [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5357: URL: https://github.com/apache/incubator-gluten/pull/5357#issuecomment-2047128149 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM] Uniformly use arrow-14.0.1 for branch-1.1.1 [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5353: URL: https://github.com/apache/incubator-gluten/pull/5353#issuecomment-2046890370 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [CORE] Enhance gluten config parsing [incubator-gluten]

2024-04-10 Thread via GitHub
Yohahaha opened a new pull request, #5357: URL: https://github.com/apache/incubator-gluten/pull/5357 ## What changes were proposed in this pull request? Allow parse config like `spark.gluten.sql.columnar.backend.velox.loadQuantum=8m`. -- This is an automated message from the

Re: [PR] [CORE] Enhance gluten config parsing [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5357: URL: https://github.com/apache/incubator-gluten/pull/5357#issuecomment-2047123212 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2047304810 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix wrong result caused by missing metadata in hash registration [incubator-gluten]

2024-04-10 Thread via GitHub
PHILO-HE commented on code in PR #5355: URL: https://github.com/apache/incubator-gluten/pull/5355#discussion_r1559021095 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -39,12 +39,14 @@ void registerFunctionOverwrite() {

Re: [PR] [GLUTEN-4039][VL] Add array filter function support [incubator-gluten]

2024-04-10 Thread via GitHub
ivoson commented on PR #5334: URL: https://github.com/apache/incubator-gluten/pull/5334#issuecomment-2046932285 Thanks @PHILO-HE @rui-mo @zhli1142015 for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] [VL] Fix wrong result caused by missing metadata in hash registration [incubator-gluten]

2024-04-10 Thread via GitHub
marin-ma opened a new pull request, #5355: URL: https://github.com/apache/incubator-gluten/pull/5355 `velox::functions::sparksql::hashMetadata()` was missing from previous rebase. Added UT. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [VL] Fix wrong result caused by missing metadata in hash registration [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5355: URL: https://github.com/apache/incubator-gluten/pull/5355#issuecomment-2046786496 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Fix wrong result caused by missing metadata in hash registration [incubator-gluten]

2024-04-10 Thread via GitHub
marin-ma commented on PR #5355: URL: https://github.com/apache/incubator-gluten/pull/5355#issuecomment-2046789180 @PHILO-HE Could you help to review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-4917][VL] Update dependencies in static packaging [incubator-gluten]

2024-04-10 Thread via GitHub
PHILO-HE merged PR #5339: URL: https://github.com/apache/incubator-gluten/pull/5339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-10 Thread via GitHub
yma11 commented on code in PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#discussion_r1559227870 ## backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala: ## @@ -390,7 +391,8 @@ abstract class

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-10 Thread via GitHub
zzcclp commented on code in PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#discussion_r1558980848 ## gluten-ut/spark32/src/test/scala/org/apache/spark/sql/hive/execution/GlutenHiveSQLQueryCHSuite.scala: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache

Re: [PR] [VL] fix wrong result for try_add [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5356: URL: https://github.com/apache/incubator-gluten/pull/5356#issuecomment-2046810008 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] fix wrong result for try_add [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5356: URL: https://github.com/apache/incubator-gluten/pull/5356#issuecomment-2046809290 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] fix wrong result for try_add [incubator-gluten]

2024-04-10 Thread via GitHub
zhli1142015 opened a new pull request, #5356: URL: https://github.com/apache/incubator-gluten/pull/5356 ## What changes were proposed in this pull request? After spark 3.4, try_add would not be converted to try_eval(add), so it isn't fallbacked and output wrong results. Fix this

Re: [PR] [GLUTEN-4039][VL] Add array filter function support [incubator-gluten]

2024-04-10 Thread via GitHub
zhli1142015 merged PR #5334: URL: https://github.com/apache/incubator-gluten/pull/5334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-04-10 Thread via GitHub
acvictor closed pull request #5131: [CORE] Enable second Spark function URL: https://github.com/apache/incubator-gluten/pull/5131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Update to_utc_timestamp and from_utc_timestamp tests [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5358: URL: https://github.com/apache/incubator-gluten/pull/5358#issuecomment-2047141809 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Update to_utc_timestamp and from_utc_timestamp tests [incubator-gluten]

2024-04-10 Thread via GitHub
github-actions[bot] commented on PR #5358: URL: https://github.com/apache/incubator-gluten/pull/5358#issuecomment-2047141345 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Update to_utc_timestamp and from_utc_timestamp tests [incubator-gluten]

2024-04-10 Thread via GitHub
acvictor opened a new pull request, #5358: URL: https://github.com/apache/incubator-gluten/pull/5358 ## What changes were proposed in this pull request? The earlier implementation of to/from_utc_timestamp excluded timezones specified as an offset from UTC. This is fixed here

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-10 Thread via GitHub
ayushi-agarwal commented on code in PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#discussion_r1559320662 ## backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala: ## @@ -390,7 +391,8 @@ abstract class

  1   2   3   4   5   6   7   8   9   10   >