This is an automated email from the ASF dual-hosted git repository.

felixybw pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git


The following commit(s) were added to refs/heads/main by this push:
     new e317e4d5d [VL] Fix bug where session config is lost when benchmark is 
enabled (#5054)
e317e4d5d is described below

commit e317e4d5dd845ab98d8ef2b46a811a6f2635ef4f
Author: BInwei Yang <felix...@apache.org>
AuthorDate: Wed Mar 20 21:28:47 2024 -0700

    [VL] Fix bug where session config is lost when benchmark is enabled (#5054)
    
    It's a quick bug fix.
    
    unordered_map::merge removes the duplicated items from source.
---
 cpp/velox/compute/VeloxRuntime.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/cpp/velox/compute/VeloxRuntime.cc 
b/cpp/velox/compute/VeloxRuntime.cc
index f8f2a527c..a77ddfbba 100644
--- a/cpp/velox/compute/VeloxRuntime.cc
+++ b/cpp/velox/compute/VeloxRuntime.cc
@@ -220,7 +220,10 @@ std::unique_ptr<ColumnarBatchSerializer> 
VeloxRuntime::createColumnarBatchSerial
 void VeloxRuntime::dumpConf(const std::string& path) {
   auto backendConf = VeloxBackend::get()->getBackendConf();
   auto allConf = backendConf;
-  allConf.merge(confMap_);
+
+  for (const auto& pair : confMap_) {
+    allConf.insert_or_assign(pair.first, pair.second);
+  }
 
   // Open file "velox.conf" for writing, automatically creating it if it 
doesn't exist,
   // or overwriting it if it does.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org

Reply via email to