zhztheplayer merged PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2022202232
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2022188411
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2022179359
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2022176620
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2022102606
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2022097782
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2022024561
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2021943260
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2021706928
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2019363124
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2019362253
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2019271115
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1538508579
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2018053323
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017901758
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017872999
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017476936
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhanglistar commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1537096832
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017244651
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017177882
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017108387
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017107151
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017090980
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017090872
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017090065
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017078751
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017062291
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017054009
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017034121
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2017027522
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2016343681
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Surbhi-Vijay commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2015481845
This is very big feature and the PR. Will go into detail in `gluten-cbo`
module later. Appreciate your work @zhztheplayer!!
--
This is an automated message from the
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2014177120
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhztheplayer commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2014174950
Guys, since the change is not affecting current code path unless
`spark.gluten.sql.advanced.cbo.enabled=true` I am preparing to merge this after
CI passed, to ease the
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533286761
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboGroup.scala:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533284131
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533284131
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r154672
##
gluten-core/src/main/scala/io/glutenproject/extension/ColumnarOverrides.scala:
##
@@ -223,6 +224,23 @@ case class ColumnarOverrideRules(session:
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533284131
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533290705
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/memo/Memo.scala:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533290705
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/memo/Memo.scala:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533289802
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/memo/ForwardMemoTable.scala:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533289122
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboPlanner.scala:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533288763
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboPlanner.scala:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533288122
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboNode.scala:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533287599
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboNode.scala:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533287265
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboNode.scala:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533286761
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboGroup.scala:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533285973
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboConfig.scala:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533285973
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboConfig.scala:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533284131
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533284131
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/CboCluster.scala:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533282556
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/Cbo.scala:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533281959
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/Cbo.scala:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533281959
##
gluten-cbo/common/src/main/scala/io/glutenproject/cbo/Cbo.scala:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
zhztheplayer commented on code in PR #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058#discussion_r1533281350
##
.github/workflows/velox_be.yml:
##
@@ -450,6 +450,16 @@ jobs:
--local --preset=velox --benchmark-type=h --error-on-memleak
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011266413
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011252200
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011228018
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011222339
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011209005
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011206379
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011169296
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011163149
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011095509
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011021726
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011020568
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011012096
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011010259
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5058:
URL:
https://github.com/apache/incubator-gluten/pull/5058#issuecomment-2011010109
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
zhztheplayer opened a new pull request, #5058:
URL: https://github.com/apache/incubator-gluten/pull/5058
See proposal https://github.com/apache/incubator-gluten/issues/5057
This is the first runnable version of ACBO with TPCH SF 1.0 and TPCDS 10.0
passed.
After this patch, one
72 matches
Mail list logo
