Repository: hbase-site
Updated Branches:
  refs/heads/asf-site 53df288a2 -> b2e107448


http://git-wip-us.apache.org/repos/asf/hbase-site/blob/b2e10744/testdevapidocs/src-html/org/apache/hadoop/hbase/security/access/TestRpcAccessChecks.html
----------------------------------------------------------------------
diff --git 
a/testdevapidocs/src-html/org/apache/hadoop/hbase/security/access/TestRpcAccessChecks.html
 
b/testdevapidocs/src-html/org/apache/hadoop/hbase/security/access/TestRpcAccessChecks.html
new file mode 100644
index 0000000..127be96
--- /dev/null
+++ 
b/testdevapidocs/src-html/org/apache/hadoop/hbase/security/access/TestRpcAccessChecks.html
@@ -0,0 +1,434 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" 
"http://www.w3.org/TR/html4/loose.dtd";>
+<html lang="en">
+<head>
+<title>Source code</title>
+<link rel="stylesheet" type="text/css" 
href="../../../../../../../stylesheet.css" title="Style">
+</head>
+<body>
+<div class="sourceContainer">
+<pre><span class="sourceLineNo">001</span><a name="line.1"></a>
+<span class="sourceLineNo">002</span>/**<a name="line.2"></a>
+<span class="sourceLineNo">003</span> * Licensed to the Apache Software 
Foundation (ASF) under one<a name="line.3"></a>
+<span class="sourceLineNo">004</span> * or more contributor license 
agreements.  See the NOTICE file<a name="line.4"></a>
+<span class="sourceLineNo">005</span> * distributed with this work for 
additional information<a name="line.5"></a>
+<span class="sourceLineNo">006</span> * regarding copyright ownership.  The 
ASF licenses this file<a name="line.6"></a>
+<span class="sourceLineNo">007</span> * to you under the Apache License, 
Version 2.0 (the<a name="line.7"></a>
+<span class="sourceLineNo">008</span> * "License"); you may not use this file 
except in compliance<a name="line.8"></a>
+<span class="sourceLineNo">009</span> * with the License.  You may obtain a 
copy of the License at<a name="line.9"></a>
+<span class="sourceLineNo">010</span> *<a name="line.10"></a>
+<span class="sourceLineNo">011</span> *     
http://www.apache.org/licenses/LICENSE-2.0<a name="line.11"></a>
+<span class="sourceLineNo">012</span> *<a name="line.12"></a>
+<span class="sourceLineNo">013</span> * Unless required by applicable law or 
agreed to in writing, software<a name="line.13"></a>
+<span class="sourceLineNo">014</span> * distributed under the License is 
distributed on an "AS IS" BASIS,<a name="line.14"></a>
+<span class="sourceLineNo">015</span> * WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express or implied.<a name="line.15"></a>
+<span class="sourceLineNo">016</span> * See the License for the specific 
language governing permissions and<a name="line.16"></a>
+<span class="sourceLineNo">017</span> * limitations under the License.<a 
name="line.17"></a>
+<span class="sourceLineNo">018</span> */<a name="line.18"></a>
+<span class="sourceLineNo">019</span>package 
org.apache.hadoop.hbase.security.access;<a name="line.19"></a>
+<span class="sourceLineNo">020</span><a name="line.20"></a>
+<span class="sourceLineNo">021</span>import static 
org.apache.hadoop.hbase.AuthUtil.toGroupEntry;<a name="line.21"></a>
+<span class="sourceLineNo">022</span>import static 
org.junit.Assert.assertArrayEquals;<a name="line.22"></a>
+<span class="sourceLineNo">023</span>import static 
org.junit.Assert.assertFalse;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import static 
org.junit.Assert.assertTrue;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import static org.junit.Assert.fail;<a 
name="line.25"></a>
+<span class="sourceLineNo">026</span>import static org.mockito.Mockito.mock;<a 
name="line.26"></a>
+<span class="sourceLineNo">027</span><a name="line.27"></a>
+<span class="sourceLineNo">028</span>import com.google.protobuf.Service;<a 
name="line.28"></a>
+<span class="sourceLineNo">029</span>import 
com.google.protobuf.ServiceException;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import java.io.IOException;<a 
name="line.30"></a>
+<span class="sourceLineNo">031</span>import 
java.security.PrivilegedExceptionAction;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import java.util.Collections;<a 
name="line.32"></a>
+<span class="sourceLineNo">033</span>import java.util.HashMap;<a 
name="line.33"></a>
+<span class="sourceLineNo">034</span>import 
org.apache.hadoop.conf.Configuration;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.Cell;<a 
name="line.35"></a>
+<span class="sourceLineNo">036</span>import 
org.apache.hadoop.hbase.CellUtil;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import 
org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import 
org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import 
org.apache.hadoop.hbase.ServerName;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import 
org.apache.hadoop.hbase.TableName;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import 
org.apache.hadoop.hbase.client.Admin;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import 
org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;<a 
name="line.42"></a>
+<span class="sourceLineNo">043</span>import 
org.apache.hadoop.hbase.client.Connection;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import 
org.apache.hadoop.hbase.client.ConnectionFactory;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import 
org.apache.hadoop.hbase.client.Get;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import 
org.apache.hadoop.hbase.client.Put;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import 
org.apache.hadoop.hbase.client.Result;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import 
org.apache.hadoop.hbase.client.Table;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import 
org.apache.hadoop.hbase.client.TableDescriptor;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import 
org.apache.hadoop.hbase.client.TableDescriptorBuilder;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import 
org.apache.hadoop.hbase.coprocessor.CoprocessorHost;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import 
org.apache.hadoop.hbase.coprocessor.MasterCoprocessor;<a name="line.52"></a>
+<span class="sourceLineNo">053</span>import 
org.apache.hadoop.hbase.coprocessor.RegionServerCoprocessor;<a 
name="line.53"></a>
+<span class="sourceLineNo">054</span>import 
org.apache.hadoop.hbase.ipc.protobuf.generated.TestProtos;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import 
org.apache.hadoop.hbase.ipc.protobuf.generated.TestRpcServiceProtos;<a 
name="line.55"></a>
+<span class="sourceLineNo">056</span>import 
org.apache.hadoop.hbase.security.AccessDeniedException;<a name="line.56"></a>
+<span class="sourceLineNo">057</span>import 
org.apache.hadoop.hbase.security.User;<a name="line.57"></a>
+<span class="sourceLineNo">058</span>import 
org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.58"></a>
+<span class="sourceLineNo">059</span>import 
org.apache.hadoop.hbase.testclassification.SecurityTests;<a name="line.59"></a>
+<span class="sourceLineNo">060</span>import 
org.apache.hadoop.hbase.util.Bytes;<a name="line.60"></a>
+<span class="sourceLineNo">061</span>import org.junit.BeforeClass;<a 
name="line.61"></a>
+<span class="sourceLineNo">062</span>import org.junit.ClassRule;<a 
name="line.62"></a>
+<span class="sourceLineNo">063</span>import org.junit.Rule;<a 
name="line.63"></a>
+<span class="sourceLineNo">064</span>import org.junit.Test;<a 
name="line.64"></a>
+<span class="sourceLineNo">065</span>import 
org.junit.experimental.categories.Category;<a name="line.65"></a>
+<span class="sourceLineNo">066</span>import org.junit.rules.TestName;<a 
name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span>/**<a name="line.68"></a>
+<span class="sourceLineNo">069</span> * This class tests operations in 
MasterRpcServices which require ADMIN access.<a name="line.69"></a>
+<span class="sourceLineNo">070</span> * It doesn't test all operations which 
require ADMIN access, only those which get vetted within<a name="line.70"></a>
+<span class="sourceLineNo">071</span> * MasterRpcServices at the point of 
entry itself (unlike old approach of using<a name="line.71"></a>
+<span class="sourceLineNo">072</span> * hooks in AccessController).<a 
name="line.72"></a>
+<span class="sourceLineNo">073</span> *<a name="line.73"></a>
+<span class="sourceLineNo">074</span> * Sidenote:<a name="line.74"></a>
+<span class="sourceLineNo">075</span> * There is one big difference between 
how security tests for AccessController hooks work, and how<a 
name="line.75"></a>
+<span class="sourceLineNo">076</span> * the tests in this class for security 
in MasterRpcServices work.<a name="line.76"></a>
+<span class="sourceLineNo">077</span> * The difference arises because of the 
way AC &amp; MasterRpcServices get the user.<a name="line.77"></a>
+<span class="sourceLineNo">078</span> *<a name="line.78"></a>
+<span class="sourceLineNo">079</span> * In AccessController, it first checks 
if there is an active rpc user in ObserverContext. If not,<a name="line.79"></a>
+<span class="sourceLineNo">080</span> * it uses UserProvider for current user. 
This *might* make sense in the context of coprocessors,<a name="line.80"></a>
+<span class="sourceLineNo">081</span> * because they can be called outside the 
context of RPCs.<a name="line.81"></a>
+<span class="sourceLineNo">082</span> * But in the context of 
MasterRpcServices, only one way makes sense - RPCServer.getRequestUser().<a 
name="line.82"></a>
+<span class="sourceLineNo">083</span> *<a name="line.83"></a>
+<span class="sourceLineNo">084</span> * In AC tests, when we do FooUser.runAs 
on AccessController instance directly, it bypasses<a name="line.84"></a>
+<span class="sourceLineNo">085</span> * the rpc framework completely, but 
works because UserProvider provides the correct user, i.e.<a name="line.85"></a>
+<span class="sourceLineNo">086</span> * FooUser in this case.<a 
name="line.86"></a>
+<span class="sourceLineNo">087</span> *<a name="line.87"></a>
+<span class="sourceLineNo">088</span> * But this doesn't work for the tests 
here, so we go around by doing complete RPCs.<a name="line.88"></a>
+<span class="sourceLineNo">089</span> */<a name="line.89"></a>
+<span class="sourceLineNo">090</span>@Category({SecurityTests.class, 
MediumTests.class})<a name="line.90"></a>
+<span class="sourceLineNo">091</span>public class TestRpcAccessChecks {<a 
name="line.91"></a>
+<span class="sourceLineNo">092</span>  @ClassRule<a name="line.92"></a>
+<span class="sourceLineNo">093</span>  public static final HBaseClassTestRule 
CLASS_RULE =<a name="line.93"></a>
+<span class="sourceLineNo">094</span>      
HBaseClassTestRule.forClass(TestRpcAccessChecks.class);<a name="line.94"></a>
+<span class="sourceLineNo">095</span><a name="line.95"></a>
+<span class="sourceLineNo">096</span>  @Rule<a name="line.96"></a>
+<span class="sourceLineNo">097</span>  public final TestName TEST_NAME = new 
TestName();<a name="line.97"></a>
+<span class="sourceLineNo">098</span><a name="line.98"></a>
+<span class="sourceLineNo">099</span>  private final static 
HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility();<a name="line.99"></a>
+<span class="sourceLineNo">100</span>  private static Configuration conf;<a 
name="line.100"></a>
+<span class="sourceLineNo">101</span><a name="line.101"></a>
+<span class="sourceLineNo">102</span>  // user granted with all global 
permission<a name="line.102"></a>
+<span class="sourceLineNo">103</span>  private static User USER_ADMIN;<a 
name="line.103"></a>
+<span class="sourceLineNo">104</span>  // user without admin permissions<a 
name="line.104"></a>
+<span class="sourceLineNo">105</span>  private static User USER_NON_ADMIN;<a 
name="line.105"></a>
+<span class="sourceLineNo">106</span><a name="line.106"></a>
+<span class="sourceLineNo">107</span>  private static final String GROUP_ADMIN 
= "admin_group";<a name="line.107"></a>
+<span class="sourceLineNo">108</span>  private static User USER_GROUP_ADMIN;<a 
name="line.108"></a>
+<span class="sourceLineNo">109</span><a name="line.109"></a>
+<span class="sourceLineNo">110</span>  // Dummy service to test execService 
calls. Needs to be public so can be loaded as Coprocessor.<a 
name="line.110"></a>
+<span class="sourceLineNo">111</span>  public static class DummyCpService 
implements MasterCoprocessor, RegionServerCoprocessor {<a name="line.111"></a>
+<span class="sourceLineNo">112</span>    public DummyCpService() {}<a 
name="line.112"></a>
+<span class="sourceLineNo">113</span><a name="line.113"></a>
+<span class="sourceLineNo">114</span>    @Override<a name="line.114"></a>
+<span class="sourceLineNo">115</span>    public Iterable&lt;Service&gt; 
getServices() {<a name="line.115"></a>
+<span class="sourceLineNo">116</span>      return 
Collections.singleton(mock(TestRpcServiceProtos.TestProtobufRpcProto.class));<a 
name="line.116"></a>
+<span class="sourceLineNo">117</span>    }<a name="line.117"></a>
+<span class="sourceLineNo">118</span>  }<a name="line.118"></a>
+<span class="sourceLineNo">119</span><a name="line.119"></a>
+<span class="sourceLineNo">120</span>  private static void 
enableSecurity(Configuration conf) throws IOException {<a name="line.120"></a>
+<span class="sourceLineNo">121</span>    
conf.set("hadoop.security.authorization", "false");<a name="line.121"></a>
+<span class="sourceLineNo">122</span>    
conf.set("hadoop.security.authentication", "simple");<a name="line.122"></a>
+<span class="sourceLineNo">123</span>    
conf.set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, 
AccessController.class.getName() +<a name="line.123"></a>
+<span class="sourceLineNo">124</span>      "," + 
DummyCpService.class.getName());<a name="line.124"></a>
+<span class="sourceLineNo">125</span>    
conf.set(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY, 
AccessController.class.getName());<a name="line.125"></a>
+<span class="sourceLineNo">126</span>    
conf.set(CoprocessorHost.REGIONSERVER_COPROCESSOR_CONF_KEY, 
AccessController.class.getName() +<a name="line.126"></a>
+<span class="sourceLineNo">127</span>      "," + 
DummyCpService.class.getName());<a name="line.127"></a>
+<span class="sourceLineNo">128</span>    
conf.set(User.HBASE_SECURITY_AUTHORIZATION_CONF_KEY, "true");<a 
name="line.128"></a>
+<span class="sourceLineNo">129</span>    
SecureTestUtil.configureSuperuser(conf);<a name="line.129"></a>
+<span class="sourceLineNo">130</span>  }<a name="line.130"></a>
+<span class="sourceLineNo">131</span><a name="line.131"></a>
+<span class="sourceLineNo">132</span>  @BeforeClass<a name="line.132"></a>
+<span class="sourceLineNo">133</span>  public static void setup() throws 
Exception {<a name="line.133"></a>
+<span class="sourceLineNo">134</span>    conf = 
TEST_UTIL.getConfiguration();<a name="line.134"></a>
+<span class="sourceLineNo">135</span><a name="line.135"></a>
+<span class="sourceLineNo">136</span>    // Enable security<a 
name="line.136"></a>
+<span class="sourceLineNo">137</span>    enableSecurity(conf);<a 
name="line.137"></a>
+<span class="sourceLineNo">138</span>    TEST_UTIL.startMiniCluster();<a 
name="line.138"></a>
+<span class="sourceLineNo">139</span><a name="line.139"></a>
+<span class="sourceLineNo">140</span>    // Wait for the ACL table to become 
available<a name="line.140"></a>
+<span class="sourceLineNo">141</span>    
TEST_UTIL.waitUntilAllRegionsAssigned(AccessControlLists.ACL_TABLE_NAME);<a 
name="line.141"></a>
+<span class="sourceLineNo">142</span><a name="line.142"></a>
+<span class="sourceLineNo">143</span>    // Create users<a name="line.143"></a>
+<span class="sourceLineNo">144</span>    USER_ADMIN = 
User.createUserForTesting(conf, "admin", new String[0]);<a name="line.144"></a>
+<span class="sourceLineNo">145</span>    USER_NON_ADMIN = 
User.createUserForTesting(conf, "non_admin", new String[0]);<a 
name="line.145"></a>
+<span class="sourceLineNo">146</span>    USER_GROUP_ADMIN =<a 
name="line.146"></a>
+<span class="sourceLineNo">147</span>        User.createUserForTesting(conf, 
"user_group_admin", new String[] { GROUP_ADMIN });<a name="line.147"></a>
+<span class="sourceLineNo">148</span><a name="line.148"></a>
+<span class="sourceLineNo">149</span>    // Assign permissions to users and 
groups<a name="line.149"></a>
+<span class="sourceLineNo">150</span>    SecureTestUtil.grantGlobal(TEST_UTIL, 
USER_ADMIN.getShortName(), Permission.Action.ADMIN);<a name="line.150"></a>
+<span class="sourceLineNo">151</span>    SecureTestUtil.grantGlobal(TEST_UTIL, 
toGroupEntry(GROUP_ADMIN), Permission.Action.ADMIN);<a name="line.151"></a>
+<span class="sourceLineNo">152</span>    // No permissions to USER_NON_ADMIN<a 
name="line.152"></a>
+<span class="sourceLineNo">153</span>  }<a name="line.153"></a>
+<span class="sourceLineNo">154</span><a name="line.154"></a>
+<span class="sourceLineNo">155</span>  interface Action {<a 
name="line.155"></a>
+<span class="sourceLineNo">156</span>    void run(Admin admin) throws 
Exception;<a name="line.156"></a>
+<span class="sourceLineNo">157</span>  }<a name="line.157"></a>
+<span class="sourceLineNo">158</span><a name="line.158"></a>
+<span class="sourceLineNo">159</span>  private void verifyAllowed(User user, 
Action action) throws Exception {<a name="line.159"></a>
+<span class="sourceLineNo">160</span>    
user.runAs((PrivilegedExceptionAction&lt;?&gt;) () -&gt; {<a 
name="line.160"></a>
+<span class="sourceLineNo">161</span>      try (Connection conn = 
ConnectionFactory.createConnection(conf);<a name="line.161"></a>
+<span class="sourceLineNo">162</span>          Admin admin = conn.getAdmin()) 
{<a name="line.162"></a>
+<span class="sourceLineNo">163</span>        action.run(admin);<a 
name="line.163"></a>
+<span class="sourceLineNo">164</span>      } catch (IOException e) {<a 
name="line.164"></a>
+<span class="sourceLineNo">165</span>        fail(e.toString());<a 
name="line.165"></a>
+<span class="sourceLineNo">166</span>      }<a name="line.166"></a>
+<span class="sourceLineNo">167</span>      return null;<a name="line.167"></a>
+<span class="sourceLineNo">168</span>    });<a name="line.168"></a>
+<span class="sourceLineNo">169</span>  }<a name="line.169"></a>
+<span class="sourceLineNo">170</span><a name="line.170"></a>
+<span class="sourceLineNo">171</span>  private void verifyDenied(User user, 
Action action) throws Exception {<a name="line.171"></a>
+<span class="sourceLineNo">172</span>    
user.runAs((PrivilegedExceptionAction&lt;?&gt;) () -&gt; {<a 
name="line.172"></a>
+<span class="sourceLineNo">173</span>      boolean accessDenied = false;<a 
name="line.173"></a>
+<span class="sourceLineNo">174</span>      try (Connection conn = 
ConnectionFactory.createConnection(conf);<a name="line.174"></a>
+<span class="sourceLineNo">175</span>          Admin admin = conn.getAdmin()) 
{<a name="line.175"></a>
+<span class="sourceLineNo">176</span>        action.run(admin);<a 
name="line.176"></a>
+<span class="sourceLineNo">177</span>      } catch (AccessDeniedException e) 
{<a name="line.177"></a>
+<span class="sourceLineNo">178</span>        accessDenied = true;<a 
name="line.178"></a>
+<span class="sourceLineNo">179</span>      }<a name="line.179"></a>
+<span class="sourceLineNo">180</span>      assertTrue("Expected access to be 
denied", accessDenied);<a name="line.180"></a>
+<span class="sourceLineNo">181</span>      return null;<a name="line.181"></a>
+<span class="sourceLineNo">182</span>    });<a name="line.182"></a>
+<span class="sourceLineNo">183</span>  }<a name="line.183"></a>
+<span class="sourceLineNo">184</span><a name="line.184"></a>
+<span class="sourceLineNo">185</span>  private void 
verifiedDeniedServiceException(User user, Action action) throws Exception {<a 
name="line.185"></a>
+<span class="sourceLineNo">186</span>    
user.runAs((PrivilegedExceptionAction&lt;?&gt;) () -&gt; {<a 
name="line.186"></a>
+<span class="sourceLineNo">187</span>      boolean accessDenied = false;<a 
name="line.187"></a>
+<span class="sourceLineNo">188</span>      try (Connection conn = 
ConnectionFactory.createConnection(conf);<a name="line.188"></a>
+<span class="sourceLineNo">189</span>          Admin admin = conn.getAdmin()) 
{<a name="line.189"></a>
+<span class="sourceLineNo">190</span>        action.run(admin);<a 
name="line.190"></a>
+<span class="sourceLineNo">191</span>      } catch (ServiceException e) {<a 
name="line.191"></a>
+<span class="sourceLineNo">192</span>        // For 
MasterRpcServices.execService.<a name="line.192"></a>
+<span class="sourceLineNo">193</span>        if (e.getCause() instanceof 
AccessDeniedException) {<a name="line.193"></a>
+<span class="sourceLineNo">194</span>          accessDenied = true;<a 
name="line.194"></a>
+<span class="sourceLineNo">195</span>        }<a name="line.195"></a>
+<span class="sourceLineNo">196</span>      }<a name="line.196"></a>
+<span class="sourceLineNo">197</span>      assertTrue("Expected access to be 
denied", accessDenied);<a name="line.197"></a>
+<span class="sourceLineNo">198</span>      return null;<a name="line.198"></a>
+<span class="sourceLineNo">199</span>    });<a name="line.199"></a>
+<span class="sourceLineNo">200</span><a name="line.200"></a>
+<span class="sourceLineNo">201</span>  }<a name="line.201"></a>
+<span class="sourceLineNo">202</span><a name="line.202"></a>
+<span class="sourceLineNo">203</span>  private void 
verifyAdminCheckForAction(Action action) throws Exception {<a 
name="line.203"></a>
+<span class="sourceLineNo">204</span>    verifyAllowed(USER_ADMIN, action);<a 
name="line.204"></a>
+<span class="sourceLineNo">205</span>    verifyAllowed(USER_GROUP_ADMIN, 
action);<a name="line.205"></a>
+<span class="sourceLineNo">206</span>    verifyDenied(USER_NON_ADMIN, 
action);<a name="line.206"></a>
+<span class="sourceLineNo">207</span>  }<a name="line.207"></a>
+<span class="sourceLineNo">208</span><a name="line.208"></a>
+<span class="sourceLineNo">209</span>  @Test<a name="line.209"></a>
+<span class="sourceLineNo">210</span>  public void testEnableCatalogJanitor() 
throws Exception {<a name="line.210"></a>
+<span class="sourceLineNo">211</span>    verifyAdminCheckForAction((admin) 
-&gt; admin.enableCatalogJanitor(true));<a name="line.211"></a>
+<span class="sourceLineNo">212</span>  }<a name="line.212"></a>
+<span class="sourceLineNo">213</span><a name="line.213"></a>
+<span class="sourceLineNo">214</span>  @Test<a name="line.214"></a>
+<span class="sourceLineNo">215</span>  public void testRunCatalogJanitor() 
throws Exception {<a name="line.215"></a>
+<span class="sourceLineNo">216</span>    verifyAdminCheckForAction((admin) 
-&gt; admin.runCatalogJanitor());<a name="line.216"></a>
+<span class="sourceLineNo">217</span>  }<a name="line.217"></a>
+<span class="sourceLineNo">218</span><a name="line.218"></a>
+<span class="sourceLineNo">219</span>  @Test<a name="line.219"></a>
+<span class="sourceLineNo">220</span>  public void testCleanerChoreRunning() 
throws Exception {<a name="line.220"></a>
+<span class="sourceLineNo">221</span>    verifyAdminCheckForAction((admin) 
-&gt; admin.cleanerChoreSwitch(true));<a name="line.221"></a>
+<span class="sourceLineNo">222</span>  }<a name="line.222"></a>
+<span class="sourceLineNo">223</span><a name="line.223"></a>
+<span class="sourceLineNo">224</span>  @Test<a name="line.224"></a>
+<span class="sourceLineNo">225</span>  public void testRunCleanerChore() 
throws Exception {<a name="line.225"></a>
+<span class="sourceLineNo">226</span>    verifyAdminCheckForAction((admin) 
-&gt; admin.runCleanerChore());<a name="line.226"></a>
+<span class="sourceLineNo">227</span>  }<a name="line.227"></a>
+<span class="sourceLineNo">228</span><a name="line.228"></a>
+<span class="sourceLineNo">229</span>  @Test<a name="line.229"></a>
+<span class="sourceLineNo">230</span>  public void testExecProcedure() throws 
Exception {<a name="line.230"></a>
+<span class="sourceLineNo">231</span>    verifyAdminCheckForAction((admin) 
-&gt; {<a name="line.231"></a>
+<span class="sourceLineNo">232</span>      // Using existing table instead of 
creating a new one.<a name="line.232"></a>
+<span class="sourceLineNo">233</span>      
admin.execProcedure("flush-table-proc", 
TableName.META_TABLE_NAME.getNameAsString(),<a name="line.233"></a>
+<span class="sourceLineNo">234</span>          new HashMap&lt;&gt;());<a 
name="line.234"></a>
+<span class="sourceLineNo">235</span>    });<a name="line.235"></a>
+<span class="sourceLineNo">236</span>  }<a name="line.236"></a>
+<span class="sourceLineNo">237</span><a name="line.237"></a>
+<span class="sourceLineNo">238</span>  @Test<a name="line.238"></a>
+<span class="sourceLineNo">239</span>  public void testExecService() throws 
Exception {<a name="line.239"></a>
+<span class="sourceLineNo">240</span>    Action action = (admin) -&gt; {<a 
name="line.240"></a>
+<span class="sourceLineNo">241</span>      
TestRpcServiceProtos.TestProtobufRpcProto.BlockingInterface service =<a 
name="line.241"></a>
+<span class="sourceLineNo">242</span>          
TestRpcServiceProtos.TestProtobufRpcProto.newBlockingStub(admin.coprocessorService());<a
 name="line.242"></a>
+<span class="sourceLineNo">243</span>      service.ping(null, 
TestProtos.EmptyRequestProto.getDefaultInstance());<a name="line.243"></a>
+<span class="sourceLineNo">244</span>    };<a name="line.244"></a>
+<span class="sourceLineNo">245</span><a name="line.245"></a>
+<span class="sourceLineNo">246</span>    verifyAllowed(USER_ADMIN, action);<a 
name="line.246"></a>
+<span class="sourceLineNo">247</span>    verifyAllowed(USER_GROUP_ADMIN, 
action);<a name="line.247"></a>
+<span class="sourceLineNo">248</span>    // This is same as above 
verifyAccessDenied<a name="line.248"></a>
+<span class="sourceLineNo">249</span>    
verifiedDeniedServiceException(USER_NON_ADMIN, action);<a name="line.249"></a>
+<span class="sourceLineNo">250</span>  }<a name="line.250"></a>
+<span class="sourceLineNo">251</span><a name="line.251"></a>
+<span class="sourceLineNo">252</span>  @Test<a name="line.252"></a>
+<span class="sourceLineNo">253</span>  public void testExecProcedureWithRet() 
throws Exception {<a name="line.253"></a>
+<span class="sourceLineNo">254</span>    verifyAdminCheckForAction((admin) 
-&gt; {<a name="line.254"></a>
+<span class="sourceLineNo">255</span>      // Using existing table instead of 
creating a new one.<a name="line.255"></a>
+<span class="sourceLineNo">256</span>      
admin.execProcedureWithReturn("flush-table-proc", 
TableName.META_TABLE_NAME.getNameAsString(),<a name="line.256"></a>
+<span class="sourceLineNo">257</span>          new HashMap&lt;&gt;());<a 
name="line.257"></a>
+<span class="sourceLineNo">258</span>    });<a name="line.258"></a>
+<span class="sourceLineNo">259</span>  }<a name="line.259"></a>
+<span class="sourceLineNo">260</span><a name="line.260"></a>
+<span class="sourceLineNo">261</span>  @Test<a name="line.261"></a>
+<span class="sourceLineNo">262</span>  public void testNormalize() throws 
Exception {<a name="line.262"></a>
+<span class="sourceLineNo">263</span>    verifyAdminCheckForAction((admin) 
-&gt; admin.normalize());<a name="line.263"></a>
+<span class="sourceLineNo">264</span>  }<a name="line.264"></a>
+<span class="sourceLineNo">265</span><a name="line.265"></a>
+<span class="sourceLineNo">266</span>  @Test<a name="line.266"></a>
+<span class="sourceLineNo">267</span>  public void testSetNormalizerRunning() 
throws Exception {<a name="line.267"></a>
+<span class="sourceLineNo">268</span>    verifyAdminCheckForAction((admin) 
-&gt; admin.normalizerSwitch(true));<a name="line.268"></a>
+<span class="sourceLineNo">269</span>  }<a name="line.269"></a>
+<span class="sourceLineNo">270</span><a name="line.270"></a>
+<span class="sourceLineNo">271</span>  @Test<a name="line.271"></a>
+<span class="sourceLineNo">272</span>  public void 
testExecRegionServerService() throws Exception {<a name="line.272"></a>
+<span class="sourceLineNo">273</span>    Action action = (admin) -&gt; {<a 
name="line.273"></a>
+<span class="sourceLineNo">274</span>      ServerName serverName = 
TEST_UTIL.getHBaseCluster().getRegionServer(0).getServerName();<a 
name="line.274"></a>
+<span class="sourceLineNo">275</span>      
TestRpcServiceProtos.TestProtobufRpcProto.BlockingInterface service =<a 
name="line.275"></a>
+<span class="sourceLineNo">276</span>          
TestRpcServiceProtos.TestProtobufRpcProto.newBlockingStub(<a 
name="line.276"></a>
+<span class="sourceLineNo">277</span>              
admin.coprocessorService(serverName));<a name="line.277"></a>
+<span class="sourceLineNo">278</span>      service.ping(null, 
TestProtos.EmptyRequestProto.getDefaultInstance());<a name="line.278"></a>
+<span class="sourceLineNo">279</span>    };<a name="line.279"></a>
+<span class="sourceLineNo">280</span><a name="line.280"></a>
+<span class="sourceLineNo">281</span>    verifyAllowed(USER_ADMIN, action);<a 
name="line.281"></a>
+<span class="sourceLineNo">282</span>    verifyAllowed(USER_GROUP_ADMIN, 
action);<a name="line.282"></a>
+<span class="sourceLineNo">283</span>    
verifiedDeniedServiceException(USER_NON_ADMIN, action);<a name="line.283"></a>
+<span class="sourceLineNo">284</span>  }<a name="line.284"></a>
+<span class="sourceLineNo">285</span><a name="line.285"></a>
+<span class="sourceLineNo">286</span>  @Test<a name="line.286"></a>
+<span class="sourceLineNo">287</span>  public void testTableFlush() throws 
Exception {<a name="line.287"></a>
+<span class="sourceLineNo">288</span>    TableName tn = 
TableName.valueOf(TEST_NAME.getMethodName());<a name="line.288"></a>
+<span class="sourceLineNo">289</span>    TableDescriptor desc = 
TableDescriptorBuilder.newBuilder(tn)<a name="line.289"></a>
+<span class="sourceLineNo">290</span>        
.setColumnFamily(ColumnFamilyDescriptorBuilder.of("f1")).build();<a 
name="line.290"></a>
+<span class="sourceLineNo">291</span>    Action adminAction = (admin) -&gt; 
{<a name="line.291"></a>
+<span class="sourceLineNo">292</span>      admin.createTable(desc);<a 
name="line.292"></a>
+<span class="sourceLineNo">293</span>      // Avoid giving a global permission 
which may screw up other tests<a name="line.293"></a>
+<span class="sourceLineNo">294</span>      SecureTestUtil.grantOnTable(<a 
name="line.294"></a>
+<span class="sourceLineNo">295</span>          TEST_UTIL, 
USER_NON_ADMIN.getShortName(), tn, null, null, Permission.Action.READ,<a 
name="line.295"></a>
+<span class="sourceLineNo">296</span>          Permission.Action.WRITE, 
Permission.Action.CREATE);<a name="line.296"></a>
+<span class="sourceLineNo">297</span>    };<a name="line.297"></a>
+<span class="sourceLineNo">298</span>    verifyAllowed(USER_ADMIN, 
adminAction);<a name="line.298"></a>
+<span class="sourceLineNo">299</span><a name="line.299"></a>
+<span class="sourceLineNo">300</span>    Action userAction = (admin) -&gt; {<a 
name="line.300"></a>
+<span class="sourceLineNo">301</span>      Connection conn = 
admin.getConnection();<a name="line.301"></a>
+<span class="sourceLineNo">302</span>      final byte[] rowKey = 
Bytes.toBytes("row1");<a name="line.302"></a>
+<span class="sourceLineNo">303</span>      final byte[] col = 
Bytes.toBytes("q1");<a name="line.303"></a>
+<span class="sourceLineNo">304</span>      final byte[] val = 
Bytes.toBytes("v1");<a name="line.304"></a>
+<span class="sourceLineNo">305</span>      try (Table table = 
conn.getTable(tn)) {<a name="line.305"></a>
+<span class="sourceLineNo">306</span>        // Write a value<a 
name="line.306"></a>
+<span class="sourceLineNo">307</span>        Put p = new Put(rowKey);<a 
name="line.307"></a>
+<span class="sourceLineNo">308</span>        p.addColumn(Bytes.toBytes("f1"), 
col, val);<a name="line.308"></a>
+<span class="sourceLineNo">309</span>        table.put(p);<a 
name="line.309"></a>
+<span class="sourceLineNo">310</span>        // Flush should not require ADMIN 
permission<a name="line.310"></a>
+<span class="sourceLineNo">311</span>        admin.flush(tn);<a 
name="line.311"></a>
+<span class="sourceLineNo">312</span>        // Nb: ideally, we would verify 
snapshot permission too (as that was fixed in the<a name="line.312"></a>
+<span class="sourceLineNo">313</span>        //   regression HBASE-20185) but 
taking a snapshot requires ADMIN permission which<a name="line.313"></a>
+<span class="sourceLineNo">314</span>        //   masks the root issue.<a 
name="line.314"></a>
+<span class="sourceLineNo">315</span>        // Make sure we read the value<a 
name="line.315"></a>
+<span class="sourceLineNo">316</span>        Result result = table.get(new 
Get(rowKey));<a name="line.316"></a>
+<span class="sourceLineNo">317</span>        assertFalse(result.isEmpty());<a 
name="line.317"></a>
+<span class="sourceLineNo">318</span>        Cell c = 
result.getColumnLatestCell(Bytes.toBytes("f1"), col);<a name="line.318"></a>
+<span class="sourceLineNo">319</span>        assertArrayEquals(val, 
CellUtil.cloneValue(c));<a name="line.319"></a>
+<span class="sourceLineNo">320</span>      }<a name="line.320"></a>
+<span class="sourceLineNo">321</span>    };<a name="line.321"></a>
+<span class="sourceLineNo">322</span>    verifyAllowed(USER_NON_ADMIN, 
userAction);<a name="line.322"></a>
+<span class="sourceLineNo">323</span>  }<a name="line.323"></a>
+<span class="sourceLineNo">324</span><a name="line.324"></a>
+<span class="sourceLineNo">325</span>  @Test<a name="line.325"></a>
+<span class="sourceLineNo">326</span>  public void testTableFlushAndSnapshot() 
throws Exception {<a name="line.326"></a>
+<span class="sourceLineNo">327</span>    TableName tn = 
TableName.valueOf(TEST_NAME.getMethodName());<a name="line.327"></a>
+<span class="sourceLineNo">328</span>    TableDescriptor desc = 
TableDescriptorBuilder.newBuilder(tn)<a name="line.328"></a>
+<span class="sourceLineNo">329</span>        
.setColumnFamily(ColumnFamilyDescriptorBuilder.of("f1")).build();<a 
name="line.329"></a>
+<span class="sourceLineNo">330</span>    Action adminAction = (admin) -&gt; 
{<a name="line.330"></a>
+<span class="sourceLineNo">331</span>      admin.createTable(desc);<a 
name="line.331"></a>
+<span class="sourceLineNo">332</span>      // Giving ADMIN here, but only on 
this table, *not* globally<a name="line.332"></a>
+<span class="sourceLineNo">333</span>      SecureTestUtil.grantOnTable(<a 
name="line.333"></a>
+<span class="sourceLineNo">334</span>          TEST_UTIL, 
USER_NON_ADMIN.getShortName(), tn, null, null, Permission.Action.READ,<a 
name="line.334"></a>
+<span class="sourceLineNo">335</span>          Permission.Action.WRITE, 
Permission.Action.CREATE, Permission.Action.ADMIN);<a name="line.335"></a>
+<span class="sourceLineNo">336</span>    };<a name="line.336"></a>
+<span class="sourceLineNo">337</span>    verifyAllowed(USER_ADMIN, 
adminAction);<a name="line.337"></a>
+<span class="sourceLineNo">338</span><a name="line.338"></a>
+<span class="sourceLineNo">339</span>    Action userAction = (admin) -&gt; {<a 
name="line.339"></a>
+<span class="sourceLineNo">340</span>      Connection conn = 
admin.getConnection();<a name="line.340"></a>
+<span class="sourceLineNo">341</span>      final byte[] rowKey = 
Bytes.toBytes("row1");<a name="line.341"></a>
+<span class="sourceLineNo">342</span>      final byte[] col = 
Bytes.toBytes("q1");<a name="line.342"></a>
+<span class="sourceLineNo">343</span>      final byte[] val = 
Bytes.toBytes("v1");<a name="line.343"></a>
+<span class="sourceLineNo">344</span>      try (Table table = 
conn.getTable(tn)) {<a name="line.344"></a>
+<span class="sourceLineNo">345</span>        // Write a value<a 
name="line.345"></a>
+<span class="sourceLineNo">346</span>        Put p = new Put(rowKey);<a 
name="line.346"></a>
+<span class="sourceLineNo">347</span>        p.addColumn(Bytes.toBytes("f1"), 
col, val);<a name="line.347"></a>
+<span class="sourceLineNo">348</span>        table.put(p);<a 
name="line.348"></a>
+<span class="sourceLineNo">349</span>        // Flush should not require ADMIN 
permission<a name="line.349"></a>
+<span class="sourceLineNo">350</span>        admin.flush(tn);<a 
name="line.350"></a>
+<span class="sourceLineNo">351</span>        // Table admin should be 
sufficient to snapshot this table<a name="line.351"></a>
+<span class="sourceLineNo">352</span>        
admin.snapshot(tn.getNameAsString() + "_snapshot1", tn);<a name="line.352"></a>
+<span class="sourceLineNo">353</span>        // Read the value just because<a 
name="line.353"></a>
+<span class="sourceLineNo">354</span>        Result result = table.get(new 
Get(rowKey));<a name="line.354"></a>
+<span class="sourceLineNo">355</span>        assertFalse(result.isEmpty());<a 
name="line.355"></a>
+<span class="sourceLineNo">356</span>        Cell c = 
result.getColumnLatestCell(Bytes.toBytes("f1"), col);<a name="line.356"></a>
+<span class="sourceLineNo">357</span>        assertArrayEquals(val, 
CellUtil.cloneValue(c));<a name="line.357"></a>
+<span class="sourceLineNo">358</span>      }<a name="line.358"></a>
+<span class="sourceLineNo">359</span>    };<a name="line.359"></a>
+<span class="sourceLineNo">360</span>    verifyAllowed(USER_NON_ADMIN, 
userAction);<a name="line.360"></a>
+<span class="sourceLineNo">361</span>  }<a name="line.361"></a>
+<span class="sourceLineNo">362</span>}<a name="line.362"></a>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+</pre>
+</div>
+</body>
+</html>

Reply via email to