http://git-wip-us.apache.org/repos/asf/hbase-site/blob/c8fd155e/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.SecureBulkLoadListener.html
----------------------------------------------------------------------
diff --git
a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.SecureBulkLoadListener.html
b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.SecureBulkLoadListener.html
index 293088d..3ec2d53 100644
---
a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.SecureBulkLoadListener.html
+++
b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.SecureBulkLoadListener.html
@@ -153,244 +153,270 @@
<span class="sourceLineNo">145</span><a name="line.145"></a>
<span class="sourceLineNo">146</span> public void cleanupBulkLoad(final
HRegion region, final CleanupBulkLoadRequest request)<a name="line.146"></a>
<span class="sourceLineNo">147</span> throws IOException {<a
name="line.147"></a>
-<span class="sourceLineNo">148</span>
region.getCoprocessorHost().preCleanupBulkLoad(getActiveUser());<a
name="line.148"></a>
-<span class="sourceLineNo">149</span><a name="line.149"></a>
-<span class="sourceLineNo">150</span> Path path = new
Path(request.getBulkToken());<a name="line.150"></a>
-<span class="sourceLineNo">151</span> if (!fs.delete(path, true)) {<a
name="line.151"></a>
-<span class="sourceLineNo">152</span> if (fs.exists(path)) {<a
name="line.152"></a>
-<span class="sourceLineNo">153</span> throw new IOException("Failed to
clean up " + path);<a name="line.153"></a>
-<span class="sourceLineNo">154</span> }<a name="line.154"></a>
-<span class="sourceLineNo">155</span> }<a name="line.155"></a>
-<span class="sourceLineNo">156</span> LOG.info("Cleaned up " + path + "
successfully.");<a name="line.156"></a>
-<span class="sourceLineNo">157</span> }<a name="line.157"></a>
-<span class="sourceLineNo">158</span><a name="line.158"></a>
-<span class="sourceLineNo">159</span> public Map<byte[],
List<Path>> secureBulkLoadHFiles(final HRegion region,<a
name="line.159"></a>
-<span class="sourceLineNo">160</span> final BulkLoadHFileRequest request)
throws IOException {<a name="line.160"></a>
-<span class="sourceLineNo">161</span> final List<Pair<byte[],
String>> familyPaths = new
ArrayList<>(request.getFamilyPathCount());<a name="line.161"></a>
-<span class="sourceLineNo">162</span>
for(ClientProtos.BulkLoadHFileRequest.FamilyPath el :
request.getFamilyPathList()) {<a name="line.162"></a>
-<span class="sourceLineNo">163</span> familyPaths.add(new
Pair<>(el.getFamily().toByteArray(), el.getPath()));<a
name="line.163"></a>
-<span class="sourceLineNo">164</span> }<a name="line.164"></a>
-<span class="sourceLineNo">165</span><a name="line.165"></a>
-<span class="sourceLineNo">166</span> Token userToken = null;<a
name="line.166"></a>
-<span class="sourceLineNo">167</span> if
(userProvider.isHadoopSecurityEnabled()) {<a name="line.167"></a>
-<span class="sourceLineNo">168</span> userToken = new
Token(request.getFsToken().getIdentifier().toByteArray(),
request.getFsToken()<a name="line.168"></a>
-<span class="sourceLineNo">169</span>
.getPassword().toByteArray(), new Text(request.getFsToken().getKind()), new
Text(<a name="line.169"></a>
-<span class="sourceLineNo">170</span>
request.getFsToken().getService()));<a name="line.170"></a>
-<span class="sourceLineNo">171</span> }<a name="line.171"></a>
-<span class="sourceLineNo">172</span> final String bulkToken =
request.getBulkToken();<a name="line.172"></a>
-<span class="sourceLineNo">173</span> User user = getActiveUser();<a
name="line.173"></a>
-<span class="sourceLineNo">174</span> final UserGroupInformation ugi =
user.getUGI();<a name="line.174"></a>
-<span class="sourceLineNo">175</span> if
(userProvider.isHadoopSecurityEnabled()) {<a name="line.175"></a>
-<span class="sourceLineNo">176</span> try {<a name="line.176"></a>
-<span class="sourceLineNo">177</span> Token tok =
TokenUtil.obtainToken(conn);<a name="line.177"></a>
-<span class="sourceLineNo">178</span> if (tok != null) {<a
name="line.178"></a>
-<span class="sourceLineNo">179</span> boolean b =
ugi.addToken(tok);<a name="line.179"></a>
-<span class="sourceLineNo">180</span> LOG.debug("token added " + tok
+ " for user " + ugi + " return=" + b);<a name="line.180"></a>
-<span class="sourceLineNo">181</span> }<a name="line.181"></a>
-<span class="sourceLineNo">182</span> } catch (IOException ioe) {<a
name="line.182"></a>
-<span class="sourceLineNo">183</span> LOG.warn("unable to add token",
ioe);<a name="line.183"></a>
-<span class="sourceLineNo">184</span> }<a name="line.184"></a>
-<span class="sourceLineNo">185</span> }<a name="line.185"></a>
-<span class="sourceLineNo">186</span> if (userToken != null) {<a
name="line.186"></a>
-<span class="sourceLineNo">187</span> ugi.addToken(userToken);<a
name="line.187"></a>
-<span class="sourceLineNo">188</span> } else if
(userProvider.isHadoopSecurityEnabled()) {<a name="line.188"></a>
-<span class="sourceLineNo">189</span> //we allow this to pass through in
"simple" security mode<a name="line.189"></a>
-<span class="sourceLineNo">190</span> //for mini cluster testing<a
name="line.190"></a>
-<span class="sourceLineNo">191</span> throw new
DoNotRetryIOException("User token cannot be null");<a name="line.191"></a>
-<span class="sourceLineNo">192</span> }<a name="line.192"></a>
-<span class="sourceLineNo">193</span><a name="line.193"></a>
-<span class="sourceLineNo">194</span> if (region.getCoprocessorHost() !=
null) {<a name="line.194"></a>
-<span class="sourceLineNo">195</span>
region.getCoprocessorHost().preBulkLoadHFile(familyPaths);<a
name="line.195"></a>
+<span class="sourceLineNo">148</span> try {<a name="line.148"></a>
+<span class="sourceLineNo">149</span>
region.getCoprocessorHost().preCleanupBulkLoad(getActiveUser());<a
name="line.149"></a>
+<span class="sourceLineNo">150</span><a name="line.150"></a>
+<span class="sourceLineNo">151</span> Path path = new
Path(request.getBulkToken());<a name="line.151"></a>
+<span class="sourceLineNo">152</span> if (!fs.delete(path, true)) {<a
name="line.152"></a>
+<span class="sourceLineNo">153</span> if (fs.exists(path)) {<a
name="line.153"></a>
+<span class="sourceLineNo">154</span> throw new IOException("Failed
to clean up " + path);<a name="line.154"></a>
+<span class="sourceLineNo">155</span> }<a name="line.155"></a>
+<span class="sourceLineNo">156</span> }<a name="line.156"></a>
+<span class="sourceLineNo">157</span> LOG.info("Cleaned up " + path + "
successfully.");<a name="line.157"></a>
+<span class="sourceLineNo">158</span> } finally {<a name="line.158"></a>
+<span class="sourceLineNo">159</span> UserGroupInformation ugi =
getActiveUser().getUGI();<a name="line.159"></a>
+<span class="sourceLineNo">160</span> try {<a name="line.160"></a>
+<span class="sourceLineNo">161</span> if
(!UserGroupInformation.getLoginUser().equals(ugi)) {<a name="line.161"></a>
+<span class="sourceLineNo">162</span>
FileSystem.closeAllForUGI(ugi);<a name="line.162"></a>
+<span class="sourceLineNo">163</span> }<a name="line.163"></a>
+<span class="sourceLineNo">164</span> } catch (IOException e) {<a
name="line.164"></a>
+<span class="sourceLineNo">165</span> LOG.error("Failed to close
FileSystem for: " + ugi, e);<a name="line.165"></a>
+<span class="sourceLineNo">166</span> }<a name="line.166"></a>
+<span class="sourceLineNo">167</span> }<a name="line.167"></a>
+<span class="sourceLineNo">168</span> }<a name="line.168"></a>
+<span class="sourceLineNo">169</span><a name="line.169"></a>
+<span class="sourceLineNo">170</span> public Map<byte[],
List<Path>> secureBulkLoadHFiles(final HRegion region,<a
name="line.170"></a>
+<span class="sourceLineNo">171</span> final BulkLoadHFileRequest request)
throws IOException {<a name="line.171"></a>
+<span class="sourceLineNo">172</span> final List<Pair<byte[],
String>> familyPaths = new
ArrayList<>(request.getFamilyPathCount());<a name="line.172"></a>
+<span class="sourceLineNo">173</span>
for(ClientProtos.BulkLoadHFileRequest.FamilyPath el :
request.getFamilyPathList()) {<a name="line.173"></a>
+<span class="sourceLineNo">174</span> familyPaths.add(new
Pair<>(el.getFamily().toByteArray(), el.getPath()));<a
name="line.174"></a>
+<span class="sourceLineNo">175</span> }<a name="line.175"></a>
+<span class="sourceLineNo">176</span><a name="line.176"></a>
+<span class="sourceLineNo">177</span> Token userToken = null;<a
name="line.177"></a>
+<span class="sourceLineNo">178</span> if
(userProvider.isHadoopSecurityEnabled()) {<a name="line.178"></a>
+<span class="sourceLineNo">179</span> userToken = new
Token(request.getFsToken().getIdentifier().toByteArray(),
request.getFsToken()<a name="line.179"></a>
+<span class="sourceLineNo">180</span>
.getPassword().toByteArray(), new Text(request.getFsToken().getKind()), new
Text(<a name="line.180"></a>
+<span class="sourceLineNo">181</span>
request.getFsToken().getService()));<a name="line.181"></a>
+<span class="sourceLineNo">182</span> }<a name="line.182"></a>
+<span class="sourceLineNo">183</span> final String bulkToken =
request.getBulkToken();<a name="line.183"></a>
+<span class="sourceLineNo">184</span> User user = getActiveUser();<a
name="line.184"></a>
+<span class="sourceLineNo">185</span> final UserGroupInformation ugi =
user.getUGI();<a name="line.185"></a>
+<span class="sourceLineNo">186</span> if
(userProvider.isHadoopSecurityEnabled()) {<a name="line.186"></a>
+<span class="sourceLineNo">187</span> try {<a name="line.187"></a>
+<span class="sourceLineNo">188</span> Token tok =
TokenUtil.obtainToken(conn);<a name="line.188"></a>
+<span class="sourceLineNo">189</span> if (tok != null) {<a
name="line.189"></a>
+<span class="sourceLineNo">190</span> boolean b =
ugi.addToken(tok);<a name="line.190"></a>
+<span class="sourceLineNo">191</span> LOG.debug("token added " + tok
+ " for user " + ugi + " return=" + b);<a name="line.191"></a>
+<span class="sourceLineNo">192</span> }<a name="line.192"></a>
+<span class="sourceLineNo">193</span> } catch (IOException ioe) {<a
name="line.193"></a>
+<span class="sourceLineNo">194</span> LOG.warn("unable to add token",
ioe);<a name="line.194"></a>
+<span class="sourceLineNo">195</span> }<a name="line.195"></a>
<span class="sourceLineNo">196</span> }<a name="line.196"></a>
-<span class="sourceLineNo">197</span> Map<byte[], List<Path>>
map = null;<a name="line.197"></a>
-<span class="sourceLineNo">198</span><a name="line.198"></a>
-<span class="sourceLineNo">199</span> try {<a name="line.199"></a>
-<span class="sourceLineNo">200</span> // Get the target fs (HBase region
server fs) delegation token<a name="line.200"></a>
-<span class="sourceLineNo">201</span> // Since we have checked the
permission via 'preBulkLoadHFile', now let's give<a name="line.201"></a>
-<span class="sourceLineNo">202</span> // the 'request user' necessary
token to operate on the target fs.<a name="line.202"></a>
-<span class="sourceLineNo">203</span> // After this point the 'doAs' user
will hold two tokens, one for the source fs<a name="line.203"></a>
-<span class="sourceLineNo">204</span> // ('request user'), another for
the target fs (HBase region server principal).<a name="line.204"></a>
-<span class="sourceLineNo">205</span> if
(userProvider.isHadoopSecurityEnabled()) {<a name="line.205"></a>
-<span class="sourceLineNo">206</span> FsDelegationToken
targetfsDelegationToken = new FsDelegationToken(userProvider,"renewer");<a
name="line.206"></a>
-<span class="sourceLineNo">207</span>
targetfsDelegationToken.acquireDelegationToken(fs);<a name="line.207"></a>
-<span class="sourceLineNo">208</span><a name="line.208"></a>
-<span class="sourceLineNo">209</span> Token<?> targetFsToken =
targetfsDelegationToken.getUserToken();<a name="line.209"></a>
-<span class="sourceLineNo">210</span> if (targetFsToken != null<a
name="line.210"></a>
-<span class="sourceLineNo">211</span> && (userToken == null
|| !targetFsToken.getService().equals(userToken.getService()))){<a
name="line.211"></a>
-<span class="sourceLineNo">212</span> ugi.addToken(targetFsToken);<a
name="line.212"></a>
-<span class="sourceLineNo">213</span> }<a name="line.213"></a>
-<span class="sourceLineNo">214</span> }<a name="line.214"></a>
-<span class="sourceLineNo">215</span><a name="line.215"></a>
-<span class="sourceLineNo">216</span> map = ugi.doAs(new
PrivilegedAction<Map<byte[], List<Path>>>() {<a
name="line.216"></a>
-<span class="sourceLineNo">217</span> @Override<a name="line.217"></a>
-<span class="sourceLineNo">218</span> public Map<byte[],
List<Path>> run() {<a name="line.218"></a>
-<span class="sourceLineNo">219</span> FileSystem fs = null;<a
name="line.219"></a>
-<span class="sourceLineNo">220</span> try {<a name="line.220"></a>
-<span class="sourceLineNo">221</span> fs = FileSystem.get(conf);<a
name="line.221"></a>
-<span class="sourceLineNo">222</span> for(Pair<byte[],
String> el: familyPaths) {<a name="line.222"></a>
-<span class="sourceLineNo">223</span> Path stageFamily = new
Path(bulkToken, Bytes.toString(el.getFirst()));<a name="line.223"></a>
-<span class="sourceLineNo">224</span> if(!fs.exists(stageFamily))
{<a name="line.224"></a>
-<span class="sourceLineNo">225</span> fs.mkdirs(stageFamily);<a
name="line.225"></a>
-<span class="sourceLineNo">226</span>
fs.setPermission(stageFamily, PERM_ALL_ACCESS);<a name="line.226"></a>
-<span class="sourceLineNo">227</span> }<a name="line.227"></a>
-<span class="sourceLineNo">228</span> }<a name="line.228"></a>
-<span class="sourceLineNo">229</span> //We call bulkLoadHFiles as
requesting user<a name="line.229"></a>
-<span class="sourceLineNo">230</span> //To enable access prior to
staging<a name="line.230"></a>
-<span class="sourceLineNo">231</span> return
region.bulkLoadHFiles(familyPaths, true,<a name="line.231"></a>
-<span class="sourceLineNo">232</span> new
SecureBulkLoadListener(fs, bulkToken, conf), request.getCopyFile());<a
name="line.232"></a>
-<span class="sourceLineNo">233</span> } catch (Exception e) {<a
name="line.233"></a>
-<span class="sourceLineNo">234</span> LOG.error("Failed to complete
bulk load", e);<a name="line.234"></a>
-<span class="sourceLineNo">235</span> }<a name="line.235"></a>
-<span class="sourceLineNo">236</span> return null;<a
name="line.236"></a>
-<span class="sourceLineNo">237</span> }<a name="line.237"></a>
-<span class="sourceLineNo">238</span> });<a name="line.238"></a>
-<span class="sourceLineNo">239</span> } finally {<a name="line.239"></a>
-<span class="sourceLineNo">240</span> if (region.getCoprocessorHost() !=
null) {<a name="line.240"></a>
-<span class="sourceLineNo">241</span>
region.getCoprocessorHost().postBulkLoadHFile(familyPaths, map);<a
name="line.241"></a>
-<span class="sourceLineNo">242</span> }<a name="line.242"></a>
-<span class="sourceLineNo">243</span> }<a name="line.243"></a>
-<span class="sourceLineNo">244</span> return map;<a name="line.244"></a>
-<span class="sourceLineNo">245</span> }<a name="line.245"></a>
-<span class="sourceLineNo">246</span><a name="line.246"></a>
-<span class="sourceLineNo">247</span> private Path createStagingDir(Path
baseDir,<a name="line.247"></a>
-<span class="sourceLineNo">248</span> User
user,<a name="line.248"></a>
-<span class="sourceLineNo">249</span> TableName
tableName) throws IOException {<a name="line.249"></a>
-<span class="sourceLineNo">250</span> String tblName =
tableName.getNameAsString().replace(":", "_");<a name="line.250"></a>
-<span class="sourceLineNo">251</span> String randomDir =
user.getShortName()+"__"+ tblName +"__"+<a name="line.251"></a>
-<span class="sourceLineNo">252</span> (new BigInteger(RANDOM_WIDTH,
random).toString(RANDOM_RADIX));<a name="line.252"></a>
-<span class="sourceLineNo">253</span> return createStagingDir(baseDir,
user, randomDir);<a name="line.253"></a>
-<span class="sourceLineNo">254</span> }<a name="line.254"></a>
-<span class="sourceLineNo">255</span><a name="line.255"></a>
-<span class="sourceLineNo">256</span> private Path createStagingDir(Path
baseDir,<a name="line.256"></a>
-<span class="sourceLineNo">257</span> User
user,<a name="line.257"></a>
-<span class="sourceLineNo">258</span> String
randomDir) throws IOException {<a name="line.258"></a>
-<span class="sourceLineNo">259</span> Path p = new Path(baseDir,
randomDir);<a name="line.259"></a>
-<span class="sourceLineNo">260</span> fs.mkdirs(p, PERM_ALL_ACCESS);<a
name="line.260"></a>
-<span class="sourceLineNo">261</span> fs.setPermission(p,
PERM_ALL_ACCESS);<a name="line.261"></a>
-<span class="sourceLineNo">262</span> return p;<a name="line.262"></a>
-<span class="sourceLineNo">263</span> }<a name="line.263"></a>
-<span class="sourceLineNo">264</span><a name="line.264"></a>
-<span class="sourceLineNo">265</span> private User getActiveUser() throws
IOException {<a name="line.265"></a>
-<span class="sourceLineNo">266</span> // for non-rpc handling, fallback to
system user<a name="line.266"></a>
-<span class="sourceLineNo">267</span> User user =
RpcServer.getRequestUser().orElse(userProvider.getCurrent());<a
name="line.267"></a>
-<span class="sourceLineNo">268</span> // this is for testing<a
name="line.268"></a>
-<span class="sourceLineNo">269</span> if
(userProvider.isHadoopSecurityEnabled() &&<a name="line.269"></a>
-<span class="sourceLineNo">270</span>
"simple".equalsIgnoreCase(conf.get(User.HBASE_SECURITY_CONF_KEY))) {<a
name="line.270"></a>
-<span class="sourceLineNo">271</span> return
User.createUserForTesting(conf, user.getShortName(), new String[] {});<a
name="line.271"></a>
-<span class="sourceLineNo">272</span> }<a name="line.272"></a>
-<span class="sourceLineNo">273</span><a name="line.273"></a>
-<span class="sourceLineNo">274</span> return user;<a name="line.274"></a>
-<span class="sourceLineNo">275</span> }<a name="line.275"></a>
-<span class="sourceLineNo">276</span><a name="line.276"></a>
-<span class="sourceLineNo">277</span> private static class
SecureBulkLoadListener implements BulkLoadListener {<a name="line.277"></a>
-<span class="sourceLineNo">278</span> // Target filesystem<a
name="line.278"></a>
-<span class="sourceLineNo">279</span> private final FileSystem fs;<a
name="line.279"></a>
-<span class="sourceLineNo">280</span> private final String stagingDir;<a
name="line.280"></a>
-<span class="sourceLineNo">281</span> private final Configuration conf;<a
name="line.281"></a>
-<span class="sourceLineNo">282</span> // Source filesystem<a
name="line.282"></a>
-<span class="sourceLineNo">283</span> private FileSystem srcFs = null;<a
name="line.283"></a>
-<span class="sourceLineNo">284</span> private Map<String,
FsPermission> origPermissions = null;<a name="line.284"></a>
-<span class="sourceLineNo">285</span><a name="line.285"></a>
-<span class="sourceLineNo">286</span> public
SecureBulkLoadListener(FileSystem fs, String stagingDir, Configuration conf)
{<a name="line.286"></a>
-<span class="sourceLineNo">287</span> this.fs = fs;<a name="line.287"></a>
-<span class="sourceLineNo">288</span> this.stagingDir = stagingDir;<a
name="line.288"></a>
-<span class="sourceLineNo">289</span> this.conf = conf;<a
name="line.289"></a>
-<span class="sourceLineNo">290</span> this.origPermissions = new
HashMap<>();<a name="line.290"></a>
-<span class="sourceLineNo">291</span> }<a name="line.291"></a>
-<span class="sourceLineNo">292</span><a name="line.292"></a>
-<span class="sourceLineNo">293</span> @Override<a name="line.293"></a>
-<span class="sourceLineNo">294</span> public String prepareBulkLoad(final
byte[] family, final String srcPath, boolean copyFile)<a name="line.294"></a>
-<span class="sourceLineNo">295</span> throws IOException {<a
name="line.295"></a>
-<span class="sourceLineNo">296</span> Path p = new Path(srcPath);<a
name="line.296"></a>
-<span class="sourceLineNo">297</span> Path stageP = new Path(stagingDir,
new Path(Bytes.toString(family), p.getName()));<a name="line.297"></a>
-<span class="sourceLineNo">298</span><a name="line.298"></a>
-<span class="sourceLineNo">299</span> // In case of Replication for bulk
load files, hfiles are already copied in staging directory<a
name="line.299"></a>
-<span class="sourceLineNo">300</span> if (p.equals(stageP)) {<a
name="line.300"></a>
-<span class="sourceLineNo">301</span> LOG.debug(p.getName()<a
name="line.301"></a>
-<span class="sourceLineNo">302</span> + " is already available in
staging directory. Skipping copy or rename.");<a name="line.302"></a>
-<span class="sourceLineNo">303</span> return stageP.toString();<a
name="line.303"></a>
-<span class="sourceLineNo">304</span> }<a name="line.304"></a>
-<span class="sourceLineNo">305</span><a name="line.305"></a>
-<span class="sourceLineNo">306</span> if (srcFs == null) {<a
name="line.306"></a>
-<span class="sourceLineNo">307</span> srcFs = FileSystem.get(p.toUri(),
conf);<a name="line.307"></a>
-<span class="sourceLineNo">308</span> }<a name="line.308"></a>
+<span class="sourceLineNo">197</span> if (userToken != null) {<a
name="line.197"></a>
+<span class="sourceLineNo">198</span> ugi.addToken(userToken);<a
name="line.198"></a>
+<span class="sourceLineNo">199</span> } else if
(userProvider.isHadoopSecurityEnabled()) {<a name="line.199"></a>
+<span class="sourceLineNo">200</span> //we allow this to pass through in
"simple" security mode<a name="line.200"></a>
+<span class="sourceLineNo">201</span> //for mini cluster testing<a
name="line.201"></a>
+<span class="sourceLineNo">202</span> throw new
DoNotRetryIOException("User token cannot be null");<a name="line.202"></a>
+<span class="sourceLineNo">203</span> }<a name="line.203"></a>
+<span class="sourceLineNo">204</span><a name="line.204"></a>
+<span class="sourceLineNo">205</span> if (region.getCoprocessorHost() !=
null) {<a name="line.205"></a>
+<span class="sourceLineNo">206</span>
region.getCoprocessorHost().preBulkLoadHFile(familyPaths);<a
name="line.206"></a>
+<span class="sourceLineNo">207</span> }<a name="line.207"></a>
+<span class="sourceLineNo">208</span> Map<byte[], List<Path>>
map = null;<a name="line.208"></a>
+<span class="sourceLineNo">209</span><a name="line.209"></a>
+<span class="sourceLineNo">210</span> try {<a name="line.210"></a>
+<span class="sourceLineNo">211</span> // Get the target fs (HBase region
server fs) delegation token<a name="line.211"></a>
+<span class="sourceLineNo">212</span> // Since we have checked the
permission via 'preBulkLoadHFile', now let's give<a name="line.212"></a>
+<span class="sourceLineNo">213</span> // the 'request user' necessary
token to operate on the target fs.<a name="line.213"></a>
+<span class="sourceLineNo">214</span> // After this point the 'doAs' user
will hold two tokens, one for the source fs<a name="line.214"></a>
+<span class="sourceLineNo">215</span> // ('request user'), another for
the target fs (HBase region server principal).<a name="line.215"></a>
+<span class="sourceLineNo">216</span> if
(userProvider.isHadoopSecurityEnabled()) {<a name="line.216"></a>
+<span class="sourceLineNo">217</span> FsDelegationToken
targetfsDelegationToken = new FsDelegationToken(userProvider,"renewer");<a
name="line.217"></a>
+<span class="sourceLineNo">218</span>
targetfsDelegationToken.acquireDelegationToken(fs);<a name="line.218"></a>
+<span class="sourceLineNo">219</span><a name="line.219"></a>
+<span class="sourceLineNo">220</span> Token<?> targetFsToken =
targetfsDelegationToken.getUserToken();<a name="line.220"></a>
+<span class="sourceLineNo">221</span> if (targetFsToken != null<a
name="line.221"></a>
+<span class="sourceLineNo">222</span> && (userToken == null
|| !targetFsToken.getService().equals(userToken.getService()))){<a
name="line.222"></a>
+<span class="sourceLineNo">223</span> ugi.addToken(targetFsToken);<a
name="line.223"></a>
+<span class="sourceLineNo">224</span> }<a name="line.224"></a>
+<span class="sourceLineNo">225</span> }<a name="line.225"></a>
+<span class="sourceLineNo">226</span><a name="line.226"></a>
+<span class="sourceLineNo">227</span> map = ugi.doAs(new
PrivilegedAction<Map<byte[], List<Path>>>() {<a
name="line.227"></a>
+<span class="sourceLineNo">228</span> @Override<a name="line.228"></a>
+<span class="sourceLineNo">229</span> public Map<byte[],
List<Path>> run() {<a name="line.229"></a>
+<span class="sourceLineNo">230</span> FileSystem fs = null;<a
name="line.230"></a>
+<span class="sourceLineNo">231</span> try {<a name="line.231"></a>
+<span class="sourceLineNo">232</span> fs = FileSystem.get(conf);<a
name="line.232"></a>
+<span class="sourceLineNo">233</span> for(Pair<byte[],
String> el: familyPaths) {<a name="line.233"></a>
+<span class="sourceLineNo">234</span> Path stageFamily = new
Path(bulkToken, Bytes.toString(el.getFirst()));<a name="line.234"></a>
+<span class="sourceLineNo">235</span> if(!fs.exists(stageFamily))
{<a name="line.235"></a>
+<span class="sourceLineNo">236</span> fs.mkdirs(stageFamily);<a
name="line.236"></a>
+<span class="sourceLineNo">237</span>
fs.setPermission(stageFamily, PERM_ALL_ACCESS);<a name="line.237"></a>
+<span class="sourceLineNo">238</span> }<a name="line.238"></a>
+<span class="sourceLineNo">239</span> }<a name="line.239"></a>
+<span class="sourceLineNo">240</span> //We call bulkLoadHFiles as
requesting user<a name="line.240"></a>
+<span class="sourceLineNo">241</span> //To enable access prior to
staging<a name="line.241"></a>
+<span class="sourceLineNo">242</span> return
region.bulkLoadHFiles(familyPaths, true,<a name="line.242"></a>
+<span class="sourceLineNo">243</span> new
SecureBulkLoadListener(fs, bulkToken, conf), request.getCopyFile());<a
name="line.243"></a>
+<span class="sourceLineNo">244</span> } catch (Exception e) {<a
name="line.244"></a>
+<span class="sourceLineNo">245</span> LOG.error("Failed to complete
bulk load", e);<a name="line.245"></a>
+<span class="sourceLineNo">246</span> }<a name="line.246"></a>
+<span class="sourceLineNo">247</span> return null;<a
name="line.247"></a>
+<span class="sourceLineNo">248</span> }<a name="line.248"></a>
+<span class="sourceLineNo">249</span> });<a name="line.249"></a>
+<span class="sourceLineNo">250</span> } finally {<a name="line.250"></a>
+<span class="sourceLineNo">251</span> if (region.getCoprocessorHost() !=
null) {<a name="line.251"></a>
+<span class="sourceLineNo">252</span>
region.getCoprocessorHost().postBulkLoadHFile(familyPaths, map);<a
name="line.252"></a>
+<span class="sourceLineNo">253</span> }<a name="line.253"></a>
+<span class="sourceLineNo">254</span> }<a name="line.254"></a>
+<span class="sourceLineNo">255</span> return map;<a name="line.255"></a>
+<span class="sourceLineNo">256</span> }<a name="line.256"></a>
+<span class="sourceLineNo">257</span><a name="line.257"></a>
+<span class="sourceLineNo">258</span> private Path createStagingDir(Path
baseDir,<a name="line.258"></a>
+<span class="sourceLineNo">259</span> User
user,<a name="line.259"></a>
+<span class="sourceLineNo">260</span> TableName
tableName) throws IOException {<a name="line.260"></a>
+<span class="sourceLineNo">261</span> String tblName =
tableName.getNameAsString().replace(":", "_");<a name="line.261"></a>
+<span class="sourceLineNo">262</span> String randomDir =
user.getShortName()+"__"+ tblName +"__"+<a name="line.262"></a>
+<span class="sourceLineNo">263</span> (new BigInteger(RANDOM_WIDTH,
random).toString(RANDOM_RADIX));<a name="line.263"></a>
+<span class="sourceLineNo">264</span> return createStagingDir(baseDir,
user, randomDir);<a name="line.264"></a>
+<span class="sourceLineNo">265</span> }<a name="line.265"></a>
+<span class="sourceLineNo">266</span><a name="line.266"></a>
+<span class="sourceLineNo">267</span> private Path createStagingDir(Path
baseDir,<a name="line.267"></a>
+<span class="sourceLineNo">268</span> User
user,<a name="line.268"></a>
+<span class="sourceLineNo">269</span> String
randomDir) throws IOException {<a name="line.269"></a>
+<span class="sourceLineNo">270</span> Path p = new Path(baseDir,
randomDir);<a name="line.270"></a>
+<span class="sourceLineNo">271</span> fs.mkdirs(p, PERM_ALL_ACCESS);<a
name="line.271"></a>
+<span class="sourceLineNo">272</span> fs.setPermission(p,
PERM_ALL_ACCESS);<a name="line.272"></a>
+<span class="sourceLineNo">273</span> return p;<a name="line.273"></a>
+<span class="sourceLineNo">274</span> }<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> private User getActiveUser() throws
IOException {<a name="line.276"></a>
+<span class="sourceLineNo">277</span> // for non-rpc handling, fallback to
system user<a name="line.277"></a>
+<span class="sourceLineNo">278</span> User user =
RpcServer.getRequestUser().orElse(userProvider.getCurrent());<a
name="line.278"></a>
+<span class="sourceLineNo">279</span> // this is for testing<a
name="line.279"></a>
+<span class="sourceLineNo">280</span> if
(userProvider.isHadoopSecurityEnabled() &&<a name="line.280"></a>
+<span class="sourceLineNo">281</span>
"simple".equalsIgnoreCase(conf.get(User.HBASE_SECURITY_CONF_KEY))) {<a
name="line.281"></a>
+<span class="sourceLineNo">282</span> return
User.createUserForTesting(conf, user.getShortName(), new String[] {});<a
name="line.282"></a>
+<span class="sourceLineNo">283</span> }<a name="line.283"></a>
+<span class="sourceLineNo">284</span><a name="line.284"></a>
+<span class="sourceLineNo">285</span> return user;<a name="line.285"></a>
+<span class="sourceLineNo">286</span> }<a name="line.286"></a>
+<span class="sourceLineNo">287</span><a name="line.287"></a>
+<span class="sourceLineNo">288</span> private static class
SecureBulkLoadListener implements BulkLoadListener {<a name="line.288"></a>
+<span class="sourceLineNo">289</span> // Target filesystem<a
name="line.289"></a>
+<span class="sourceLineNo">290</span> private final FileSystem fs;<a
name="line.290"></a>
+<span class="sourceLineNo">291</span> private final String stagingDir;<a
name="line.291"></a>
+<span class="sourceLineNo">292</span> private final Configuration conf;<a
name="line.292"></a>
+<span class="sourceLineNo">293</span> // Source filesystem<a
name="line.293"></a>
+<span class="sourceLineNo">294</span> private FileSystem srcFs = null;<a
name="line.294"></a>
+<span class="sourceLineNo">295</span> private Map<String,
FsPermission> origPermissions = null;<a name="line.295"></a>
+<span class="sourceLineNo">296</span><a name="line.296"></a>
+<span class="sourceLineNo">297</span> public
SecureBulkLoadListener(FileSystem fs, String stagingDir, Configuration conf)
{<a name="line.297"></a>
+<span class="sourceLineNo">298</span> this.fs = fs;<a name="line.298"></a>
+<span class="sourceLineNo">299</span> this.stagingDir = stagingDir;<a
name="line.299"></a>
+<span class="sourceLineNo">300</span> this.conf = conf;<a
name="line.300"></a>
+<span class="sourceLineNo">301</span> this.origPermissions = new
HashMap<>();<a name="line.301"></a>
+<span class="sourceLineNo">302</span> }<a name="line.302"></a>
+<span class="sourceLineNo">303</span><a name="line.303"></a>
+<span class="sourceLineNo">304</span> @Override<a name="line.304"></a>
+<span class="sourceLineNo">305</span> public String prepareBulkLoad(final
byte[] family, final String srcPath, boolean copyFile)<a name="line.305"></a>
+<span class="sourceLineNo">306</span> throws IOException {<a
name="line.306"></a>
+<span class="sourceLineNo">307</span> Path p = new Path(srcPath);<a
name="line.307"></a>
+<span class="sourceLineNo">308</span> Path stageP = new Path(stagingDir,
new Path(Bytes.toString(family), p.getName()));<a name="line.308"></a>
<span class="sourceLineNo">309</span><a name="line.309"></a>
-<span class="sourceLineNo">310</span> if(!isFile(p)) {<a
name="line.310"></a>
-<span class="sourceLineNo">311</span> throw new IOException("Path does
not reference a file: " + p);<a name="line.311"></a>
-<span class="sourceLineNo">312</span> }<a name="line.312"></a>
-<span class="sourceLineNo">313</span><a name="line.313"></a>
-<span class="sourceLineNo">314</span> // Check to see if the source and
target filesystems are the same<a name="line.314"></a>
-<span class="sourceLineNo">315</span> if (!FSHDFSUtils.isSameHdfs(conf,
srcFs, fs)) {<a name="line.315"></a>
-<span class="sourceLineNo">316</span> LOG.debug("Bulk-load file " +
srcPath + " is on different filesystem than " +<a name="line.316"></a>
-<span class="sourceLineNo">317</span> "the destination filesystem.
Copying file over to destination staging dir.");<a name="line.317"></a>
-<span class="sourceLineNo">318</span> FileUtil.copy(srcFs, p, fs,
stageP, false, conf);<a name="line.318"></a>
-<span class="sourceLineNo">319</span> } else if (copyFile) {<a
name="line.319"></a>
-<span class="sourceLineNo">320</span> LOG.debug("Bulk-load file " +
srcPath + " is copied to destination staging dir.");<a name="line.320"></a>
-<span class="sourceLineNo">321</span> FileUtil.copy(srcFs, p, fs,
stageP, false, conf);<a name="line.321"></a>
-<span class="sourceLineNo">322</span> } else {<a name="line.322"></a>
-<span class="sourceLineNo">323</span> LOG.debug("Moving " + p + " to "
+ stageP);<a name="line.323"></a>
-<span class="sourceLineNo">324</span> FileStatus origFileStatus =
fs.getFileStatus(p);<a name="line.324"></a>
-<span class="sourceLineNo">325</span> origPermissions.put(srcPath,
origFileStatus.getPermission());<a name="line.325"></a>
-<span class="sourceLineNo">326</span> if(!fs.rename(p, stageP)) {<a
name="line.326"></a>
-<span class="sourceLineNo">327</span> throw new IOException("Failed
to move HFile: " + p + " to " + stageP);<a name="line.327"></a>
-<span class="sourceLineNo">328</span> }<a name="line.328"></a>
-<span class="sourceLineNo">329</span> }<a name="line.329"></a>
-<span class="sourceLineNo">330</span> fs.setPermission(stageP,
PERM_ALL_ACCESS);<a name="line.330"></a>
-<span class="sourceLineNo">331</span> return stageP.toString();<a
name="line.331"></a>
-<span class="sourceLineNo">332</span> }<a name="line.332"></a>
-<span class="sourceLineNo">333</span><a name="line.333"></a>
-<span class="sourceLineNo">334</span> @Override<a name="line.334"></a>
-<span class="sourceLineNo">335</span> public void doneBulkLoad(byte[]
family, String srcPath) throws IOException {<a name="line.335"></a>
-<span class="sourceLineNo">336</span> LOG.debug("Bulk Load done for: " +
srcPath);<a name="line.336"></a>
-<span class="sourceLineNo">337</span> }<a name="line.337"></a>
-<span class="sourceLineNo">338</span><a name="line.338"></a>
-<span class="sourceLineNo">339</span> @Override<a name="line.339"></a>
-<span class="sourceLineNo">340</span> public void failedBulkLoad(final
byte[] family, final String srcPath) throws IOException {<a name="line.340"></a>
-<span class="sourceLineNo">341</span> if (!FSHDFSUtils.isSameHdfs(conf,
srcFs, fs)) {<a name="line.341"></a>
-<span class="sourceLineNo">342</span> // files are copied so no need to
move them back<a name="line.342"></a>
-<span class="sourceLineNo">343</span> return;<a name="line.343"></a>
-<span class="sourceLineNo">344</span> }<a name="line.344"></a>
-<span class="sourceLineNo">345</span> Path p = new Path(srcPath);<a
name="line.345"></a>
-<span class="sourceLineNo">346</span> Path stageP = new
Path(stagingDir,<a name="line.346"></a>
-<span class="sourceLineNo">347</span> new
Path(Bytes.toString(family), p.getName()));<a name="line.347"></a>
-<span class="sourceLineNo">348</span><a name="line.348"></a>
-<span class="sourceLineNo">349</span> // In case of Replication for bulk
load files, hfiles are not renamed by end point during<a name="line.349"></a>
-<span class="sourceLineNo">350</span> // prepare stage, so no need of
rename here again<a name="line.350"></a>
-<span class="sourceLineNo">351</span> if (p.equals(stageP)) {<a
name="line.351"></a>
-<span class="sourceLineNo">352</span> LOG.debug(p.getName() + " is
already available in source directory. Skipping rename.");<a
name="line.352"></a>
-<span class="sourceLineNo">353</span> return;<a name="line.353"></a>
-<span class="sourceLineNo">354</span> }<a name="line.354"></a>
-<span class="sourceLineNo">355</span><a name="line.355"></a>
-<span class="sourceLineNo">356</span> LOG.debug("Moving " + stageP + "
back to " + p);<a name="line.356"></a>
-<span class="sourceLineNo">357</span> if(!fs.rename(stageP, p))<a
name="line.357"></a>
-<span class="sourceLineNo">358</span> throw new IOException("Failed to
move HFile: " + stageP + " to " + p);<a name="line.358"></a>
-<span class="sourceLineNo">359</span><a name="line.359"></a>
-<span class="sourceLineNo">360</span> // restore original permission<a
name="line.360"></a>
-<span class="sourceLineNo">361</span> if
(origPermissions.containsKey(srcPath)) {<a name="line.361"></a>
-<span class="sourceLineNo">362</span> fs.setPermission(p,
origPermissions.get(srcPath));<a name="line.362"></a>
-<span class="sourceLineNo">363</span> } else {<a name="line.363"></a>
-<span class="sourceLineNo">364</span> LOG.warn("Can't find previous
permission for path=" + srcPath);<a name="line.364"></a>
-<span class="sourceLineNo">365</span> }<a name="line.365"></a>
-<span class="sourceLineNo">366</span> }<a name="line.366"></a>
-<span class="sourceLineNo">367</span><a name="line.367"></a>
-<span class="sourceLineNo">368</span> /**<a name="line.368"></a>
-<span class="sourceLineNo">369</span> * Check if the path is referencing a
file.<a name="line.369"></a>
-<span class="sourceLineNo">370</span> * This is mainly needed to avoid
symlinks.<a name="line.370"></a>
-<span class="sourceLineNo">371</span> * @param p<a name="line.371"></a>
-<span class="sourceLineNo">372</span> * @return true if the p is a file<a
name="line.372"></a>
-<span class="sourceLineNo">373</span> * @throws IOException<a
name="line.373"></a>
-<span class="sourceLineNo">374</span> */<a name="line.374"></a>
-<span class="sourceLineNo">375</span> private boolean isFile(Path p) throws
IOException {<a name="line.375"></a>
-<span class="sourceLineNo">376</span> FileStatus status =
srcFs.getFileStatus(p);<a name="line.376"></a>
-<span class="sourceLineNo">377</span> boolean isFile =
!status.isDirectory();<a name="line.377"></a>
-<span class="sourceLineNo">378</span> try {<a name="line.378"></a>
-<span class="sourceLineNo">379</span> isFile = isFile &&
!(Boolean)Methods.call(FileStatus.class, status, "isSymlink", null, null);<a
name="line.379"></a>
-<span class="sourceLineNo">380</span> } catch (Exception e) {<a
name="line.380"></a>
-<span class="sourceLineNo">381</span> }<a name="line.381"></a>
-<span class="sourceLineNo">382</span> return isFile;<a
name="line.382"></a>
-<span class="sourceLineNo">383</span> }<a name="line.383"></a>
-<span class="sourceLineNo">384</span> }<a name="line.384"></a>
-<span class="sourceLineNo">385</span>}<a name="line.385"></a>
+<span class="sourceLineNo">310</span> // In case of Replication for bulk
load files, hfiles are already copied in staging directory<a
name="line.310"></a>
+<span class="sourceLineNo">311</span> if (p.equals(stageP)) {<a
name="line.311"></a>
+<span class="sourceLineNo">312</span> LOG.debug(p.getName()<a
name="line.312"></a>
+<span class="sourceLineNo">313</span> + " is already available in
staging directory. Skipping copy or rename.");<a name="line.313"></a>
+<span class="sourceLineNo">314</span> return stageP.toString();<a
name="line.314"></a>
+<span class="sourceLineNo">315</span> }<a name="line.315"></a>
+<span class="sourceLineNo">316</span><a name="line.316"></a>
+<span class="sourceLineNo">317</span> if (srcFs == null) {<a
name="line.317"></a>
+<span class="sourceLineNo">318</span> srcFs =
FileSystem.newInstance(p.toUri(), conf);<a name="line.318"></a>
+<span class="sourceLineNo">319</span> }<a name="line.319"></a>
+<span class="sourceLineNo">320</span><a name="line.320"></a>
+<span class="sourceLineNo">321</span> if(!isFile(p)) {<a
name="line.321"></a>
+<span class="sourceLineNo">322</span> throw new IOException("Path does
not reference a file: " + p);<a name="line.322"></a>
+<span class="sourceLineNo">323</span> }<a name="line.323"></a>
+<span class="sourceLineNo">324</span><a name="line.324"></a>
+<span class="sourceLineNo">325</span> // Check to see if the source and
target filesystems are the same<a name="line.325"></a>
+<span class="sourceLineNo">326</span> if (!FSHDFSUtils.isSameHdfs(conf,
srcFs, fs)) {<a name="line.326"></a>
+<span class="sourceLineNo">327</span> LOG.debug("Bulk-load file " +
srcPath + " is on different filesystem than " +<a name="line.327"></a>
+<span class="sourceLineNo">328</span> "the destination filesystem.
Copying file over to destination staging dir.");<a name="line.328"></a>
+<span class="sourceLineNo">329</span> FileUtil.copy(srcFs, p, fs,
stageP, false, conf);<a name="line.329"></a>
+<span class="sourceLineNo">330</span> } else if (copyFile) {<a
name="line.330"></a>
+<span class="sourceLineNo">331</span> LOG.debug("Bulk-load file " +
srcPath + " is copied to destination staging dir.");<a name="line.331"></a>
+<span class="sourceLineNo">332</span> FileUtil.copy(srcFs, p, fs,
stageP, false, conf);<a name="line.332"></a>
+<span class="sourceLineNo">333</span> } else {<a name="line.333"></a>
+<span class="sourceLineNo">334</span> LOG.debug("Moving " + p + " to "
+ stageP);<a name="line.334"></a>
+<span class="sourceLineNo">335</span> FileStatus origFileStatus =
fs.getFileStatus(p);<a name="line.335"></a>
+<span class="sourceLineNo">336</span> origPermissions.put(srcPath,
origFileStatus.getPermission());<a name="line.336"></a>
+<span class="sourceLineNo">337</span> if(!fs.rename(p, stageP)) {<a
name="line.337"></a>
+<span class="sourceLineNo">338</span> throw new IOException("Failed
to move HFile: " + p + " to " + stageP);<a name="line.338"></a>
+<span class="sourceLineNo">339</span> }<a name="line.339"></a>
+<span class="sourceLineNo">340</span> }<a name="line.340"></a>
+<span class="sourceLineNo">341</span> fs.setPermission(stageP,
PERM_ALL_ACCESS);<a name="line.341"></a>
+<span class="sourceLineNo">342</span> return stageP.toString();<a
name="line.342"></a>
+<span class="sourceLineNo">343</span> }<a name="line.343"></a>
+<span class="sourceLineNo">344</span><a name="line.344"></a>
+<span class="sourceLineNo">345</span> @Override<a name="line.345"></a>
+<span class="sourceLineNo">346</span> public void doneBulkLoad(byte[]
family, String srcPath) throws IOException {<a name="line.346"></a>
+<span class="sourceLineNo">347</span> LOG.debug("Bulk Load done for: " +
srcPath);<a name="line.347"></a>
+<span class="sourceLineNo">348</span> closeSrcFs();<a name="line.348"></a>
+<span class="sourceLineNo">349</span> }<a name="line.349"></a>
+<span class="sourceLineNo">350</span><a name="line.350"></a>
+<span class="sourceLineNo">351</span> private void closeSrcFs() throws
IOException {<a name="line.351"></a>
+<span class="sourceLineNo">352</span> if (srcFs != null) {<a
name="line.352"></a>
+<span class="sourceLineNo">353</span> srcFs.close();<a
name="line.353"></a>
+<span class="sourceLineNo">354</span> srcFs = null;<a
name="line.354"></a>
+<span class="sourceLineNo">355</span> }<a name="line.355"></a>
+<span class="sourceLineNo">356</span> }<a name="line.356"></a>
+<span class="sourceLineNo">357</span><a name="line.357"></a>
+<span class="sourceLineNo">358</span> @Override<a name="line.358"></a>
+<span class="sourceLineNo">359</span> public void failedBulkLoad(final
byte[] family, final String srcPath) throws IOException {<a name="line.359"></a>
+<span class="sourceLineNo">360</span> try {<a name="line.360"></a>
+<span class="sourceLineNo">361</span> Path p = new Path(srcPath);<a
name="line.361"></a>
+<span class="sourceLineNo">362</span> if (srcFs == null) {<a
name="line.362"></a>
+<span class="sourceLineNo">363</span> srcFs =
FileSystem.newInstance(p.toUri(), conf);<a name="line.363"></a>
+<span class="sourceLineNo">364</span> }<a name="line.364"></a>
+<span class="sourceLineNo">365</span> if (!FSHDFSUtils.isSameHdfs(conf,
srcFs, fs)) {<a name="line.365"></a>
+<span class="sourceLineNo">366</span> // files are copied so no need
to move them back<a name="line.366"></a>
+<span class="sourceLineNo">367</span> return;<a name="line.367"></a>
+<span class="sourceLineNo">368</span> }<a name="line.368"></a>
+<span class="sourceLineNo">369</span> Path stageP = new
Path(stagingDir, new Path(Bytes.toString(family), p.getName()));<a
name="line.369"></a>
+<span class="sourceLineNo">370</span><a name="line.370"></a>
+<span class="sourceLineNo">371</span> // In case of Replication for
bulk load files, hfiles are not renamed by end point during<a
name="line.371"></a>
+<span class="sourceLineNo">372</span> // prepare stage, so no need of
rename here again<a name="line.372"></a>
+<span class="sourceLineNo">373</span> if (p.equals(stageP)) {<a
name="line.373"></a>
+<span class="sourceLineNo">374</span> LOG.debug(p.getName() + " is
already available in source directory. Skipping rename.");<a
name="line.374"></a>
+<span class="sourceLineNo">375</span> return;<a name="line.375"></a>
+<span class="sourceLineNo">376</span> }<a name="line.376"></a>
+<span class="sourceLineNo">377</span><a name="line.377"></a>
+<span class="sourceLineNo">378</span> LOG.debug("Moving " + stageP + "
back to " + p);<a name="line.378"></a>
+<span class="sourceLineNo">379</span> if (!fs.rename(stageP, p)) {<a
name="line.379"></a>
+<span class="sourceLineNo">380</span> throw new IOException("Failed
to move HFile: " + stageP + " to " + p);<a name="line.380"></a>
+<span class="sourceLineNo">381</span> }<a name="line.381"></a>
+<span class="sourceLineNo">382</span><a name="line.382"></a>
+<span class="sourceLineNo">383</span> // restore original permission<a
name="line.383"></a>
+<span class="sourceLineNo">384</span> if
(origPermissions.containsKey(srcPath)) {<a name="line.384"></a>
+<span class="sourceLineNo">385</span> fs.setPermission(p,
origPermissions.get(srcPath));<a name="line.385"></a>
+<span class="sourceLineNo">386</span> } else {<a name="line.386"></a>
+<span class="sourceLineNo">387</span> LOG.warn("Can't find previous
permission for path=" + srcPath);<a name="line.387"></a>
+<span class="sourceLineNo">388</span> }<a name="line.388"></a>
+<span class="sourceLineNo">389</span> } finally {<a name="line.389"></a>
+<span class="sourceLineNo">390</span> closeSrcFs();<a
name="line.390"></a>
+<span class="sourceLineNo">391</span> }<a name="line.391"></a>
+<span class="sourceLineNo">392</span> }<a name="line.392"></a>
+<span class="sourceLineNo">393</span><a name="line.393"></a>
+<span class="sourceLineNo">394</span> /**<a name="line.394"></a>
+<span class="sourceLineNo">395</span> * Check if the path is referencing a
file.<a name="line.395"></a>
+<span class="sourceLineNo">396</span> * This is mainly needed to avoid
symlinks.<a name="line.396"></a>
+<span class="sourceLineNo">397</span> * @param p<a name="line.397"></a>
+<span class="sourceLineNo">398</span> * @return true if the p is a file<a
name="line.398"></a>
+<span class="sourceLineNo">399</span> * @throws IOException<a
name="line.399"></a>
+<span class="sourceLineNo">400</span> */<a name="line.400"></a>
+<span class="sourceLineNo">401</span> private boolean isFile(Path p) throws
IOException {<a name="line.401"></a>
+<span class="sourceLineNo">402</span> FileStatus status =
srcFs.getFileStatus(p);<a name="line.402"></a>
+<span class="sourceLineNo">403</span> boolean isFile =
!status.isDirectory();<a name="line.403"></a>
+<span class="sourceLineNo">404</span> try {<a name="line.404"></a>
+<span class="sourceLineNo">405</span> isFile = isFile &&
!(Boolean)Methods.call(FileStatus.class, status, "isSymlink", null, null);<a
name="line.405"></a>
+<span class="sourceLineNo">406</span> } catch (Exception e) {<a
name="line.406"></a>
+<span class="sourceLineNo">407</span> }<a name="line.407"></a>
+<span class="sourceLineNo">408</span> return isFile;<a
name="line.408"></a>
+<span class="sourceLineNo">409</span> }<a name="line.409"></a>
+<span class="sourceLineNo">410</span> }<a name="line.410"></a>
+<span class="sourceLineNo">411</span>}<a name="line.411"></a>