HBASE-20554 "WALs outstanding" message from CleanerChore is noisy
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/c191462a Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/c191462a Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/c191462a Branch: refs/heads/branch-1 Commit: c191462ac35461c6c592a3d7ab2328b88963b461 Parents: 5406f63 Author: Andrew Purtell <apurt...@apache.org> Authored: Wed May 9 10:16:44 2018 -0700 Committer: Andrew Purtell <apurt...@apache.org> Committed: Wed May 9 19:13:17 2018 -0700 ---------------------------------------------------------------------- .../hadoop/hbase/master/cleaner/CleanerChore.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/hbase/blob/c191462a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java ---------------------------------------------------------------------- diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java index ea18193..f073d30 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java @@ -263,9 +263,13 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu try { POOL.latchCountUp(); if (runCleaner()) { - LOG.debug("Cleaned all WALs under " + oldFileDir); + if (LOG.isTraceEnabled()) { + LOG.trace("Cleaned all WALs under " + oldFileDir); + } } else { - LOG.warn("WALs outstanding under " + oldFileDir); + if (LOG.isTraceEnabled()) { + LOG.trace("WALs outstanding under " + oldFileDir); + } } } finally { POOL.latchCountDown(); @@ -278,7 +282,9 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod()))); } } else { - LOG.debug("Cleaner chore disabled! Not cleaning."); + if (LOG.isTraceEnabled()) { + LOG.trace("Cleaner chore disabled! Not cleaning."); + } } }