[hbase] branch branch-2 updated: HBASE-21056 Findbugs false positive: BucketCache.persistToFile may fail to clean up java.io.OutputStream

[psomogyi]

This is an automated email from the ASF dual-hosted git repository.

psomogyi pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new 1110e23  HBASE-21056 Findbugs false positive: 
BucketCache.persistToFile may fail to clean up java.io.OutputStream
1110e23 is described below

commit 1110e23a61253ace60b0ea2150cdbf6a75ef5b4b
Author: Sean Busbey <bus...@apache.org>
AuthorDate: Wed Aug 15 09:24:55 2018 -0500

    HBASE-21056 Findbugs false positive: BucketCache.persistToFile may fail to 
clean up java.io.OutputStream
    
    Signed-off-by: Andrew Purtell <apurt...@apache.org>
---
 .../main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java  | 2 ++
 1 file changed, 2 insertions(+)

diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
index ef8c4d1..99abfea 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
@@ -1044,6 +1044,8 @@ public class BucketCache implements BlockCache, HeapSize {
   /**
    * @see #retrieveFromFile(int[])
    */
+  
@edu.umd.cs.findbugs.annotations.SuppressWarnings(value="OBL_UNSATISFIED_OBLIGATION",
+      justification = "false positive, try-with-resources ensures close is 
called.")
   private void persistToFile() throws IOException {
     assert !cacheEnabled;
     if (!ioEngine.isPersistent()) {