This is an automated email from the ASF dual-hosted git repository. jdere pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push: new 34d2bda HIVE-21518: GenericUDFOPNotEqualNS does not run in LLAP (Jason Dere, reviewed by Vineet Garg) 34d2bda is described below commit 34d2bda8ec52299b5fa398648ddc1ce40bd94182 Author: Jason Dere <jd...@hortonworks.com> AuthorDate: Mon Apr 1 13:18:59 2019 -0700 HIVE-21518: GenericUDFOPNotEqualNS does not run in LLAP (Jason Dere, reviewed by Vineet Garg) --- itests/src/test/resources/testconfiguration.properties | 1 + ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java | 2 ++ ql/src/test/queries/clientpositive/llap_notequalns.q | 5 +++++ ql/src/test/results/clientpositive/llap/llap_notequalns.q.out | 9 +++++++++ 4 files changed, 17 insertions(+) diff --git a/itests/src/test/resources/testconfiguration.properties b/itests/src/test/resources/testconfiguration.properties index c61c430..96dfbc4 100644 --- a/itests/src/test/resources/testconfiguration.properties +++ b/itests/src/test/resources/testconfiguration.properties @@ -776,6 +776,7 @@ minillaplocal.query.files=\ udaf_collect_set_2.q,\ udaf_all_keyword.q,\ udf_coalesce.q,\ + llap_notequalns.q,\ union_assertion_type.q,\ union_fast_stats.q,\ union_rowcounts.q,\ diff --git a/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java index 253570b..d08b05f 100644 --- a/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java +++ b/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java @@ -567,6 +567,8 @@ public final class FunctionRegistry { system.registerHiddenBuiltIn(GenericUDFOPDTIPlus.class); system.registerHiddenBuiltIn(GenericUDFOPNumericMinus.class); system.registerHiddenBuiltIn(GenericUDFOPNumericPlus.class); + // No operator for nullsafe not equal, but add as built-in to allow for LLAP. + system.registerHiddenBuiltIn(GenericUDFOPNotEqualNS.class); // mask UDFs system.registerGenericUDF(GenericUDFMask.UDF_NAME, GenericUDFMask.class); diff --git a/ql/src/test/queries/clientpositive/llap_notequalns.q b/ql/src/test/queries/clientpositive/llap_notequalns.q new file mode 100644 index 0000000..a09d09d --- /dev/null +++ b/ql/src/test/queries/clientpositive/llap_notequalns.q @@ -0,0 +1,5 @@ +--! qt:dataset:src + +set hive.fetch.task.conversion=none; + +SELECT NOT (key <=> key) from src tablesample (1 rows); diff --git a/ql/src/test/results/clientpositive/llap/llap_notequalns.q.out b/ql/src/test/results/clientpositive/llap/llap_notequalns.q.out new file mode 100644 index 0000000..31c6021 --- /dev/null +++ b/ql/src/test/results/clientpositive/llap/llap_notequalns.q.out @@ -0,0 +1,9 @@ +PREHOOK: query: SELECT NOT (key <=> key) from src tablesample (1 rows) +PREHOOK: type: QUERY +PREHOOK: Input: default@src +#### A masked pattern was here #### +POSTHOOK: query: SELECT NOT (key <=> key) from src tablesample (1 rows) +POSTHOOK: type: QUERY +POSTHOOK: Input: default@src +#### A masked pattern was here #### +false