This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hive.git
The following commit(s) were added to refs/heads/master by this push: new 698194183a2 HIVE-27846: HIVE-27849: Tests under hive-unit module are not running (Stamatis Zampetakis reviewed by Ayush Saxena) 698194183a2 is described below commit 698194183a2cb4ee6bc528ee71462cbae2c2c7ad Author: Stamatis Zampetakis <zabe...@gmail.com> AuthorDate: Thu Nov 2 12:52:41 2023 +0100 HIVE-27846: HIVE-27849: Tests under hive-unit module are not running (Stamatis Zampetakis reviewed by Ayush Saxena) 1. Drop jupiter-engine dependency from hive-unit module preventing tests from running. 2. Remove redundant jupiter annotations from TestStorageSchemaReader to avoid dependencies to jupiter API. 3. Revert ivy upgrade cause since it leads to failures in replication tests: * TestReplAcrossInstancesWithJsonMessageFormat; * TestReplicationScenariosAcrossInstances tests. 4. Disable TestCrudCompactorOnTez#secondCompactionShouldBeRefusedBeforeEnqueueing test till HIVE-27848 is resolved. Close apache/hive#4850 --- itests/hive-unit/pom.xml | 5 ----- .../org/apache/hadoop/hive/metastore/TestStorageSchemaReader.java | 6 ++---- .../apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java | 2 ++ pom.xml | 2 +- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/itests/hive-unit/pom.xml b/itests/hive-unit/pom.xml index 09d4f5712f9..29ece216722 100644 --- a/itests/hive-unit/pom.xml +++ b/itests/hive-unit/pom.xml @@ -208,11 +208,6 @@ <artifactId>junit</artifactId> <scope>test</scope> </dependency> - <dependency> - <groupId>org.junit.jupiter</groupId> - <artifactId>junit-jupiter-engine</artifactId> - <scope>test</scope> - </dependency> <dependency> <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-hdfs</artifactId> diff --git a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestStorageSchemaReader.java b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestStorageSchemaReader.java index c6e1f1a4b0d..fadd793bc23 100644 --- a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestStorageSchemaReader.java +++ b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestStorageSchemaReader.java @@ -36,8 +36,6 @@ import org.apache.thrift.TException; import org.junit.After; import org.junit.Before; import org.junit.Test; -import org.junit.jupiter.api.AfterEach; -import org.junit.jupiter.api.BeforeEach; import java.util.HashMap; import java.util.List; @@ -59,7 +57,7 @@ public class TestStorageSchemaReader { Map<String, String> jdbcTableParams = new HashMap<>(); Map<String, String> jdbcSerdeParams = new HashMap<>(); - @Before @BeforeEach public void setUp() throws Exception { + @Before public void setUp() throws Exception { dbName = "sampleDb"; hiveConf = new HiveConf(this.getClass()); new DatabaseBuilder().setName(dbName).create(new HiveMetaStoreClient(hiveConf), hiveConf); @@ -83,7 +81,7 @@ public class TestStorageSchemaReader { jdbcTableParams.put("storage_handler", "org.apache.hive.storage.jdbc.JdbcStorageHandler"); } - @After @AfterEach public void tearDown() throws Exception { + @After public void tearDown() throws Exception { new HiveMetaStoreClient(hiveConf).dropDatabase(dbName, true, true, true); } diff --git a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java index e72811e103b..295bbdd09f7 100644 --- a/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java +++ b/itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java @@ -77,6 +77,7 @@ import org.apache.orc.StripeInformation; import org.apache.orc.TypeDescription; import org.apache.orc.impl.RecordReaderImpl; import org.junit.Assert; +import org.junit.Ignore; import org.junit.Test; import org.mockito.ArgumentCaptor; import org.mockito.Mockito; @@ -601,6 +602,7 @@ public class TestCrudCompactorOnTez extends CompactorOnTezTest { } @Test + @Ignore("HIVE-27848") public void secondCompactionShouldBeRefusedBeforeEnqueueing() throws Exception { conf.setBoolVar(HiveConf.ConfVars.COMPACTOR_CRUD_QUERY_BASED, true); diff --git a/pom.xml b/pom.xml index bf8a5d3e5fd..c163ce1d3a2 100644 --- a/pom.xml +++ b/pom.xml @@ -151,7 +151,7 @@ <!-- httpcomponents are not always in version sync --> <httpcomponents.client.version>4.5.13</httpcomponents.client.version> <httpcomponents.core.version>4.4.13</httpcomponents.core.version> - <ivy.version>2.5.2</ivy.version> + <ivy.version>2.5.1</ivy.version> <jackson.version>2.13.5</jackson.version> <jamon.plugin.version>2.3.4</jamon.plugin.version> <jamon-runtime.version>2.4.1</jamon-runtime.version>