[GitHub] [incubator-hudi] XuQianJin-Stars commented on issue #1044: [HUDI-361] Implement CSV metrics reporter

2019-11-22 Thread GitBox
XuQianJin-Stars commented on issue #1044: [HUDI-361] Implement CSV metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1044#issuecomment-557770820 The CI is broken! This is an automated message from the

[jira] [Updated] (HUDI-361) Implement CSV metrics reporter

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-361: Labels: pull-request-available (was: ) > Implement CSV metrics reporter >

[GitHub] [incubator-hudi] XuQianJin-Stars opened a new pull request #1044: [HUDI-361] Implement CSV metrics reporter

2019-11-22 Thread GitBox
XuQianJin-Stars opened a new pull request #1044: [HUDI-361] Implement CSV metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1044 Currently, there are only two reporters MetricsGraphiteReporter and InMemoryMetricsReporter. InMemoryMetricsReporter is used for testing. So

[jira] [Updated] (HUDI-361) Implement CSV metrics reporter

2019-11-22 Thread Forward Xu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forward Xu updated HUDI-361: Description: Currently, there are only two reporters  {{MetricsGraphiteReporter}} and 

[jira] [Updated] (HUDI-361) Implement CSV metrics reporter

2019-11-22 Thread Forward Xu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forward Xu updated HUDI-361: Summary: Implement CSV metrics reporter (was: Implement csv metrics reporter) > Implement CSV metrics

[jira] [Updated] (HUDI-328) Add support for Delete api in HoodieWriteClient

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-328: Labels: pull-request-available (was: ) > Add support for Delete api in HoodieWriteClient >

[GitHub] [incubator-hudi] bvaradar merged pull request #1004: [HUDI-328] Adding delete api to HoodieWriteClient

2019-11-22 Thread GitBox
bvaradar merged pull request #1004: [HUDI-328] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004 This is an automated message from the Apache Git Service. To respond to the

[incubator-hudi] branch master updated: [HUDI-328] Adding delete api to HoodieWriteClient (#1004)

2019-11-22 Thread vbalaji
This is an automated email from the ASF dual-hosted git repository. vbalaji pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new c335510 [HUDI-328] Adding delete api

[GitHub] [incubator-hudi] nsivabalan commented on issue #1021: how can i deal this problem when partition's value changed with the same row_key?

2019-11-22 Thread GitBox
nsivabalan commented on issue #1021: how can i deal this problem when partition's value changed with the same row_key? URL: https://github.com/apache/incubator-hudi/issues/1021#issuecomment-557726866 Sure. I can take a look.

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1004: [HUDI-328] Adding delete api to HoodieWriteClient

2019-11-22 Thread GitBox
nsivabalan commented on a change in pull request #1004: [HUDI-328] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r349825756 ## File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieSanity.java

[GitHub] [incubator-hudi] leesf commented on issue #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-22 Thread GitBox
leesf commented on issue #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#issuecomment-557696257 @pratyakshsharma Could you please add some tests when sourceLimit or `Config.MAX_EVENTS_FROM_KAFKA_SOURCE_PROP`

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-22 Thread GitBox
leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349792634 ## File path:

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-328] Adding delete api to HoodieWriteClient

2019-11-22 Thread GitBox
bvaradar commented on a change in pull request #1004: [HUDI-328] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r349776679 ## File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieSanity.java

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-328] Adding delete api to HoodieWriteClient

2019-11-22 Thread GitBox
bvaradar commented on a change in pull request #1004: [HUDI-328] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r349776876 ## File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieSanity.java

[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request #1042: [HUDI-359] Add hudi-env for hudi-cli module

2019-11-22 Thread GitBox
lamber-ken commented on a change in pull request #1042: [HUDI-359] Add hudi-env for hudi-cli module URL: https://github.com/apache/incubator-hudi/pull/1042#discussion_r349747771 ## File path: hudi-cli/hudi-cli.sh ## @@ -20,15 +20,12 @@ DIR="$( cd "$( dirname

[jira] [Updated] (HUDI-358) Add Java-doc and importOrder checkstyle rule

2019-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-358: Labels: pull-request-available (was: ) > Add Java-doc and importOrder checkstyle rule >

[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1043: [HUDI-358] Add Java-doc and importOrder checkstyle rule

2019-11-22 Thread GitBox
lamber-ken opened a new pull request #1043: [HUDI-358] Add Java-doc and importOrder checkstyle rule URL: https://github.com/apache/incubator-hudi/pull/1043 ## What is the purpose of the pull request Add checkstyle rule to enhance code quality and the java doc. ## Brief change

[jira] [Commented] (HUDI-184) Integrate Hudi with Apache Flink

2019-11-22 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980247#comment-16980247 ] vinoyang commented on HUDI-184: --- [~vinoth] I have started to think about some questions and view the

[GitHub] [incubator-hudi] nsivabalan commented on issue #1004: [HUDI-328] Adding delete api to HoodieWriteClient

2019-11-22 Thread GitBox
nsivabalan commented on issue #1004: [HUDI-328] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#issuecomment-557562325 @bvaradar : have fixed the build issue. Patch is good to be merged. You can check the latest commit for the fix(instead of

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-22 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980153#comment-16980153 ] lamber-ken commented on HUDI-354: - Okay, I see. > Introduce stricter comment and code style validation

[GitHub] [incubator-hudi] alphairys commented on issue #1034: Datasource Writer throws error on resolving struct fields

2019-11-22 Thread GitBox
alphairys commented on issue #1034: Datasource Writer throws error on resolving struct fields URL: https://github.com/apache/incubator-hudi/issues/1034#issuecomment-557518462 @rbhartia , thanks for the update. Will be on the lookout for the fix.

[jira] [Commented] (HUDI-184) Integrate Hudi with Apache Flink

2019-11-22 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980117#comment-16980117 ] Vinoth Chandar commented on HUDI-184: - We can start with streaming APIs IMO. I think Batch APIs might

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-22 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980107#comment-16980107 ] Vinoth Chandar commented on HUDI-354: - FYI My only rule of thumb around these is to not make

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-22 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980105#comment-16980105 ] lamber-ken commented on HUDI-354: - Hi, [~vinoth] When using same checkstyle rule, [~xleesf] and I can go

[GitHub] [incubator-hudi] vinothchandar commented on issue #1021: how can i deal this problem when partition's value changed with the same row_key?

2019-11-22 Thread GitBox
vinothchandar commented on issue #1021: how can i deal this problem when partition's value changed with the same row_key? URL: https://github.com/apache/incubator-hudi/issues/1021#issuecomment-557510757 This seems similar to https://issues.apache.org/jira/browse/HUDI-116 we fixed

[GitHub] [incubator-hudi] vinothchandar closed issue #764: Hoodie 0.4.7: Error upserting bucketType UPDATE for partition #, No value present

2019-11-22 Thread GitBox
vinothchandar closed issue #764: Hoodie 0.4.7: Error upserting bucketType UPDATE for partition #, No value present URL: https://github.com/apache/incubator-hudi/issues/764 This is an automated message from the Apache Git

[jira] [Updated] (HUDI-360) Add github stale action workflow for issue management

2019-11-22 Thread Gurudatt Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/HUDI-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gurudatt Kulkarni updated HUDI-360: --- Description: Add a GitHub action for closing stale (90 days) issues. > Add github stale action

[GitHub] [incubator-hudi] lamber-ken closed issue #1041: [Question] Where is client jar in hudi-cli.sh

2019-11-22 Thread GitBox
lamber-ken closed issue #1041: [Question] Where is client jar in hudi-cli.sh URL: https://github.com/apache/incubator-hudi/issues/1041 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-hudi] lamber-ken commented on issue #1041: [Question] Where is client jar in hudi-cli.sh

2019-11-22 Thread GitBox
lamber-ken commented on issue #1041: [Question] Where is client jar in hudi-cli.sh URL: https://github.com/apache/incubator-hudi/issues/1041#issuecomment-557505402 > @lamber-ken So, sometime you need the RecordPayload etc which is user code... Client jar is arguably named confusingly :) .

[jira] [Created] (HUDI-360) Add github stale action workflow for issue management

2019-11-22 Thread Gurudatt Kulkarni (Jira)
Gurudatt Kulkarni created HUDI-360: -- Summary: Add github stale action workflow for issue management Key: HUDI-360 URL: https://issues.apache.org/jira/browse/HUDI-360 Project: Apache Hudi (incubating)

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1042: [HUDI-359] Add hudi-env for hudi-cli module

2019-11-22 Thread GitBox
vinothchandar commented on a change in pull request #1042: [HUDI-359] Add hudi-env for hudi-cli module URL: https://github.com/apache/incubator-hudi/pull/1042#discussion_r349560574 ## File path: hudi-cli/conf/hudi-env.sh ## @@ -0,0 +1,24 @@ +#!/usr/bin/env bash +

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-22 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980079#comment-16980079 ] lamber-ken commented on HUDI-354: - hi, [~gurudatt], the right way is choose between CustomImportOrder and

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-22 Thread GitBox
leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349559219 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on issue #1040: [HUDI-327] Add null/empty checks to key generators

2019-11-22 Thread GitBox
vinothchandar commented on issue #1040: [HUDI-327] Add null/empty checks to key generators URL: https://github.com/apache/incubator-hudi/pull/1040#issuecomment-557500023 Rekicked the CI. Seemed like it ran out of memory. Don't think its related to this PR per se.

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-22 Thread Gurudatt Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980075#comment-16980075 ] Gurudatt Kulkarni commented on HUDI-354: [~lamber-ken] You don't have to apologize :) . I am new to

[jira] [Updated] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-22 Thread Gurudatt Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gurudatt Kulkarni updated HUDI-354: --- Attachment: Screenshot 2019-11-22 at 5.02.32 PM.png > Introduce stricter comment and code

[GitHub] [incubator-hudi] vinothchandar merged pull request #1024: [HUDI-345] Fix used deprecated function

2019-11-22 Thread GitBox
vinothchandar merged pull request #1024: [HUDI-345] Fix used deprecated function URL: https://github.com/apache/incubator-hudi/pull/1024 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-hudi] branch master updated (17eaf41 -> 7bc08cb)

2019-11-22 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git. from 17eaf41 [HUDI-348] Add Issue template for the project (#1029) add 7bc08cb [HUDI-345] Fix used

[jira] [Updated] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-22 Thread Gurudatt Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gurudatt Kulkarni updated HUDI-354: --- Attachment: Screenshot 2019-11-22 at 4.58.58 PM.png > Introduce stricter comment and code

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-22 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980074#comment-16980074 ] Vinoth Chandar commented on HUDI-354: - Took a cursory pass at what the maven-enforcer-plugin does.. Do

[GitHub] [incubator-hudi] vinothchandar commented on issue #1041: [Question] Where is client jar in hudi-cli.sh

2019-11-22 Thread GitBox
vinothchandar commented on issue #1041: [Question] Where is client jar in hudi-cli.sh URL: https://github.com/apache/incubator-hudi/issues/1041#issuecomment-557496948 @lamber-ken So, sometime you need the RecordPayload etc which is user code... Client jar is arguably named confusingly :)

[incubator-hudi] branch master updated (1e14390 -> 17eaf41)

2019-11-22 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git. from 1e14390 [HUDI-350]: updated default value of config.getCleanerCommitsRetained() in javadocs add

[GitHub] [incubator-hudi] vinothchandar merged pull request #1029: [HUDI-348] Add Issue template for the project

2019-11-22 Thread GitBox
vinothchandar merged pull request #1029: [HUDI-348] Add Issue template for the project URL: https://github.com/apache/incubator-hudi/pull/1029 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HUDI-184) Integrate Hudi with Apache Flink

2019-11-22 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979954#comment-16979954 ] vinoyang commented on HUDI-184: --- [~taherk77] Thanks for sharing your thought. I agree that we can start by