[GitHub] [hudi] hj2016 commented on pull request #1978: [HUDI-1184] Fix the support of hbase index partition path change

2020-09-11 Thread GitBox
hj2016 commented on pull request #1978: URL: https://github.com/apache/hudi/pull/1978#issuecomment-691379071 @n3nash The problem nsivabalan said, I have fixed it a few days ago. I don’t know if you are talking about the same problem. If not, can I elaborate on it?

[hudi] branch master updated: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly (#2084)

2020-09-11 Thread vbalaji
This is an automated email from the ASF dual-hosted git repository. vbalaji pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 5e61454 [HUDI-802] AWSDmsTransformer does not

[hudi] branch master updated: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly (#2084)

2020-09-11 Thread vbalaji
This is an automated email from the ASF dual-hosted git repository. vbalaji pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 5e61454 [HUDI-802] AWSDmsTransformer does not

[hudi] branch master updated: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly (#2084)

2020-09-11 Thread vbalaji
This is an automated email from the ASF dual-hosted git repository. vbalaji pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 5e61454 [HUDI-802] AWSDmsTransformer does not

[GitHub] [hudi] bvaradar merged pull request #2084: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly

2020-09-11 Thread GitBox
bvaradar merged pull request #2084: URL: https://github.com/apache/hudi/pull/2084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hudi] nsivabalan commented on pull request #2084: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly

2020-09-11 Thread GitBox
nsivabalan commented on pull request #2084: URL: https://github.com/apache/hudi/pull/2084#issuecomment-691327993 yeah, https://github.com/apache/hudi/pull/1792 fixed the issue for OverwriteWithLatestAvroPayload and not for AWSDmsAvroPayload. thanks @bvaradar.

[GitHub] [hudi] bvaradar commented on pull request #2084: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly

2020-09-11 Thread GitBox
bvaradar commented on pull request #2084: URL: https://github.com/apache/hudi/pull/2084#issuecomment-691324390 @tooptoop4 : The issue was still there. I added a testcase (testPreCombineWithDelete) which would fail with existing code but passes with this PR.

[GitHub] [hudi] abhijeetkushe commented on issue #1737: [SUPPORT]spark streaming create small parquet files

2020-09-11 Thread GitBox
abhijeetkushe commented on issue #1737: URL: https://github.com/apache/hudi/issues/1737#issuecomment-691268965 @bvaradar The hudi version we are using 0.5.2-incubating deployed on EMR. Good point on the terminology.I will rephrase my question COW with 'hoodie.cleaner.commits.retained':

[GitHub] [hudi] bvaradar commented on pull request #2058: [HUDI-1259] Cache some framework binaries to speed up the progress of building docker image in local env

2020-09-11 Thread GitBox
bvaradar commented on pull request #2058: URL: https://github.com/apache/hudi/pull/2058#issuecomment-691209314 Yes @yanghua : The docker containers are for mainly for internal (testing and demo) consumption but I agree we can document it for engineers to know. Would you mind helping

[GitHub] [hudi] bvaradar closed issue #2062: [SUPPORT] Duplicates in _ro and _rt table for MOR Table type

2020-09-11 Thread GitBox
bvaradar closed issue #2062: URL: https://github.com/apache/hudi/issues/2062 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hudi] bvaradar commented on issue #2062: [SUPPORT] Duplicates in _ro and _rt table for MOR Table type

2020-09-11 Thread GitBox
bvaradar commented on issue #2062: URL: https://github.com/apache/hudi/issues/2062#issuecomment-691206241 @kpurella : I think you should either try patching the PR I had mentioned or use 0.6.0 This is an automated message

[GitHub] [hudi] n3nash commented on pull request #1242: [HUDI-544] Archived commits command code cleanup

2020-09-11 Thread GitBox
n3nash commented on pull request #1242: URL: https://github.com/apache/hudi/pull/1242#issuecomment-691203252 @hddong Extremely sorry, this fell through the crack, please rebase and I will merge this right after. This is an

[GitHub] [hudi] n3nash commented on pull request #1978: [HUDI-1184] Fix the support of hbase index partition path change

2020-09-11 Thread GitBox
n3nash commented on pull request #1978: URL: https://github.com/apache/hudi/pull/1978#issuecomment-691202637 @hj2016 Please rebase and fix the tests, we can land after that. This is an automated message from the Apache Git

[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2020-09-11 Thread GitBox
n3nash commented on a change in pull request #2012: URL: https://github.com/apache/hudi/pull/2012#discussion_r487165310 ## File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java ## @@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[]

[GitHub] [hudi] n3nash commented on a change in pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2020-09-11 Thread GitBox
n3nash commented on a change in pull request #2012: URL: https://github.com/apache/hudi/pull/2012#discussion_r487165310 ## File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java ## @@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[]

[GitHub] [hudi] n3nash commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long

2020-09-11 Thread GitBox
n3nash commented on pull request #2071: URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964 @shenh062326 The PR looks fine to me, high level, what is the reason for this change ? Is it just to correct timestamp types ?

[GitHub] [hudi] rajgowtham24 opened a new issue #2086: [SUPPORT] Hive Sync Not Working through run_sync_tool.sh

2020-09-11 Thread GitBox
rajgowtham24 opened a new issue #2086: URL: https://github.com/apache/hudi/issues/2086 Hi, I am trying to achieve two identical copy of the Hudi Tables in different buckets. For the above scenario, I have copied the contents of the hudi table data files into another bucket

[GitHub] [hudi] bvaradar commented on issue #1737: [SUPPORT]spark streaming create small parquet files

2020-09-11 Thread GitBox
bvaradar commented on issue #1737: URL: https://github.com/apache/hudi/issues/1737#issuecomment-691198064 @abhijeetkushe : Just to get the terminology right : Compaction within Hudi is the process of all the log files belonging to a logical file and creating a columnar file. This is only

[GitHub] [hudi] leesf commented on a change in pull request #1929: [HUDI-1160] Support update partial fields for CoW table

2020-09-11 Thread GitBox
leesf commented on a change in pull request #1929: URL: https://github.com/apache/hudi/pull/1929#discussion_r487137203 ## File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java ## @@ -90,9 +92,19 @@ protected HoodieWriteHandle(HoodieWriteConfig config,

[GitHub] [hudi] vinothchandar commented on a change in pull request #2048: [HUDI-1072][WIP] Introduce REPLACE top level action

2020-09-11 Thread GitBox
vinothchandar commented on a change in pull request #2048: URL: https://github.com/apache/hudi/pull/2048#discussion_r486369440 ## File path: hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -87,44 +88,55 @@ protected

[jira] [Commented] (HUDI-1208) Ordering Field should be optional when precombine is turned off

2020-09-11 Thread Balaji Varadarajan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194355#comment-17194355 ] Balaji Varadarajan commented on HUDI-1208: -- [~shenhong]: Sure, You can take this. > Ordering

[jira] [Commented] (HUDI-1209) Properties File must be optional when running deltastreamer

2020-09-11 Thread Balaji Varadarajan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194354#comment-17194354 ] Balaji Varadarajan commented on HUDI-1209: -- [~shenhong]: Sure. You can take this.  > Properties

[jira] [Commented] (HUDI-1058) Make delete marker configurable

2020-09-11 Thread Raymond Xu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194348#comment-17194348 ] Raymond Xu commented on HUDI-1058: -- No worries [~shenhong]. thanks for the update. > Make delete marker

[GitHub] [hudi] leesf commented on a change in pull request #1929: [HUDI-1160] Support update partial fields for CoW table

2020-09-11 Thread GitBox
leesf commented on a change in pull request #1929: URL: https://github.com/apache/hudi/pull/1929#discussion_r487128690 ## File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -94,6 +95,11 @@ public static final String

[GitHub] [hudi] leesf commented on a change in pull request #1929: [HUDI-1160] Support update partial fields for CoW table

2020-09-11 Thread GitBox
leesf commented on a change in pull request #1929: URL: https://github.com/apache/hudi/pull/1929#discussion_r487128319 ## File path: hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -117,7 +118,17 @@ public boolean commitStats(String

[GitHub] [hudi] leesf commented on a change in pull request #1929: [HUDI-1160] Support update partial fields for CoW table

2020-09-11 Thread GitBox
leesf commented on a change in pull request #1929: URL: https://github.com/apache/hudi/pull/1929#discussion_r487126922 ## File path: hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -117,7 +118,17 @@ public boolean commitStats(String

[GitHub] [hudi] abhijeetkushe edited a comment on issue #1737: [SUPPORT]spark streaming create small parquet files

2020-09-11 Thread GitBox
abhijeetkushe edited a comment on issue #1737: URL: https://github.com/apache/hudi/issues/1737#issuecomment-690685990 @vinothchandar I am facing a similar problem.I am doing a POC for Hudi and am using with the same data for both COW and MOR.I see the compaction happening for both

[GitHub] [hudi] rajgowtham24 commented on issue #2075: [SUPPORT] hoodie.datasource.write.precombine.field not working as expected

2020-09-11 Thread GitBox
rajgowtham24 commented on issue #2075: URL: https://github.com/apache/hudi/issues/2075#issuecomment-691079649 Thanks @bvaradar will check on that This is an automated message from the Apache Git Service. To respond to the

[hudi] branch asf-site updated: Travis CI build asf-site

2020-09-11 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new b67f9f0 Travis CI build asf-site b67f9f0 is

[hudi] branch asf-site updated: [MINOR]Add clinbrain to powered by page (#2078)

2020-09-11 Thread pratyakshsharma
This is an automated email from the ASF dual-hosted git repository. pratyakshsharma pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new 6d2b0cf [MINOR]Add clinbrain to

[GitHub] [hudi] pratyakshsharma merged pull request #2078: [MINOR]Add clinbrain to powered by page

2020-09-11 Thread GitBox
pratyakshsharma merged pull request #2078: URL: https://github.com/apache/hudi/pull/2078 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hudi] pratyakshsharma commented on pull request #2078: [MINOR]Add clinbrain to powered by page

2020-09-11 Thread GitBox
pratyakshsharma commented on pull request #2078: URL: https://github.com/apache/hudi/pull/2078#issuecomment-691050799 LGTM, merging. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hudi] leesf commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…

2020-09-11 Thread GitBox
leesf commented on pull request #1748: URL: https://github.com/apache/hudi/pull/1748#issuecomment-691043300 > @leesf we no longer use SimpleDateFormat in TimestampBasedKeyGenerator. So the issues linked with usage of SimpleDateFormat are also no longer there. Guess we can close this?

[GitHub] [hudi] leesf closed pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…

2020-09-11 Thread GitBox
leesf closed pull request #1748: URL: https://github.com/apache/hudi/pull/1748 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hudi] pratyakshsharma commented on pull request #2085: [HUDI-1209] Properties File must be optional when running deltastreamer

2020-09-11 Thread GitBox
pratyakshsharma commented on pull request #2085: URL: https://github.com/apache/hudi/pull/2085#issuecomment-691021969 Changes look good to me. Can you see why the build is failing? @shenh062326 This is an automated message

[jira] [Updated] (HUDI-982) Add commit action implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-982: - Description: Add commit action implemetation to hudi-flink-client (was: could be like this   {code:java}

[jira] [Updated] (HUDI-982) Add commit action implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-982: - Summary: Add commit action implemetation to hudi-flink-client (was: Introduce AbstractHoodieTable for

[jira] [Updated] (HUDI-981) Add async compact implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-981: - Summary: Add async compact implemetation to hudi-flink-client (was: Introduce AbstractHoodieIndex for

[jira] [Updated] (HUDI-981) Add async compact implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-981: - Description: Add async compact implemetation to hudi-flink-client > Add async compact implemetation to

[jira] [Updated] (HUDI-981) Add async compact implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-981: - Description: (was: At a high level, HoodieIndex should be irrelevant to engines. So we should abstract

[jira] [Updated] (HUDI-913) Add read client implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-913: - Description: Add read client implemetation to hudi-flink-client       was: Introduce

[jira] [Updated] (HUDI-912) Add write client implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-912: - Summary: Add write client implemetation to hudi-flink-client (was: Introduce HoodieWriteKey for hudi

[jira] [Updated] (HUDI-912) Add write client implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-912: - Description: Add write client implemetation to hudi-flink-client (was: Introduce HoodieWriteKey as Hudi

[jira] [Updated] (HUDI-913) Add read client implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-913: - Summary: Add read client implemetation to hudi-flink-client (was: Introduce HoodieEngineContext for hudi

[jira] [Updated] (HUDI-911) Add tableimplemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-911: - Summary: Add tableimplemetation to hudi-flink-client (was: Introduce HoodieWriteOutput for hudi write

[jira] [Updated] (HUDI-911) Add tableimplemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-911: - Description: Add tableimplemetation to hudi-flink-client (was: Introduce HoodieWriteOutput as the unified

[jira] [Updated] (HUDI-911) Add table implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-911: - Summary: Add table implemetation to hudi-flink-client (was: Add tableimplemetation to hudi-flink-client)

[jira] [Updated] (HUDI-911) Add table implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-911: - Description: Add table implemetation to hudi-flink-client (was: Add tableimplemetation to

[jira] [Updated] (HUDI-910) Add index implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-910: - Summary: Add index implemetation to hudi-flink-client (was: Introduce HoodieWriteInput for hudi write

[jira] [Updated] (HUDI-910) Add index implemetation to hudi-flink-client

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-910: - Description: Add index implemetation to hudi-flink-client (was: Introduce HoodieWriteInput as the unified

[jira] [Updated] (HUDI-909) Introduce hudi-flink-client module to support flink engine

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-909: - Summary: Introduce hudi-flink-client module to support flink engine (was: Introduce hudi-client-flink

[jira] [Updated] (HUDI-909) Introduce hudi-flink-client module to support flink engine

2020-09-11 Thread wangxianghu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangxianghu updated HUDI-909: - Description: Introduce hudi-flink-client module to support flink engine based on new abstraction (was:

[GitHub] [hudi] shenh062326 opened a new pull request #2085: [HUDI-1209] Properties File must be optional when running deltastreamer

2020-09-11 Thread GitBox
shenh062326 opened a new pull request #2085: URL: https://github.com/apache/hudi/pull/2085 ## What is the purpose of the pull request * Prevent print error message when user has not specify "--props" when running deltastreamer. ## Brief change log *(for example:)*

[jira] [Updated] (HUDI-1209) Properties File must be optional when running deltastreamer

2020-09-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-1209: - Labels: pull-request-available (was: ) > Properties File must be optional when running

[jira] [Closed] (HUDI-1156) Remove unused dependencies from HoodieDeltaStreamerWrapper Class

2020-09-11 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pratyaksh Sharma closed HUDI-1156. -- > Remove unused dependencies from HoodieDeltaStreamerWrapper Class >

[jira] [Updated] (HUDI-1156) Remove unused dependencies from HoodieDeltaStreamerWrapper Class

2020-09-11 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pratyaksh Sharma updated HUDI-1156: --- Status: Open (was: New) > Remove unused dependencies from HoodieDeltaStreamerWrapper Class >

[jira] [Resolved] (HUDI-1156) Remove unused dependencies from HoodieDeltaStreamerWrapper Class

2020-09-11 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pratyaksh Sharma resolved HUDI-1156. Resolution: Fixed Fixed > Remove unused dependencies from HoodieDeltaStreamerWrapper Class

[jira] [Commented] (HUDI-1029) Use FastDateFormat for parsing and formating in TimestampBasedKeyGenerator

2020-09-11 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194109#comment-17194109 ] Pratyaksh Sharma commented on HUDI-1029: We don't use SimpleDateFormat in

[GitHub] [hudi] pratyakshsharma commented on pull request #1748: [WIP] [HUDI-1029] Use FastDateFormat for parsing and formating in Timestamp…

2020-09-11 Thread GitBox
pratyakshsharma commented on pull request #1748: URL: https://github.com/apache/hudi/pull/1748#issuecomment-690966794 @leesf we no longer use SimpleDateFormat in TimestampBasedKeyGenerator. So the issues linked with usage of SimpleDateFormat are also no longer there. Guess we can close

[jira] [Commented] (HUDI-735) Improve deltastreamer error message when case mismatch of commandline arguments.

2020-09-11 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194105#comment-17194105 ] Pratyaksh Sharma commented on HUDI-735: --- Anything else needs to be done here? As per the description

[jira] [Commented] (HUDI-1208) Ordering Field should be optional when precombine is turned off

2020-09-11 Thread shenh062326 (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194075#comment-17194075 ] shenh062326 commented on HUDI-1208: --- I can take this issue if you have not start it. > Ordering Field

[jira] [Commented] (HUDI-1209) Properties File must be optional when running deltastreamer

2020-09-11 Thread shenh062326 (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194076#comment-17194076 ] shenh062326 commented on HUDI-1209: --- I can take this issue if you have not start it. > Properties File

[jira] [Assigned] (HUDI-1208) Ordering Field should be optional when precombine is turned off

2020-09-11 Thread shenh062326 (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenh062326 reassigned HUDI-1208: - Assignee: shenh062326 > Ordering Field should be optional when precombine is turned off >

[jira] [Assigned] (HUDI-1209) Properties File must be optional when running deltastreamer

2020-09-11 Thread shenh062326 (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenh062326 reassigned HUDI-1209: - Assignee: shenh062326 > Properties File must be optional when running deltastreamer >

[GitHub] [hudi] shenh062326 commented on pull request #2071: [HUDI-1143] Change timestamp field in HoodieTestDataGenerator from double to long

2020-09-11 Thread GitBox
shenh062326 commented on pull request #2071: URL: https://github.com/apache/hudi/pull/2071#issuecomment-690928998 @n3nash can you take a look at this MR. This is an automated message from the Apache Git Service. To respond

[GitHub] [hudi] tooptoop4 commented on pull request #2084: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly

2020-09-11 Thread GitBox
tooptoop4 commented on pull request #2084: URL: https://github.com/apache/hudi/pull/2084#issuecomment-690925786 I thought https://github.com/apache/hudi/pull/1792 fixed it? This is an automated message from the Apache Git

[GitHub] [hudi] yanghua commented on pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-09-11 Thread GitBox
yanghua commented on pull request #1827: URL: https://github.com/apache/hudi/pull/1827#issuecomment-690922454 @leesf Thanks for your awesome work. Can you squash these commits for the subsequent review? This is an automated