[GitHub] [hudi] nsivabalan commented on a change in pull request #2577: [HUDI-1618] Fixing NPE with Parquet src in multi table delta streamer

2021-02-20 Thread GitBox
nsivabalan commented on a change in pull request #2577: URL: https://github.com/apache/hudi/pull/2577#discussion_r579756037 ## File path: .github/workflows/issue.yml ## @@ -0,0 +1,29 @@ +name: Labeling new issue Review comment: sorry, wrongly added. will remove this fil

[GitHub] [hudi] nsivabalan commented on pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
nsivabalan commented on pull request #2443: URL: https://github.com/apache/hudi/pull/2443#issuecomment-782802631 @vinothchandar @yanghua : A general doubt on supporting this config knob. As quoted above if connection fails and if we set this config of interest to true, then IMetaStoreClien

[GitHub] [hudi] nsivabalan commented on a change in pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
nsivabalan commented on a change in pull request #2443: URL: https://github.com/apache/hudi/pull/2443#discussion_r579751395 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java ## @@ -293,6 +293,8 @@ public static HiveSyncCon

[GitHub] [hudi] nsivabalan commented on a change in pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
nsivabalan commented on a change in pull request #2443: URL: https://github.com/apache/hudi/pull/2443#discussion_r579750318 ## File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java ## @@ -58,8 +58,8 @@ private final HiveSyncConfig cfg;

[jira] [Resolved] (HUDI-1586) Reduce the coupling of hadoop.

2021-02-20 Thread Gary Li (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Li resolved HUDI-1586. --- Resolution: Fixed > Reduce the coupling of hadoop. > -- > > Key: H

[jira] [Commented] (HUDI-1586) Reduce the coupling of hadoop.

2021-02-20 Thread Gary Li (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17287845#comment-17287845 ] Gary Li commented on HUDI-1586: --- [~ZhangChaoming] thanks for your contribution, please feel

[jira] [Updated] (HUDI-1586) Reduce the coupling of hadoop.

2021-02-20 Thread Gary Li (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Li updated HUDI-1586: -- Fix Version/s: 0.8.0 > Reduce the coupling of hadoop. > -- > > Key:

[hudi] branch master updated: [HUDI-1586] [Common Core] [Flink Integration] Reduce the coupling of hadoop. (#2540)

2021-02-20 Thread garyli
This is an automated email from the ASF dual-hosted git repository. garyli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 43a0776 [HUDI-1586] [Common Core] [Flink Integrat

[GitHub] [hudi] garyli1019 merged pull request #2540: [HUDI-1586] [Common Core] [Flink Integration] Reduce the coupling of hadoop.

2021-02-20 Thread GitBox
garyli1019 merged pull request #2540: URL: https://github.com/apache/hudi/pull/2540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hudi] codecov-io edited a comment on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-720892015 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=h1) Report > Merging [#2227](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=desc) (8d1257d) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-720892015 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=h1) Report > Merging [#2227](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=desc) (8d1257d) in

[GitHub] [hudi] nsivabalan edited a comment on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
nsivabalan edited a comment on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-782770387 > @nsivabalan Let you take over this PR. Please go ahead. Sure. By take over you mean, just reviewing or you want me to address all comments by myself and get it to

[GitHub] [hudi] nsivabalan edited a comment on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
nsivabalan edited a comment on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-782770387 > @nsivabalan Let you take over this PR. Please go ahead. Sure. by take over you mean, just reviewing right? or you want me to address all comments by myself and ge

[GitHub] [hudi] nsivabalan commented on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
nsivabalan commented on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-782770387 > @nsivabalan Let you take over this PR. Please go ahead. Sure. This is an automated message from the Ap

[GitHub] [hudi] nsivabalan commented on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
nsivabalan commented on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-782770366 @liujinhui1994 : I pushed a commit to this PR with tests to delta streamer to test transition from parquet dfs to kaka dfs :) Hope that's fine with you. If you plan to make more

[GitHub] [hudi] nsivabalan opened a new pull request #2587: [WIP] Enhancing delta streamer tests

2021-02-20 Thread GitBox
nsivabalan opened a new pull request #2587: URL: https://github.com/apache/hudi/pull/2587 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the

[GitHub] [hudi] nsivabalan commented on a change in pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
nsivabalan commented on a change in pull request #2227: URL: https://github.com/apache/hudi/pull/2227#discussion_r579684280 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java ## @@ -156,15 +163,18 @@ public static long tota

[GitHub] [hudi] nsivabalan commented on a change in pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
nsivabalan commented on a change in pull request #2227: URL: https://github.com/apache/hudi/pull/2227#discussion_r579684280 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java ## @@ -156,15 +163,18 @@ public static long tota

[GitHub] [hudi] nsivabalan commented on a change in pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
nsivabalan commented on a change in pull request #2227: URL: https://github.com/apache/hudi/pull/2227#discussion_r579684280 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java ## @@ -156,15 +163,18 @@ public static long tota

[GitHub] [hudi] codecov-io edited a comment on pull request #2445: [MINOR] Callback message add partitionPath Field

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2445: URL: https://github.com/apache/hudi/pull/2445#issuecomment-782598913 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=h1) Report > Merging [#2445](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=desc) (45ffdcc) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2445: [MINOR] Callback message add partitionPath Field

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2445: URL: https://github.com/apache/hudi/pull/2445#issuecomment-782598913 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=h1) Report > Merging [#2445](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=desc) (45ffdcc) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2445: [MINOR] Callback message add partitionPath Field

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2445: URL: https://github.com/apache/hudi/pull/2445#issuecomment-782598913 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=h1) Report > Merging [#2445](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=desc) (45ffdcc) in

[GitHub] [hudi] liujinhui1994 commented on pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
liujinhui1994 commented on pull request #2443: URL: https://github.com/apache/hudi/pull/2443#issuecomment-782672436 @nsivabalan @yanghua please help review This is an automated message from the Apache Git Service. To respond

[GitHub] [hudi] liujinhui1994 commented on a change in pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
liujinhui1994 commented on a change in pull request #2443: URL: https://github.com/apache/hudi/pull/2443#discussion_r579660766 ## File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java ## @@ -58,8 +58,8 @@ private final HiveSyncConfig cfg

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=h1) Report > Merging [#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=desc) (872519b) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=h1) Report > Merging [#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=desc) (19af8b7) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=h1) Report > Merging [#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=desc) (19af8b7) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=h1) Report > Merging [#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=desc) (19af8b7) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=h1) Report > Merging [#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=desc) (872519b) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=h1) Report > Merging [#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=desc) (11831a3) in

[hudi] branch asf-site updated: Travis CI build asf-site

2021-02-20 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new ffe4e7f Travis CI build asf-site ffe4e7f is d

[jira] [Closed] (HUDI-1617) Blog: different key generators in Hudi

2021-02-20 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang closed HUDI-1617. -- Assignee: sivabalan narayanan Resolution: Done Done via asf-site branch: 1148e188ac761eb54f7af4c0547cdc9ba

[GitHub] [hudi] yanghua merged pull request #2575: [HUDI-1617] Adding a blog for KeyGenerators in Apache Hudi

2021-02-20 Thread GitBox
yanghua merged pull request #2575: URL: https://github.com/apache/hudi/pull/2575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[hudi] branch asf-site updated: [HUDI-1617] Adding a blog for KeyGenerators in Apache Hudi (#2575)

2021-02-20 Thread vinoyang
This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new 1148e18 [HUDI-1617] Adding a blog for KeyGe

[GitHub] [hudi] yanghua commented on a change in pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
yanghua commented on a change in pull request #2443: URL: https://github.com/apache/hudi/pull/2443#discussion_r579644520 ## File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java ## @@ -58,8 +58,8 @@ private final HiveSyncConfig cfg; p

[GitHub] [hudi] yanghua commented on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
yanghua commented on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-782611052 @nsivabalan Let you take over this PR. Please go ahead. This is an automated message from the Apache Git Service. T

[GitHub] [hudi] yanghua commented on a change in pull request #2445: [MINOR] Callback message add partitionPath Field

2021-02-20 Thread GitBox
yanghua commented on a change in pull request #2445: URL: https://github.com/apache/hudi/pull/2445#discussion_r579643845 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java ## @@ -66,10 +66,12 @@ import java.io.IOEx

[GitHub] [hudi] codecov-io edited a comment on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-720892015 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=h1) Report > Merging [#2227](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=desc) (43d4f7f) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2443: URL: https://github.com/apache/hudi/pull/2443#issuecomment-760147630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hudi] codecov-io edited a comment on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-720892015 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=h1) Report > Merging [#2227](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=desc) (43d4f7f) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2227: URL: https://github.com/apache/hudi/pull/2227#issuecomment-720892015 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=h1) Report > Merging [#2227](https://codecov.io/gh/apache/hudi/pull/2227?src=pr&el=desc) (43d4f7f) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2445: [MINOR] Callback message add partitionPath Field

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2445: URL: https://github.com/apache/hudi/pull/2445#issuecomment-782598913 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=h1) Report > Merging [#2445](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=desc) (a63e5e4) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2188: [HUDI-1347]fix Hbase index partition changes cause data duplication p…

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2188: URL: https://github.com/apache/hudi/pull/2188#issuecomment-711139438 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=h1) Report > Merging [#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=desc) (acee09f) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2283: [HUDI-1415] Read Hoodie Table As Spark DataSource Table

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2283: URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=h1) Report > Merging [#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr&el=desc) (acee09f) in

[GitHub] [hudi] codecov-io edited a comment on pull request #2445: [MINOR] Callback message add partitionPath Field

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2445: URL: https://github.com/apache/hudi/pull/2445#issuecomment-782598913 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=h1) Report > Merging [#2445](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=desc) (a63e5e4) in

[GitHub] [hudi] codecov-io commented on pull request #2445: [MINOR] Callback message add partitionPath Field

2021-02-20 Thread GitBox
codecov-io commented on pull request #2445: URL: https://github.com/apache/hudi/pull/2445#issuecomment-782598913 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=h1) Report > Merging [#2445](https://codecov.io/gh/apache/hudi/pull/2445?src=pr&el=desc) (a63e5e4) into [ma

[GitHub] [hudi] codecov-io edited a comment on pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2443: URL: https://github.com/apache/hudi/pull/2443#issuecomment-760147630 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2443?src=pr&el=h1) Report > Merging [#2443](https://codecov.io/gh/apache/hudi/pull/2443?src=pr&el=desc) (56f3f68) in

[GitHub] [hudi] liujinhui1994 commented on a change in pull request #2227: [HUDI-1367] Make deltaStreamer transition from dfsSouce to kafkasouce

2021-02-20 Thread GitBox
liujinhui1994 commented on a change in pull request #2227: URL: https://github.com/apache/hudi/pull/2227#discussion_r579630158 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java ## @@ -227,12 +232,23 @@ public KafkaOffsetGe

[GitHub] [hudi] codecov-io edited a comment on pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2443: URL: https://github.com/apache/hudi/pull/2443#issuecomment-760147630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [hudi] hj2016 commented on pull request #2188: [HUDI-1347]fix Hbase index partition changes cause data duplication p…

2021-02-20 Thread GitBox
hj2016 commented on pull request #2188: URL: https://github.com/apache/hudi/pull/2188#issuecomment-782593156 @nsivabalan Maybe n3nash is busy and hasn't responded to me. I first modified it according to my ideas. You can confirm whether you can merge. Leave me a message if you have any qu

[GitHub] [hudi] codecov-io edited a comment on pull request #2443: [HUDI-1269] Make whether the failure of connect hive affects hudi ingest process configurable

2021-02-20 Thread GitBox
codecov-io edited a comment on pull request #2443: URL: https://github.com/apache/hudi/pull/2443#issuecomment-760147630 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2443?src=pr&el=h1) Report > Merging [#2443](https://codecov.io/gh/apache/hudi/pull/2443?src=pr&el=desc) (86faca0) in

[GitHub] [hudi] yanghua commented on a change in pull request #2577: [HUDI-1618] Fixing NPE with Parquet src in multi table delta streamer

2021-02-20 Thread GitBox
yanghua commented on a change in pull request #2577: URL: https://github.com/apache/hudi/pull/2577#discussion_r579626627 ## File path: .github/workflows/issue.yml ## @@ -0,0 +1,29 @@ +name: Labeling new issue Review comment: Why do we need to contain this file in the PR

[GitHub] [hudi] liujinhui1994 commented on pull request #2438: [HUDI-1447] DeltaStreamer kafka source supports consuming from specified timestamp

2021-02-20 Thread GitBox
liujinhui1994 commented on pull request #2438: URL: https://github.com/apache/hudi/pull/2438#issuecomment-782589121 I have verified, please help review @wangxianghu @yanghua @nsivabalan This is an automated message fr

[GitHub] [hudi] liujinhui1994 removed a comment on pull request #2438: [HUDI-1447] DeltaStreamer kafka source supports consuming from specified timestamp

2021-02-20 Thread GitBox
liujinhui1994 removed a comment on pull request #2438: URL: https://github.com/apache/hudi/pull/2438#issuecomment-782588952 @yanghua @wangxianghu @nsivabalan I have verified, please help review This is an automat

[GitHub] [hudi] liujinhui1994 commented on pull request #2438: [HUDI-1447] DeltaStreamer kafka source supports consuming from specified timestamp

2021-02-20 Thread GitBox
liujinhui1994 commented on pull request #2438: URL: https://github.com/apache/hudi/pull/2438#issuecomment-782588952 @yanghua @wangxianghu @nsivabalan I have verified, please help review This is an automated messa