[GitHub] [hudi] danny0405 commented on pull request #2899: [HUDI-1865] Make embedded time line service singleton

2021-05-06 Thread GitBox
danny0405 commented on pull request #2899: URL: https://github.com/apache/hudi/pull/2899#issuecomment-834118649 > Looking at the usage of `createEmbeddedTimelineService()`, there are broadly two. > > * AbstractHoodieClient can start (during intiialization) and stop (during close())

[GitHub] [hudi] danny0405 commented on pull request #2899: [HUDI-1865] Make embedded time line service singleton

2021-05-06 Thread GitBox
danny0405 commented on pull request #2899: URL: https://github.com/apache/hudi/pull/2899#issuecomment-834117293 > AbstractHoodieClient They are not singleton, as i said, each writer task takes a AbstractWriteClient, and there may be multiple write tasks in one process. I agree

[GitHub] [hudi] vinothchandar commented on pull request #2899: [HUDI-1865] Make embedded time line service singleton

2021-05-06 Thread GitBox
vinothchandar commented on pull request #2899: URL: https://github.com/apache/hudi/pull/2899#issuecomment-834116492 >This change is introducing another instance which will double the overhead. What benefits do you see by doing this ? Would it though? I mean, its just an object refere

[GitHub] [hudi] ssdong commented on pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

2021-05-06 Thread GitBox
ssdong commented on pull request #2784: URL: https://github.com/apache/hudi/pull/2784#issuecomment-834115800 @vinothchandar No problem! Thank you for your precious time and let me know if you have a second thought on this fix. :) -- This is an automated message from the Apache Git Servi

[jira] [Updated] (HUDI-1872) Move HoodieFlinkStreamer into hudi-utilities module

2021-05-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-1872: - Labels: pull-request-available (was: ) > Move HoodieFlinkStreamer into hudi-utilities module > --

[GitHub] [hudi] MyLanPangzi opened a new pull request #2922: [HUDI-1872] Move HoodieFlinkStreamer into hudi-utilities module

2021-05-06 Thread GitBox
MyLanPangzi opened a new pull request #2922: URL: https://github.com/apache/hudi/pull/2922 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the

[GitHub] [hudi] yanghua commented on issue #2883: [SUPPORT] Does Hudi support flink DataStream API?

2021-05-06 Thread GitBox
yanghua commented on issue #2883: URL: https://github.com/apache/hudi/issues/2883#issuecomment-834111741 > @yanghua @leesf @dannyhchen : can one of you folks take this up Yes, you can change or rewrite your `HoodieFlinkStreamer` so that you can replace the source or do more things.

[GitHub] [hudi] dirksan28 edited a comment on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-05-06 Thread GitBox
dirksan28 edited a comment on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-834091378 I've been observing this issue for several months now. From my point of view a working schema evolution is highly fundamental for the meaningful use of hudi. I am amazed t

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2920: [HUDI-1878] Add max memory option for flink writer task

2021-05-06 Thread GitBox
codecov-commenter edited a comment on pull request #2920: URL: https://github.com/apache/hudi/pull/2920#issuecomment-834095568 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] dirksan28 edited a comment on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-05-06 Thread GitBox
dirksan28 edited a comment on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-834091378 I've been observing this issue for several months now. From my point of view working schema evolution is highly fundamental for the meaningful use of hudi. I am amazed tha

[GitHub] [hudi] danny0405 commented on pull request #2904: [HUDI-1818] Validate and check required option for HoodieTable (Azure CI)

2021-05-06 Thread GitBox
danny0405 commented on pull request #2904: URL: https://github.com/apache/hudi/pull/2904#issuecomment-834095894 The test would be removed in HUDI-1878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [hudi] codecov-commenter commented on pull request #2920: [HUDI-1878] Add max memory option for flink writer task

2021-05-06 Thread GitBox
codecov-commenter commented on pull request #2920: URL: https://github.com/apache/hudi/pull/2920#issuecomment-834095568 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2920?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[jira] [Updated] (HUDI-1880) Support streaming read with compaction and cleaning

2021-05-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-1880: - Labels: pull-request-available (was: ) > Support streaming read with compaction and cleaning > --

[GitHub] [hudi] danny0405 opened a new pull request #2921: [HUDI-1880] Support streaming read with compaction and cleaning

2021-05-06 Thread GitBox
danny0405 opened a new pull request #2921: URL: https://github.com/apache/hudi/pull/2921 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of the p

[jira] [Updated] (HUDI-1880) Support streaming read with compaction and cleaning

2021-05-06 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen updated HUDI-1880: - Summary: Support streaming read with compaction and cleaning (was: Support flink streaming read with comp

[jira] [Created] (HUDI-1880) Support flink streaming read with compaction and cleaning

2021-05-06 Thread Danny Chen (Jira)
Danny Chen created HUDI-1880: Summary: Support flink streaming read with compaction and cleaning Key: HUDI-1880 URL: https://issues.apache.org/jira/browse/HUDI-1880 Project: Apache Hudi Issue Typ

[jira] [Updated] (HUDI-1878) Add max memory option for flink writer task

2021-05-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-1878: - Labels: pull-request-available (was: ) > Add max memory option for flink writer task > --

[GitHub] [hudi] danny0405 opened a new pull request #2920: [HUDI-1878] Add max memory option for flink writer task

2021-05-06 Thread GitBox
danny0405 opened a new pull request #2920: URL: https://github.com/apache/hudi/pull/2920 Also removes the rate limiter because it has the similar functionality. ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributi

[GitHub] [hudi] dirksan28 commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-05-06 Thread GitBox
dirksan28 commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-834091378 I've been observing this issue for several months now. From my point of view that is a big problem for the meaningful use of hudi. I am amazed that this is not classified as a mi

[GitHub] [hudi] vinothchandar commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-05-06 Thread GitBox
vinothchandar commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-834087051 Actually pretty bummed to hear that. @nsivabalan @n3nash can we do something here to prioritize this? Or at least source more help from dev list/slack? -- This is an autom

[GitHub] [hudi] sbernauer edited a comment on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-05-06 Thread GitBox
sbernauer edited a comment on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-834085407 Hi together, we sadly can't do schema evolution for 10 months now (https://github.com/apache/hudi/issues/1845) and have to rely on ugly workarounds. Many thanks

[GitHub] [hudi] sbernauer commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-05-06 Thread GitBox
sbernauer commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-834085407 Hi together, we sadly can't do schema evolution for 10 months now (https://github.com/apache/hudi/issues/1845) and have to rely on ugly workarounds. Many thanks for wor

[GitHub] [hudi] danny0405 commented on pull request #2899: [HUDI-1865] Make embedded time line service singleton

2021-05-06 Thread GitBox
danny0405 commented on pull request #2899: URL: https://github.com/apache/hudi/pull/2899#issuecomment-834084750 Hi @vinothchandar Can you take a look, this PR is small and we need this in emergency. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hudi] tandonraghav opened a new issue #2919: [SUPPORT] Schema Evolution Failing - Adding New fields

2021-05-06 Thread GitBox
tandonraghav opened a new issue #2919: URL: https://github.com/apache/hudi/issues/2919 I am facing issue in Schema Evolution. While adding a new field to the Spark DF, it is giving exception if there are previous Log files/Records which do not have that field. I can see *type* is re

[jira] [Commented] (HUDI-431) Design and develop parquet logging in Log file

2021-05-06 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340578#comment-17340578 ] Vinoth Chandar commented on HUDI-431: - [~szhou] Not sure how read-ahead works with file

[GitHub] [hudi] vinothchandar commented on pull request #2719: [HUDI-1721] run_sync_tool support hive3

2021-05-06 Thread GitBox
vinothchandar commented on pull request #2719: URL: https://github.com/apache/hudi/pull/2719#issuecomment-834075609 any reason why you closed this @MyLanPangzi ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [hudi] nsivabalan commented on a change in pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
nsivabalan commented on a change in pull request #2915: URL: https://github.com/apache/hudi/pull/2915#discussion_r627927954 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/JdbcSource.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (HUDI-431) Design and develop parquet logging in Log file

2021-05-06 Thread Simon Zhou (Jira)
[ https://issues.apache.org/jira/browse/HUDI-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340566#comment-17340566 ] Simon Zhou commented on HUDI-431: - I should have re-framed my question as: what is the adva

[jira] [Commented] (HUDI-1879) Spark DataSource tables/HoodieFileIndex issues for Merge On Read

2021-05-06 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340557#comment-17340557 ] Udit Mehrotra commented on HUDI-1879: - [~vinoth] [~pzw2018] Noticed a couple of blocki

[jira] [Updated] (HUDI-1879) Spark DataSource tables/HoodieFileIndex issues for Merge On Read

2021-05-06 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udit Mehrotra updated HUDI-1879: Description: *Read as DataSource Tables* and *HoodieFileIndex* implementation that went in  [https:/

[jira] [Updated] (HUDI-1879) Spark DataSource tables/HoodieFileIndex issues for Merge On Read

2021-05-06 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udit Mehrotra updated HUDI-1879: Summary: Spark DataSource tables/HoodieFileIndex issues for Merge On Read (was: HoodieFileIndex iss

[jira] [Updated] (HUDI-1879) HoodieFileIndex issues for Merge On Read

2021-05-06 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udit Mehrotra updated HUDI-1879: Description: *HoodieFileIndex* implementation that went in [https://github.com/apache/hudi/pull/265

[jira] [Created] (HUDI-1879) HoodieFileIndex issues for Merge On Read

2021-05-06 Thread Udit Mehrotra (Jira)
Udit Mehrotra created HUDI-1879: --- Summary: HoodieFileIndex issues for Merge On Read Key: HUDI-1879 URL: https://issues.apache.org/jira/browse/HUDI-1879 Project: Apache Hudi Issue Type: Bug

[jira] [Created] (HUDI-1878) Add max memory option for flink writer task

2021-05-06 Thread Danny Chen (Jira)
Danny Chen created HUDI-1878: Summary: Add max memory option for flink writer task Key: HUDI-1878 URL: https://issues.apache.org/jira/browse/HUDI-1878 Project: Apache Hudi Issue Type: Improvement

[jira] [Closed] (HUDI-1821) Remove legacy code for Flink writer

2021-05-06 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang closed HUDI-1821. -- Resolution: Done 0a5863939b8da149f6dab3ec0fdb86d77baa9739 > Remove legacy code for Flink writer > -

[hudi] branch master updated (0284cde -> 0a58639)

2021-05-06 Thread vinoyang
This is an automated email from the ASF dual-hosted git repository. vinoyang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git. from 0284cde [HUDI-1876] wiring in Hadoop Conf with AvroSchemaConverters instantiation (#2914) add 0a58639 [HUDI-1

[GitHub] [hudi] yanghua merged pull request #2868: [HUDI-1821] Remove legacy code for Flink writer

2021-05-06 Thread GitBox
yanghua merged pull request #2868: URL: https://github.com/apache/hudi/pull/2868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please co

[GitHub] [hudi] yanghua commented on pull request #2868: [HUDI-1821] Remove legacy code for Flink writer

2021-05-06 Thread GitBox
yanghua commented on pull request #2868: URL: https://github.com/apache/hudi/pull/2868#issuecomment-834023836 > > > see https://issues.apache.org/jira/browse/HUDI-1872 > > > > > > @MyLanPangzi Are you interested in this ticket? To continue refactoring. > > yes, I have alrea

[GitHub] [hudi] liijiankang closed issue #2917: [SUPPORT]NoSuchElementException: No value present

2021-05-06 Thread GitBox
liijiankang closed issue #2917: URL: https://github.com/apache/hudi/issues/2917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [hudi] MyLanPangzi closed pull request #2719: [HUDI-1721] run_sync_tool support hive3

2021-05-06 Thread GitBox
MyLanPangzi closed pull request #2719: URL: https://github.com/apache/hudi/pull/2719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [hudi] nsivabalan commented on pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
nsivabalan commented on pull request #2915: URL: https://github.com/apache/hudi/pull/2915#issuecomment-833988217 Can we add tests for these scenarios 1. no matching rows with incremental fetch. lets say everything is caught up. 2. records in source table range from 0 to 100. you set

[GitHub] [hudi] nsivabalan commented on a change in pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
nsivabalan commented on a change in pull request #2915: URL: https://github.com/apache/hudi/pull/2915#discussion_r627846007 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/JdbcSource.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software

[GitHub] [hudi] codecov-commenter commented on pull request #2918: [HUDI-1877] Add support in clustering to not change record location

2021-05-06 Thread GitBox
codecov-commenter commented on pull request #2918: URL: https://github.com/apache/hudi/pull/2918#issuecomment-833971983 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [hudi] satishkotha opened a new pull request #2918: [HUDI-1877] Add support in clustering to not change record location

2021-05-06 Thread GitBox
satishkotha opened a new pull request #2918: URL: https://github.com/apache/hudi/pull/2918 ## What is the purpose of the pull request Add support for reusing fileId in clustering execution strategy. This is strategy specific. Default is still to create new files ## Brief chang

[jira] [Updated] (HUDI-1877) clustering support for external index

2021-05-06 Thread satish (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] satish updated HUDI-1877: - Description: We want to support records staying in same fileId after clustering (For example, sort each file OR re

[jira] [Resolved] (HUDI-1833) pending cluster rollback when there are greater commits

2021-05-06 Thread satish (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] satish resolved HUDI-1833. -- Resolution: Fixed > pending cluster rollback when there are greater commits > --

[jira] [Closed] (HUDI-1833) pending cluster rollback when there are greater commits

2021-05-06 Thread satish (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] satish closed HUDI-1833. > pending cluster rollback when there are greater commits > --- > >

[jira] [Created] (HUDI-1877) clustering support for external index

2021-05-06 Thread satish (Jira)
satish created HUDI-1877: Summary: clustering support for external index Key: HUDI-1877 URL: https://issues.apache.org/jira/browse/HUDI-1877 Project: Apache Hudi Issue Type: Sub-task Repo

[jira] [Commented] (HUDI-874) Schema evolution does not work with AWS Glue catalog

2021-05-06 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340409#comment-17340409 ] Udit Mehrotra commented on HUDI-874: [~balajiit] can you share some quick/easy reproduc

[GitHub] [hudi] vinothchandar commented on pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
vinothchandar commented on pull request #2915: URL: https://github.com/apache/hudi/pull/2915#issuecomment-833746933 Great suggestions @leesf ! We can file followups for those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hudi] vburenin commented on a change in pull request #2714: [HUDI-1707] Reduces log level for too verbose messages from info to debug level.

2021-05-06 Thread GitBox
vburenin commented on a change in pull request #2714: URL: https://github.com/apache/hudi/pull/2714#discussion_r606851124 ## File path: hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HiveSchemaUtil.java ## @@ -109,7 +109,7 @@ public static SchemaDifference g

[GitHub] [hudi] vinothchandar commented on pull request #2714: [HUDI-1707] Reduces log level for too verbose messages from info to debug level.

2021-05-06 Thread GitBox
vinothchandar commented on pull request #2714: URL: https://github.com/apache/hudi/pull/2714#issuecomment-833683614 >it would be changed to debug if there are some stats to indicate the time cost. I think it is an important stat when profiling. Typically, we turn on logs with perf pr

[GitHub] [hudi] vinothchandar commented on pull request #2714: [HUDI-1707] Reduces log level for too verbose messages from info to debug level.

2021-05-06 Thread GitBox
vinothchandar commented on pull request #2714: URL: https://github.com/apache/hudi/pull/2714#issuecomment-833682238 This test is just flaky ``` [INFO] [ERROR] Failures: [ERROR] TestHoodieMultiTableDeltaStreamer.testMultiTableExecutionWithKafkaSource:168 expected: but w

[GitHub] [hudi] mpouttu removed a comment on pull request #2907: [HUDI-1873] collect() call causing issues with very large upserts

2021-05-06 Thread GitBox
mpouttu removed a comment on pull request #2907: URL: https://github.com/apache/hudi/pull/2907#issuecomment-833616754 Hello, I am looking at the test failures and they don't have to do with my changes. The only possible side effect from my change would be that some detail logging that is a

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2907: [HUDI-1873] collect() call causing issues with very large upserts

2021-05-06 Thread GitBox
codecov-commenter edited a comment on pull request #2907: URL: https://github.com/apache/hudi/pull/2907#issuecomment-830598873 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2907?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] mpouttu commented on pull request #2907: [HUDI-1873] collect() call causing issues with very large upserts

2021-05-06 Thread GitBox
mpouttu commented on pull request #2907: URL: https://github.com/apache/hudi/pull/2907#issuecomment-833616754 Hello, I am looking at the test failures and they don't have to do with my changes. The only possible side effect from my change would be that some detail logging that is already i

[GitHub] [hudi] vinothchandar commented on a change in pull request #2809: [HUDI-1789] Support reading older snapshots

2021-05-06 Thread GitBox
vinothchandar commented on a change in pull request #2809: URL: https://github.com/apache/hudi/pull/2809#discussion_r627514500 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieHiveUtils.java ## @@ -122,19 +135,44 @@ public static Path getNthParent(

[GitHub] [hudi] vinothchandar commented on pull request #2784: [HUDI-1740] Fix insert-overwrite API archival

2021-05-06 Thread GitBox
vinothchandar commented on pull request #2784: URL: https://github.com/apache/hudi/pull/2784#issuecomment-833601155 Thanks for this @ssdong and also the great explanation and detailed comments along the way. I am on it. This is a bit deep, been trying to set aside an hour or so. :) --

[GitHub] [hudi] leesf commented on a change in pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
leesf commented on a change in pull request #2915: URL: https://github.com/apache/hudi/pull/2915#discussion_r627418429 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/JdbcSource.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [hudi] leesf commented on a change in pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
leesf commented on a change in pull request #2915: URL: https://github.com/apache/hudi/pull/2915#discussion_r627417386 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/JdbcSource.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [hudi] leesf commented on a change in pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
leesf commented on a change in pull request #2915: URL: https://github.com/apache/hudi/pull/2915#discussion_r627417046 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/JdbcSource.java ## @@ -0,0 +1,326 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [hudi] leesf commented on a change in pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
leesf commented on a change in pull request #2915: URL: https://github.com/apache/hudi/pull/2915#discussion_r627412205 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/SqlQueryBuilder.java ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [hudi] leesf commented on a change in pull request #2915: [HUDI-251] Adds JDBC source support for DeltaStreamer

2021-05-06 Thread GitBox
leesf commented on a change in pull request #2915: URL: https://github.com/apache/hudi/pull/2915#discussion_r627411500 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/SqlQueryBuilder.java ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [hudi] MyLanPangzi commented on pull request #2868: [HUDI-1821] Remove legacy code for Flink writer

2021-05-06 Thread GitBox
MyLanPangzi commented on pull request #2868: URL: https://github.com/apache/hudi/pull/2868#issuecomment-833493033 > > see https://issues.apache.org/jira/browse/HUDI-1872 > > @MyLanPangzi Are you interested in this ticket? To continue refactoring. yes, I have already made part o

[GitHub] [hudi] yanghua commented on pull request #2868: [HUDI-1821] Remove legacy code for Flink writer

2021-05-06 Thread GitBox
yanghua commented on pull request #2868: URL: https://github.com/apache/hudi/pull/2868#issuecomment-833459923 > see https://issues.apache.org/jira/browse/HUDI-1872 @MyLanPangzi Are you interested in this ticket? To continue refactoring. -- This is an automated message from the Apac

[GitHub] [hudi] liijiankang commented on issue #2917: [SUPPORT]NoSuchElementException: No value present

2021-05-06 Thread GitBox
liijiankang commented on issue #2917: URL: https://github.com/apache/hudi/issues/2917#issuecomment-833349514 ![2](https://user-images.githubusercontent.com/42951757/117268956-6b121880-ae8a-11eb-8448-eed776dbcdcf.jpg) -- This is an automated message from the Apache Git Service. To res

[GitHub] [hudi] MyLanPangzi commented on pull request #2904: [HUDI-1818] Validate and check required option for HoodieTable (Azure CI)

2021-05-06 Thread GitBox
MyLanPangzi commented on pull request #2904: URL: https://github.com/apache/hudi/pull/2904#issuecomment-833342296 @danny0405 hi, the org.apache.hudi.sink.transform.TestRowDataToHoodieFunction#testRateLimit cannot pass, could you help me inspect the ut ? -- This is an automated message

[GitHub] [hudi] liijiankang opened a new issue #2917: [SUPPORT]NoSuchElementException: No value present

2021-05-06 Thread GitBox
liijiankang opened a new issue #2917: URL: https://github.com/apache/hudi/issues/2917 **Describe the problem you faced** Kafka data written to the hudi MOR table throws an exception **Expected behavior** Kafka data is written to the hudi COW table without exception .Hope it can

[GitHub] [hudi] MyLanPangzi commented on pull request #2719: [HUDI-1721] run_sync_tool support hive3

2021-05-06 Thread GitBox
MyLanPangzi commented on pull request #2719: URL: https://github.com/apache/hudi/pull/2719#issuecomment-82159 i test with hive 2.3.8 and add follow shell. i got a runtime exception seems abnormal. HIVE_VERSION=$(hive --version|head -n 1|awk '{print $2}') if [[ $HIVE_VERSIO

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2904: [HUDI-1818] Validate and check required option for HoodieTable (Azure CI)

2021-05-06 Thread GitBox
codecov-commenter edited a comment on pull request #2904: URL: https://github.com/apache/hudi/pull/2904#issuecomment-830024729 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2904?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The

[GitHub] [hudi] yanghua commented on a change in pull request #2898: [HUDI-1871] Fix hive conf for Flink writer hive meta sync

2021-05-06 Thread GitBox
yanghua commented on a change in pull request #2898: URL: https://github.com/apache/hudi/pull/2898#discussion_r627167070 ## File path: hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java ## @@ -51,11 +51,10 @@ public HiveSyncTool hiveSyncTool() { retu

[GitHub] [hudi] hudi-bot edited a comment on pull request #2904: [HUDI-1818] Validate and check required option for HoodieTable (Azure CI)

2021-05-06 Thread GitBox
hudi-bot edited a comment on pull request #2904: URL: https://github.com/apache/hudi/pull/2904#issuecomment-830836315 ## CI report: * b43dc8db3e25949c77e9bb50d0122bdca9c43073 Travis: [FAILURE](https://travis-ci.com/github/apachehudi-ci/hudi-branch-ci/builds/225042351)

[GitHub] [hudi] codecov-commenter edited a comment on pull request #2904: [HUDI-1818] Validate and check required option for HoodieTable (Azure CI)

2021-05-06 Thread GitBox
codecov-commenter edited a comment on pull request #2904: URL: https://github.com/apache/hudi/pull/2904#issuecomment-830024729 # [Codecov](https://codecov.io/gh/apache/hudi/pull/2904?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The