[GitHub] [hudi] codecov-commenter edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869327388 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869327388 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869327388 #

[GitHub] [hudi] nsivabalan commented on a change in pull request #3142: [HUDI-1483] Support async clustering for deltastreamer and Spark streaming

2021-06-27 Thread GitBox
nsivabalan commented on a change in pull request #3142: URL: https://github.com/apache/hudi/pull/3142#discussion_r659456141 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/async/AsyncClusteringService.java ## @@ -0,0 +1,131 @@ +/* + * Licensed to

[GitHub] [hudi] hudi-bot edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862905306 ## CI report: * ac71607f82fb615ca9e47e6ac00ace68b2e96a99 Azure:

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862906759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862906759 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869327388 #

[GitHub] [hudi] zhangyue19921010 edited a comment on pull request #3145: [Docs] Improving Hudi Configurations docs

2021-06-27 Thread GitBox
zhangyue19921010 edited a comment on pull request #3145: URL: https://github.com/apache/hudi/pull/3145#issuecomment-869353685 Here is pic before this PR that Contents and tables will cover each other

[GitHub] [hudi] zhangyue19921010 commented on pull request #3145: [Docs] Improving Hudi Configurations docs

2021-06-27 Thread GitBox
zhangyue19921010 commented on pull request #3145: URL: https://github.com/apache/hudi/pull/3145#issuecomment-869353685 Here is pic before this PR that Contents and tables will not cover each other

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] codope commented on a change in pull request #3158: [WIP][HUDI-1860] Add INSERT_OVERWRITE support to DeltaStreamer

2021-06-27 Thread GitBox
codope commented on a change in pull request #3158: URL: https://github.com/apache/hudi/pull/3158#discussion_r659470200 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientOnCopyOnWriteStorage.java ## @@ -1242,11 +1242,11 @@

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862906759 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869327388 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869325847 ## CI report: * 47941e913528dbacd05f222c0d98f6ab2a34db31 Azure:

[GitHub] [hudi] wangxianghu commented on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
wangxianghu commented on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869345067 reopen to trigger the ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hudi] wangxianghu closed pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
wangxianghu closed pull request #3167: URL: https://github.com/apache/hudi/pull/3167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] zhangyue19921010 commented on pull request #3145: [Docs] Improving Hudi Configurations docs

2021-06-27 Thread GitBox
zhangyue19921010 commented on pull request #3145: URL: https://github.com/apache/hudi/pull/3145#issuecomment-869343192 Hi @leesf Thanks for your review! I generate the site in my local and here is the pic : ![0 0 0 0_4000_docs_configurations

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869327388 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862906759 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865079044 ## CI report: * 548390e6bd363be3ec299be8f2a2a3703f36566a Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862905306 ## CI report: * e2423c075b07740a81cf4c275348a04ca58de9b4 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3100: [HUDI-2034] Support explicit partition compaction strategy for flink …

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3100: URL: https://github.com/apache/hudi/pull/3100#issuecomment-862905306 ## CI report: * e2423c075b07740a81cf4c275348a04ca58de9b4 Azure:

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869327388 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] hudi-bot edited a comment on pull request #3146: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3146: URL: https://github.com/apache/hudi/pull/3146#issuecomment-867438049 ## CI report: * a373b98620420ec6e728f422c42b2a74d11b3d5c Azure:

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3146: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3146: URL: https://github.com/apache/hudi/pull/3146#issuecomment-867510590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] codecov-commenter commented on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
codecov-commenter commented on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869327388 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3167?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3146: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3146: URL: https://github.com/apache/hudi/pull/3146#issuecomment-867510590 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869325847 ## CI report: * 47941e913528dbacd05f222c0d98f6ab2a34db31 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865079044 ## CI report: * cd545b199fbe8c68ebd0b0be5ce91722a76c349a Azure:

[GitHub] [hudi] hudi-bot commented on pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
hudi-bot commented on pull request #3167: URL: https://github.com/apache/hudi/pull/3167#issuecomment-869325847 ## CI report: * 47941e913528dbacd05f222c0d98f6ab2a34db31 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] wangxianghu opened a new pull request #3167: [MINOR] Drop duplicate keygenerator class configuration setting

2021-06-27 Thread GitBox
wangxianghu opened a new pull request #3167: URL: https://github.com/apache/hudi/pull/3167 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* ## What is the purpose of

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865177596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865177596 #

[GitHub] [hudi] nsivabalan commented on a change in pull request #3147: [HUDI-1983] [DOC]Add key gen type config to Configurations page in hudi we…

2021-06-27 Thread GitBox
nsivabalan commented on a change in pull request #3147: URL: https://github.com/apache/hudi/pull/3147#discussion_r659453008 ## File path: docs/_docs/2_4_configurations.md ## @@ -83,8 +83,12 @@ Actual value ontained by invoking .toString() KEYGENERATOR_CLASS_OPT_KEY

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3146: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3146: URL: https://github.com/apache/hudi/pull/3146#issuecomment-867510590 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] nsivabalan commented on a change in pull request #3128: [HUDI-2029] Implement compression for DiskBasedMap in Spillable Map

2021-06-27 Thread GitBox
nsivabalan commented on a change in pull request #3128: URL: https://github.com/apache/hudi/pull/3128#discussion_r659451616 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/ExternalSpillableMap.java ## @@ -80,22 +84,38 @@ private final String

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865177596 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3146: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3146: URL: https://github.com/apache/hudi/pull/3146#issuecomment-867510590 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3146: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3146: URL: https://github.com/apache/hudi/pull/3146#issuecomment-867438049 ## CI report: * 9f29a8afc1a6e049984a789001042921d917f180 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3146: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3146: URL: https://github.com/apache/hudi/pull/3146#issuecomment-867438049 ## CI report: * 9f29a8afc1a6e049984a789001042921d917f180 Azure:

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3146: [HUDI-2057] CTAS Generate An External Table When Create Managed Table

2021-06-27 Thread GitBox
pengzhiwei2018 commented on a change in pull request #3146: URL: https://github.com/apache/hudi/pull/3146#discussion_r659436687 ## File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala ## @@ -355,6 +355,8 @@ object

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3140: [HUDI-2063] Add Doc For Spark Sql Integrates With Hudi

2021-06-27 Thread GitBox
pengzhiwei2018 commented on a change in pull request #3140: URL: https://github.com/apache/hudi/pull/3140#discussion_r659434155 ## File path: docs/_docs/1_1_spark_quick_start_guide.md ## @@ -300,6 +300,221 @@ spark. show(100, false) ``` +# Spark-Sql example +## Setup

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] hudi-bot edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865079044 ## CI report: * cd545b199fbe8c68ebd0b0be5ce91722a76c349a Azure:

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865177596 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865079044 ## CI report: * 6d70a1dd2a20de7b08d859bc9f51a19e35891c93 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3126: URL: https://github.com/apache/hudi/pull/3126#issuecomment-865079044 ## CI report: * 6d70a1dd2a20de7b08d859bc9f51a19e35891c93 Azure:

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3126: [HUDI-2051] Enable Hive Sync When Spark Enable Hive Meta For Spark Sql

2021-06-27 Thread GitBox
pengzhiwei2018 commented on a change in pull request #3126: URL: https://github.com/apache/hudi/pull/3126#discussion_r659425547 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala ## @@ -426,7

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] nsivabalan commented on a change in pull request #3117: [HUDI-2028] Implement RockDbBasedMap as an alternate to DiskBasedMap in ExternalSpillableMap

2021-06-27 Thread GitBox
nsivabalan commented on a change in pull request #3117: URL: https://github.com/apache/hudi/pull/3117#discussion_r659419442 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/SpillableRocksDBBasedMap.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864770805 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] hudi-bot edited a comment on pull request #3120: [HUDI-2045] Support Read Hoodie As DataSource Table For Flink And Del…

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3120: URL: https://github.com/apache/hudi/pull/3120#issuecomment-864760893 ## CI report: * aaca30fffd1ea37f803f51ef3cf49c59ed79badc UNKNOWN * fcd06c8bccfc90b272b51d3511094e6617ec25bd UNKNOWN *

[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3154: [HUDI-1884] MergeInto Support Partial Update For COW

2021-06-27 Thread GitBox
pengzhiwei2018 commented on a change in pull request #3154: URL: https://github.com/apache/hudi/pull/3154#discussion_r659420453 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala ## @@ -164,7 +165,47 @@ case

[jira] [Commented] (HUDI-1211) Test failures w/ some index tests (TestHoodieIndex)

2021-06-27 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370374#comment-17370374 ] sivabalan narayanan commented on HUDI-1211: --- don't think this is an issue right now. we can

[jira] [Updated] (HUDI-1211) Test failures w/ some index tests (TestHoodieIndex)

2021-06-27 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan updated HUDI-1211: -- Status: In Progress (was: Open) > Test failures w/ some index tests (TestHoodieIndex)

[jira] [Closed] (HUDI-1211) Test failures w/ some index tests (TestHoodieIndex)

2021-06-27 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sivabalan narayanan closed HUDI-1211. - Resolution: Invalid > Test failures w/ some index tests (TestHoodieIndex) >

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3071: [WIP] [HUDI-1976] Resolve vulnerability

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3071: URL: https://github.com/apache/hudi/pull/3071#issuecomment-869203433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] hudi-bot edited a comment on pull request #3071: [WIP] [HUDI-1976] Resolve vulnerability

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3071: URL: https://github.com/apache/hudi/pull/3071#issuecomment-869222972 ## CI report: * 9640a41dff18eb2387acd7565015fb97db98f476 Azure:

[GitHub] [hudi] xushiyan commented on pull request #3003: [HUDI-1939] Replace joda-time api with java8 new time api

2021-06-27 Thread GitBox
xushiyan commented on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-869225643 - [ ] fix UT failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] hudi-bot edited a comment on pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3166: URL: https://github.com/apache/hudi/pull/3166#issuecomment-869219682 ## CI report: * 85a7049f582bc1ccbb70e2ce97cd72a3c96758b5 Azure:

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3166: URL: https://github.com/apache/hudi/pull/3166#issuecomment-869220231 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3166: URL: https://github.com/apache/hudi/pull/3166#issuecomment-869220231 #

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3166: URL: https://github.com/apache/hudi/pull/3166#issuecomment-869220231 #

[GitHub] [hudi] hudi-bot edited a comment on pull request #3071: [WIP] [HUDI-1976] Resolve vulnerability

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3071: URL: https://github.com/apache/hudi/pull/3071#issuecomment-869222972 ## CI report: * 9640a41dff18eb2387acd7565015fb97db98f476 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #3071: [WIP] [HUDI-1976] Resolve vulnerability

2021-06-27 Thread GitBox
hudi-bot commented on pull request #3071: URL: https://github.com/apache/hudi/pull/3071#issuecomment-869222972 ## CI report: * 9640a41dff18eb2387acd7565015fb97db98f476 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] codecov-commenter edited a comment on pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
codecov-commenter edited a comment on pull request #3166: URL: https://github.com/apache/hudi/pull/3166#issuecomment-869220231 #

[GitHub] [hudi] codecov-commenter commented on pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
codecov-commenter commented on pull request #3166: URL: https://github.com/apache/hudi/pull/3166#issuecomment-869220231 # [Codecov](https://codecov.io/gh/apache/hudi/pull/3166?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [hudi] hudi-bot edited a comment on pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #3166: URL: https://github.com/apache/hudi/pull/3166#issuecomment-869219682 ## CI report: * 85a7049f582bc1ccbb70e2ce97cd72a3c96758b5 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
hudi-bot commented on pull request #3166: URL: https://github.com/apache/hudi/pull/3166#issuecomment-869219682 ## CI report: * 85a7049f582bc1ccbb70e2ce97cd72a3c96758b5 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[jira] [Updated] (HUDI-2081) Move TestHiveSyncTool to functional

2021-06-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-2081: - Labels: pull-request-available (was: ) > Move TestHiveSyncTool to functional >

[GitHub] [hudi] xushiyan opened a new pull request #3166: [HUDI-2081] Move schema util tests out from TestHiveSyncTool

2021-06-27 Thread GitBox
xushiyan opened a new pull request #3166: URL: https://github.com/apache/hudi/pull/3166 ## Committer checklist - [ ] Has a corresponding JIRA in PR title & commit - [ ] Commit message is descriptive of the change - [ ] CI is green - [ ] Necessary

[jira] [Updated] (HUDI-2081) Move TestHiveSyncTool to functional

2021-06-27 Thread Raymond Xu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raymond Xu updated HUDI-2081: - Status: In Progress (was: Open) > Move TestHiveSyncTool to functional >

[GitHub] [hudi] vinothchandar commented on pull request #3003: [HUDI-1939][WIP] Replace joda-time api with java8 new time api

2021-06-27 Thread GitBox
vinothchandar commented on pull request #3003: URL: https://github.com/apache/hudi/pull/3003#issuecomment-869217062 Is the WIP in the title still needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (HUDI-2083) Hudi CLI does not with S3

2021-06-27 Thread Vinay (Jira)
Vinay created HUDI-2083: --- Summary: Hudi CLI does not with S3 Key: HUDI-2083 URL: https://issues.apache.org/jira/browse/HUDI-2083 Project: Apache Hudi Issue Type: Task Components: CLI

[jira] [Updated] (HUDI-2083) Hudi CLI does not work with S3

2021-06-27 Thread Vinay (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated HUDI-2083: Summary: Hudi CLI does not work with S3 (was: Hudi CLI does not with S3) > Hudi CLI does not work with S3 >

[GitHub] [hudi] hudi-bot edited a comment on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-869215376 ## CI report: * f7e53eb22bf7a1e109ba258c7ac21d983d807738 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2378: [HUDI-1491] Support partition pruning for MOR snapshot query

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #2378: URL: https://github.com/apache/hudi/pull/2378#issuecomment-869215174 ## CI report: * 295290ebdd0a01a8e403e9799a7bfdb75364b435 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2378: [HUDI-1491] Support partition pruning for MOR snapshot query

2021-06-27 Thread GitBox
hudi-bot edited a comment on pull request #2378: URL: https://github.com/apache/hudi/pull/2378#issuecomment-869215174 ## CI report: * 295290ebdd0a01a8e403e9799a7bfdb75364b435 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-06-27 Thread GitBox
hudi-bot commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-869215376 ## CI report: * f7e53eb22bf7a1e109ba258c7ac21d983d807738 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] vinothchandar commented on pull request #2012: [HUDI-1129] Deltastreamer Add support for schema evolution

2021-06-27 Thread GitBox
vinothchandar commented on pull request #2012: URL: https://github.com/apache/hudi/pull/2012#issuecomment-869215210 @nsivabalan whats the next step for this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hudi] hudi-bot commented on pull request #2378: [HUDI-1491] Support partition pruning for MOR snapshot query

2021-06-27 Thread GitBox
hudi-bot commented on pull request #2378: URL: https://github.com/apache/hudi/pull/2378#issuecomment-869215174 ## CI report: * 295290ebdd0a01a8e403e9799a7bfdb75364b435 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[jira] [Comment Edited] (HUDI-1211) Test failures w/ some index tests (TestHoodieIndex)

2021-06-27 Thread Raymond Xu (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17370315#comment-17370315 ] Raymond Xu edited comment on HUDI-1211 at 6/27/21, 7:40 PM: [~shivnarayan] is

[GitHub] [hudi] n3nash commented on issue #3078: [SUPPORT] combineAndGetUpdateValue is not getting called when Schema evolution happens

2021-06-27 Thread GitBox
n3nash commented on issue #3078: URL: https://github.com/apache/hudi/issues/3078#issuecomment-869213421 @guanziyue Thanks for the detailed explanation. @tandonraghav During compaction, `combineAndGetUpdateValue` is never called. See this to get an understanding of how compaction

[GitHub] [hudi] tandonraghav commented on issue #3078: [SUPPORT] combineAndGetUpdateValue is not getting called when Schema evolution happens

2021-06-27 Thread GitBox
tandonraghav commented on issue #3078: URL: https://github.com/apache/hudi/issues/3078#issuecomment-869211898 @guanziyue Well, in my testing combinAndGetUpdateValue in not getting called at all. I am not worried about how compaction is happening for delta records. Do you have a

  1   2   >