[GitHub] [hudi] peanut-chenzhong edited a comment on pull request #3761: [HUDI-2509] OverwriteNonDefaultsWithLatestAvroPayload doesn`t work when upsert data with some null value column

peanut-chenzhong edited a comment on pull request #3761: URL: https://github.com/apache/hudi/pull/3761#issuecomment-95720 > @peanut-chenzhong : I see even without the fix, the added test succeeds. Objects.equals(value, defaultValue) returns true even for null, null. Can you check if th

[GitHub] [hudi] hudi-bot edited a comment on pull request #3771: [HUDI-2402] Add Kerberos configuration options to Hive Sync

hudi-bot edited a comment on pull request #3771: URL: https://github.com/apache/hudi/pull/3771#issuecomment-939200284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] jadireddi edited a comment on issue #3558: [SUPPORT] Schema evolution error: promoted data type from integer to double

jadireddi edited a comment on issue #3558: URL: https://github.com/apache/hudi/issues/3558#issuecomment-957726431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [hudi] xiarixiaoyao commented on pull request #3808: [HUDI-2560] introduce id_based schema to support full schema evolution.

xiarixiaoyao commented on pull request #3808: URL: https://github.com/apache/hudi/pull/3808#issuecomment-957066897 @bvaradar Thank you for your review， will update the code today。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [hudi] zhedoubushishi commented on a change in pull request #3486: [HUDI-2314] Add support for DynamoDb based lock

zhedoubushishi commented on a change in pull request #3486: URL: https://github.com/apache/hudi/pull/3486#discussion_r740755755 ## File path: hudi-client/hudi-client-common/pom.xml ## @@ -275,6 +300,45 @@ false + +io.fabric8 +d

[GitHub] [hudi] JB-data commented on issue #3905: [SUPPORT] Transform from kafka complains about table not found when using transformer.sql

JB-data commented on issue #3905: URL: https://github.com/apache/hudi/issues/3905#issuecomment-957953303 I have seen by coincidence @nsivabalan respond to similar questions.. maybe he is so kind to take a look? Thanks! -- This is an automated message from the Apache Git Service. To re

[GitHub] [hudi] YannByron commented on pull request #3844: [HUDI-1869] Upgrading Spark3 To 3.1

YannByron commented on pull request #3844: URL: https://github.com/apache/hudi/pull/3844#issuecomment-957133846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [hudi] hudi-bot edited a comment on pull request #3761: [HUDI-2509] OverwriteNonDefaultsWithLatestAvroPayload doesn`t work when upsert data with some null value column

hudi-bot edited a comment on pull request #3761: URL: https://github.com/apache/hudi/pull/3761#issuecomment-938264265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] hudi-bot edited a comment on pull request #3769: [HUDI-2005][WIP] Fixing partition path creation in AbstractTableFileSystemView

hudi-bot edited a comment on pull request #3769: URL: https://github.com/apache/hudi/pull/3769#issuecomment-939013386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] codope commented on a change in pull request #3865: [HUDI-2005][WIP] Removing direct fs call in HoodieLogFileReader

codope commented on a change in pull request #3865: URL: https://github.com/apache/hudi/pull/3865#discussion_r740731116 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieRealtimeFileSplit.java ## @@ -58,6 +62,10 @@ public HoodieRealtimeFileSplit(

[GitHub] [hudi] nsivabalan commented on pull request #3799: [HUDI-2491] hoodie.datasource.hive_sync.mode=hms mode is supported in…

nsivabalan commented on pull request #3799: URL: https://github.com/apache/hudi/pull/3799#issuecomment-957063566 @fuyun2024 : looks like there are some conflicts with master. Can you rebase with latest. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [hudi] nsivabalan commented on pull request #3820: [HUDI-2579] Make deltastreamer checkpoint state merging more explicit

nsivabalan commented on pull request #3820: URL: https://github.com/apache/hudi/pull/3820#issuecomment-956855780 @hudi-bot azure run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] hudi-bot edited a comment on pull request #3865: [HUDI-2005][WIP] Removing direct fs call in HoodieLogFileReader

hudi-bot edited a comment on pull request #3865: URL: https://github.com/apache/hudi/pull/3865#issuecomment-951550415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] hudi-bot commented on pull request #3902: [MINOR] Adding a deprecated constructor to AbstractSyncHoodieClient so that old callers does not break

hudi-bot commented on pull request #3902: URL: https://github.com/apache/hudi/pull/3902#issuecomment-956754482 ## CI report: * 4893ab6a04d8d061a975afcb345c730cbe1672ea UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] hudi-bot edited a comment on pull request #3900: [HUDI-2595] Fixing metadata table updates such that only regular writes from data table can trigger table services in metadata table

hudi-bot edited a comment on pull request #3900: URL: https://github.com/apache/hudi/pull/3900#issuecomment-956209542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] novakov-alexey edited a comment on issue #3558: [SUPPORT] Schema evolution error: promoted data type from integer to double

novakov-alexey edited a comment on issue #3558: URL: https://github.com/apache/hudi/issues/3558#issuecomment-957466015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [hudi] bkosuru commented on issue #3892: Insert produces 44764 files with ~50MB each

bkosuru commented on issue #3892: URL: https://github.com/apache/hudi/issues/3892#issuecomment-956441700 Hi @dongkelun, Thanks for the suggestion. The number of files reduced to 2998 for INSERT. I have couple of questions. 1) What options control the size and number of parquet fi

[GitHub] [hudi] hudi-bot edited a comment on pull request #3904: [WIP][HUDI-1295] Metadata Index - Bloom filter metadata to speed up index lookups

hudi-bot edited a comment on pull request #3904: URL: https://github.com/apache/hudi/pull/3904#issuecomment-957238023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] hudi-bot commented on pull request #3904: [WIP][HUDI-1295] Metadata Index - Bloom filter metadata to speed up index lookups

hudi-bot commented on pull request #3904: URL: https://github.com/apache/hudi/pull/3904#issuecomment-957238023 ## CI report: * b44ebe5eb1da433b6ddf86b4839e280ea9cc6f9f UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] codope commented on a change in pull request #3771: [HUDI-2402] Add Kerberos configuration options to Hive Sync

codope commented on a change in pull request #3771: URL: https://github.com/apache/hudi/pull/3771#discussion_r740865098 ## File path: hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java ## @@ -1017,4 +1019,36 @@ public void testTypeConverter(Strin

[GitHub] [hudi] hudi-bot edited a comment on pull request #3823: [HUDI-2538] persist some configs to hoodie.properties when the first write

hudi-bot edited a comment on pull request #3823: URL: https://github.com/apache/hudi/pull/3823#issuecomment-946850790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] nsivabalan merged pull request #3901: [HUDI-2662] Downloads from Nexus Pentaho repo taking too long

nsivabalan merged pull request #3901: URL: https://github.com/apache/hudi/pull/3901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [hudi] nsivabalan commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages

nsivabalan commented on pull request #3889: URL: https://github.com/apache/hudi/pull/3889#issuecomment-956856529 @hudi-bot azure run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] nsivabalan commented on pull request #3486: [HUDI-2314] Add support for DynamoDb based lock

nsivabalan commented on pull request #3486: URL: https://github.com/apache/hudi/pull/3486#issuecomment-956557401 @zhedoubushishi : Do you think you will find time to address feedback. We are looking to see if we can get this in for the upcoming release. would appreciate if you can spare so

[GitHub] [hudi] nsivabalan merged pull request #3881: [HUDI-2627]Fix unsupported query instant time format in quickstart page

nsivabalan merged pull request #3881: URL: https://github.com/apache/hudi/pull/3881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [hudi] liujinhui1994 commented on pull request #3614: [HUDI-2370] Supports data encryption

liujinhui1994 commented on pull request #3614: URL: https://github.com/apache/hudi/pull/3614#issuecomment-957025580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hudi] vinothchandar commented on pull request #3330: [HUDI-2101][RFC-28]support z-order for hudi

vinothchandar commented on pull request #3330: URL: https://github.com/apache/hudi/pull/3330#issuecomment-957382195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [hudi] nsivabalan commented on pull request #3887: [HUDI-2648] Retry FileSystem action instead of failed directly.

nsivabalan commented on pull request #3887: URL: https://github.com/apache/hudi/pull/3887#issuecomment-956857417 @hudi-bot azure run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] hudi-bot edited a comment on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages

hudi-bot edited a comment on pull request #3889: URL: https://github.com/apache/hudi/pull/3889#issuecomment-954508326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] danny0405 commented on pull request #3899: [HUDI-2660] Delete the view storage properties first before creation

danny0405 commented on pull request #3899: URL: https://github.com/apache/hudi/pull/3899#issuecomment-957059969 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [hudi] hudi-bot edited a comment on pull request #3888: [HUDI-2624] Implement Non Index type for HUDI

hudi-bot edited a comment on pull request #3888: URL: https://github.com/apache/hudi/pull/3888#issuecomment-954503596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] kenny291 commented on issue #3558: [SUPPORT] Schema evolution error: promoted data type from integer to double

kenny291 commented on issue #3558: URL: https://github.com/apache/hudi/issues/3558#issuecomment-957484205 @novakov-alexey, double to int is not compatibility in Avro schema revolution http://avro.apache.org/docs/current/spec#Schema+Resolution -- This is an automated message from the

[GitHub] [hudi] nsivabalan commented on pull request #2819: [HUDI-1794] Moved static COMMIT_FORMATTER to thread local variable as SimpleDateFormat is not thread safe.

nsivabalan commented on pull request #2819: URL: https://github.com/apache/hudi/pull/2819#issuecomment-956859813 @hudi-bot azure run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] hudi-bot commented on pull request #3903: [HUDI-2651] Sync all the missing sql options for HoodieFlinkStreamer

hudi-bot commented on pull request #3903: URL: https://github.com/apache/hudi/pull/3903#issuecomment-957173931 ## CI report: * 9754611552f4db38f7679f54dfe86a3191bb7473 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] nsivabalan merged pull request #3902: [MINOR] Adding a deprecated constructor to AbstractSyncHoodieClient so that old callers does not break

nsivabalan merged pull request #3902: URL: https://github.com/apache/hudi/pull/3902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [hudi] hudi-bot edited a comment on pull request #3903: [HUDI-2651] Sync all the missing sql options for HoodieFlinkStreamer

hudi-bot edited a comment on pull request #3903: URL: https://github.com/apache/hudi/pull/3903#issuecomment-957173931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] nsivabalan commented on a change in pull request #3614: [HUDI-2370] Supports data encryption

nsivabalan commented on a change in pull request #3614: URL: https://github.com/apache/hudi/pull/3614#discussion_r740499106 ## File path: pom.xml ## @@ -91,7 +91,7 @@ 2.0.0 5.3.4 2.17 -1.10.1 +1.12.0 Review comment: @liujinhui1994 : may I know wha

[GitHub] [hudi] hudi-bot edited a comment on pull request #3614: [HUDI-2370] Supports data encryption

hudi-bot edited a comment on pull request #3614: URL: https://github.com/apache/hudi/pull/3614#issuecomment-914114290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] manojpec commented on pull request #3889: [HUDI-2443] Hudi KVComparator for all HFile writer usages

manojpec commented on pull request #3889: URL: https://github.com/apache/hudi/pull/3889#issuecomment-957096349 @hudi-bot azure run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [hudi] hudi-bot edited a comment on pull request #3203: [HUDI-2086] Refactor hive mor_incremental_view

hudi-bot edited a comment on pull request #3203: URL: https://github.com/apache/hudi/pull/3203#issuecomment-872092745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] hudi-bot edited a comment on pull request #3817: [HUDI-2582] Support concurrent key gen for different tables with row writer path

hudi-bot edited a comment on pull request #3817: URL: https://github.com/apache/hudi/pull/3817#issuecomment-945545601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] hudi-bot edited a comment on pull request #3330: [HUDI-2101][RFC-28]support z-order for hudi

hudi-bot edited a comment on pull request #3330: URL: https://github.com/apache/hudi/pull/3330#issuecomment-885350571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] nsivabalan commented on pull request #3865: [HUDI-2005][WIP] Removing direct fs call in HoodieLogFileReader

nsivabalan commented on pull request #3865: URL: https://github.com/apache/hudi/pull/3865#issuecomment-956857981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [hudi] nsivabalan edited a comment on pull request #3901: [MINOR] Downloads from Nexus Pentaho repo taking too long

nsivabalan edited a comment on pull request #3901: URL: https://github.com/apache/hudi/pull/3901#issuecomment-956457262 I inspected every jar thats getting delayed with pentaho. I could confirm that we can find every jar of interest in other nexus domains. ``` https://public

[GitHub] [hudi] hudi-bot edited a comment on pull request #3899: [HUDI-2660] Delete the view storage properties first before creation

hudi-bot edited a comment on pull request #3899: URL: https://github.com/apache/hudi/pull/3899#issuecomment-956165515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] test-wangxiaoyu commented on pull request #3771: [HUDI-2402] Add Kerberos configuration options to Hive Sync

test-wangxiaoyu commented on pull request #3771: URL: https://github.com/apache/hudi/pull/3771#issuecomment-957242076 > @test-wangxiaoyu Can you rebase with master? There was an issue which was causing CI failure which has now been fixed. Okay, I've done what you said -- This is a

[GitHub] [hudi] nsivabalan commented on pull request #3824: [HUDI-1292] Millisecond granularity for instant timestamps

nsivabalan commented on pull request #3824: URL: https://github.com/apache/hudi/pull/3824#issuecomment-956862033 @hudi-bot azure run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3765: [HUDI-2533] New option for hoodieClusteringJob to check, rollback and re-execute the last failed clustering job

zhangyue19921010 removed a comment on pull request #3765: URL: https://github.com/apache/hudi/pull/3765#issuecomment-957144474 @hudi-bot run azure re-run the last Azure build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [hudi] nsivabalan commented on issue #3890: [SUPPORT] Hudi Sync did not add previous partitions

nsivabalan commented on issue #3890: URL: https://github.com/apache/hudi/issues/3890#issuecomment-956790581 Can you take this up @codope please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hudi] xushiyan commented on a change in pull request #3844: [HUDI-1869] Upgrading Spark3 To 3.1

xushiyan commented on a change in pull request #3844: URL: https://github.com/apache/hudi/pull/3844#discussion_r740624602 ## File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/AvroConversionHelper.scala ## @@ -131,7 +131,7 @@ object AvroConversionHelper {

[GitHub] [hudi] hudi-bot edited a comment on pull request #3820: [HUDI-2579] Make deltastreamer checkpoint state merging more explicit

hudi-bot edited a comment on pull request #3820: URL: https://github.com/apache/hudi/pull/3820#issuecomment-945958915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] hudi-bot edited a comment on pull request #3902: [MINOR] Adding a deprecated constructor to AbstractSyncHoodieClient so that old callers does not break

hudi-bot edited a comment on pull request #3902: URL: https://github.com/apache/hudi/pull/3902#issuecomment-956754482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] zhangyue19921010 removed a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

zhangyue19921010 removed a comment on pull request #3897: URL: https://github.com/apache/hudi/pull/3897#issuecomment-956043709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [hudi] codope commented on a change in pull request #3761: [HUDI-2509] OverwriteNonDefaultsWithLatestAvroPayload doesn`t work when upsert data with some null value column

codope commented on a change in pull request #3761: URL: https://github.com/apache/hudi/pull/3761#discussion_r741051384 ## File path: hudi-common/src/test/java/org/apache/hudi/common/model/TestOverwriteNonDefaultsWithLatestAvroPayload.java ## @@ -126,4 +127,33 @@ public void t

[GitHub] [hudi] hudi-bot edited a comment on pull request #3053: [HUDI-1932] Update Hive sync timestamp when change detected

hudi-bot edited a comment on pull request #3053: URL: https://github.com/apache/hudi/pull/3053#issuecomment-956788282 ## CI report: * 6d6921ed8105efa3910e003e986d5e94d2c93c26 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/re

[GitHub] [hudi] xiarixiaoyao commented on pull request #3330: [HUDI-2101][RFC-28]support z-order for hudi

xiarixiaoyao commented on pull request #3330: URL: https://github.com/apache/hudi/pull/3330#issuecomment-957446790 @vinothchandar yes， hilbert curve is ready， i think time is enough to add hilbert curve. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [hudi] fuyun2024 commented on pull request #3799: [HUDI-2491] hoodie.datasource.hive_sync.mode=hms mode is supported in…

fuyun2024 commented on pull request #3799: URL: https://github.com/apache/hudi/pull/3799#issuecomment-957029458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [hudi] nsivabalan merged pull request #3746: [HUDI-2515] Add close when producing records failed

nsivabalan merged pull request #3746: URL: https://github.com/apache/hudi/pull/3746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [hudi] YannByron commented on a change in pull request #3844: [HUDI-1869] Upgrading Spark3 To 3.1

YannByron commented on a change in pull request #3844: URL: https://github.com/apache/hudi/pull/3844#discussion_r740646803 ## File path: hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestHoodieSqlBase.scala ## @@ -92,6 +96,19 @@ class TestHoodieSqlB

[GitHub] [hudi] prashantwason commented on pull request #2819: [HUDI-1794] Moved static COMMIT_FORMATTER to thread local variable as SimpleDateFormat is not thread safe.

prashantwason commented on pull request #2819: URL: https://github.com/apache/hudi/pull/2819#issuecomment-956537136 @codope Fixed the test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [hudi] kywe665 commented on pull request #3855: [HUDI-2607] Reorganize Hudi Docs

kywe665 commented on pull request #3855: URL: https://github.com/apache/hudi/pull/3855#issuecomment-957020219 Good catch, I just cleaned up all absolute links -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [hudi] nsivabalan commented on pull request #3700: [HUDI-2471] Add support ignoring case in merge into

nsivabalan commented on pull request #3700: URL: https://github.com/apache/hudi/pull/3700#issuecomment-957074628 @hudi-bot azure run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] nsivabalan commented on issue #3894: [SUPPORT] Property hoodie.datasource.write.recordkey.field not found during version ONE to TWO migration

nsivabalan commented on issue #3894: URL: https://github.com/apache/hudi/issues/3894#issuecomment-956784862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [hudi] zhangyue19921010 commented on pull request #3765: [HUDI-2533] New option for hoodieClusteringJob to check, rollback and re-execute the last failed clustering job

zhangyue19921010 commented on pull request #3765: URL: https://github.com/apache/hudi/pull/3765#issuecomment-957144474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [hudi] codope commented on pull request #3830: [HUDI-2077] Set schema validation from main write config

codope commented on pull request #3830: URL: https://github.com/apache/hudi/pull/3830#issuecomment-957121442 > in general, I agree with your intention. but not for schema validation. Metadata is an impl detail. User does not even know whats the schema for metadata table. so, atleast for th

[GitHub] [hudi] hudi-bot edited a comment on pull request #3803: [HUDI-2472] Enabling Metadata table for TestCleaner unit tests

hudi-bot edited a comment on pull request #3803: URL: https://github.com/apache/hudi/pull/3803#issuecomment-943565382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] haoliang7 closed issue #3898: [SUPPORT] Hudi vs Hoodie

haoliang7 closed issue #3898: URL: https://github.com/apache/hudi/issues/3898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [hudi] hudi-bot edited a comment on pull request #3824: [HUDI-1292] Millisecond granularity for instant timestamps

hudi-bot edited a comment on pull request #3824: URL: https://github.com/apache/hudi/pull/3824#issuecomment-946872755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] nsivabalan commented on issue #3892: Insert produces 44764 files with ~50MB each

nsivabalan commented on issue #3892: URL: https://github.com/apache/hudi/issues/3892#issuecomment-956756527 Let me try to explain. @bhasudha : Can you document this somewhere. might be useful for everyone in the community in general. Bulk_insert: This does not do any small file

[GitHub] [hudi] hudi-bot edited a comment on pull request #3844: [HUDI-1869] Upgrading Spark3 To 3.1

hudi-bot edited a comment on pull request #3844: URL: https://github.com/apache/hudi/pull/3844#issuecomment-949285568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] nsivabalan commented on pull request #3817: [HUDI-2582] Support concurrent key gen for different tables with row writer path

nsivabalan commented on pull request #3817: URL: https://github.com/apache/hudi/pull/3817#issuecomment-956554404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [hudi] codope closed pull request #3830: [HUDI-2077] Set schema validation from main write config

codope closed pull request #3830: URL: https://github.com/apache/hudi/pull/3830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [hudi] jadireddi commented on issue #3558: [SUPPORT] Schema evolution error: promoted data type from integer to double

jadireddi commented on issue #3558: URL: https://github.com/apache/hudi/issues/3558#issuecomment-957726431 @nsivabalan , Hudi uses `parquet-avro`. So there is a slight variation for the primitive typesconversion between avro and parquet-avro. AFAIK, int is promoted to int long

[GitHub] [hudi] haoliang7 commented on issue #3898: [SUPPORT] Hudi vs Hoodie

haoliang7 commented on issue #3898: URL: https://github.com/apache/hudi/issues/3898#issuecomment-957010738 @nsivabalan Got it. Thank you for explanation. IMHO, it's better to unify the names. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hudi] nsivabalan merged pull request #3769: [HUDI-2005] Fixing partition path creation in AbstractTableFileSystemView

nsivabalan merged pull request #3769: URL: https://github.com/apache/hudi/pull/3769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [hudi] nsivabalan edited a comment on issue #3892: Insert produces 44764 files with ~50MB each

nsivabalan edited a comment on issue #3892: URL: https://github.com/apache/hudi/issues/3892#issuecomment-956756527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [hudi] nsivabalan commented on pull request #3902: [MINOR] Adding a deprecated constructor to AbstractSyncHoodieClient so that old callers does not break

nsivabalan commented on pull request #3902: URL: https://github.com/apache/hudi/pull/3902#issuecomment-956856134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [hudi] hudi-bot edited a comment on pull request #3901: [MINOR] Downloads from Nexus Pentaho repo taking too long

hudi-bot edited a comment on pull request #3901: URL: https://github.com/apache/hudi/pull/3901#issuecomment-956223142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] xiarixiaoyao commented on pull request #3203: [HUDI-2086] Refactor hive mor_incremental_view

xiarixiaoyao commented on pull request #3203: URL: https://github.com/apache/hudi/pull/3203#issuecomment-957530371 @codope thanks for your review. Adressed all comments。 Add test case for compaction to verify that incremental reads do NOT show inserts after compaction timestamp， oth

[GitHub] [hudi] nsivabalan commented on pull request #3830: [HUDI-2077] Set schema validation from main write config

nsivabalan commented on pull request #3830: URL: https://github.com/apache/hudi/pull/3830#issuecomment-956525831 in general, I agree with your intention. but not for schema validation. Metadata is an impl detail. User does not even know whats the schema for metadata table. so, atleast for

[GitHub] [hudi] hudi-bot commented on pull request #3053: [HUDI-1932] Update Hive sync timestamp when change detected

hudi-bot commented on pull request #3053: URL: https://github.com/apache/hudi/pull/3053#issuecomment-956788282 ## CI report: * 6d6921ed8105efa3910e003e986d5e94d2c93c26 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run travis`

[GitHub] [hudi] nsivabalan commented on pull request #3765: [HUDI-2533] New option for hoodieClusteringJob to check, rollback and re-execute the last failed clustering job

nsivabalan commented on pull request #3765: URL: https://github.com/apache/hudi/pull/3765#issuecomment-956528663 @codope : I will let you drive this to completion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hudi] nsivabalan commented on pull request #3900: [HUDI-2595] Fixing metadata table updates such that only regular writes from data table can trigger table services in metadata table

nsivabalan commented on pull request #3900: URL: https://github.com/apache/hudi/pull/3900#issuecomment-956864765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [hudi] codope commented on issue #3782: [SUPPORT] Hudi Concurrent write (OCC) with upsert tables random errors

codope commented on issue #3782: URL: https://github.com/apache/hudi/issues/3782#issuecomment-956417085 @umehrot2 Do you have a patch that can be tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [hudi] hudi-bot edited a comment on pull request #3486: [HUDI-2314] Add support for DynamoDb based lock

hudi-bot edited a comment on pull request #3486: URL: https://github.com/apache/hudi/pull/3486#issuecomment-899911684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] nsivabalan commented on pull request #2790: [HUDI-1779] Fail to bootstrap/upsert a table which contains timestamp column

nsivabalan commented on pull request #2790: URL: https://github.com/apache/hudi/pull/2790#issuecomment-957073766 @li36909 : also would be good to put up a separate patch for upgrading parquet version. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hudi] hudi-bot edited a comment on pull request #3746: [HUDI-2515] Add close when producing records failed

hudi-bot edited a comment on pull request #3746: URL: https://github.com/apache/hudi/pull/3746#issuecomment-933086527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] nsivabalan commented on pull request #3769: [HUDI-2005][WIP] Fixing partition path creation in AbstractTableFileSystemView

nsivabalan commented on pull request #3769: URL: https://github.com/apache/hudi/pull/3769#issuecomment-956859040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [hudi] nsivabalan commented on a change in pull request #3769: [HUDI-2005] Fixing partition path creation in AbstractTableFileSystemView

nsivabalan commented on a change in pull request #3769: URL: https://github.com/apache/hudi/pull/3769#discussion_r740705982 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/commit/TestUpsertPartitioner.java ## @@ -217,7 +218,7 @@ public vo

[GitHub] [hudi] hudi-bot edited a comment on pull request #3857: [WIP][HUDI-2332] Add clustering and compaction in Kafka Connect Sink

hudi-bot edited a comment on pull request #3857: URL: https://github.com/apache/hudi/pull/3857#issuecomment-950560156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] nsivabalan commented on a change in pull request #3873: [HUDI-2634] Improved the metadata table bootstrap for very large tables.

nsivabalan commented on a change in pull request #3873: URL: https://github.com/apache/hudi/pull/3873#discussion_r740454888 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java ## @@ -645,4 +612,83 @@ protecte

[GitHub] [hudi] nsivabalan commented on a change in pull request #3901: [MINOR] Downloads from Nexus Pentaho repo taking too long

nsivabalan commented on a change in pull request #3901: URL: https://github.com/apache/hudi/pull/3901#discussion_r740539568 ## File path: hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java ## @@ -199,10 +203,14 @@ private void initIfNeeded() {

[GitHub] [hudi] liujinhui1994 commented on a change in pull request #3614: [HUDI-2370] Supports data encryption

liujinhui1994 commented on a change in pull request #3614: URL: https://github.com/apache/hudi/pull/3614#discussion_r740663071 ## File path: pom.xml ## @@ -91,7 +91,7 @@ 2.0.0 5.3.4 2.17 -1.10.1 +1.12.0 Review comment: Currently working on the las

[GitHub] [hudi] peanut-chenzhong commented on pull request #3761: [HUDI-2509] OverwriteNonDefaultsWithLatestAvroPayload doesn`t work when upsert data with some null value column

peanut-chenzhong commented on pull request #3761: URL: https://github.com/apache/hudi/pull/3761#issuecomment-95720 > @peanut-chenzhong : I see even without the fix, the added test succeeds. Objects.equals(value, defaultValue) returns true even for null, null. Can you check if the fix i

[GitHub] [hudi] novakov-alexey commented on issue #3558: [SUPPORT] Schema evolution error: promoted data type from integer to double

novakov-alexey commented on issue #3558: URL: https://github.com/apache/hudi/issues/3558#issuecomment-957334067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [hudi] zuyanton commented on pull request #3053: [HUDI-1932] Update Hive sync timestamp when change detected

zuyanton commented on pull request #3053: URL: https://github.com/apache/hudi/pull/3053#issuecomment-956785065 Hi Team, is there an update on this issue ? is it still planned to get into 0.10.0 release ? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #3203: [HUDI-2086] Refactor hive mor_incremental_view

xiarixiaoyao commented on a change in pull request #3203: URL: https://github.com/apache/hudi/pull/3203#discussion_r740695703 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java ## @@ -161,6 +148,82 @@ return rtSplit

[GitHub] [hudi] hudi-bot edited a comment on pull request #3765: [HUDI-2533] New option for hoodieClusteringJob to check, rollback and re-execute the last failed clustering job

hudi-bot edited a comment on pull request #3765: URL: https://github.com/apache/hudi/pull/3765#issuecomment-938488397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] hudi-bot edited a comment on pull request #3897: [HUDI-2658] When disable auto clean, do not check if MIN_COMMITS_TO_KEEP was larger CLEANER_COMMITS_RETAINED or not.

hudi-bot edited a comment on pull request #3897: URL: https://github.com/apache/hudi/pull/3897#issuecomment-955953458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [hudi] vinothchandar commented on a change in pull request #3901: [MINOR] Downloads from Nexus Pentaho repo taking too long

vinothchandar commented on a change in pull request #3901: URL: https://github.com/apache/hudi/pull/3901#discussion_r740523866 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java ## @@ -834,6 +834,7 @@ publi

<    1   2   3   4   5   6   7   >