xiarixiaoyao commented on PR #5572:
URL: https://github.com/apache/hudi/pull/5572#issuecomment-1126868812
LGTM
@minihippo just a few comments,
looking forward to the implementation of HoodieTableMetastoreClient
--
This is an automated message from the Apache Git Service.
To res
xiarixiaoyao commented on code in PR #5572:
URL: https://github.com/apache/hudi/pull/5572#discussion_r873115257
##
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetastoreConfig.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
gnailJC opened a new issue, #5586:
URL: https://github.com/apache/hudi/issues/5586
**_Tips before filing an issue_**
- Have you gone through our [FAQs](https://hudi.apache.org/learn/faq/)? yes
- Join the mailing list to engage in conversations and get faster support at
dev-subs
dongkelun commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1126862567
@nsivabalan As the comments in the code,`lastCompletedCommitTimestamp` is
the last completed commit timestamp before clean. There is no guarantee that it
is the last one on the whole tim
hudi-bot commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1126862212
## CI report:
* 7ccf5f2f31a435cbc8ac8515a6b61e07c54f486e Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8412
hudi-bot commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1126861812
## CI report:
* 7ccf5f2f31a435cbc8ac8515a6b61e07c54f486e Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8412
hudi-bot commented on PR #5564:
URL: https://github.com/apache/hudi/pull/5564#issuecomment-1126861505
## CI report:
* ed44089bf95146b90871ec173056a3296c9f3a2e Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8659
cdmikechen commented on code in PR #3391:
URL: https://github.com/apache/hudi/pull/3391#discussion_r873107531
##
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##
@@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {
pu
jinxing64 commented on code in PR #5564:
URL: https://github.com/apache/hudi/pull/5564#discussion_r873107339
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/DropHoodieTableCommand.scala:
##
@@ -88,42 +86,33 @@ extends HoodieLeafRunnabl
jinxing64 commented on code in PR #5564:
URL: https://github.com/apache/hudi/pull/5564#discussion_r873107298
##
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestDropTable.scala:
##
@@ -72,4 +72,154 @@ class TestDropTable extends HoodieSparkSqlTestBas
jinxing64 commented on code in PR #5564:
URL: https://github.com/apache/hudi/pull/5564#discussion_r873107281
##
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/DropHoodieTableCommand.scala:
##
@@ -88,42 +86,33 @@ extends HoodieLeafRunnabl
hudi-bot commented on PR #5564:
URL: https://github.com/apache/hudi/pull/5564#issuecomment-1126855588
## CI report:
* 461556f31268d1f912f7e8d7376064cac0e1bef9 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8606
hudi-bot commented on PR #5564:
URL: https://github.com/apache/hudi/pull/5564#issuecomment-1126855308
## CI report:
* 461556f31268d1f912f7e8d7376064cac0e1bef9 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8606
jinxing64 commented on code in PR #5534:
URL: https://github.com/apache/hudi/pull/5534#discussion_r873099587
##
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala:
##
@@ -81,13 +81,13 @@ class TestAlterTableDropPartition e
XuQianJin-Stars commented on code in PR #3391:
URL: https://github.com/apache/hudi/pull/3391#discussion_r873098250
##
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##
@@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {
XuQianJin-Stars commented on PR #5584:
URL: https://github.com/apache/hudi/pull/5584#issuecomment-1126840497
check --conf
'spark.sql.extensions=org.apache.spark.sql.hudi.HoodieSparkSessionExtension' in
scala and python
for`version-0.9.0`,`version-0.10.0`,`version-0.10.1`,`version-0.11.0`
hudi-bot commented on PR #5557:
URL: https://github.com/apache/hudi/pull/5557#issuecomment-1126836072
## CI report:
* 615b4501abe3b4b371021b3d7430f37a4d98db9c Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8658
hudi-bot commented on PR #5557:
URL: https://github.com/apache/hudi/pull/5557#issuecomment-1126825106
## CI report:
* 8d74f872b11843a5bd4ada875aa6edec21e82837 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8574
hudi-bot commented on PR #5557:
URL: https://github.com/apache/hudi/pull/5557#issuecomment-1126824815
## CI report:
* 8d74f872b11843a5bd4ada875aa6edec21e82837 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8574
hudi-bot commented on PR #5585:
URL: https://github.com/apache/hudi/pull/5585#issuecomment-1126805982
## CI report:
* 09ab05f52efd4fb9e18b90fec08a78c60930d018 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8657
hudi-bot commented on PR #5585:
URL: https://github.com/apache/hudi/pull/5585#issuecomment-1126796647
## CI report:
* 09ab05f52efd4fb9e18b90fec08a78c60930d018 Azure:
[PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8657
hudi-bot commented on PR #5585:
URL: https://github.com/apache/hudi/pull/5585#issuecomment-1126796176
## CI report:
* 09ab05f52efd4fb9e18b90fec08a78c60930d018 UNKNOWN
Bot commands
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the
[
https://issues.apache.org/jira/browse/HUDI-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HUDI-4099:
-
Labels: pull-request-available (was: )
> hive sync no partition table error
> ---
bettermouse opened a new pull request, #5585:
URL: https://github.com/apache/hudi/pull/5585
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before
opening a pull request.*
## What is the pur
[
https://issues.apache.org/jira/browse/HUDI-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bettermouse updated HUDI-4099:
--
Affects Version/s: 0.11.0
> hive sync no partition table error
> --
>
>
[
https://issues.apache.org/jira/browse/HUDI-4099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bettermouse updated HUDI-4099:
--
Fix Version/s: 0.11.1
> hive sync no partition table error
> --
>
>
bettermouse created HUDI-4099:
-
Summary: hive sync no partition table error
Key: HUDI-4099
URL: https://issues.apache.org/jira/browse/HUDI-4099
Project: Apache Hudi
Issue Type: Bug
Comp
xiarixiaoyao commented on code in PR #5572:
URL: https://github.com/apache/hudi/pull/5572#discussion_r873052659
##
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##
@@ -184,6 +191,11 @@ public static HoodieTableFileSystemView
createInMem
xiarixiaoyao commented on code in PR #5572:
URL: https://github.com/apache/hudi/pull/5572#discussion_r873052612
##
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##
@@ -165,6 +167,11 @@ private static HoodieTableFileSystemView
createInMe
liuzhuang2017 commented on PR #5584:
URL: https://github.com/apache/hudi/pull/5584#issuecomment-1126725716
@nsivabalan , Thanks your review，I will fix it right away.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cdmikechen commented on code in PR #3391:
URL: https://github.com/apache/hudi/pull/3391#discussion_r872982532
##
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##
@@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {
pu
cdmikechen commented on code in PR #3391:
URL: https://github.com/apache/hudi/pull/3391#discussion_r872981445
##
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##
@@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {
pu
cdmikechen commented on code in PR #3391:
URL: https://github.com/apache/hudi/pull/3391#discussion_r872981445
##
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##
@@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {
pu
nsivabalan merged PR #5464:
URL: https://github.com/apache/hudi/pull/5464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apach
sunke38 commented on issue #5550:
URL: https://github.com/apache/hudi/issues/5550#issuecomment-1126698070
Still same problem
spark-submit --jars
/home/kadm/module/hudi-0.11/packaging/hudi-spark-bundle/target/hudi-spark3.2-bundle_2.12-0.11.0.jar
--packages
org.apache.spark:spark-sql-
nsivabalan commented on PR #5042:
URL: https://github.com/apache/hudi/pull/5042#issuecomment-1126697629
closing out the patch for now. if you still encounter any issues, feel free
to reach out. or put up a new patch. thanks!
--
This is an automated message from the Apache Git Service.
To
nsivabalan closed pull request #5042: [HUDI-3802] Three bulk_insert files are
concurrently submitted and executed with a difference of 2s, the insert fails
occasionally.
URL: https://github.com/apache/hudi/pull/5042
--
This is an automated message from the Apache Git Service.
To respond to t
nsivabalan commented on code in PR #5341:
URL: https://github.com/apache/hudi/pull/5341#discussion_r872969982
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackHelper.java:
##
@@ -210,7 +210,7 @@ protected Map
generateHeader(Strin
This is an automated email from the ASF dual-hosted git repository.
sivabalan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new 6e16e719cd [HUDI-3980] Suport kerberos hbase in
nsivabalan commented on PR #5464:
URL: https://github.com/apache/hudi/pull/5464#issuecomment-1126696936
cool, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
nsivabalan commented on PR #5478:
URL: https://github.com/apache/hudi/pull/5478#issuecomment-1126696763
good find on the bug.
if my understanding is right, lastCompletedCommitTimestamp actually refers
to last CompletedCommit w/o any holes. i.e. before the last completed commit,
there sh
nsivabalan commented on issue #5488:
URL: https://github.com/apache/hudi/issues/5488#issuecomment-1126695845
@parisni : can you confirm the above suggested solution works for you. feel
free to close out the issue. we have a PR to fix the documentation.
https://github.com/apache/hudi/pull/55
nsivabalan commented on PR #5584:
URL: https://github.com/apache/hudi/pull/5584#issuecomment-1126695647
I guess the issue is only with spark3.2 where HoodieCatalog is mandatory.
So, I guess we don't need to add to 0.10.0 or any older versions. we added
spark3.2 support only with 0.11.
nsivabalan commented on PR #5573:
URL: https://github.com/apache/hudi/pull/5573#issuecomment-1126695162
high level question/thoughts.
is this about partition column value being null or partition path field
config value set to null?
also, can we ensure we look at all write paths? i.e. s
[
https://issues.apache.org/jira/browse/HUDI-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sivabalan narayanan reassigned HUDI-3890:
-
Assignee: (was: Raymond Xu)
> Fix apache rat check to detect all missing lice
[
https://issues.apache.org/jira/browse/HUDI-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537027#comment-17537027
]
sivabalan narayanan commented on HUDI-3890:
---
looks like we exclude the sql files
[
https://issues.apache.org/jira/browse/HUDI-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sivabalan narayanan closed HUDI-3890.
-
Resolution: Not A Problem
> Fix apache rat check to detect all missing license
> -
[
https://issues.apache.org/jira/browse/HUDI-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sivabalan narayanan reassigned HUDI-3890:
-
Assignee: Raymond Xu
> Fix apache rat check to detect all missing license
> -
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126693844
## CI report:
* b0064e9b4c46e6bb2398eddd3a5161c53ac62421 Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8655
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126684729
## CI report:
* 318304964fb808f2d0bffb0b854ab3ff9ad7f27b Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8654
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126684250
## CI report:
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096
liuzhuang2017 commented on PR #5584:
URL: https://github.com/apache/hudi/pull/5584#issuecomment-1126678348
@XuQianJin-Stars ,Ok，thanks your review. I will modify the other versions
immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
hudi-bot commented on PR #3599:
URL: https://github.com/apache/hudi/pull/3599#issuecomment-1126678111
## CI report:
* c3405300e9bc97445637c7251536ec0f0d6fbbd1 UNKNOWN
* e5003cfa74eb34255bceb50f1916c57c9c8812de Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2
XuQianJin-Stars commented on PR #5584:
URL: https://github.com/apache/hudi/pull/5584#issuecomment-1126677892
Also add these to `version-0.9.0`,`version-0.10.0`,`version-0.10.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
XuQianJin-Stars commented on code in PR #5572:
URL: https://github.com/apache/hudi/pull/5572#discussion_r872954968
##
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##
@@ -612,6 +623,21 @@ public void initializeBootstrapDirsIfNotExists() throw
XuQianJin-Stars commented on code in PR #5572:
URL: https://github.com/apache/hudi/pull/5572#discussion_r872955363
##
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java:
##
@@ -459,6 +459,9 @@ private Stream getCommitInstantsToArchive
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126676426
## CI report:
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096
hudi-bot commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126675687
## CI report:
* 81f59f6d17f2b0b0e26243d2ea49b1166af8a546 Azure:
[SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8096
liuzhuang2017 opened a new pull request, #5584:
URL: https://github.com/apache/hudi/pull/5584
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before
opening a pull request.*
## What is the p
hudi-bot commented on PR #3599:
URL: https://github.com/apache/hudi/pull/3599#issuecomment-1126670350
## CI report:
* e68d1192395b62f26864d8009ed01cf4f0c18806 Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8539
hudi-bot commented on PR #3599:
URL: https://github.com/apache/hudi/pull/3599#issuecomment-1126669865
## CI report:
* e68d1192395b62f26864d8009ed01cf4f0c18806 Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8539
hudi-bot commented on PR #3599:
URL: https://github.com/apache/hudi/pull/3599#issuecomment-1126669404
## CI report:
* e68d1192395b62f26864d8009ed01cf4f0c18806 Azure:
[FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8539
XuQianJin-Stars commented on PR #5320:
URL: https://github.com/apache/hudi/pull/5320#issuecomment-1126668229
hi @KnightChess rebase this pr？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
XuQianJin-Stars commented on code in PR #5534:
URL: https://github.com/apache/hudi/pull/5534#discussion_r872949175
##
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala:
##
@@ -81,13 +81,13 @@ class TestAlterTableDropParti
XuQianJin-Stars commented on PR #3391:
URL: https://github.com/apache/hudi/pull/3391#issuecomment-1126663449
hi @cdmikechen Overall looks good，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
XuQianJin-Stars commented on code in PR #3391:
URL: https://github.com/apache/hudi/pull/3391#discussion_r872945827
##
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncConfig.java:
##
@@ -160,7 +160,7 @@ public class HiveSyncConfig extends HoodieSyncConfig {
66 matches
Mail list logo
