[jira] [Created] (HUDI-5248) Support MetadataColumnStatsIndex for Spark record

2022-11-20 Thread Frank Wong (Jira)
Frank Wong created HUDI-5248: Summary: Support MetadataColumnStatsIndex for Spark record Key: HUDI-5248 URL: https://issues.apache.org/jira/browse/HUDI-5248 Project: Apache Hudi Issue Type: Epic

[GitHub] [hudi] wzx140 commented on a diff in pull request #7021: [Minor] fix multi deser avro payload

2022-11-20 Thread GitBox
wzx140 commented on code in PR #7021: URL: https://github.com/apache/hudi/pull/7021#discussion_r1027289037 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -215,18 +216,16 @@ private Option prepareRecord(HoodieRecord hoodieRecord

[GitHub] [hudi] wzx140 commented on pull request #7021: [Minor] fix multi deser avro payload

2022-11-20 Thread GitBox
wzx140 commented on PR #7021: URL: https://github.com/apache/hudi/pull/7021#issuecomment-1321130768 @alexeykudinkin You cached the isDelete and canProduceSentinel flag in HoodiePayload to support multiply call isDelete and shouldIgnore. We will call isDelete and then getData to write to fi

[GitHub] [hudi] hewanghw opened a new issue, #7252: [SUPPORT] Error to write hudi table into minio s3 bucket

2022-11-20 Thread GitBox
hewanghw opened a new issue, #7252: URL: https://github.com/apache/hudi/issues/7252 **Describe the problem you faced** I'm trying to write a hudi table into minio s3 bucket by flink SQL, but it fails. The hudi table is created, but only contains meta data diretory .hoodie t

[GitHub] [hudi] xushiyan commented on a diff in pull request #7251: [HUDI-5070] Move flaky cleaner tests to separate class

2022-11-20 Thread GitBox
xushiyan commented on code in PR #7251: URL: https://github.com/apache/hudi/pull/7251#discussion_r1027284723 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java: ## @@ -228,32 +212,63 @@ public void testInsertAndCleanFailedWritesByVersions() th

[GitHub] [hudi] xushiyan commented on a diff in pull request #7251: [HUDI-5070] Move flaky cleaner tests to separate class

2022-11-20 Thread GitBox
xushiyan commented on code in PR #7251: URL: https://github.com/apache/hudi/pull/7251#discussion_r1027284997 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/clean/TestCleanerInsertAndCleanByCommits.java: ## @@ -127,23 +126,21 @@ private void testInser

[GitHub] [hudi] xushiyan commented on a diff in pull request #7251: [HUDI-5070] Move flaky cleaner tests to separate class

2022-11-20 Thread GitBox
xushiyan commented on code in PR #7251: URL: https://github.com/apache/hudi/pull/7251#discussion_r1027284761 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java: ## @@ -228,32 +212,63 @@ public void testInsertAndCleanFailedWritesByVersions() th

[GitHub] [hudi] xushiyan commented on a diff in pull request #7251: [HUDI-5070] Move flaky cleaner tests to separate class

2022-11-20 Thread GitBox
xushiyan commented on code in PR #7251: URL: https://github.com/apache/hudi/pull/7251#discussion_r1027284723 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java: ## @@ -228,32 +212,63 @@ public void testInsertAndCleanFailedWritesByVersions() th

[GitHub] [hudi] xushiyan commented on a diff in pull request #7251: [HUDI-5070] Move flaky cleaner tests to separate class

2022-11-20 Thread GitBox
xushiyan commented on code in PR #7251: URL: https://github.com/apache/hudi/pull/7251#discussion_r1027284594 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java: ## @@ -211,14 +203,6 @@ public static Pair> insertFirstFailedBigBatchForCli r

[GitHub] [hudi] xushiyan commented on a diff in pull request #7251: [HUDI-5070] Move flaky cleaner tests to separate class

2022-11-20 Thread GitBox
xushiyan commented on code in PR #7251: URL: https://github.com/apache/hudi/pull/7251#discussion_r1027284687 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java: ## @@ -228,32 +212,63 @@ public void testInsertAndCleanFailedWritesByVersions() th

[GitHub] [hudi] xushiyan opened a new pull request, #7251: [HUDI-5070] Move flaky cleaner tests to separate class

2022-11-20 Thread GitBox
xushiyan opened a new pull request, #7251: URL: https://github.com/apache/hudi/pull/7251 ### Change Logs - Move flaky testInsertAndCleanByVersions to run with `SparkClientFunctionalTestHarness` to avoid hdfs which in CI env resulted in ``` Caused by: java.net.ConnectExcepti

[GitHub] [hudi] hudi-bot commented on pull request #7250: [HUDI-5247] Clean up java client tests

2022-11-20 Thread GitBox
hudi-bot commented on PR #7250: URL: https://github.com/apache/hudi/pull/7250#issuecomment-1321116002 ## CI report: * d23361a6a6df136cd73fdf91a3df553942a85d10 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1313

[GitHub] [hudi] hudi-bot commented on pull request #7250: [HUDI-5247] Clean up java client tests

2022-11-20 Thread GitBox
hudi-bot commented on PR #7250: URL: https://github.com/apache/hudi/pull/7250#issuecomment-1321081381 ## CI report: * d23361a6a6df136cd73fdf91a3df553942a85d10 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1313

[GitHub] [hudi] hudi-bot commented on pull request #7250: [HUDI-5247] Clean up java client tests

2022-11-20 Thread GitBox
hudi-bot commented on PR #7250: URL: https://github.com/apache/hudi/pull/7250#issuecomment-1321080177 ## CI report: * d23361a6a6df136cd73fdf91a3df553942a85d10 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #7248: [HUDI-5244] Fix bugs in schema evolution client with lost operation field and not found schema

2022-11-20 Thread GitBox
hudi-bot commented on PR #7248: URL: https://github.com/apache/hudi/pull/7248#issuecomment-1321078965 ## CI report: * 146e298463775642b8a487cd1a901dbdc93ebb90 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1313

[GitHub] [hudi] xushiyan commented on issue #7249: [SUPPORT] How to run cleaner table service on DFS source of DeltaStreamer ?

2022-11-20 Thread GitBox
xushiyan commented on issue #7249: URL: https://github.com/apache/hudi/issues/7249#issuecomment-1321076589 @bhasudha can you pls help clarifying this? documentation may need improvement accordingly -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [hudi] nsivabalan commented on a diff in pull request #6382: [HUDI-4612][RFC-59] RFC-59 Materials (RFC Proposal) Submission: "Multiple event_time Fields Latest Verification in a Single Table"

2022-11-20 Thread GitBox
nsivabalan commented on code in PR #6382: URL: https://github.com/apache/hudi/pull/6382#discussion_r1027249528 ## rfc/rfc-59/rfc-59.md: ## @@ -0,0 +1,285 @@ + +# RFC-[number]: [Title] + + + +## Proposers + +- Proposer1 @XinyaoTian +- Proposer2 @guixilan + +## Approvers + - Appro

[GitHub] [hudi] xushiyan commented on a diff in pull request #7250: [HUDI-5247] Clean up java client tests

2022-11-20 Thread GitBox
xushiyan commented on code in PR #7250: URL: https://github.com/apache/hudi/pull/7250#discussion_r1027251587 ## hudi-client/hudi-java-client/src/test/java/org/apache/hudi/testutils/HoodieJavaClientTestBase.java: ## @@ -1,48 +0,0 @@ -/* - * Licensed to the Apache Software Foundat

[GitHub] [hudi] xushiyan commented on a diff in pull request #7250: [HUDI-5247] Clean up java client tests

2022-11-20 Thread GitBox
xushiyan commented on code in PR #7250: URL: https://github.com/apache/hudi/pull/7250#discussion_r1027251538 ## hudi-client/hudi-java-client/src/test/java/org/apache/hudi/testutils/HoodieJavaClientTestHarness.java: ## @@ -187,50 +154,14 @@ protected void cleanupClients() {

[jira] [Updated] (HUDI-5247) Clean up java client tests

2022-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-5247: - Labels: pull-request-available (was: ) > Clean up java client tests > --

[GitHub] [hudi] xushiyan opened a new pull request, #7250: [HUDI-5247] Clean up java client tests

2022-11-20 Thread GitBox
xushiyan opened a new pull request, #7250: URL: https://github.com/apache/hudi/pull/7250 ### Change Logs Test utils clean up ### Impact NA ### Risk level None ### Documentation Update NA ### Contributor's checklist - [ ] Read thro

[jira] [Created] (HUDI-5247) Clean up java client tests

2022-11-20 Thread Raymond Xu (Jira)
Raymond Xu created HUDI-5247: Summary: Clean up java client tests Key: HUDI-5247 URL: https://issues.apache.org/jira/browse/HUDI-5247 Project: Apache Hudi Issue Type: Improvement Compon

[GitHub] [hudi] nsivabalan commented on a diff in pull request #6358: [HUDI-4588][HUDI-4472] Addressing schema handling issues in the write path

2022-11-20 Thread GitBox
nsivabalan commented on code in PR #6358: URL: https://github.com/apache/hudi/pull/6358#discussion_r1027248946 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -239,83 +289,65 @@ object HoodieSparkSqlWriter {

[GitHub] [hudi] nsivabalan commented on a diff in pull request #6358: [HUDI-4588][HUDI-4472] Addressing schema handling issues in the write path

2022-11-20 Thread GitBox
nsivabalan commented on code in PR #6358: URL: https://github.com/apache/hudi/pull/6358#discussion_r1027247902 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -347,6 +378,95 @@ object HoodieSparkSqlWriter { } }

[jira] [Created] (HUDI-5246) Improve validation for partition path

2022-11-20 Thread Raymond Xu (Jira)
Raymond Xu created HUDI-5246: Summary: Improve validation for partition path Key: HUDI-5246 URL: https://issues.apache.org/jira/browse/HUDI-5246 Project: Apache Hudi Issue Type: Improvement

[GitHub] [hudi] xushiyan closed issue #7247: [SUPPORT] Duplicates on upserts when record partition path begins with "/".

2022-11-20 Thread GitBox
xushiyan closed issue #7247: [SUPPORT] Duplicates on upserts when record partition path begins with "/". URL: https://github.com/apache/hudi/issues/7247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hudi] xushiyan commented on issue #7247: [SUPPORT] Duplicates on upserts when record partition path begins with "/".

2022-11-20 Thread GitBox
xushiyan commented on issue #7247: URL: https://github.com/apache/hudi/issues/7247#issuecomment-1321068591 partition path should always be relative and never start with `/`, which indicates absolute path in unix. I'll file a jira for improving the validation. -- This is an automated messa

[GitHub] [hudi] hudi-bot commented on pull request #7248: [HUDI-5244] Fix bugs in schema evolution client with lost operation field and not found schema

2022-11-20 Thread GitBox
hudi-bot commented on PR #7248: URL: https://github.com/apache/hudi/pull/7248#issuecomment-1321065054 ## CI report: * 035d1ca955024eefcad2989882f402940569f3a2 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1312

<    1   2