[GitHub] [hudi] boneanxs commented on pull request #7264: [HUDI-5253] HoodieMergeOnReadTableInputFormat could have duplicate records issue if it contains delta files while still splittable

2022-11-22 Thread GitBox
boneanxs commented on PR #7264: URL: https://github.com/apache/hudi/pull/7264#issuecomment-1324651032 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hudi] hudi-bot commented on pull request #7179: [HUDI-5193] Enhancing spark-ds write tests for some of the core user flows

2022-11-22 Thread GitBox
hudi-bot commented on PR #7179: URL: https://github.com/apache/hudi/pull/7179#issuecomment-1324628425 ## CI report: * d4e392ce4f62a1d37b275b404872ae00374f339b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320

[GitHub] [hudi] ROOBALJINDAL commented on issue #7064: [SUPPORT] Data ingestion from csv file i.e. CsvDFSSource is working for FilebasedSchemaProvider but not working if schema is provided with Schema

2022-11-22 Thread GitBox
ROOBALJINDAL commented on issue #7064: URL: https://github.com/apache/hudi/issues/7064#issuecomment-1324620970 @nsivabalan We updated the code as follows and built hudi and it worked fine for us now `return (originalProvider instanceof FilebasedSchemaProvider || originalProvider i

[GitHub] [hudi] hudi-bot commented on pull request #7280: [HUDI-5231] Fixed checkstyle for hudi-aws

2022-11-22 Thread GitBox
hudi-bot commented on PR #7280: URL: https://github.com/apache/hudi/pull/7280#issuecomment-1324571100 ## CI report: * 63bce8375b2ee0c75191bba51bb8e2cd06f147eb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320

[GitHub] [hudi] hudi-bot commented on pull request #6358: [HUDI-4588][HUDI-4472] Addressing schema handling issues in the write path

2022-11-22 Thread GitBox
hudi-bot commented on PR #6358: URL: https://github.com/apache/hudi/pull/6358#issuecomment-1324570412 ## CI report: * 288d166c49602a4593b1e97763a467811903737d UNKNOWN * 8a37a64610ed23294dc48570bbda72aeb0bb00ea UNKNOWN * 9db4d3db4cdac99deb1f7ea96de2c69ebf2e97c5 Azure: [SUCCES

[GitHub] [hudi] hudi-bot commented on pull request #6358: [HUDI-4588][HUDI-4472] Addressing schema handling issues in the write path

2022-11-22 Thread GitBox
hudi-bot commented on PR #6358: URL: https://github.com/apache/hudi/pull/6358#issuecomment-1324567447 ## CI report: * 288d166c49602a4593b1e97763a467811903737d UNKNOWN * 8a37a64610ed23294dc48570bbda72aeb0bb00ea UNKNOWN * 9db4d3db4cdac99deb1f7ea96de2c69ebf2e97c5 Azure: [SUCCES

[GitHub] [hudi] hudi-bot commented on pull request #7279: Test defaults

2022-11-22 Thread GitBox
hudi-bot commented on PR #7279: URL: https://github.com/apache/hudi/pull/7279#issuecomment-1324564961 ## CI report: * 2e35f759bd3cb80a9001d085317b774491139c63 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6358: [HUDI-4588][HUDI-4472] Addressing schema handling issues in the write path

2022-11-22 Thread GitBox
alexeykudinkin commented on code in PR #6358: URL: https://github.com/apache/hudi/pull/6358#discussion_r1030020375 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -347,6 +385,91 @@ object HoodieSparkSqlWriter { }

[jira] [Commented] (HUDI-3661) Flink async compaction is not thread safe when use watermark

2022-11-22 Thread zhihao song (Jira)
[ https://issues.apache.org/jira/browse/HUDI-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637566#comment-17637566 ] zhihao song commented on HUDI-3661: --- Thanks,but should "we should not let async compacti

[GitHub] [hudi] hudi-bot commented on pull request #7278: [HUDI-5231] Fixed checkstyle for hudi-hive-sync

2022-11-22 Thread GitBox
hudi-bot commented on PR #7278: URL: https://github.com/apache/hudi/pull/7278#issuecomment-1324524237 ## CI report: * 5d9344201ea3810b43bed708bf0d5cc75b86d480 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320

[GitHub] [hudi] hudi-bot commented on pull request #7189: [HUDI-5159]Add support write success file to finished partition in flink streaming write

2022-11-22 Thread GitBox
hudi-bot commented on PR #7189: URL: https://github.com/apache/hudi/pull/7189#issuecomment-1324524052 ## CI report: * b07f5635a3f2f087897ac6f5f8a892b365831414 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1300

[GitHub] [hudi] hudi-bot commented on pull request #7003: [minor] add more test for rfc46

2022-11-22 Thread GitBox
hudi-bot commented on PR #7003: URL: https://github.com/apache/hudi/pull/7003#issuecomment-1324523811 ## CI report: * 1c1d6e24197b60f243657a892b0591be2256538f UNKNOWN * 790c32c99000390fdba07f5428f4a5d4148a6a3c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #7189: [HUDI-5159]Add support write success file to finished partition in flink streaming write

2022-11-22 Thread GitBox
hudi-bot commented on PR #7189: URL: https://github.com/apache/hudi/pull/7189#issuecomment-1324520066 ## CI report: * b07f5635a3f2f087897ac6f5f8a892b365831414 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1300

[GitHub] [hudi] hudi-bot commented on pull request #7003: [minor] add more test for rfc46

2022-11-22 Thread GitBox
hudi-bot commented on PR #7003: URL: https://github.com/apache/hudi/pull/7003#issuecomment-1324519681 ## CI report: * 1c1d6e24197b60f243657a892b0591be2256538f UNKNOWN * 790c32c99000390fdba07f5428f4a5d4148a6a3c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] danny0405 commented on pull request #5830: [HUDI-3981][WIP][RFC-33] Flink engine support for comprehensive schema evolution

2022-11-22 Thread GitBox
danny0405 commented on PR #5830: URL: https://github.com/apache/hudi/pull/5830#issuecomment-1324519494 > @danny0405 It is hard to maintain this PR. Despite the fact that this feature is related only to flink, changes are needed in common part. For example, [#5830 (comment)](https://github.

[GitHub] [hudi] KevinyhZou commented on pull request #7189: [HUDI-5159]Add support write success file to finished partition in flink streaming write

2022-11-22 Thread GitBox
KevinyhZou commented on PR #7189: URL: https://github.com/apache/hudi/pull/7189#issuecomment-1324518234 > Thanks for the contribution @KevinyhZou , somehow i feel the PR is valuable and we can generalize it to all the writer cases: append mode, upsert, and we can move the partition check do

[GitHub] [hudi] hudi-bot commented on pull request #7241: [HUDI-5241] Optimize HoodieDefaultTimeline API

2022-11-22 Thread GitBox
hudi-bot commented on PR #7241: URL: https://github.com/apache/hudi/pull/7241#issuecomment-1324516850 ## CI report: * 3045f14ac99e049be4b40d14906b8aef0f3ed34d UNKNOWN * 0d568743e2a1266f1797672a6140e2d6b6083c9e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #7277: [HUDI-5231] Fixed checkstyle for hudi-sync-common

2022-11-22 Thread GitBox
hudi-bot commented on PR #7277: URL: https://github.com/apache/hudi/pull/7277#issuecomment-1324516925 ## CI report: * 7e86086e1aa47d78b0f474efcfa15fb2e2e19606 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1319

[GitHub] [hudi] YannByron commented on pull request #7241: [HUDI-5241] Optimize HoodieDefaultTimeline API

2022-11-22 Thread GitBox
YannByron commented on PR #7241: URL: https://github.com/apache/hudi/pull/7241#issuecomment-1324509826 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Updated] (HUDI-5252) ClusteringCommitSink supports to rollback clustering

2022-11-22 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/HUDI-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen updated HUDI-5252: - Fix Version/s: 0.12.2 > ClusteringCommitSink supports to rollback clustering > ---

[jira] [Commented] (HUDI-5252) ClusteringCommitSink supports to rollback clustering

2022-11-22 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/HUDI-5252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637555#comment-17637555 ] Danny Chen commented on HUDI-5252: -- Fixed via master branch: 3109d890f13b1b29e5796a9f34ab

[hudi] branch master updated: [HUDI-5252] ClusteringCommitSink supports to rollback clustering (#7263)

2022-11-22 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 3109d890f1 [HUDI-5252] ClusteringCommitSink sup

[GitHub] [hudi] danny0405 merged pull request #7263: [HUDI-5252] ClusteringCommitSink supports to rollback clustering

2022-11-22 Thread GitBox
danny0405 merged PR #7263: URL: https://github.com/apache/hudi/pull/7263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache

[GitHub] [hudi] danny0405 commented on pull request #7231: [HUDI-5234] streaming read skip clustering

2022-11-22 Thread GitBox
danny0405 commented on PR #7231: URL: https://github.com/apache/hudi/pull/7231#issuecomment-1324506140 Thanks for the contribution, I have reviewed and applied a patch: [5234.zip](https://github.com/apache/hudi/files/10072655/5234.zip) And the following tests are failing: `ITTest

[GitHub] [hudi] hudi-bot commented on pull request #6725: [HUDI-4881] Push down filters if possible when syncing partitions to Hive

2022-11-22 Thread GitBox
hudi-bot commented on PR #6725: URL: https://github.com/apache/hudi/pull/6725#issuecomment-1324478776 ## CI report: * 86c7cb9e86117943f5af62bb8375eaa83dedf094 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1317

[GitHub] [hudi] hudi-bot commented on pull request #6133: [HUDI-1575] Early Conflict Detection For Multi-writer

2022-11-22 Thread GitBox
hudi-bot commented on PR #6133: URL: https://github.com/apache/hudi/pull/6133#issuecomment-1324478500 ## CI report: * dbe3db845908d261baa5a1aa71d19e0db55816de UNKNOWN * 678cce4a9748cb54a90a559384a0cb0443082535 UNKNOWN * 6fc5bf1ce7921bf25acc3659565457264d8b9dc2 UNKNOWN * 0b

[GitHub] [hudi] hudi-bot commented on pull request #6725: [HUDI-4881] Push down filters if possible when syncing partitions to Hive

2022-11-22 Thread GitBox
hudi-bot commented on PR #6725: URL: https://github.com/apache/hudi/pull/6725#issuecomment-1324475706 ## CI report: * 86c7cb9e86117943f5af62bb8375eaa83dedf094 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1317

[GitHub] [hudi] hudi-bot commented on pull request #6133: [HUDI-1575] Early Conflict Detection For Multi-writer

2022-11-22 Thread GitBox
hudi-bot commented on PR #6133: URL: https://github.com/apache/hudi/pull/6133#issuecomment-1324475418 ## CI report: * dbe3db845908d261baa5a1aa71d19e0db55816de UNKNOWN * 678cce4a9748cb54a90a559384a0cb0443082535 UNKNOWN * 6fc5bf1ce7921bf25acc3659565457264d8b9dc2 UNKNOWN * 0b

[GitHub] [hudi] leesf commented on a diff in pull request #7035: [HUDI-5075] Adding support to rollback residual clustering after disabling clustering

2022-11-22 Thread GitBox
leesf commented on code in PR #7035: URL: https://github.com/apache/hudi/pull/7035#discussion_r1029976979 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java: ## @@ -310,6 +310,14 @@ public class HoodieClusteringConfig extends Hoodi

[GitHub] [hudi] hudi-bot commented on pull request #7270: [HUDI-5258] Fix checkstyle issues in hudi-common

2022-11-22 Thread GitBox
hudi-bot commented on PR #7270: URL: https://github.com/apache/hudi/pull/7270#issuecomment-1324472632 ## CI report: * f86915990d2b31e6881bf6454f4cea32ce9bc6a4 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1319

[GitHub] [hudi] hudi-bot commented on pull request #7276: [HUDI-5231] Fixed checkstyle for hudi-hadoop-mr

2022-11-22 Thread GitBox
hudi-bot commented on PR #7276: URL: https://github.com/apache/hudi/pull/7276#issuecomment-1324472662 ## CI report: * 036fa93b716a5c9466d85e26b001d15abb604acf Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1319

[GitHub] [hudi] hudi-bot commented on pull request #7264: [HUDI-5253] HoodieMergeOnReadTableInputFormat could have duplicate records issue if it contains delta files while still splittable

2022-11-22 Thread GitBox
hudi-bot commented on PR #7264: URL: https://github.com/apache/hudi/pull/7264#issuecomment-1324472586 ## CI report: * 1b07f271c16acd022d7853df55bb0a838b8b30de Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1317

[GitHub] [hudi] SteNicholas commented on pull request #7263: [HUDI-5252] ClusteringCommitSink supports to rollback clustering

2022-11-22 Thread GitBox
SteNicholas commented on PR #7263: URL: https://github.com/apache/hudi/pull/7263#issuecomment-1324469685 @danny0405, I have already addressed above comments. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hudi] dwshmilyss commented on issue #7275: [SUPPORT] java.lang.NoSuchMethodError: org.apache.hudi.common.table.TableSchemaResolver.getTableAvroSchema(Z)Lorg/apache/avro/Schema;

2022-11-22 Thread GitBox
dwshmilyss commented on issue #7275: URL: https://github.com/apache/hudi/issues/7275#issuecomment-1324464886 @xushiyan The cause of the problem is jar conflicts. It can't put hadoop-mr-bundles in the jars directory of spark, which causes conflicts,I think some classes are colliding in hadoo

[GitHub] [hudi] danny0405 commented on pull request #7159: [HUDI-5173]Skip if there is only one file in clusteringGroup

2022-11-22 Thread GitBox
danny0405 commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1324463330 There are many tests fails with clustering, should fix it though ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hudi] scxwhite commented on issue #7254: [SUPPORT] Incremental query performance

2022-11-22 Thread GitBox
scxwhite commented on issue #7254: URL: https://github.com/apache/hudi/issues/7254#issuecomment-1324453507 When most partitions and files in your table are updated, file filtering will degenerate. Incremental query and full filtering are almost identical. -- This is an automated message f

[GitHub] [hudi] scxwhite commented on issue #7254: [SUPPORT] Incremental query performance

2022-11-22 Thread GitBox
scxwhite commented on issue #7254: URL: https://github.com/apache/hudi/issues/7254#issuecomment-1324452549 Because the table in Cow format will copy the previous data file every time the data is updated. Although you use incremental queries, it will still read the latest data file and filte

[GitHub] [hudi] boneanxs commented on pull request #7264: [HUDI-5253] HoodieMergeOnReadTableInputFormat could have duplicate records issue if it contains delta files while still splittable

2022-11-22 Thread GitBox
boneanxs commented on PR #7264: URL: https://github.com/apache/hudi/pull/7264#issuecomment-1324450660 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hudi] hudi-bot commented on pull request #7179: [HUDI-5193] Enhancing spark-ds write tests for some of the core user flows

2022-11-22 Thread GitBox
hudi-bot commented on PR #7179: URL: https://github.com/apache/hudi/pull/7179#issuecomment-1324434974 ## CI report: * 0fa117da43d2ca18f325f688c8742da6a977869e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1315

[GitHub] [hudi] hudi-bot commented on pull request #7179: [HUDI-5193] Enhancing spark-ds write tests for some of the core user flows

2022-11-22 Thread GitBox
hudi-bot commented on PR #7179: URL: https://github.com/apache/hudi/pull/7179#issuecomment-1324429894 ## CI report: * 0fa117da43d2ca18f325f688c8742da6a977869e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1315

[GitHub] [hudi] hudi-bot commented on pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
hudi-bot commented on PR #7243: URL: https://github.com/apache/hudi/pull/7243#issuecomment-1324426173 ## CI report: * 446a74c8b44d71e6145871f5bbdc6ce0174eec56 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1319

[hudi] branch master updated: [MINOR] Use direct marker for spark engine when timeline server is disabled (#7272)

2022-11-22 Thread leesf
This is an automated email from the ASF dual-hosted git repository. leesf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 91e0db57b9 [MINOR] Use direct marker for spark engi

[GitHub] [hudi] leesf merged pull request #7272: [MINOR] Use direct marker for spark when timeline server is disabled

2022-11-22 Thread GitBox
leesf merged PR #7272: URL: https://github.com/apache/hudi/pull/7272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
nsivabalan commented on PR #7243: URL: https://github.com/apache/hudi/pull/7243#issuecomment-1324402848 can you fix the PR desc w/ right config key -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hudi] hudi-bot commented on pull request #7280: [HUDI-5231] Fixed checkstyle for hudi-aws

2022-11-22 Thread GitBox
hudi-bot commented on PR #7280: URL: https://github.com/apache/hudi/pull/7280#issuecomment-1324384471 ## CI report: * 63bce8375b2ee0c75191bba51bb8e2cd06f147eb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320

[GitHub] [hudi] hudi-bot commented on pull request #7279: Test defaults

2022-11-22 Thread GitBox
hudi-bot commented on PR #7279: URL: https://github.com/apache/hudi/pull/7279#issuecomment-1324384436 ## CI report: * 2e35f759bd3cb80a9001d085317b774491139c63 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320

[GitHub] [hudi] hudi-bot commented on pull request #7278: [HUDI-5231] Fixed checkstyle for hudi-hive-sync

2022-11-22 Thread GitBox
hudi-bot commented on PR #7278: URL: https://github.com/apache/hudi/pull/7278#issuecomment-1324384402 ## CI report: * 5d9344201ea3810b43bed708bf0d5cc75b86d480 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1320

[GitHub] [hudi] hudi-bot commented on pull request #7280: [HUDI-5231] Fixed checkstyle for hudi-aws

2022-11-22 Thread GitBox
hudi-bot commented on PR #7280: URL: https://github.com/apache/hudi/pull/7280#issuecomment-1324380509 ## CI report: * 63bce8375b2ee0c75191bba51bb8e2cd06f147eb UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #7279: Test defaults

2022-11-22 Thread GitBox
hudi-bot commented on PR #7279: URL: https://github.com/apache/hudi/pull/7279#issuecomment-1324380482 ## CI report: * 2e35f759bd3cb80a9001d085317b774491139c63 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #7278: [HUDI-5231] Fixed checkstyle for hudi-hive-sync

2022-11-22 Thread GitBox
hudi-bot commented on PR #7278: URL: https://github.com/apache/hudi/pull/7278#issuecomment-1324380464 ## CI report: * 5d9344201ea3810b43bed708bf0d5cc75b86d480 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #7230: [HUDI-5269] Enhancing spark-sql write tests for some of the core user flows

2022-11-22 Thread GitBox
hudi-bot commented on PR #7230: URL: https://github.com/apache/hudi/pull/7230#issuecomment-1324376907 ## CI report: * 36b9c8520cb7859701aedfdd28cd94622a2314b0 UNKNOWN * ed4aa7890fa0528ab9ea0b82a91c98e0ffa3d058 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] jonvex opened a new pull request, #7280: [HUDI-5231] Fixed checkstyle for hudi-aws

2022-11-22 Thread GitBox
jonvex opened a new pull request, #7280: URL: https://github.com/apache/hudi/pull/7280 ### Change Logs Fixed checkstyle for hudi-aws ### Impact Less warnings ### Risk level (write none, low medium or high below) none ### Documentation Update N/

[GitHub] [hudi] the-other-tim-brown opened a new pull request, #7279: Test defaults

2022-11-22 Thread GitBox
the-other-tim-brown opened a new pull request, #7279: URL: https://github.com/apache/hudi/pull/7279 ### Change Logs _Describe context and summary for this change. Highlight if any code was copied._ ### Impact _Describe any public API or user-facing feature change or any

[GitHub] [hudi] jonvex opened a new pull request, #7278: [HUDI-5231] Fixed checkstyle for hudi-hive-sync

2022-11-22 Thread GitBox
jonvex opened a new pull request, #7278: URL: https://github.com/apache/hudi/pull/7278 ### Change Logs Fixed checkstyle for hudi-hive-sync ### Impact Less warnings ### Risk level (write none, low medium or high below) none ### Documentation Update

[GitHub] [hudi] hudi-bot commented on pull request #7277: [HUDI-5231] fixed checkstyle for hudi-sync-common

2022-11-22 Thread GitBox
hudi-bot commented on PR #7277: URL: https://github.com/apache/hudi/pull/7277#issuecomment-1324337102 ## CI report: * 7e86086e1aa47d78b0f474efcfa15fb2e2e19606 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1319

[GitHub] [hudi] hudi-bot commented on pull request #7277: [HUDI-5231] fixed checkstyle for hudi-sync-common

2022-11-22 Thread GitBox
hudi-bot commented on PR #7277: URL: https://github.com/apache/hudi/pull/7277#issuecomment-1324333142 ## CI report: * 7e86086e1aa47d78b0f474efcfa15fb2e2e19606 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #7270: [HUDI-5258] Fix checkstyle issues in hudi-common

2022-11-22 Thread GitBox
hudi-bot commented on PR #7270: URL: https://github.com/apache/hudi/pull/7270#issuecomment-1324333057 ## CI report: * 6287809ec0db88b6585c56917af5b6bae6d81872 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1316

[GitHub] [hudi] hudi-bot commented on pull request #7276: [HUDI-5231] fixed checkstyle for hudi-hadoop-mr

2022-11-22 Thread GitBox
hudi-bot commented on PR #7276: URL: https://github.com/apache/hudi/pull/7276#issuecomment-1324333098 ## CI report: * 036fa93b716a5c9466d85e26b001d15abb604acf Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1319

[GitHub] [hudi] hudi-bot commented on pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
hudi-bot commented on PR #7243: URL: https://github.com/apache/hudi/pull/7243#issuecomment-1324332993 ## CI report: * 59308d4021ddd1d6a28cd258ad04c00545f4264f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=131

[GitHub] [hudi] jonvex opened a new pull request, #7277: fixed all warnings

2022-11-22 Thread GitBox
jonvex opened a new pull request, #7277: URL: https://github.com/apache/hudi/pull/7277 ### Change Logs Fix all checkstyle in hudi-sync-common ### Impact Less warnings ### Risk level (write none, low medium or high below) none ### Documentation Update

[GitHub] [hudi] hudi-bot commented on pull request #7276: [HUDI-5231] fixed checkstyle for hudi-hadoop-mr

2022-11-22 Thread GitBox
hudi-bot commented on PR #7276: URL: https://github.com/apache/hudi/pull/7276#issuecomment-1324328730 ## CI report: * 036fa93b716a5c9466d85e26b001d15abb604acf UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #7270: [HUDI-5258] Fix checkstyle issues in hudi-common

2022-11-22 Thread GitBox
hudi-bot commented on PR #7270: URL: https://github.com/apache/hudi/pull/7270#issuecomment-1324328684 ## CI report: * 6287809ec0db88b6585c56917af5b6bae6d81872 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1316

[GitHub] [hudi] hudi-bot commented on pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
hudi-bot commented on PR #7243: URL: https://github.com/apache/hudi/pull/7243#issuecomment-1324328593 ## CI report: * 79e84bb1ae7284d2632ef6d2077128d5fab34a7d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=131

[jira] [Updated] (HUDI-5231) Address checkstyle warnings while building hudi

2022-11-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-5231: - Labels: pull-request-available (was: ) > Address checkstyle warnings while building hudi > --

[GitHub] [hudi] jonvex opened a new pull request, #7276: [HUDI-5231] fixed checkstyle for hudi-hadoop-mr

2022-11-22 Thread GitBox
jonvex opened a new pull request, #7276: URL: https://github.com/apache/hudi/pull/7276 ### Change Logs Fixed checkstyle for hudi-hadoop-mr ### Impact Makes our project look more professional ### Risk level (write none, low medium or high below) none #

[hudi] branch master updated: [MINOR] Fix typos in HoodieTimelineArchiver (#7268)

2022-11-22 Thread yihua
This is an automated email from the ASF dual-hosted git repository. yihua pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new dd1a2f544e [MINOR] Fix typos in HoodieTimelineArchi

[GitHub] [hudi] yihua merged pull request #7268: [MINOR] Fix typos in HoodieTimelineArchiver

2022-11-22 Thread GitBox
yihua merged PR #7268: URL: https://github.com/apache/hudi/pull/7268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #7272: [MINOR] Use direct marker for spark when timeline server is disabled

2022-11-22 Thread GitBox
yihua commented on code in PR #7272: URL: https://github.com/apache/hudi/pull/7272#discussion_r1029845170 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java: ## @@ -2794,7 +2794,11 @@ public HoodieWriteConfig build() { private Stri

[GitHub] [hudi] yihua commented on a diff in pull request #7270: [HUDI-5258] Fix checkstyle issues in hudi-common

2022-11-22 Thread GitBox
yihua commented on code in PR #7270: URL: https://github.com/apache/hudi/pull/7270#discussion_r1029841609 ## hudi-common/src/main/java/org/apache/hudi/common/engine/LocalTaskContextSupplier.java: ## @@ -22,6 +22,9 @@ import java.util.function.Supplier; +/** + * Supplier of

[GitHub] [hudi] hudi-bot commented on pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
hudi-bot commented on PR #7243: URL: https://github.com/apache/hudi/pull/7243#issuecomment-1324251319 ## CI report: * 79e84bb1ae7284d2632ef6d2077128d5fab34a7d Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=131

[GitHub] [hudi] hudi-bot commented on pull request #7230: [HUDI-5269] Enhancing spark-sql write tests for some of the core user flows

2022-11-22 Thread GitBox
hudi-bot commented on PR #7230: URL: https://github.com/apache/hudi/pull/7230#issuecomment-1324251221 ## CI report: * 36b9c8520cb7859701aedfdd28cd94622a2314b0 UNKNOWN * 0d789c5578677f9d4cec1d957dd135891b758d70 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
hudi-bot commented on PR #7243: URL: https://github.com/apache/hudi/pull/7243#issuecomment-1324246008 ## CI report: * afb5f8f483ee62d25d07ff489fea043203bda0f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1311

[GitHub] [hudi] hudi-bot commented on pull request #7230: [HUDI-5269] Enhancing spark-sql write tests for some of the core user flows

2022-11-22 Thread GitBox
hudi-bot commented on PR #7230: URL: https://github.com/apache/hudi/pull/7230#issuecomment-1324245915 ## CI report: * 36b9c8520cb7859701aedfdd28cd94622a2314b0 UNKNOWN * 0d789c5578677f9d4cec1d957dd135891b758d70 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
hudi-bot commented on PR #7243: URL: https://github.com/apache/hudi/pull/7243#issuecomment-1324240697 ## CI report: * afb5f8f483ee62d25d07ff489fea043203bda0f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1311

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
nsivabalan commented on code in PR #7243: URL: https://github.com/apache/hudi/pull/7243#discussion_r1029801201 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java: ## @@ -243,9 +243,20 @@ public boolean commitStats(String instantTime

[GitHub] [hudi] nsivabalan commented on a diff in pull request #7230: [HUDI-5269] Enhancing spark-sql write tests for some of the core user flows

2022-11-22 Thread GitBox
nsivabalan commented on code in PR #7230: URL: https://github.com/apache/hudi/pull/7230#discussion_r1029797977 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkSql.scala: ## @@ -0,0 +1,442 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Updated] (HUDI-5205) Support flink 1.16

2022-11-22 Thread Rahil Chertara (Jira)
[ https://issues.apache.org/jira/browse/HUDI-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahil Chertara updated HUDI-5205: - Fix Version/s: 0.13.0 (was: 1.0.0) > Support flink 1.16 > -

[GitHub] [hudi] jklim96 commented on issue #7254: [SUPPORT] Incremental query performance

2022-11-22 Thread GitBox
jklim96 commented on issue #7254: URL: https://github.com/apache/hudi/issues/7254#issuecomment-1324196083 We are currently using CoW as some parts of our infrastructure on AWS currently don't allow us to use MoR due to some outdated dependencies. Would you be able to give some additio

[jira] [Commented] (HUDI-5231) Address checkstyle warnings while building hudi

2022-11-22 Thread Jonathan Vexler (Jira)
[ https://issues.apache.org/jira/browse/HUDI-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637444#comment-17637444 ] Jonathan Vexler commented on HUDI-5231: --- Ethan claims to have a fix for hudi-common

[GitHub] [hudi] hudi-bot commented on pull request #7243: [HUDI-5242] Do not fail Meta sync in Deltastreamer when inline table service fails

2022-11-22 Thread GitBox
hudi-bot commented on PR #7243: URL: https://github.com/apache/hudi/pull/7243#issuecomment-1324182057 ## CI report: * afb5f8f483ee62d25d07ff489fea043203bda0f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1311

[GitHub] [hudi] xushiyan closed issue #6808: [SUPPORT] Cannot sync to spark embedded derby hive meta store (the default one)

2022-11-22 Thread GitBox
xushiyan closed issue #6808: [SUPPORT] Cannot sync to spark embedded derby hive meta store (the default one) URL: https://github.com/apache/hudi/issues/6808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hudi] xushiyan commented on issue #6808: [SUPPORT] Cannot sync to spark embedded derby hive meta store (the default one)

2022-11-22 Thread GitBox
xushiyan commented on issue #6808: URL: https://github.com/apache/hudi/issues/6808#issuecomment-1324172279 @schlichtanders the derby url is not following the pattern specified here https://db.apache.org/derby/docs/10.14/ref/rrefjdbc10889.html if you use named attribute like databaseName=xxx

[GitHub] [hudi] hudi-bot commented on pull request #7231: [HUDI-5234] streaming read skip clustering

2022-11-22 Thread GitBox
hudi-bot commented on PR #7231: URL: https://github.com/apache/hudi/pull/7231#issuecomment-1324165223 ## CI report: * 6fcd5d63a78b6b8a14fb1081f9821bf6a156312a Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1318

[GitHub] [hudi] hudi-bot commented on pull request #6133: [HUDI-1575] Early Conflict Detection For Multi-writer

2022-11-22 Thread GitBox
hudi-bot commented on PR #6133: URL: https://github.com/apache/hudi/pull/6133#issuecomment-1324163703 ## CI report: * dbe3db845908d261baa5a1aa71d19e0db55816de UNKNOWN * 678cce4a9748cb54a90a559384a0cb0443082535 UNKNOWN * 6fc5bf1ce7921bf25acc3659565457264d8b9dc2 UNKNOWN * 0b

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6725: [HUDI-4881] Push down filters if possible when syncing partitions to Hive

2022-11-22 Thread GitBox
alexeykudinkin commented on code in PR #6725: URL: https://github.com/apache/hudi/pull/6725#discussion_r1029747120 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/PartitionFilterGenerator.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7080: [HUDI-4142][RFC-64] New APIs to facilitate faster Query Engine integrations

2022-11-22 Thread GitBox
alexeykudinkin commented on code in PR #7080: URL: https://github.com/apache/hudi/pull/7080#discussion_r1029741529 ## rfc/rfc-64/rfc-64.md: ## @@ -0,0 +1,509 @@ + + +# RFC-64: New Hudi Table Spec API for Query Integrations + +## Proposers + +- @codope +- @alexeykudinkin + +## Ap

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7003: [minor] add more test for rfc46

2022-11-22 Thread GitBox
alexeykudinkin commented on code in PR #7003: URL: https://github.com/apache/hudi/pull/7003#discussion_r1029735768 ## hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/HoodieInternalRowUtils.scala: ## @@ -72,8 +72,46 @@ object HoodieInternalRowUtils {

[GitHub] [hudi] Gatsby-Lee commented on issue #3008: [SUPPORT] Hive Sync issues on deletes and non partitioned table

2022-11-22 Thread GitBox
Gatsby-Lee commented on issue #3008: URL: https://github.com/apache/hudi/issues/3008#issuecomment-1324103144 @pranotishanbhag why do you have to use "GlobalDeleteKeyGenerator" to delete records? For me, I use the same key for INSERT/UPDATE/DELETE for a table. -- This is an automated

[GitHub] [hudi] alexeykudinkin commented on pull request #6358: [HUDI-4588][HUDI-4472] Addressing schema handling issues in the write path

2022-11-22 Thread GitBox
alexeykudinkin commented on PR #6358: URL: https://github.com/apache/hudi/pull/6358#issuecomment-1324096009 @xushiyan i rebased on the latest master yday, and it was still failing (other tests started to fail). At this point i think we should offboard whole of `TestCleaner` off HDFS -- T

[GitHub] [hudi] hudi-bot commented on pull request #7230: [HUDI-5269] Enhancing spark-sql write tests for some of the core user flows

2022-11-22 Thread GitBox
hudi-bot commented on PR #7230: URL: https://github.com/apache/hudi/pull/7230#issuecomment-1324083340 ## CI report: * 36b9c8520cb7859701aedfdd28cd94622a2314b0 UNKNOWN * 0d789c5578677f9d4cec1d957dd135891b758d70 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #7159: [HUDI-5173]Skip if there is only one file in clusteringGroup

2022-11-22 Thread GitBox
hudi-bot commented on PR #7159: URL: https://github.com/apache/hudi/pull/7159#issuecomment-1324083037 ## CI report: * 15ecd91180d32c7fa1905c11408f4bc23347e682 UNKNOWN * e917f20f1438d8eb27884742a8fad7ec7f3d9560 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] xushiyan commented on issue #7154: [SUPPORT] Hudi 0.12.2 release (Unknown versionCode:5)

2022-11-22 Thread GitBox
xushiyan commented on issue #7154: URL: https://github.com/apache/hudi/issues/7154#issuecomment-1324073756 closing as downgrade 5 -> 4 was verified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hudi] xushiyan closed issue #7154: [SUPPORT] Hudi 0.12.2 release (Unknown versionCode:5)

2022-11-22 Thread GitBox
xushiyan closed issue #7154: [SUPPORT] Hudi 0.12.2 release (Unknown versionCode:5) URL: https://github.com/apache/hudi/issues/7154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [hudi] xushiyan commented on issue #7271: [SUPPORT] org.apache.hudi.exception.HoodieException: Unknown versionCode:3

2022-11-22 Thread GitBox
xushiyan commented on issue #7271: URL: https://github.com/apache/hudi/issues/7271#issuecomment-1324071802 > to downgrade or upgrade table version through cli. But how can I do that on the glue ? Downgrade/upgrade is via hudi cli which is documented here https://hudi.apache.org/docs/

[GitHub] [hudi] xushiyan closed issue #7271: [SUPPORT] org.apache.hudi.exception.HoodieException: Unknown versionCode:3

2022-11-22 Thread GitBox
xushiyan closed issue #7271: [SUPPORT] org.apache.hudi.exception.HoodieException: Unknown versionCode:3 URL: https://github.com/apache/hudi/issues/7271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hudi] kazdy commented on issue #7274: [SUPPORT] How to create a hudi table without suffix in snapshot read mode using SparkSQL

2022-11-22 Thread GitBox
kazdy commented on issue #7274: URL: https://github.com/apache/hudi/issues/7274#issuecomment-1324016597 Hi, Table (base one without suffix) must exist before _ro or _rt table is created with sql DDL. This works if I create first table without suffix and not use `hoodie.query

[GitHub] [hudi] hudi-bot commented on pull request #6725: [HUDI-4881] Push down filters if possible when syncing partitions to Hive

2022-11-22 Thread GitBox
hudi-bot commented on PR #6725: URL: https://github.com/apache/hudi/pull/6725#issuecomment-1323990765 ## CI report: * 86c7cb9e86117943f5af62bb8375eaa83dedf094 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1317

[hudi] branch master updated (8d2ad715a5 -> ceb94b47d0)

2022-11-22 Thread codope
This is an automated email from the ASF dual-hosted git repository. codope pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git from 8d2ad715a5 [HUDI-712] Improve exporter file listing and copy perf (#7267) add ceb94b47d0 [HUDI-5157] Support dropp

[GitHub] [hudi] codope merged pull request #7132: [HUDI-5157] Adding capability to remove all meta fields from source hudi table with Hudi incr source

2022-11-22 Thread GitBox
codope merged PR #7132: URL: https://github.com/apache/hudi/pull/7132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.or

[jira] [Updated] (HUDI-5260) Insert into sql with strict insert mode and no preCombineField should not overwrite existing records

2022-11-22 Thread kazdy (Jira)
[ https://issues.apache.org/jira/browse/HUDI-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kazdy updated HUDI-5260: Status: In Progress (was: Open) > Insert into sql with strict insert mode and no preCombineField should not > over

  1   2   3   >