[GitHub] [hudi] hudi-bot commented on pull request #8429: [HUDI-5975] Release 0.12.3 rc2 prep apr11

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8429: URL: https://github.com/apache/hudi/pull/8429#issuecomment-1504743600 ## CI report: * acd347c5e6cd019ee98b7f1fa435b95153e71238 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1627

[GitHub] [hudi] LiJie20190102 commented on pull request #8424: [HUDI-6065] Fix deltastreamer shutdown when post write termination strategy enabled

2023-04-11 Thread via GitHub
LiJie20190102 commented on PR #8424: URL: https://github.com/apache/hudi/pull/8424#issuecomment-1504737582 > @LiJie20190102 Looks you have mentioned the wrong JIRA number. [HUDI-6057](https://issues.apache.org/jira/browse/HUDI-6057) is related to Flink Upgrade. Sorry, I have modified

[GitHub] [hudi] LiJie20190102 commented on pull request #8424: [HUDI-6065] Fix deltastreamer shutdown when post write termination strategy enabled

2023-04-11 Thread via GitHub
LiJie20190102 commented on PR #8424: URL: https://github.com/apache/hudi/pull/8424#issuecomment-1504737203 > @LiJie20190102 Have you checked if this fix solves your problem? #8173 #8173 can indeed solve the shutdown problem, but if there are still pending compaction/clustering instant

[GitHub] [hudi] hudi-bot commented on pull request #8429: [HUDI-5975] Release 0.12.3 rc2 prep apr11

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8429: URL: https://github.com/apache/hudi/pull/8429#issuecomment-1504733798 ## CI report: * acd347c5e6cd019ee98b7f1fa435b95153e71238 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1627

[GitHub] [hudi] hudi-bot commented on pull request #8429: [HUDI-5975] Release 0.12.3 rc2 prep apr11

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8429: URL: https://github.com/apache/hudi/pull/8429#issuecomment-1504726746 ## CI report: * acd347c5e6cd019ee98b7f1fa435b95153e71238 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1627

[jira] [Created] (HUDI-6065) PostWriteTermination Strategy does not shutdown the spark job completely (including compaction/clustering)

2023-04-11 Thread LiJie2023 (Jira)
LiJie2023 created HUDI-6065: --- Summary: PostWriteTermination Strategy does not shutdown the spark job completely (including compaction/clustering) Key: HUDI-6065 URL: https://issues.apache.org/jira/browse/HUDI-6065

[GitHub] [hudi] hudi-bot commented on pull request #8338: [HUDI-5996] Verify the consistency of bucket num at job sta…

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8338: URL: https://github.com/apache/hudi/pull/8338#issuecomment-1504726402 ## CI report: * fccdb147c249b08d856819e028986d76603828e9 UNKNOWN * 86a201c099bbc2016d53d987aa481b779464c9c2 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] slfan1989 commented on pull request #8435: [HUDI-6064] Improve JDBCExecutor#getTableSchema Use ColName.

2023-04-11 Thread via GitHub
slfan1989 commented on PR #8435: URL: https://github.com/apache/hudi/pull/8435#issuecomment-1504700781 @danny0405 Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hudi] hudi-bot commented on pull request #8299: [HUDI-5990]Avoid missing data during incremental queries

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8299: URL: https://github.com/apache/hudi/pull/8299#issuecomment-1504676930 ## CI report: * 71963bcf055f63179dfdcc235478aff8487bd328 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1595

[GitHub] [hudi] hudi-bot commented on pull request #8299: [HUDI-5990]Avoid missing data during incremental queries

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8299: URL: https://github.com/apache/hudi/pull/8299#issuecomment-1504669117 ## CI report: * 71963bcf055f63179dfdcc235478aff8487bd328 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1595

[GitHub] [hudi] Mulavar commented on pull request #8385: [HUDI-6040]Stop writing and reading compaction plans from .aux folder

2023-04-11 Thread via GitHub
Mulavar commented on PR #8385: URL: https://github.com/apache/hudi/pull/8385#issuecomment-1504603719 > @Mulavar : This requires a table version change also as we need to create .aux files when we downgrade to older version. Can you add relevant UpgradeDowngrade handlers for this. @bv

[GitHub] [hudi] hudi-bot commented on pull request #8335: [HUDI-6009] Let the jetty server in TimelineService create daemon threads

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8335: URL: https://github.com/apache/hudi/pull/8335#issuecomment-1504598719 ## CI report: * 9bcbb85e4b2bb803e03900b8f01c938833bb1185 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1610

[GitHub] [hudi] hudi-bot commented on pull request #8335: [HUDI-6009] Let the jetty server in TimelineService create daemon threads

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8335: URL: https://github.com/apache/hudi/pull/8335#issuecomment-1504590323 ## CI report: * 9bcbb85e4b2bb803e03900b8f01c938833bb1185 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1610

[GitHub] [hudi] hudi-bot commented on pull request #8385: [HUDI-6040]Stop writing and reading compaction plans from .aux folder

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8385: URL: https://github.com/apache/hudi/pull/8385#issuecomment-1504582669 ## CI report: * 19ff36f7635f289b752b46cf692014b22f4b9ab8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1625

[GitHub] [hudi] danny0405 commented on a diff in pull request #8300: [HUDI-5991] Fix RDDCustomColumnsSortPartitioner's RepartitionRecords

2023-04-11 Thread via GitHub
danny0405 commented on code in PR #8300: URL: https://github.com/apache/hudi/pull/8300#discussion_r1163570948 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java: ## @@ -61,13 +61,8 @@ public JavaRDD> repartit

[GitHub] [hudi] danny0405 commented on a diff in pull request #8300: [HUDI-5991] Fix RDDCustomColumnsSortPartitioner's RepartitionRecords

2023-04-11 Thread via GitHub
danny0405 commented on code in PR #8300: URL: https://github.com/apache/hudi/pull/8300#discussion_r1163569337 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java: ## @@ -61,13 +61,8 @@ public JavaRDD> repartit

[GitHub] [hudi] hudi-bot commented on pull request #8385: [HUDI-6040]Stop writing and reading compaction plans from .aux folder

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8385: URL: https://github.com/apache/hudi/pull/8385#issuecomment-1504537773 ## CI report: * 19ff36f7635f289b752b46cf692014b22f4b9ab8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1625

[GitHub] [hudi] hudi-bot commented on pull request #8435: [HUDI-6064] Improve JDBCExecutor#getTableSchema Use ColName.

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8435: URL: https://github.com/apache/hudi/pull/8435#issuecomment-1504529199 ## CI report: * fda3847c439a2d889bc29c6511ce26bdd922d13c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1627

[GitHub] [hudi] hudi-bot commented on pull request #8429: [HUDI-5975] Release 0.12.3 rc2 prep apr11

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8429: URL: https://github.com/apache/hudi/pull/8429#issuecomment-1504529115 ## CI report: * 18f438577f444c75e8060a20b7fdf59e40e9ab7e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] hudi-bot commented on pull request #8385: [HUDI-6040]Stop writing and reading compaction plans from .aux folder

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8385: URL: https://github.com/apache/hudi/pull/8385#issuecomment-1504528832 ## CI report: * 19ff36f7635f289b752b46cf692014b22f4b9ab8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1625

[GitHub] [hudi] hudi-bot commented on pull request #8338: [HUDI-5996] Verify the consistency of bucket num at job sta…

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8338: URL: https://github.com/apache/hudi/pull/8338#issuecomment-1504528612 ## CI report: * fccdb147c249b08d856819e028986d76603828e9 UNKNOWN * 7abfb144f1c76d65cf00115d5bfa9a82b1a28846 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] danny0405 commented on pull request #2701: [HUDI 1623] New Hoodie Instant on disk format with end time and milliseconds granularity

2023-04-11 Thread via GitHub
danny0405 commented on PR #2701: URL: https://github.com/apache/hudi/pull/2701#issuecomment-1504527704 A valuable PR especially for the use case in incremental style: incremental streaming read, incremental cleaning, incremental meta sync, etc. -- This is an automated message from the Apa

[GitHub] [hudi] ad1happy2go commented on issue #7827: [SUPPORT]Errors are thrown when querying rt table of no deltalogs count(1)/count(*) by presto

2023-04-11 Thread via GitHub
ad1happy2go commented on issue #7827: URL: https://github.com/apache/hudi/issues/7827#issuecomment-1504522724 @silencily Can you please confirm if upgrading to newer presto version fixed your issue? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [hudi] hudi-bot commented on pull request #8429: [HUDI-5975] Release 0.12.3 rc2 prep apr11

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8429: URL: https://github.com/apache/hudi/pull/8429#issuecomment-1504521437 ## CI report: * 18f438577f444c75e8060a20b7fdf59e40e9ab7e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] hudi-bot commented on pull request #8435: [HUDI-6064] Improve JDBCExecutor#getTableSchema Use ColName.

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8435: URL: https://github.com/apache/hudi/pull/8435#issuecomment-1504521522 ## CI report: * fda3847c439a2d889bc29c6511ce26bdd922d13c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #8338: [HUDI-5996] Verify the consistency of bucket num at job sta…

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8338: URL: https://github.com/apache/hudi/pull/8338#issuecomment-1504521063 ## CI report: * fccdb147c249b08d856819e028986d76603828e9 UNKNOWN * 7abfb144f1c76d65cf00115d5bfa9a82b1a28846 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] ad1happy2go commented on issue #8144: [SUPPORT]Unable to connect to an s3 hudi table

2023-04-11 Thread via GitHub
ad1happy2go commented on issue #8144: URL: https://github.com/apache/hudi/issues/8144#issuecomment-1504517165 @peter-mccabe Are you still facing this issue? If yes, can you share complete stack trace of the error? Are you setting up S3 keys properly in Hadoop fs configuration to conn

[GitHub] [hudi] hudi-bot commented on pull request #8434: [HUDI-6063] Modify logging errors In JDBCExecutor.

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8434: URL: https://github.com/apache/hudi/pull/8434#issuecomment-1504513257 ## CI report: * 321a9073e72e4c06cc8c93b6fb114b9ed6aecfbd Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] zhangyue19921010 commented on pull request #7143: [HUDI-5175] Improving FileIndex load performance in PARALLELISM mode

2023-04-11 Thread via GitHub
zhangyue19921010 commented on PR #7143: URL: https://github.com/apache/hudi/pull/7143#issuecomment-1504508775 Hey Hey! @bvaradar Sorry for missing this PR. And Appreciate for your attention and review. Sure, will address this PR later this week. Thanks! -- This is an automated message

[jira] [Updated] (HUDI-6064) Improve JDBCExecutor#getTableSchema Use ColName

2023-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-6064: - Labels: pull-request-available (was: ) > Improve JDBCExecutor#getTableSchema Use ColName > --

[GitHub] [hudi] LinMingQiang commented on pull request #8338: [HUDI-5996] Verify the consistency of bucket num at job sta…

2023-04-11 Thread via GitHub
LinMingQiang commented on PR #8338: URL: https://github.com/apache/hudi/pull/8338#issuecomment-1504502481 add test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hudi] slfan1989 opened a new pull request, #8435: [HUDI-6064] Improve JDBCExecutor#getTableSchema Use ColName.

2023-04-11 Thread via GitHub
slfan1989 opened a new pull request, #8435: URL: https://github.com/apache/hudi/pull/8435 ### Change Logs JDBCExecutor#getTableSchema Use ColIndex, which is not conducive to code reading, use ColName instead of ColIndex. ### Impact none. ### Risk level (write none

[jira] [Created] (HUDI-6064) Improve JDBCExecutor#getTableSchema Use ColName

2023-04-11 Thread Shilun Fan (Jira)
Shilun Fan created HUDI-6064: Summary: Improve JDBCExecutor#getTableSchema Use ColName Key: HUDI-6064 URL: https://issues.apache.org/jira/browse/HUDI-6064 Project: Apache Hudi Issue Type: Improve

[jira] [Updated] (HUDI-6064) Improve JDBCExecutor#getTableSchema Use ColName

2023-04-11 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HUDI-6064: - Status: In Progress (was: Open) > Improve JDBCExecutor#getTableSchema Use ColName > -

[GitHub] [hudi] xccui commented on issue #8325: [SUPPORT] spark read hudi error: Unable to instantiate HFileBootstrapIndex

2023-04-11 Thread via GitHub
xccui commented on issue #8325: URL: https://github.com/apache/hudi/issues/8325#issuecomment-1504472901 Got some time today to take a closer look at the errors. `HFileBootstrapIndex` needs to access some remote data during initialization. There should be some connection issues (e.g. file sy

[GitHub] [hudi] hudi-bot commented on pull request #8433: [minor] avoid synchronized block in ReflectionUtils if key is present in cache

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8433: URL: https://github.com/apache/hudi/pull/8433#issuecomment-1504463584 ## CI report: * 106eefb312139bfec944a5693e2e3608f0a11bd1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] bvaradar commented on a diff in pull request #8378: [HUDI-6031] fix bug: checkpoint lost after changing cow to mor

2023-04-11 Thread via GitHub
bvaradar commented on code in PR #8378: URL: https://github.com/apache/hudi/pull/8378#discussion_r1163506777 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java: ## @@ -650,16 +648,19 @@ private JavaRDD getTransformedRDD(Dataset rowDataset, bo

[GitHub] [hudi] wuwenchi commented on pull request #7834: [HUDI-5690] Add simpleBucketPartitioner to support using the simple bucket index under bulkinsert

2023-04-11 Thread via GitHub
wuwenchi commented on PR #7834: URL: https://github.com/apache/hudi/pull/7834#issuecomment-1504421161 > @wuwenchi : Please ping me in this PR once you have addressed all comments and is ready for review. @bvaradar All comments have now been corrected, it's ready to review now, thanks

[GitHub] [hudi] codope commented on pull request #8424: [HUDI-6057] Fix deltastreamer shutdown when post write termination strategy enabled

2023-04-11 Thread via GitHub
codope commented on PR #8424: URL: https://github.com/apache/hudi/pull/8424#issuecomment-1504419143 @LiJie20190102 Have you checked if this fix solves your problem? https://github.com/apache/hudi/pull/8173 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hudi] bvaradar commented on pull request #7834: [HUDI-5690] Add simpleBucketPartitioner to support using the simple bucket index under bulkinsert

2023-04-11 Thread via GitHub
bvaradar commented on PR #7834: URL: https://github.com/apache/hudi/pull/7834#issuecomment-1504414285 @wuwenchi : Please ping me in this PR once you have addressed all comments and is ready for review. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hudi] bvaradar commented on pull request #7143: [HUDI-5175] Improving FileIndex load performance in PARALLELISM mode

2023-04-11 Thread via GitHub
bvaradar commented on PR #7143: URL: https://github.com/apache/hudi/pull/7143#issuecomment-1504411183 @zhangyue19921010 : Pinging to see if you can address review comments ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hudi] bvaradar commented on pull request #7913: Adding support for EPOCHMICROSECONDS in TimestampBasedAvroKeyGenerator

2023-04-11 Thread via GitHub
bvaradar commented on PR #7913: URL: https://github.com/apache/hudi/pull/7913#issuecomment-1504409552 @sydneybeal : Pinging to see if you can address the comments ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[hudi] branch master updated (8f014c033c3 -> 10040de05ad)

2023-04-11 Thread vbalaji
This is an automated email from the ASF dual-hosted git repository. vbalaji pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git from 8f014c033c3 [HUDI-6014] Remove unused import in hudi-spark (#8350) add 10040de05ad [HUDI-5389] Remove Hudi Cli Dup

[GitHub] [hudi] bvaradar merged pull request #8360: [HUDI-5389] Remove Hudi Cli Duplicates Code.

2023-04-11 Thread via GitHub
bvaradar merged PR #8360: URL: https://github.com/apache/hudi/pull/8360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.

[GitHub] [hudi] bvaradar commented on pull request #7680: [HUDI-5548] spark sql show | update hudi's table properties

2023-04-11 Thread via GitHub
bvaradar commented on PR #7680: URL: https://github.com/apache/hudi/pull/7680#issuecomment-1504392751 @XuQianJin-Stars : Can you let us know if you will be able to look at the failing test and also rebase please. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [hudi] bvaradar commented on pull request #8385: [HUDI-6040]Stop writing and reading compaction plans from .aux folder

2023-04-11 Thread via GitHub
bvaradar commented on PR #8385: URL: https://github.com/apache/hudi/pull/8385#issuecomment-1504389808 @Mulavar : We need to create a higher version 6 and write upgrade/downgrade to handle transition from current version (5). You can look at https://github.com/apache/hudi/pull/6248 as examp

[GitHub] [hudi] hudi-bot commented on pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
hudi-bot commented on PR #7881: URL: https://github.com/apache/hudi/pull/7881#issuecomment-1504379935 ## CI report: * c378a74c177a2f1a924609a44f0978ee347d272a UNKNOWN * a2a75f077cf831e05b5659eaf0990ebc4865622e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[hudi] branch master updated: [HUDI-6014] Remove unused import in hudi-spark (#8350)

2023-04-11 Thread vbalaji
This is an automated email from the ASF dual-hosted git repository. vbalaji pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 8f014c033c3 [HUDI-6014] Remove unused import in h

[GitHub] [hudi] bvaradar merged pull request #8350: [HUDI-6014] Remove unused import in hudi-spark

2023-04-11 Thread via GitHub
bvaradar merged PR #8350: URL: https://github.com/apache/hudi/pull/8350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.

[GitHub] [hudi] hudi-bot commented on pull request #8434: [HUDI-6063] Modify logging errors In JDBCExecutor.

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8434: URL: https://github.com/apache/hudi/pull/8434#issuecomment-1504336034 ## CI report: * 321a9073e72e4c06cc8c93b6fb114b9ed6aecfbd Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] hudi-bot commented on pull request #8433: [minor] avoid synchronized block in ReflectionUtils if key is present in cache

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8433: URL: https://github.com/apache/hudi/pull/8433#issuecomment-1504335986 ## CI report: * 106eefb312139bfec944a5693e2e3608f0a11bd1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] hudi-bot commented on pull request #8434: [HUDI-6063] Modify logging errors In JDBCExecutor.

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8434: URL: https://github.com/apache/hudi/pull/8434#issuecomment-1504328434 ## CI report: * 321a9073e72e4c06cc8c93b6fb114b9ed6aecfbd UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #8433: [minor] avoid synchronized block in ReflectionUtils if key is present in cache

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8433: URL: https://github.com/apache/hudi/pull/8433#issuecomment-1504328379 ## CI report: * 106eefb312139bfec944a5693e2e3608f0a11bd1 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[jira] [Updated] (HUDI-6063) Modify logging errors In JDBCExecutor

2023-04-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-6063: - Labels: pull-request-available (was: ) > Modify logging errors In JDBCExecutor >

[GitHub] [hudi] slfan1989 opened a new pull request, #8434: [HUDI-6063] Modify logging errors In JDBCExecutor.

2023-04-11 Thread via GitHub
slfan1989 opened a new pull request, #8434: URL: https://github.com/apache/hudi/pull/8434 ### Change Logs There is a logging error in JDBCExecutor. During the process of drop partitions, the log prints add partitions. ### Impact none. ### Risk level (write none, l

[jira] [Assigned] (HUDI-6063) Modify logging errors In JDBCExecutor

2023-04-11 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan reassigned HUDI-6063: Assignee: Shilun Fan > Modify logging errors In JDBCExecutor >

[jira] [Updated] (HUDI-6063) Modify logging errors In JDBCExecutor

2023-04-11 Thread Shilun Fan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shilun Fan updated HUDI-6063: - Status: In Progress (was: Open) > Modify logging errors In JDBCExecutor > ---

[jira] [Created] (HUDI-6063) Modify logging errors In JDBCExecutor

2023-04-11 Thread Shilun Fan (Jira)
Shilun Fan created HUDI-6063: Summary: Modify logging errors In JDBCExecutor Key: HUDI-6063 URL: https://issues.apache.org/jira/browse/HUDI-6063 Project: Apache Hudi Issue Type: Bug Com

[GitHub] [hudi] slfan1989 commented on a diff in pull request #8388: [HUDI-5816] List all partitions as the fallback mechanism in Hive and Glue Sync

2023-04-11 Thread via GitHub
slfan1989 commented on code in PR #8388: URL: https://github.com/apache/hudi/pull/8388#discussion_r1163442102 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java: ## @@ -258,13 +258,28 @@ protected void syncHoodieTable(String tableName, boolean useR

[GitHub] [hudi] slfan1989 commented on a diff in pull request #8388: [HUDI-5816] List all partitions as the fallback mechanism in Hive and Glue Sync

2023-04-11 Thread via GitHub
slfan1989 commented on code in PR #8388: URL: https://github.com/apache/hudi/pull/8388#discussion_r1163441854 ## hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HiveSyncTool.java: ## @@ -258,13 +258,28 @@ protected void syncHoodieTable(String tableName, boolean useR

[GitHub] [hudi] the-other-tim-brown opened a new pull request, #8433: [minor] avoid synchronized block in ReflectionUtils if key is present in cache

2023-04-11 Thread via GitHub
the-other-tim-brown opened a new pull request, #8433: URL: https://github.com/apache/hudi/pull/8433 ### Change Logs Avoids acquiring a lock to check whether a value is present in a cache to allow better performance when the value is already in the cache. ### Impact This

[GitHub] [hudi] hudi-bot commented on pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
hudi-bot commented on PR #7881: URL: https://github.com/apache/hudi/pull/7881#issuecomment-1504268255 ## CI report: * c378a74c177a2f1a924609a44f0978ee347d272a UNKNOWN * 8fd9b3a58eb63e330b306ed70843e677dfbc4a2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
hudi-bot commented on PR #7881: URL: https://github.com/apache/hudi/pull/7881#issuecomment-1504260452 ## CI report: * c378a74c177a2f1a924609a44f0978ee347d272a UNKNOWN * 8fd9b3a58eb63e330b306ed70843e677dfbc4a2d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #8432: Fix NPE when upsert merger and null map or array

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8432: URL: https://github.com/apache/hudi/pull/8432#issuecomment-1504253664 ## CI report: * f4502dad350e0dc84299dc0bd5889506420b0f49 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[jira] [Updated] (HUDI-5997) Support DFS Schema Provider with S3/GCS EventsHoodieIncrSource

2023-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/HUDI-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Léo Biscassi updated HUDI-5997: --- Status: In Progress (was: Open) > Support DFS Schema Provider with S3/GCS EventsHoodieIncrSource > --

[jira] [Assigned] (HUDI-5997) Support DFS Schema Provider with S3/GCS EventsHoodieIncrSource

2023-04-11 Thread Jira
[ https://issues.apache.org/jira/browse/HUDI-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Léo Biscassi reassigned HUDI-5997: -- Assignee: Léo Biscassi > Support DFS Schema Provider with S3/GCS EventsHoodieIncrSource > -

[GitHub] [hudi] jonvex commented on a diff in pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
jonvex commented on code in PR #7881: URL: https://github.com/apache/hudi/pull/7881#discussion_r1163391536 ## hudi-common/src/test/java/org/apache/hudi/common/config/TestConfigProperty.java: ## @@ -171,4 +171,28 @@ public void testAdvancedValue() { assertTrue(FAKE_BOOLEAN_C

[GitHub] [hudi] hudi-bot commented on pull request #8082: [HUDI-5868] Upgrade Spark to 3.3.2

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8082: URL: https://github.com/apache/hudi/pull/8082#issuecomment-1504203496 ## CI report: * f43a772d2efe7d19657b44d2ce8b92b8fcee390f UNKNOWN * 58edb8dbad6d6e4dd7455bcabc5e5f70369493ab Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] jonvex commented on a diff in pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
jonvex commented on code in PR #7881: URL: https://github.com/apache/hudi/pull/7881#discussion_r1163375572 ## hudi-common/src/main/java/org/apache/hudi/common/config/ConfigProperty.java: ## @@ -139,6 +144,49 @@ public ConfigProperty withDocumentation(String doc) { return ne

[GitHub] [hudi] jonvex commented on a diff in pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
jonvex commented on code in PR #7881: URL: https://github.com/apache/hudi/pull/7881#discussion_r1163352137 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java: ## @@ -168,23 +168,16 @@ public class HoodieWriteConfig extends HoodieConfig

[GitHub] [hudi] jonvex commented on a diff in pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
jonvex commented on code in PR #7881: URL: https://github.com/apache/hudi/pull/7881#discussion_r1163346107 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java: ## @@ -732,40 +712,17 @@ public String getValue() { } } + @En

[GitHub] [hudi] hudi-bot commented on pull request #8432: Fix NPE when upsert merger and null map or array

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8432: URL: https://github.com/apache/hudi/pull/8432#issuecomment-1504104875 ## CI report: * f4502dad350e0dc84299dc0bd5889506420b0f49 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8430: URL: https://github.com/apache/hudi/pull/8430#issuecomment-1504104816 ## CI report: * d357330a200b9c5ad7f719d9985d40ef2e604d51 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[jira] [Created] (HUDI-6062) Update LayoutOptimizationStrategy and ClusteringOperator to use standard enum notation

2023-04-11 Thread Jonathan Vexler (Jira)
Jonathan Vexler created HUDI-6062: - Summary: Update LayoutOptimizationStrategy and ClusteringOperator to use standard enum notation Key: HUDI-6062 URL: https://issues.apache.org/jira/browse/HUDI-6062

[jira] [Created] (HUDI-6061) NPE with nullable MapType and new hudi merger

2023-04-11 Thread nicolas paris (Jira)
nicolas paris created HUDI-6061: --- Summary: NPE with nullable MapType and new hudi merger Key: HUDI-6061 URL: https://issues.apache.org/jira/browse/HUDI-6061 Project: Apache Hudi Issue Type: Bug

[GitHub] [hudi] jonvex commented on a diff in pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
jonvex commented on code in PR #7881: URL: https://github.com/apache/hudi/pull/7881#discussion_r1163302008 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/bootstrap/BootstrapMode.java: ## @@ -18,18 +18,28 @@ package org.apache.hudi.client.bootstrap; +

[GitHub] [hudi] hudi-bot commented on pull request #8432: Fix NPE when upsert merger and null map or array

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8432: URL: https://github.com/apache/hudi/pull/8432#issuecomment-150405 ## CI report: * f4502dad350e0dc84299dc0bd5889506420b0f49 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] parisni opened a new pull request, #8432: Fix NPE when upsert merger and null map or array

2023-04-11 Thread via GitHub
parisni opened a new pull request, #8432: URL: https://github.com/apache/hudi/pull/8432 ### Change Logs Fixes #8431 ### Impact _Describe any public API or user-facing feature change or any performance impact._ ### Risk level (write none, low medium or high below)

[GitHub] [hudi] hudi-bot commented on pull request #8429: [HUDI-5975] Release 0.12.3 rc2 prep apr11

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8429: URL: https://github.com/apache/hudi/pull/8429#issuecomment-1504039432 ## CI report: * 18f438577f444c75e8060a20b7fdf59e40e9ab7e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] parisni opened a new issue, #8431: [SUPPORT] NPE with MapType and new hudi merger

2023-04-11 Thread via GitHub
parisni opened a new issue, #8431: URL: https://github.com/apache/hudi/issues/8431 **Describe the problem you faced** When dealing with null map values during an upsert with the new hudi merger api, then null pointer raises. AFAIK, it happens when both MapTypes are containing null in

[GitHub] [hudi] CTTY commented on a diff in pull request #8082: [HUDI-5868] Upgrade Spark to 3.3.2

2023-04-11 Thread via GitHub
CTTY commented on code in PR #8082: URL: https://github.com/apache/hudi/pull/8082#discussion_r1163228965 ## hudi-spark-datasource/hudi-spark3.3.x/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/Spark332PlusHoodieParquetFileFormat.scala: ## @@ -0,0 +1,41 @@ +/*

[GitHub] [hudi] hudi-bot commented on pull request #8300: [HUDI-5991] Fix RDDCustomColumnsSortPartitioner's RepartitionRecords

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8300: URL: https://github.com/apache/hudi/pull/8300#issuecomment-1503970614 ## CI report: * b7ab237090a715521e580113486849489d1bf00c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] hudi-bot commented on pull request #8082: [HUDI-5868] Upgrade Spark to 3.3.2

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8082: URL: https://github.com/apache/hudi/pull/8082#issuecomment-1503894762 ## CI report: * f43a772d2efe7d19657b44d2ce8b92b8fcee390f UNKNOWN * 46a2c22795b5e1be2bc74f92090cd1a496ea9a39 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #8082: [HUDI-5868] Upgrade Spark to 3.3.2

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8082: URL: https://github.com/apache/hudi/pull/8082#issuecomment-1503886479 ## CI report: * f43a772d2efe7d19657b44d2ce8b92b8fcee390f UNKNOWN * 46a2c22795b5e1be2bc74f92090cd1a496ea9a39 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #8082: [HUDI-5868] Upgrade Spark to 3.3.2

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8082: URL: https://github.com/apache/hudi/pull/8082#issuecomment-1503877790 ## CI report: * f43a772d2efe7d19657b44d2ce8b92b8fcee390f UNKNOWN * 46a2c22795b5e1be2bc74f92090cd1a496ea9a39 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

[GitHub] [hudi] hudi-bot commented on pull request #8358: [HUDI-6017] Sort the results of Call help Procedure with no params

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8358: URL: https://github.com/apache/hudi/pull/8358#issuecomment-1503878485 ## CI report: * 2c0e780e2dce3717fc3586417b5110dea2ca028c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1625

[GitHub] [hudi] nsivabalan commented on pull request #8429: [HUDI-5975] Release 0.12.3 rc2 prep apr11

2023-04-11 Thread via GitHub
nsivabalan commented on PR #8429: URL: https://github.com/apache/hudi/pull/8429#issuecomment-1503874676 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hudi] ad1happy2go commented on issue #8016: Inline Clustering : Clustering failed to write to files

2023-04-11 Thread via GitHub
ad1happy2go commented on issue #8016: URL: https://github.com/apache/hudi/issues/8016#issuecomment-1503856835 @raghavant-git Did you got a chance to test with those parameters? Are you still facing this issue? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] jonvex commented on a diff in pull request #8303: [HUDI-5998] Speed up reads from bootstrapped tables in spark

2023-04-11 Thread via GitHub
jonvex commented on code in PR #8303: URL: https://github.com/apache/hudi/pull/8303#discussion_r1163162168 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala: ## @@ -270,6 +271,21 @@ object DefaultSource { } } + private def r

[GitHub] [hudi] Madan16 commented on issue #8428: [SUPPORT]: When trying to UPSERT, Getting issues like : An error occurred while calling o168.save. org/apache/spark/sql/avro/SchemaConverters$ AND

2023-04-11 Thread via GitHub
Madan16 commented on issue #8428: URL: https://github.com/apache/hudi/issues/8428#issuecomment-1503853073 > @Madan16 I wanted to ask were you using AWS Glue version : Glue 3.0 only from start. (When the job is successful) > > My guess is somehow the version mismatch might be happening

[GitHub] [hudi] ad1happy2go commented on issue #8017: [SUPPORT] Parquet file size is small after running deltastreamer in BULK_INSERT which results in large number of files under same partitioning

2023-04-11 Thread via GitHub
ad1happy2go commented on issue #8017: URL: https://github.com/apache/hudi/issues/8017#issuecomment-1503852321 @ROOBALJINDAL Are you still facing this issue? If yes, can you provide reproducible script if possible. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [hudi] jonvex commented on a diff in pull request #7881: [HUDI-5723] Automate and standardize enum configs

2023-04-11 Thread via GitHub
jonvex commented on code in PR #7881: URL: https://github.com/apache/hudi/pull/7881#discussion_r1163153414 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java: ## @@ -194,16 +187,18 @@ public class HoodieWriteConfig extends HoodieConfig

[GitHub] [hudi] ad1happy2go commented on issue #8428: [SUPPORT]: When trying to UPSERT, Getting issues like : An error occurred while calling o168.save. org/apache/spark/sql/avro/SchemaConverters$

2023-04-11 Thread via GitHub
ad1happy2go commented on issue #8428: URL: https://github.com/apache/hudi/issues/8428#issuecomment-1503843944 @Madan16 I wanted to ask were you using AWS Glue version : Glue 3.0 only from start. (When the job is successful) My guess is somehow the version mismatch might be happening w

[GitHub] [hudi] rahil-c commented on pull request #8082: [HUDI-5868] Upgrade Spark to 3.3.2

2023-04-11 Thread via GitHub
rahil-c commented on PR #8082: URL: https://github.com/apache/hudi/pull/8082#issuecomment-1503840585 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8430: URL: https://github.com/apache/hudi/pull/8430#issuecomment-1503828676 ## CI report: * d357330a200b9c5ad7f719d9985d40ef2e604d51 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1626

[GitHub] [hudi] zyclove commented on issue #8244: [SUPPORT] Is there any plan to support metadata management, index and table optimization services?

2023-04-11 Thread via GitHub
zyclove commented on issue #8244: URL: https://github.com/apache/hudi/issues/8244#issuecomment-1503828199 Do you have contact with the arctic project team? As the arctic project very much hopes to support hudi metadata management and data optimization. > @zyclove Do you need any o

[GitHub] [hudi] ad1happy2go commented on issue #8130: Spark java.util.NoSuchElementException: FileID * partition path p_c=CN_1 does not exist.

2023-04-11 Thread via GitHub
ad1happy2go commented on issue #8130: URL: https://github.com/apache/hudi/issues/8130#issuecomment-1503826578 @18511327133 Couldn't able to reproduce the issue. Can you provide exact reproducible script with your datasets. -- This is an automated message from the Apache Git Se

[GitHub] [hudi] hudi-bot commented on pull request #8430: [HUDI-6060] Added a config to backup instants before deletion during rollbacks and restores.

2023-04-11 Thread via GitHub
hudi-bot commented on PR #8430: URL: https://github.com/apache/hudi/pull/8430#issuecomment-1503818107 ## CI report: * d357330a200b9c5ad7f719d9985d40ef2e604d51 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] ad1happy2go commented on issue #8244: [SUPPORT] Is there any plan to support metadata management, index and table optimization services?

2023-04-11 Thread via GitHub
ad1happy2go commented on issue #8244: URL: https://github.com/apache/hudi/issues/8244#issuecomment-1503814032 @zyclove Do you need any other help as part of this ticket or can we close the same? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hudi] ad1happy2go commented on issue #8236: [SUPPORT]Duplicate data in MOR table Hudi

2023-04-11 Thread via GitHub
ad1happy2go commented on issue #8236: URL: https://github.com/apache/hudi/issues/8236#issuecomment-1503813179 @xiagupqin Can you please let us know if you got this issue again with the fix or disabling metadata. -- This is an automated message from the Apache Git Service. To respond to th

  1   2   >