[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1619538682 ## CI report: * ded032d61349861050c47d7fe71a8f15db5bcdbe Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9112: [HUDI-6465] Fix data skipping support BIGINT

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9112: URL: https://github.com/apache/hudi/pull/9112#issuecomment-1619530186 ## CI report: * 45bcbc09dacb95a4f7e2c66fba71dd29e13c620d Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9110: [MINOR] Test table cleanup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9110: URL: https://github.com/apache/hudi/pull/9110#issuecomment-1619530106 ## CI report: * 8014062978c512d904bc4d51298907f1ecdabd8d Azure:

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1619529695 ## CI report: * ded032d61349861050c47d7fe71a8f15db5bcdbe Azure:

[hudi] branch master updated: [HUDI-6462] Add Hudi client init callback interface (#9108)

2023-07-03 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 4bba6af0fa1 [HUDI-6462] Add Hudi client init

[GitHub] [hudi] nsivabalan merged pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
nsivabalan merged PR #9108: URL: https://github.com/apache/hudi/pull/9108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hudi] amrishlal commented on a diff in pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
amrishlal commented on code in PR #8978: URL: https://github.com/apache/hudi/pull/8978#discussion_r1251488891 ## hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java: ## @@ -227,9 +231,21 @@ public static HoodieWriteResult

[GitHub] [hudi] Alowator commented on pull request #9112: [HUDI-6465] Fix data skipping support BIGINT

2023-07-03 Thread via GitHub
Alowator commented on PR #9112: URL: https://github.com/apache/hudi/pull/9112#issuecomment-1619488311 Rebased on latest master after #9114 with pipelines fixes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hudi] nsivabalan commented on a diff in pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
nsivabalan commented on code in PR #8978: URL: https://github.com/apache/hudi/pull/8978#discussion_r1251481229 ## hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java: ## @@ -227,9 +231,21 @@ public static HoodieWriteResult

[GitHub] [hudi] nsivabalan commented on a diff in pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
nsivabalan commented on code in PR #8978: URL: https://github.com/apache/hudi/pull/8978#discussion_r1251480969 ## hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/DataSourceUtils.java: ## @@ -227,9 +231,21 @@ public static HoodieWriteResult

[GitHub] [hudi] hudi-bot commented on pull request #9113: [HUDI-6466] Fix spark insert overwrite partitioned table with dynamic partition

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9113: URL: https://github.com/apache/hudi/pull/9113#issuecomment-1619481354 ## CI report: * c6127a02ea8c3f4e8819559dbb4efa9f64bc040f Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9112: [HUDI-6465] Fix data skipping support BIGINT

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9112: URL: https://github.com/apache/hudi/pull/9112#issuecomment-1619481308 ## CI report: * 45bcbc09dacb95a4f7e2c66fba71dd29e13c620d Azure:

[GitHub] [hudi] Alowator commented on pull request #9112: [HUDI-6465] Fix data skipping support BIGINT

2023-07-03 Thread via GitHub
Alowator commented on PR #9112: URL: https://github.com/apache/hudi/pull/9112#issuecomment-1619477901 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hudi] hudi-bot commented on pull request #9113: [HUDI-6466] Fix spark insert overwrite partitioned table with dynamic partition

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9113: URL: https://github.com/apache/hudi/pull/9113#issuecomment-1619472786 ## CI report: * c6127a02ea8c3f4e8819559dbb4efa9f64bc040f Azure:

[GitHub] [hudi] ad1happy2go commented on issue #8964: test automatic compression failed, no parquet file generated

2023-07-03 Thread via GitHub
ad1happy2go commented on issue #8964: URL: https://github.com/apache/hudi/issues/8964#issuecomment-1619466884 @ZhangxuezhenUCAS While packaging the jar manually, you can shade the parquet jars also like we do other jars. Let us know what information or help you need to get it working. --

[GitHub] [hudi] hudi-bot commented on pull request #9113: [HUDI-6466] Fix spark insert overwrite partitioned table with dynamic partition

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9113: URL: https://github.com/apache/hudi/pull/9113#issuecomment-1619466691 ## CI report: * c6127a02ea8c3f4e8819559dbb4efa9f64bc040f Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9087: [HUDI-6329] Aadjust the partitioner automatically for flink consistent hashing index

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9087: URL: https://github.com/apache/hudi/pull/9087#issuecomment-1619466599 ## CI report: * 47e33acb50156f19b8c35eaca775f5f2ba8c5ead UNKNOWN * cc9a8531d606735d9b31b9f9f6a56f606d45b6f1 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1619466400 ## CI report: * ded032d61349861050c47d7fe71a8f15db5bcdbe Azure:

[GitHub] [hudi] nsivabalan commented on a diff in pull request #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
nsivabalan commented on code in PR #9117: URL: https://github.com/apache/hudi/pull/9117#discussion_r1251468123 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -1161,25 +1165,36 @@ protected boolean

[GitHub] [hudi] ad1happy2go commented on issue #9022: [SUPPORT] Kind of corrupted MDT

2023-07-03 Thread via GitHub
ad1happy2go commented on issue #9022: URL: https://github.com/apache/hudi/issues/9022#issuecomment-1619464788 @parisni I confirmed that we are not facing this error while reading metadata table with the version you specified. Closing out the issue. Please reopen in case you face this issue

[GitHub] [hudi] flashJd commented on pull request #9113: [HUDI-6466] Fix spark insert overwrite partitioned table with dynamic partition

2023-07-03 Thread via GitHub
flashJd commented on PR #9113: URL: https://github.com/apache/hudi/pull/9113#issuecomment-1619439352 @hudi-bot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hudi] hudi-bot commented on pull request #9087: [HUDI-6329] Aadjust the partitioner automatically for flink consistent hashing index

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9087: URL: https://github.com/apache/hudi/pull/9087#issuecomment-1619430671 ## CI report: * 47e33acb50156f19b8c35eaca775f5f2ba8c5ead UNKNOWN * cc9a8531d606735d9b31b9f9f6a56f606d45b6f1 Azure:

[GitHub] [hudi] flashJd commented on pull request #9113: [HUDI-6466] Fix spark insert overwrite partitioned table with dynamic partition

2023-07-03 Thread via GitHub
flashJd commented on PR #9113: URL: https://github.com/apache/hudi/pull/9113#issuecomment-1619426298 https://github.com/apache/hudi/blob/5d196fe61757987af29b38e1b5cf38d7ca001924/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#L879 Modify

[GitHub] [hudi] hudi-bot commented on pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9108: URL: https://github.com/apache/hudi/pull/9108#issuecomment-1619425450 ## CI report: * 9b67bc501f473e9e4caf8dccba04dce8a1601f5b Azure:

[GitHub] [hudi] beyond1920 commented on a diff in pull request #9087: [HUDI-6329] Aadjust the partitioner automatically for flink consistent hashing index

2023-07-03 Thread via GitHub
beyond1920 commented on code in PR #9087: URL: https://github.com/apache/hudi/pull/9087#discussion_r1251440287 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/update/strategy/FlinkConsistentBucketUpdateStrategy.java: ## @@ -0,0 +1,147 @@ +/* +

[GitHub] [hudi] hudi-bot commented on pull request #8891: [Hudi-6318]The skip merge config for incremental-read ensures consistency in both stream and batch scenarios

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8891: URL: https://github.com/apache/hudi/pull/8891#issuecomment-1619387699 ## CI report: * 36b11d3609fdf04192f3910ea024022e22052169 Azure:

[GitHub] [hudi] danny0405 commented on pull request #9113: [HUDI-6466] Fix spark insert overwrite partitioned table with dynamic partition

2023-07-03 Thread via GitHub
danny0405 commented on PR #9113: URL: https://github.com/apache/hudi/pull/9113#issuecomment-1619381392 Seems a huge behavior change, may not have time for the fix for release 0.14.0, cc @boneanxs can you help for the review here? -- This is an automated message from the Apache Git

[GitHub] [hudi] hudi-bot commented on pull request #8891: [Hudi-6318]The skip merge config for incremental-read ensures consistency in both stream and batch scenarios

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8891: URL: https://github.com/apache/hudi/pull/8891#issuecomment-1619380817 ## CI report: * 36b11d3609fdf04192f3910ea024022e22052169 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9116: [HUDI-6470] Add spark sql conf in AlterTableCommand

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9116: URL: https://github.com/apache/hudi/pull/9116#issuecomment-1619375851 ## CI report: * 80b8747dfec3e4cac7719796a46e52e9846081f5 Azure:

[GitHub] [hudi] danny0405 commented on pull request #9115: [HUDI-6469] Revert HUDI-6311

2023-07-03 Thread via GitHub
danny0405 commented on PR #9115: URL: https://github.com/apache/hudi/pull/9115#issuecomment-1619365436 Hi @jonvex Can you elaborate a little more why to revert the changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #8891: [Hudi-6318]The skip merge config for incremental-read ensures consistency in both stream and batch scenarios

2023-07-03 Thread via GitHub
zhuanshenbsj1 commented on code in PR #8891: URL: https://github.com/apache/hudi/pull/8891#discussion_r1251402811 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java: ## @@ -396,6 +396,8 @@ private List buildInputSplits() {

[GitHub] [hudi] danny0405 commented on a diff in pull request #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
danny0405 commented on code in PR #9117: URL: https://github.com/apache/hudi/pull/9117#discussion_r1251402017 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ## @@ -257,6 +257,10 @@ private Option prepareRecord(HoodieRecord

[GitHub] [hudi] danny0405 commented on a diff in pull request #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
danny0405 commented on code in PR #9117: URL: https://github.com/apache/hudi/pull/9117#discussion_r1251401570 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -1161,25 +1165,36 @@ protected boolean

[GitHub] [hudi] danny0405 commented on pull request #9116: [HUDI-6470] Add spark sql conf in AlterTableCommand

2023-07-03 Thread via GitHub
danny0405 commented on PR #9116: URL: https://github.com/apache/hudi/pull/9116#issuecomment-1619355101 It's greate if we can add a simple test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hudi] danny0405 commented on pull request #8610: [HUDI-6156] Prevent leaving tmp file in timeline when multi process t…

2023-07-03 Thread via GitHub
danny0405 commented on PR #8610: URL: https://github.com/apache/hudi/pull/8610#issuecomment-1619353878 @hbgstc123 Can you update the PR and resolve the test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hudi] danny0405 commented on issue #9101: [SUPPORT] Transaction and spark job final state inconsistency in batch processing

2023-07-03 Thread via GitHub
danny0405 commented on issue #9101: URL: https://github.com/apache/hudi/issues/9101#issuecomment-1619350001 inline archiving and cleaning may have this issue, do you try the async cleaning instead? Is there any spark param to control the failover behavior, seems not very easy to fix from

[GitHub] [hudi] hudi-bot commented on pull request #9116: [HUDI-6470] Add spark sql conf in AlterTableCommand

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9116: URL: https://github.com/apache/hudi/pull/9116#issuecomment-1619345051 ## CI report: * 80b8747dfec3e4cac7719796a46e52e9846081f5 Azure:

[GitHub] [hudi] danny0405 commented on a diff in pull request #9114: [HUDI-6467] Fix deletes handling in rli when partition path is updated

2023-07-03 Thread via GitHub
danny0405 commented on code in PR #9114: URL: https://github.com/apache/hudi/pull/9114#discussion_r1251389097 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -1159,10 +1161,27 @@ protected boolean

[GitHub] [hudi] hudi-bot commented on pull request #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9117: URL: https://github.com/apache/hudi/pull/9117#issuecomment-1619333860 ## CI report: * 06cf7c29c35c4bf718f0d015bdf2cc3382deb068 UNKNOWN * 70250eb58fec89adce0e7a0ea1f0ccb03173e79a Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9083: URL: https://github.com/apache/hudi/pull/9083#issuecomment-1619333701 ## CI report: * 3a0bfb88049cf2c0f8afe5c925dbd76fa6f7cd89 UNKNOWN * f156c1694aca3a9e2ca4ed26959c6a5a1b773354 Azure:

[GitHub] [hudi] zhuanshenbsj1 commented on pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

2023-07-03 Thread via GitHub
zhuanshenbsj1 commented on PR #9038: URL: https://github.com/apache/hudi/pull/9038#issuecomment-1619333115 > There are many test failures: > >

[GitHub] [hudi] danny0405 commented on a diff in pull request #9114: [HUDI-6467] Fix deletes handling in rli when partition path is updated

2023-07-03 Thread via GitHub
danny0405 commented on code in PR #9114: URL: https://github.com/apache/hudi/pull/9114#discussion_r1251380823 ## hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestGlobalIndexEnableUpdatePartitions.java: ## @@ -65,8 +65,8 @@ private static Stream

[jira] [Closed] (HUDI-3639) [Incremental] Add Proper Incremental Records FIltering support into Hudi's custom RDD

2023-07-03 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/HUDI-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen closed HUDI-3639. Resolution: Fixed Fixed via master branch: 5d196fe61757987af29b38e1b5cf38d7ca001924 > [Incremental] Add

[hudi] branch master updated: [HUDI-3639] Add Proper Incremental Records FIltering support into Hudi's custom RDD (#8668)

2023-07-03 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 5d196fe6175 [HUDI-3639] Add Proper Incremental

[GitHub] [hudi] danny0405 merged pull request #8668: [HUDI-3639] Add Proper Incremental Records FIltering support into Hudi's custom RDD

2023-07-03 Thread via GitHub
danny0405 merged PR #8668: URL: https://github.com/apache/hudi/pull/8668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1619305334 ## CI report: * 79fac007f537294c5f8a2e40617296e3c44537dd Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9108: URL: https://github.com/apache/hudi/pull/9108#issuecomment-1619299464 ## CI report: * 7f7dae8012b51f42fe9452e1ecc555b524a7dc6b Azure:

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1619299254 ## CI report: * 7142fb46cef77575be4346fa0a9cf2fb7bee03b1 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9108: URL: https://github.com/apache/hudi/pull/9108#issuecomment-1619294803 ## CI report: * 7f7dae8012b51f42fe9452e1ecc555b524a7dc6b Azure:

[GitHub] [hudi] jonvex commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
jonvex commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251342434 ## hudi-spark-datasource/hudi-spark3.2plus-common/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark32PlusAnalysis.scala: ## @@ -128,9 +131,135 @@ case class

[GitHub] [hudi] jonvex commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
jonvex commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251342069 ## hudi-spark-datasource/hudi-spark3.2plus-common/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark32PlusAnalysis.scala: ## @@ -128,9 +131,135 @@ case class

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1619265221 ## CI report: * 7142fb46cef77575be4346fa0a9cf2fb7bee03b1 Azure:

[GitHub] [hudi] jonvex commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
jonvex commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251341306 ## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala: ## @@ -43,23 +43,29 @@ object HoodieAnalysis extends

[GitHub] [hudi] jonvex commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
jonvex commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251340425 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoKeyGenerator.scala: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache

[GitHub] [hudi] hudi-bot commented on pull request #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9117: URL: https://github.com/apache/hudi/pull/9117#issuecomment-1619260606 ## CI report: * 1e58d179d02fd489ff0b6404b6c270c0589a95d7 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1619260402 ## CI report: * 7142fb46cef77575be4346fa0a9cf2fb7bee03b1 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9117: URL: https://github.com/apache/hudi/pull/9117#issuecomment-1619256505 ## CI report: * 1e58d179d02fd489ff0b6404b6c270c0589a95d7 Azure:

[GitHub] [hudi] jonvex commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
jonvex commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251337496 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCreateRecordUtils.scala: ## @@ -206,27 +222,29 @@ object HoodieCreateRecordUtils { }

[GitHub] [hudi] jonvex commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
jonvex commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251336316 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieInternalProxyIndex.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251329643 ## hudi-spark-datasource/hudi-spark3.0.x/src/main/scala/org/apache/spark/sql/catalyst/analysis/HoodieSpark30Analysis.scala: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251327647 ## hudi-spark-datasource/hudi-spark3.2plus-common/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieSpark32PlusAnalysis.scala: ## @@ -128,9 +131,135 @@ case class

[GitHub] [hudi] hudi-bot commented on pull request #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9117: URL: https://github.com/apache/hudi/pull/9117#issuecomment-1619229336 ## CI report: * 1e58d179d02fd489ff0b6404b6c270c0589a95d7 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9108: URL: https://github.com/apache/hudi/pull/9108#issuecomment-1619229269 ## CI report: * 7f7dae8012b51f42fe9452e1ecc555b524a7dc6b Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9083: URL: https://github.com/apache/hudi/pull/9083#issuecomment-1619229040 ## CI report: * 3a0bfb88049cf2c0f8afe5c925dbd76fa6f7cd89 UNKNOWN * 575c165468bcf8a4650935ab4020975a8d75e73e Azure:

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251313925 ## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala: ## @@ -298,26 +333,34 @@ case class

[GitHub] [hudi] hudi-bot commented on pull request #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9117: URL: https://github.com/apache/hudi/pull/9117#issuecomment-1619223964 ## CI report: * 1e58d179d02fd489ff0b6404b6c270c0589a95d7 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run the

[GitHub] [hudi] hudi-bot commented on pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9083: URL: https://github.com/apache/hudi/pull/9083#issuecomment-1619223779 ## CI report: * 3a0bfb88049cf2c0f8afe5c925dbd76fa6f7cd89 UNKNOWN * 575c165468bcf8a4650935ab4020975a8d75e73e Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9083: URL: https://github.com/apache/hudi/pull/9083#issuecomment-1619217778 ## CI report: * 3a0bfb88049cf2c0f8afe5c925dbd76fa6f7cd89 UNKNOWN * 575c165468bcf8a4650935ab4020975a8d75e73e Azure:

[GitHub] [hudi] nsivabalan opened a new pull request, #9117: [HUDI-6437] Fixing/optimizing record updates to RLI

2023-07-03 Thread via GitHub
nsivabalan opened a new pull request, #9117: URL: https://github.com/apache/hudi/pull/9117 ### Change Logs Optimizing updates to RLI partition in MDT when Update Partition path = false and few minor fixes. ### Impact Optimizing updates to RLI partition in MDT when

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251290919 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieInternalProxyIndex.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation

[hudi] branch master updated: [HUDI-6467] Fix deletes handling in rli when partition path is updated (#9114)

2023-07-03 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new c5b5953b0b8 [HUDI-6467] Fix deletes handling

[GitHub] [hudi] nsivabalan merged pull request #9114: [HUDI-6467] Fix deletes handling in rli when partition path is updated

2023-07-03 Thread via GitHub
nsivabalan merged PR #9114: URL: https://github.com/apache/hudi/pull/9114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hudi] hudi-bot commented on pull request #9114: [HUDI-6467] Fix deletes handling in rli when partition path is updated

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9114: URL: https://github.com/apache/hudi/pull/9114#issuecomment-1619183340 ## CI report: * 07601ef7fa5c3b16846e5f973c9f1845c3d6 Azure:

[GitHub] [hudi] yihua commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
yihua commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251283969 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieInternalProxyIndex.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hudi] hudi-bot commented on pull request #9116: [HUDI-6470] Add spark sql conf in AlterTableCommand

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9116: URL: https://github.com/apache/hudi/pull/9116#issuecomment-1619119598 ## CI report: * 80b8747dfec3e4cac7719796a46e52e9846081f5 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1619119227 ## CI report: * 7142fb46cef77575be4346fa0a9cf2fb7bee03b1 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9108: URL: https://github.com/apache/hudi/pull/9108#issuecomment-1619061262 ## CI report: * 298590e894d6eb2a39c4eb523b0b8e09903f9635 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9083: URL: https://github.com/apache/hudi/pull/9083#issuecomment-1619061131 ## CI report: * 3a0bfb88049cf2c0f8afe5c925dbd76fa6f7cd89 UNKNOWN * 633f78cab4bdf225125bd028cf4a2b141844ef09 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9083: URL: https://github.com/apache/hudi/pull/9083#issuecomment-1619053605 ## CI report: * 3a0bfb88049cf2c0f8afe5c925dbd76fa6f7cd89 UNKNOWN * 633f78cab4bdf225125bd028cf4a2b141844ef09 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9108: URL: https://github.com/apache/hudi/pull/9108#issuecomment-1619053709 ## CI report: * 3fbcdb8f1f2c7504b8564ead1d065c1d862f83fb Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9083: URL: https://github.com/apache/hudi/pull/9083#issuecomment-1619046246 ## CI report: * 3a0bfb88049cf2c0f8afe5c925dbd76fa6f7cd89 UNKNOWN * 633f78cab4bdf225125bd028cf4a2b141844ef09 Azure:

[GitHub] [hudi] yihua commented on a diff in pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
yihua commented on code in PR #9108: URL: https://github.com/apache/hudi/pull/9108#discussion_r1251218379 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/callback/TestThrowExceptionCallback.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (HUDI-6473) RLI and update partition path follow up

2023-07-03 Thread sivabalan narayanan (Jira)
sivabalan narayanan created HUDI-6473: - Summary: RLI and update partition path follow up Key: HUDI-6473 URL: https://issues.apache.org/jira/browse/HUDI-6473 Project: Apache Hudi Issue

[jira] [Created] (HUDI-6472) Spark Sql Merge Into does not ignore case

2023-07-03 Thread Jonathan Vexler (Jira)
Jonathan Vexler created HUDI-6472: - Summary: Spark Sql Merge Into does not ignore case Key: HUDI-6472 URL: https://issues.apache.org/jira/browse/HUDI-6472 Project: Apache Hudi Issue Type:

[GitHub] [hudi] hudi-bot commented on pull request #9114: [HUDI-6467] Fix deletes handling in rli when partition path is updated

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9114: URL: https://github.com/apache/hudi/pull/9114#issuecomment-1618997883 ## CI report: * 02a297b2e0cdfd364b2dccffdad4ff6df9adf564 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9108: URL: https://github.com/apache/hudi/pull/9108#issuecomment-1618997748 ## CI report: * 3fbcdb8f1f2c7504b8564ead1d065c1d862f83fb Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9114: [HUDI-6467] Fix deletes handling in rli when partition path is updated

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9114: URL: https://github.com/apache/hudi/pull/9114#issuecomment-1618988954 ## CI report: * 02a297b2e0cdfd364b2dccffdad4ff6df9adf564 Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9108: URL: https://github.com/apache/hudi/pull/9108#issuecomment-1618988868 ## CI report: * 3fbcdb8f1f2c7504b8564ead1d065c1d862f83fb Azure:

[GitHub] [hudi] hudi-bot commented on pull request #9115: [HUDI-6469] Revert HUDI-6311

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9115: URL: https://github.com/apache/hudi/pull/9115#issuecomment-1618981905 ## CI report: * 2a046240c1e7c0a18f9b57c0845298ea65b72951 Azure:

[GitHub] [hudi] yihua commented on a diff in pull request #9114: [HUDI-6467] Fix deletes handling in rli when partition path is updated

2023-07-03 Thread via GitHub
yihua commented on code in PR #9114: URL: https://github.com/apache/hudi/pull/9114#discussion_r1251176617 ## hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/functional/TestGlobalIndexEnableUpdatePartitions.java: ## @@ -65,8 +65,8 @@ private static Stream

[GitHub] [hudi] yihua commented on a diff in pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
yihua commented on code in PR #9108: URL: https://github.com/apache/hudi/pull/9108#discussion_r1251167929 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/callback/TestThrowExceptionCallback.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] [hudi] yihua commented on a diff in pull request #9108: [HUDI-6462] Add Hudi client init callback interface

2023-07-03 Thread via GitHub
yihua commented on code in PR #9108: URL: https://github.com/apache/hudi/pull/9108#discussion_r1251167572 ## hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/callback/TestChangeConfigInitCallback.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software

[GitHub] [hudi] hudi-bot commented on pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

2023-07-03 Thread via GitHub
hudi-bot commented on PR #9038: URL: https://github.com/apache/hudi/pull/9038#issuecomment-1618936154 ## CI report: * a65a29c0cf1c8feb9f39e168ba80c99ebcae1c5d UNKNOWN * 33e1774f08f40abfb216f0e8f8894f6000b2ee3e Azure:

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1618935992 ## CI report: * 85d6a980287b105a661025ed5aa45da319ad52a1 Azure:

[jira] [Updated] (HUDI-6471) Global index not fully supported for spark sql merge into

2023-07-03 Thread Jonathan Vexler (Jira)
[ https://issues.apache.org/jira/browse/HUDI-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Vexler updated HUDI-6471: -- Description: With the changes to merge into introduced in HUDI-6464, the config  h4.

[GitHub] [hudi] jonvex commented on a diff in pull request #9083: [HUDI-6464] Spark SQL Merge Into for pkless tables

2023-07-03 Thread via GitHub
jonvex commented on code in PR #9083: URL: https://github.com/apache/hudi/pull/9083#discussion_r1251149304 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieInternalProxyIndex.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (HUDI-6471) Global index not fully supported for spark sql merge into

2023-07-03 Thread Jonathan Vexler (Jira)
Jonathan Vexler created HUDI-6471: - Summary: Global index not fully supported for spark sql merge into Key: HUDI-6471 URL: https://issues.apache.org/jira/browse/HUDI-6471 Project: Apache Hudi

[GitHub] [hudi] hudi-bot commented on pull request #8978: [HUDI-6315] Optimize DELETE codepath to use meta fields instead of key generation and index lookup

2023-07-03 Thread via GitHub
hudi-bot commented on PR #8978: URL: https://github.com/apache/hudi/pull/8978#issuecomment-1618926995 ## CI report: * 85d6a980287b105a661025ed5aa45da319ad52a1 Azure:

[GitHub] [hudi] ad1happy2go commented on issue #7600: Hoodie clean is not deleting old files for MOR table

2023-07-03 Thread via GitHub
ad1happy2go commented on issue #7600: URL: https://github.com/apache/hudi/issues/7600#issuecomment-1618920425 @umehrot2 @koochiswathiTR Were you able to get it resolved with those configs. Please let us know in case you need any other help on this. -- This is an automated message from

[GitHub] [hudi] nsivabalan commented on a diff in pull request #9114: [HUDI-6467] Fix deletes handling in rli when partition path is updated

2023-07-03 Thread via GitHub
nsivabalan commented on code in PR #9114: URL: https://github.com/apache/hudi/pull/9114#discussion_r1251129461 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -1159,10 +1161,30 @@ protected boolean

  1   2   >