Re: [PR] [HUDI-5101] Adding spark-structured streaming test support via spark-submit job [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #7074: URL: https://github.com/apache/hudi/pull/7074#issuecomment-1986781329 ## CI report: * 8071a25549b3df02d24836d1d76ee05fcd4888c9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2285

Re: [PR] [HUDI-6378] allow to delete twice for an empty table [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #8967: URL: https://github.com/apache/hudi/pull/8967#issuecomment-1986779195 ## CI report: * 96b14a14446288bae5070db221f8d0ea04e98d8f UNKNOWN * 8de8962b2bebdf980a1c53b67e055747eb3c5a0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

Re: [PR] [HUDI-6043] Metadata Table should use default values for Compaction preserveCommitMetadata field [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #8393: URL: https://github.com/apache/hudi/pull/8393#issuecomment-1986779021 ## CI report: * 9b2f869aa656f8e8da14da382834e9f4a8750c7e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1616

Re: [PR] [HUDI-6378] allow to delete twice for an empty table [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #8967: URL: https://github.com/apache/hudi/pull/8967#issuecomment-1986777158 ## CI report: * 96b14a14446288bae5070db221f8d0ea04e98d8f UNKNOWN * 8de8962b2bebdf980a1c53b67e055747eb3c5a0e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2

Re: [PR] [HUDI-6043] Metadata Table should use default values for Compaction preserveCommitMetadata field [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #8393: URL: https://github.com/apache/hudi/pull/8393#issuecomment-1986776752 ## CI report: * 9b2f869aa656f8e8da14da382834e9f4a8750c7e Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1616

Re: [PR] [HUDI-6415] Prevent create mor table without precombine spark sql [hudi]

2024-03-08 Thread via GitHub
yihua commented on PR #9031: URL: https://github.com/apache/hudi/pull/9031#issuecomment-1986773421 @jonvex is this PR still needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [HUDI-5973] Add cachedSchema per batch, fix idempotency with getSourceSchema calls [hudi]

2024-03-08 Thread via GitHub
yihua commented on PR #8246: URL: https://github.com/apache/hudi/pull/8246#issuecomment-1986761165 #10261 is landed. Closing this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [HUDI-5973] Add cachedSchema per batch, fix idempotency with getSourceSchema calls [hudi]

2024-03-08 Thread via GitHub
yihua closed pull request #8246: [HUDI-5973] Add cachedSchema per batch, fix idempotency with getSourceSchema calls URL: https://github.com/apache/hudi/pull/8246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [HUDI-5688] Fixing read of an empty table [hudi]

2024-03-08 Thread via GitHub
yihua closed pull request #8174: [HUDI-5688] Fixing read of an empty table URL: https://github.com/apache/hudi/pull/8174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [HUDI-5688] Fixing read of an empty table [hudi]

2024-03-08 Thread via GitHub
yihua commented on PR #8174: URL: https://github.com/apache/hudi/pull/8174#issuecomment-1986761091 Reading an empty table is fixed in #10689 and the same test is added in that PR. Closing this one. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Assigned] (HUDI-7494) multi writer sync partition to glue will missing some partitions

2024-03-08 Thread nicolas paris (Jira)
[ https://issues.apache.org/jira/browse/HUDI-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas paris reassigned HUDI-7494: --- Assignee: nicolas paris > multi writer sync partition to glue will missing some partitions >

Re: [PR] [HUDI-5101] Adding spark-structured streaming test support via spark-submit job [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #7074: URL: https://github.com/apache/hudi/pull/7074#issuecomment-1986750576 ## CI report: * 6aae3ad023fa21c0d19662c632139f89a7263e0f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1289

Re: [PR] [HUDI-5101] Adding spark-structured streaming test support via spark-submit job [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #7074: URL: https://github.com/apache/hudi/pull/7074#issuecomment-1986749220 ## CI report: * 6aae3ad023fa21c0d19662c632139f89a7263e0f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1289

Re: [PR] [HUDI-53] Record Level Index [hudi]

2024-03-08 Thread via GitHub
yihua commented on PR #7429: URL: https://github.com/apache/hudi/pull/7429#issuecomment-1986746064 Closing this as the Record Level Index is landed in #8758 and included in Hudi 0.14.0 release. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [HUDI-53] Record Level Index [hudi]

2024-03-08 Thread via GitHub
yihua closed pull request #7429: [HUDI-53] Record Level Index URL: https://github.com/apache/hudi/pull/7429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [HUDI-7008] Fixing usage of Kafka Avro deserializer w/ debezium sources [hudi]

2024-03-08 Thread via GitHub
yihua commented on code in PR #7225: URL: https://github.com/apache/hudi/pull/7225#discussion_r1518486609 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/debezium/DebeziumSource.java: ## @@ -90,6 +94,12 @@ public DebeziumSource(TypedProperties props, JavaSpark

Re: [PR] [HUDI-5001] column name sanitization for row source [hudi]

2024-03-08 Thread via GitHub
yihua commented on PR #6905: URL: https://github.com/apache/hudi/pull/6905#issuecomment-1986736518 @jonvex Do you think if there is still value to add this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

(hudi) branch master updated: [MINOR] Code clean for time generator (#10842)

2024-03-08 Thread yihua
This is an automated email from the ASF dual-hosted git repository. yihua pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new ab28ee6b978 [MINOR] Code clean for time generator (

Re: [PR] [MINOR] Code clean for time generator [hudi]

2024-03-08 Thread via GitHub
yihua merged PR #10842: URL: https://github.com/apache/hudi/pull/10842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.o

Re: [PR] [MINOR] Code clean for time generator [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10842: URL: https://github.com/apache/hudi/pull/10842#issuecomment-1986700305 ## CI report: * ee8fb60b9f0a958ad532e166ff12224734cf3e31 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [MINOR] Code clean for time generator [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10842: URL: https://github.com/apache/hudi/pull/10842#issuecomment-1986680353 ## CI report: * ee8fb60b9f0a958ad532e166ff12224734cf3e31 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [MINOR] Code clean for time generator [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10842: URL: https://github.com/apache/hudi/pull/10842#issuecomment-1986677733 ## CI report: * ee8fb60b9f0a958ad532e166ff12224734cf3e31 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run th

Re: [PR] [MINOR] Code clean for time generator [hudi]

2024-03-08 Thread via GitHub
danny0405 commented on PR #10842: URL: https://github.com/apache/hudi/pull/10842#issuecomment-1986665827 @codope Would you mind to take a look at this minor change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] [MINOR] Code clean for time generator [hudi]

2024-03-08 Thread via GitHub
danny0405 opened a new pull request, #10842: URL: https://github.com/apache/hudi/pull/10842 ### Change Logs Just a minor code clean. ### Impact no impact ### Risk level (write none, low medium or high below) low ### Documentation Update no upda

Re: [PR] [HUDI-7492] fix the issue of incorrect keygenerator specification when creating m… [hudi]

2024-03-08 Thread via GitHub
danny0405 commented on PR #10840: URL: https://github.com/apache/hudi/pull/10840#issuecomment-1986649237 There is a test failure: https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=22849&view=logs&j=7601efb9-4019-552e-11ba-eb31b66593b2&t=9688f101-287d-53f4-2a80-87

Re: [PR] [HUDI-7457] Remove runtime shutdown hook from HoodieLogFormatWriter [hudi]

2024-03-08 Thread via GitHub
danny0405 commented on PR #10789: URL: https://github.com/apache/hudi/pull/10789#issuecomment-1986644567 > I will create a PR for this fix It's great if you already have a fix by removing these annoy shudown hooks. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [HUDI-7494]: multi writer sync partition to glue will missing some partitions [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10841: URL: https://github.com/apache/hudi/pull/10841#issuecomment-1986564580 ## CI report: * 178a4ef27cbdcbc48fc4a0126b9f4ccc91dd2e3c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7457] Remove runtime shutdown hook from HoodieLogFormatWriter [hudi]

2024-03-08 Thread via GitHub
nbalajee commented on code in PR #10789: URL: https://github.com/apache/hudi/pull/10789#discussion_r1518400672 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java: ## @@ -62,15 +61,14 @@ public class HoodieLogFormatWriter implements HoodieLo

Re: [PR] [HUDI-7457] Remove runtime shutdown hook from HoodieLogFormatWriter [hudi]

2024-03-08 Thread via GitHub
nbalajee commented on PR #10789: URL: https://github.com/apache/hudi/pull/10789#issuecomment-1986539574 When HoodieLogFormatter is writing/appending to a log file, if the container were to crash, HDFS NN would retain the lease on the file, until expiration. Any further appends to the log f

Re: [PR] [HUDI-7494]: multi writer sync partition to glue will missing some partitions [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10841: URL: https://github.com/apache/hudi/pull/10841#issuecomment-1986524053 ## CI report: * 178a4ef27cbdcbc48fc4a0126b9f4ccc91dd2e3c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7494]: multi writer sync partition to glue will missing some partitions [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10841: URL: https://github.com/apache/hudi/pull/10841#issuecomment-1986517813 ## CI report: * 178a4ef27cbdcbc48fc4a0126b9f4ccc91dd2e3c UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run th

[jira] [Updated] (HUDI-7494) multi writer sync partition to glue will missing some partitions

2024-03-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-7494: - Labels: pull-request-available (was: ) > multi writer sync partition to glue will missing some pa

[PR] [HUDI-7494]: multi writer sync partition to glue will missing some partitions [hudi]

2024-03-08 Thread via GitHub
parisni opened a new pull request, #10841: URL: https://github.com/apache/hudi/pull/10841 Glue will miss some partitions when multiple writers are involved. This is related to #8745 and it fixes #8634 ### Change Logs _Describe context and summary for this change. Highlight

Re: [I] [SUPPORT] java.lang.NoClassDefFoundError: org/apache/hudi/com/fasterxml/jackson/module/scala/DefaultScalaModule$ when doing an Incremental CDC Query in 0.14.1 [hudi]

2024-03-08 Thread via GitHub
Tyler-Rendina commented on issue #10590: URL: https://github.com/apache/hudi/issues/10590#issuecomment-1986499887 I have the properties set and it works with out of the box hudi versions. I think it's got something to do with the custom hudi build I created. Part of my bootstrap scri

[jira] [Updated] (HUDI-7494) multi writer sync partition to glue will missing some partitions

2024-03-08 Thread nicolas paris (Jira)
[ https://issues.apache.org/jira/browse/HUDI-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas paris updated HUDI-7494: Issue Type: Bug (was: Test) > multi writer sync partition to glue will missing some partitions > --

[jira] [Created] (HUDI-7494) multi writer sync partition to glue will missing some partitions

2024-03-08 Thread nicolas paris (Jira)
nicolas paris created HUDI-7494: --- Summary: multi writer sync partition to glue will missing some partitions Key: HUDI-7494 URL: https://issues.apache.org/jira/browse/HUDI-7494 Project: Apache Hudi

Re: [I] [SUPPORT] java.lang.NoClassDefFoundError: org/apache/hudi/com/fasterxml/jackson/module/scala/DefaultScalaModule$ when doing an Incremental CDC Query in 0.14.1 [hudi]

2024-03-08 Thread via GitHub
VitoMakarevich commented on issue #10590: URL: https://github.com/apache/hudi/issues/10590#issuecomment-1986489187 99% following these steps should fix issue for you https://docs.aws.amazon.com/emr/latest/ReleaseGuide/emr-spark-glue.html Namely Specify the value for hive.metastor

Re: [I] [SUPPORT] java.lang.NoClassDefFoundError: org/apache/hudi/com/fasterxml/jackson/module/scala/DefaultScalaModule$ when doing an Incremental CDC Query in 0.14.1 [hudi]

2024-03-08 Thread via GitHub
Tyler-Rendina commented on issue #10590: URL: https://github.com/apache/hudi/issues/10590#issuecomment-1986474921 I got it to compile, bootstrapped the spark bundle, hive sync, and aws bundle to emr. Now getting java.lang.ClassNotFoundException: Class com.amazonaws.glue.catalog.metastore.A

Re: [PR] [HUDI-7489] Avoid collecting WriteStatus to driver in row writer code path [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10836: URL: https://github.com/apache/hudi/pull/10836#issuecomment-1986434178 ## CI report: * 72a23b30a71d227e54ee63cf5684215fb3d2b2f5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [I] [SUPPORT] Performance Tuning: Slow stages (Building Workload Profile & Getting Small files from partitions) during Hudi Writes [hudi]

2024-03-08 Thread via GitHub
FFCMSouza commented on issue #2620: URL: https://github.com/apache/hudi/issues/2620#issuecomment-1986433311 I'm having the same problema on hudi version 0.14.1 and spark 3.4.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [HUDI-7489] Avoid collecting WriteStatus to driver in row writer code path [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10836: URL: https://github.com/apache/hudi/pull/10836#issuecomment-1986379651 ## CI report: * 743f394ba5d3b6f7ebe79d399fb8d11d50a26a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7489] Avoid collecting WriteStatus to driver in row writer code path [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10836: URL: https://github.com/apache/hudi/pull/10836#issuecomment-1986281572 ## CI report: * 743f394ba5d3b6f7ebe79d399fb8d11d50a26a3b Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

[jira] [Created] (HUDI-7493) Clean configuration for clean service

2024-03-08 Thread Lin Liu (Jira)
Lin Liu created HUDI-7493: - Summary: Clean configuration for clean service Key: HUDI-7493 URL: https://issues.apache.org/jira/browse/HUDI-7493 Project: Apache Hudi Issue Type: Bug Reporte

Re: [PR] [HUDI-7489] Avoid collecting WriteStatus to driver in row writer code path [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10836: URL: https://github.com/apache/hudi/pull/10836#issuecomment-1986269221 ## CI report: * 743f394ba5d3b6f7ebe79d399fb8d11d50a26a3b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7489] Avoid collecting WriteStatus to driver in row writer code path [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10836: URL: https://github.com/apache/hudi/pull/10836#issuecomment-1986212820 ## CI report: * 743f394ba5d3b6f7ebe79d399fb8d11d50a26a3b UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run th

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
the-other-tim-brown commented on code in PR #10676: URL: https://github.com/apache/hudi/pull/10676#discussion_r1518112714 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java: ## @@ -266,13 +266,19 @@ public static HoodieDefaultTimeline getTimel

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
nsivabalan commented on code in PR #10676: URL: https://github.com/apache/hudi/pull/10676#discussion_r1518111949 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java: ## @@ -266,13 +266,19 @@ public static HoodieDefaultTimeline getTimeline(Hoodi

Re: [PR] [HUDI-7402] Align MDT cleaner configs with the data table [hudi]

2024-03-08 Thread via GitHub
nsivabalan merged PR #10655: URL: https://github.com/apache/hudi/pull/10655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apa

Re: [PR] [DOCS] Updated inline and async process with more details [hudi]

2024-03-08 Thread via GitHub
nsivabalan merged PR #10664: URL: https://github.com/apache/hudi/pull/10664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apa

(hudi) branch master updated (2af83e2d9a8 -> dc349f5293f)

2024-03-08 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git from 2af83e2d9a8 [HUDI-7411] Meta sync should consider cleaner commit (#10676) add dc349f5293f [ENG-6316] Bump clean

(hudi) branch asf-site updated: [DOCS] Updated inline and async process with more details (#10664)

2024-03-08 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new 19734b58a62 [DOCS] Updated inline and async

Re: [PR] [MINOR] Add a test case on pending rollback commits when the instantsToRollback are deleted [hudi]

2024-03-08 Thread via GitHub
nsivabalan commented on PR #10648: URL: https://github.com/apache/hudi/pull/10648#issuecomment-1986180033 and check for CI failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [MINOR] Add a test case on pending rollback commits when the instantsToRollback are deleted [hudi]

2024-03-08 Thread via GitHub
nsivabalan commented on PR #10648: URL: https://github.com/apache/hudi/pull/10648#issuecomment-1986179579 hey @suryaprasanna : can you fill in details in PR desc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [HUDI-7457] Remove runtime shutdown hook from HoodieLogFormatWriter [hudi]

2024-03-08 Thread via GitHub
nsivabalan commented on code in PR #10789: URL: https://github.com/apache/hudi/pull/10789#discussion_r1518086776 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java: ## @@ -62,15 +61,14 @@ public class HoodieLogFormatWriter implements Hoodie

Re: [I] [SUPPORT] java.lang.NoClassDefFoundError: org/apache/hudi/com/fasterxml/jackson/module/scala/DefaultScalaModule$ when doing an Incremental CDC Query in 0.14.1 [hudi]

2024-03-08 Thread via GitHub
Tyler-Rendina commented on issue #10590: URL: https://github.com/apache/hudi/issues/10590#issuecomment-1986174927 Awesome thank you, I checked out release-0.14.1 and updated the pom.xml file, I attempted to build the jars with `mvn clean package -DskipTests -Dspark3.3 -Dscala-2.12`, but it

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
the-other-tim-brown commented on code in PR #10676: URL: https://github.com/apache/hudi/pull/10676#discussion_r1518082368 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java: ## @@ -266,13 +266,19 @@ public static HoodieDefaultTimeline getTimel

Re: [PR] [HUDI-7457] Remove runtime shutdown hook from HoodieLogFormatWriter [hudi]

2024-03-08 Thread via GitHub
nsivabalan commented on PR #10789: URL: https://github.com/apache/hudi/pull/10789#issuecomment-1986166391 We are waiting to hear from @n3nash or @bvaradar to remember why we had to add the shutdown hook right? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [HUDI-7430] Fix empty schema issue for compactor [hudi]

2024-03-08 Thread via GitHub
nsivabalan commented on PR #10718: URL: https://github.com/apache/hudi/pull/10718#issuecomment-1986164578 we can close it then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [HUDI-7430] Fix empty schema issue for compactor [hudi]

2024-03-08 Thread via GitHub
nsivabalan closed pull request #10718: [HUDI-7430] Fix empty schema issue for compactor URL: https://github.com/apache/hudi/pull/10718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

(hudi) branch master updated: [HUDI-7411] Meta sync should consider cleaner commit (#10676)

2024-03-08 Thread sivabalan
This is an automated email from the ASF dual-hosted git repository. sivabalan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 2af83e2d9a8 [HUDI-7411] Meta sync should consid

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
nsivabalan merged PR #10676: URL: https://github.com/apache/hudi/pull/10676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apa

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10676: URL: https://github.com/apache/hudi/pull/10676#issuecomment-1985530919 ## CI report: * 2433556442faea975ed3c97a0abb0a8adf2610c8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7492] fix the issue of incorrect keygenerator specification when creating m… [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10840: URL: https://github.com/apache/hudi/pull/10840#issuecomment-1985521447 ## CI report: * 6d5e970a92b3ff9c4622187cf691358719722d5c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [I] [SUPPORT] Dataloss in FlinkCDC into Hudi without any exception or other infomation [hudi]

2024-03-08 Thread via GitHub
xuzifu666 commented on issue #10542: URL: https://github.com/apache/hudi/issues/10542#issuecomment-1985518679 > Can we revert the PR first or we get a quick fix with a configuration flag and by default it is disabled. OK I would revert the pr@danny0405 -- This is an automated mess

Re: [I] [SUPPORT] Dataloss in FlinkCDC into Hudi without any exception or other infomation [hudi]

2024-03-08 Thread via GitHub
danny0405 commented on issue #10542: URL: https://github.com/apache/hudi/issues/10542#issuecomment-1985503057 Can we revert the PR first or we get a quick fix with a configuration flag and by default it is disabled. -- This is an automated message from the Apache Git Service. To respond t

Re: [I] [SUPPORT] Dataloss in FlinkCDC into Hudi without any exception or other infomation [hudi]

2024-03-08 Thread via GitHub
danny0405 commented on issue #10542: URL: https://github.com/apache/hudi/issues/10542#issuecomment-1985501658 Hmm, I kind of figuring out why Flink get data loss here, Flink actually could flush multiple times for one log file in one commit, that would definitely cause data loss here, can w

Re: [PR] [HUDI-7492] fix the issue of incorrect keygenerator specification when creating m… [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10840: URL: https://github.com/apache/hudi/pull/10840#issuecomment-1985456378 ## CI report: * ad19525993057e8f0152067fdae1fab2ff57dedc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7492] fix the issue of incorrect keygenerator specification when creating m… [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10840: URL: https://github.com/apache/hudi/pull/10840#issuecomment-1985444922 ## CI report: * ad19525993057e8f0152067fdae1fab2ff57dedc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10676: URL: https://github.com/apache/hudi/pull/10676#issuecomment-1985444564 ## CI report: * d5f38b26cede75b6d07367cb661f0fd20256e3e0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10676: URL: https://github.com/apache/hudi/pull/10676#issuecomment-1985433841 ## CI report: * d5f38b26cede75b6d07367cb661f0fd20256e3e0 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7492] fix the issue of incorrect keygenerator specification when creating m… [hudi]

2024-03-08 Thread via GitHub
empcl commented on code in PR #10840: URL: https://github.com/apache/hudi/pull/10840#discussion_r1517530324 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/catalog/TestHoodieCatalog.java: ## @@ -258,6 +267,40 @@ public void testCreateTable() throws Except

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
codope commented on PR #10676: URL: https://github.com/apache/hudi/pull/10676#issuecomment-1985431672 @nsivabalan Added a test, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [HUDI-7411] Meta sync should consider cleaner commit [hudi]

2024-03-08 Thread via GitHub
codope commented on code in PR #10676: URL: https://github.com/apache/hudi/pull/10676#discussion_r1517529187 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/TimelineUtils.java: ## @@ -266,13 +266,19 @@ public static HoodieDefaultTimeline getTimeline(HoodieTab

Re: [PR] [HUDI-7470] Compaction completed not need write to mdt if mdt is disable [hudi]

2024-03-08 Thread via GitHub
xuzifu666 commented on code in PR #10801: URL: https://github.com/apache/hudi/pull/10801#discussion_r1517505749 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java: ## @@ -327,8 +327,10 @@ protected void completeCompaction(Hoo

Re: [PR] [HUDI-7470] Compaction completed not need write to mdt if mdt is disable [hudi]

2024-03-08 Thread via GitHub
xuzifu666 closed pull request #10801: [HUDI-7470] Compaction completed not need write to mdt if mdt is disable URL: https://github.com/apache/hudi/pull/10801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Closed] (HUDI-7476) Incremental loading for archived timeline

2024-03-08 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/HUDI-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen closed HUDI-7476. Resolution: Fixed Fixed via master branch: 58bc859b173a3648ff5f7f2042aaadf8281cac2c > Incremental loading f

(hudi) branch master updated: [HUDI-7476] Incremental loading for archived timeline (#10807)

2024-03-08 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 58bc859b173 [HUDI-7476] Incremental loading for

Re: [PR] [HUDI-7476] Incremental loading for archived timeline [hudi]

2024-03-08 Thread via GitHub
danny0405 merged PR #10807: URL: https://github.com/apache/hudi/pull/10807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apac

Re: [PR] [HUDI-7476] Incremental loading for archived timeline [hudi]

2024-03-08 Thread via GitHub
codope commented on code in PR #10807: URL: https://github.com/apache/hudi/pull/10807#discussion_r1517467044 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java: ## @@ -581,4 +596,43 @@ public HoodieDefaultTimeline mergeTimeline(HoodieD

(hudi) branch master updated: [HUDI-7491] Fixing handling null values of extra metadata in clean commit metadata (#10837)

2024-03-08 Thread codope
This is an automated email from the ASF dual-hosted git repository. codope pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new f308aa2b7b0 [HUDI-7491] Fixing handling null value

Re: [PR] [HUDI-7491] Fixing handling null values of extra metadata in clean commit metadata [hudi]

2024-03-08 Thread via GitHub
codope merged PR #10837: URL: https://github.com/apache/hudi/pull/10837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.

Re: [PR] [HUDI-7491] Fixing handling null values of extra metadata in clean commit metadata [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10837: URL: https://github.com/apache/hudi/pull/10837#issuecomment-1985332669 ## CI report: * b32d47808df9db9a2bda7f5b5d7e7fe2668aee3c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7492] fix the issue of incorrect keygenerator specification when creating m… [hudi]

2024-03-08 Thread via GitHub
danny0405 commented on code in PR #10840: URL: https://github.com/apache/hudi/pull/10840#discussion_r1517380255 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/catalog/TestHoodieCatalog.java: ## @@ -258,6 +267,40 @@ public void testCreateTable() throws Ex

Re: [PR] [HUDI-7492] fix the issue of incorrect keygenerator specification when creating m… [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10840: URL: https://github.com/apache/hudi/pull/10840#issuecomment-1985244847 ## CI report: * ad19525993057e8f0152067fdae1fab2ff57dedc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

Re: [PR] [HUDI-7489] Avoid collecting WriteStatus to driver in row writer code path [hudi]

2024-03-08 Thread via GitHub
hudi-bot commented on PR #10836: URL: https://github.com/apache/hudi/pull/10836#issuecomment-1985244800 ## CI report: * 72a23b30a71d227e54ee63cf5684215fb3d2b2f5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22

(hudi) branch asf-site updated: [DOCS] Updated powered by logo (#10839)

2024-03-08 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new 958f8869446 [DOCS] Updated powered by logo

Re: [PR] [DOCS] updated powered by logo [hudi]

2024-03-08 Thread via GitHub
danny0405 merged PR #10839: URL: https://github.com/apache/hudi/pull/10839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apac