[GitHub] [hudi] KnightChess commented on a diff in pull request #5825: [HUDI-4217] improve repeat init object in ExpressionPayload

2022-07-26 Thread GitBox
KnightChess commented on code in PR #5825: URL: https://github.com/apache/hudi/pull/5825#discussion_r930545666 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/payload/SqlTypedRecord.scala: ## @@ -17,27 +17,59 @@ package org.apache.s

[GitHub] [hudi] KnightChess commented on a diff in pull request #5825: [HUDI-4217] improve repeat init object in ExpressionPayload

2022-06-15 Thread GitBox
KnightChess commented on code in PR #5825: URL: https://github.com/apache/hudi/pull/5825#discussion_r897640266 ## hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala: ## @@ -318,5 +305,26 @@ object ExpressionPayload {

[GitHub] [hudi] KnightChess commented on a diff in pull request #5825: [HUDI-4217] improve repeat init object in ExpressionPayload

2022-06-14 Thread GitBox
KnightChess commented on code in PR #5825: URL: https://github.com/apache/hudi/pull/5825#discussion_r896835464 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/payload/SqlTypedRecord.scala: ## @@ -17,27 +17,59 @@ package org.apache.s

[GitHub] [hudi] KnightChess commented on a diff in pull request #5825: [HUDI-4217] improve repeat init object in ExpressionPayload

2022-06-09 Thread GitBox
KnightChess commented on code in PR #5825: URL: https://github.com/apache/hudi/pull/5825#discussion_r894120312 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/payload/SqlTypedRecord.scala: ## @@ -17,27 +17,59 @@ package org.apache.s