[GitHub] [hudi] Mathieu1124 commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-07-20 Thread GitBox
Mathieu1124 commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r457128988 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/common/HoodieEngineContext.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the

[GitHub] [hudi] Mathieu1124 commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-07-20 Thread GitBox
Mathieu1124 commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r457127004 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/common/HoodieEngineContext.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the

[GitHub] [hudi] Mathieu1124 commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-07-17 Thread GitBox
Mathieu1124 commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r456247721 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/storage/HoodieParquetWriter.java ## @@ -40,7 +39,7 @@ *

[GitHub] [hudi] Mathieu1124 commented on a change in pull request #1827: [HUDI-1089] Refactor hudi-client to support multi-engine

2020-07-17 Thread GitBox
Mathieu1124 commented on a change in pull request #1827: URL: https://github.com/apache/hudi/pull/1827#discussion_r456239385 ## File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/CompactionCommand.java ## @@ -593,8 +592,8 @@ public String repairCompaction(