[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-08-07 Thread GitBox
Mathieu1124 commented on pull request #1886: URL: https://github.com/apache/hudi/pull/1886#issuecomment-670453889 > > > > I was wondering can we move this implement to hudi-client module just like the way all the implementations of metrics does. > > I think we can move this

[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-08-06 Thread GitBox
Mathieu1124 commented on pull request #1886: URL: https://github.com/apache/hudi/pull/1886#issuecomment-670294044 @yanghua VC seems busy, do you have any other concern about this pr ? if it is ok, can we merge this first, and file a new pr if VC agree to move this to hudi-client :)

[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-08-05 Thread GitBox
Mathieu1124 commented on pull request #1886: URL: https://github.com/apache/hudi/pull/1886#issuecomment-669261486 Hi @vinothchandar, I was wondering can we move this implement to hudi-client module just like the way all the implementations of metrics does. put this implementation in

[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-08-02 Thread GitBox
Mathieu1124 commented on pull request #1886: URL: https://github.com/apache/hudi/pull/1886#issuecomment-667773074 > > > @Mathieu1124 Thanks for your contribution. Left some comments you can consider. Did you test this feature in your local? Yes, I tested it in my local, it

[GitHub] [hudi] Mathieu1124 commented on pull request #1886: [HUDI-1122]Introduce a kafka implementation of hoodie write commit ca…

2020-07-29 Thread GitBox
Mathieu1124 commented on pull request #1886: URL: https://github.com/apache/hudi/pull/1886#issuecomment-665661859 @yanghua please take a look when free This is an automated message from the Apache Git Service. To respond to