Mulavar commented on PR #8529:
URL: https://github.com/apache/hudi/pull/8529#issuecomment-1536007917
@danny0405 Hi danny, I've added the notion as you said, should I revert the
changed code and the unit test?
--
This is an automated message from the Apache Git Service.
To respond to the
Mulavar commented on PR #8529:
URL: https://github.com/apache/hudi/pull/8529#issuecomment-1524761536
> Add some notion like this:
>
> ```java
> CAUTION: the method requires that all the file slices must only
contain log files.
> ```
Copy that, and just to make sure, we
Mulavar commented on PR #8529:
URL: https://github.com/apache/hudi/pull/8529#issuecomment-1523235110
> > I agreed with you that IncrementalInputSplits has no error with this
patch, and I made a mistake about it. However I'm thinking about whether the
logic of this method itself is correct,
Mulavar commented on PR #8529:
URL: https://github.com/apache/hudi/pull/8529#issuecomment-1522869185
I agreed with you that IncrementalInputSplits has no error with this patch,
and I made a mistake about it.
However I'm thinking about whether the logic of this method itself is
correct,
Mulavar commented on PR #8529:
URL: https://github.com/apache/hudi/pull/8529#issuecomment-1518927233
> @codope Hi codope, I've added a unit test that covers the scenario for
AbstractTableFileSystemView, do I still need to add some tests for
IncrementalInputSplits?
@codope Hi codope,
Mulavar commented on PR #8529:
URL: https://github.com/apache/hudi/pull/8529#issuecomment-1517466078
@codope Hi codope, I've added a unit test that covers the scenario for
AbstractTableFileSystemView, do I still need to add some tests for
IncrementalInputSplits?
--
This is an automated
