[GitHub] [hudi] SteNicholas commented on a diff in pull request #9211: [HUDI-6540] Support failed writes clean policy for Flink

2023-07-30 Thread via GitHub
SteNicholas commented on code in PR #9211: URL: https://github.com/apache/hudi/pull/9211#discussion_r1278770434 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java: ## @@ -114,10 +116,28 @@ public void testCheckpointFails() throws Exc

[GitHub] [hudi] SteNicholas commented on a diff in pull request #9211: [HUDI-6540] Support failed writes clean policy for Flink

2023-07-25 Thread via GitHub
SteNicholas commented on code in PR #9211: URL: https://github.com/apache/hudi/pull/9211#discussion_r1274428725 ## hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java: ## @@ -114,10 +116,28 @@ public void testCheckpointFails() throws Exc

[GitHub] [hudi] SteNicholas commented on a diff in pull request #9211: [HUDI-6540] Support failed writes clean policy for Flink

2023-07-25 Thread via GitHub
SteNicholas commented on code in PR #9211: URL: https://github.com/apache/hudi/pull/9211#discussion_r1273233193 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSink.java: ## @@ -95,6 +95,9 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Co