[GitHub] [hudi] YannByron commented on a diff in pull request #7042: [HUDI-5082] Improve the cdc log file name format

2022-11-04 Thread GitBox
YannByron commented on code in PR #7042: URL: https://github.com/apache/hudi/pull/7042#discussion_r1014582854 ## hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java: ## @@ -355,11 +356,19 @@ public static String createNewFileId(String idPfx, int id) { return S

[GitHub] [hudi] YannByron commented on a diff in pull request #7042: [HUDI-5082] Improve the cdc log file name format

2022-11-02 Thread GitBox
YannByron commented on code in PR #7042: URL: https://github.com/apache/hudi/pull/7042#discussion_r1012550114 ## hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java: ## @@ -79,7 +80,7 @@ public class FSUtils { private static final Logger LOG = LogManager.getLogge

[GitHub] [hudi] YannByron commented on a diff in pull request #7042: [HUDI-5082] Improve the cdc log file name format

2022-10-28 Thread GitBox
YannByron commented on code in PR #7042: URL: https://github.com/apache/hudi/pull/7042#discussion_r1007877496 ## hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java: ## @@ -79,7 +80,7 @@ public class FSUtils { private static final Logger LOG = LogManager.getLogge