[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-25 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r929165914 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/BuiltinKeyGenerator.java: ## @@ -66,12 +66,26 @@ protected BuiltinKeyGenerator(TypedProperties

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-19 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r925029410 ## hudi-common/src/main/java/org/apache/hudi/common/util/HoodieTimer.java: ## @@ -30,7 +30,17 @@ public class HoodieTimer { // Ordered stack of TimeInfo's to m

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-19 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r925026537 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache So

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-19 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r925024764 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache So

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-19 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r924811553 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/model/HoodieInternalRow.java: ## @@ -24,31 +24,66 @@ import org.apache.spark.sql.catalyst.util

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-15 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r922484376 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/NonpartitionedKeyGenerator.java: ## @@ -51,6 +61,24 @@ public String getRecordKey(GenericRecord

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-15 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r922484121 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/BuiltinKeyGenerator.java: ## @@ -66,12 +66,26 @@ protected BuiltinKeyGenerator(TypedProperties

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-15 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r922483854 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache So

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-15 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r922483453 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache So

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5470: [HUDI-3993] Replacing UDF in Bulk Insert w/ RDD transformation

2022-07-15 Thread GitBox
alexeykudinkin commented on code in PR #5470: URL: https://github.com/apache/hudi/pull/5470#discussion_r922483301 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache So