[GitHub] [hudi] boneanxs commented on a diff in pull request #6468: [HUDI-4731] Shutdown CloudWatch reporter when query completes

2023-07-03 Thread via GitHub
boneanxs commented on code in PR #6468: URL: https://github.com/apache/hudi/pull/6468#discussion_r1250340527 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/Metrics.java: ## @@ -53,14 +53,15 @@ private Metrics(HoodieWriteConfig metricConfig) { }

[GitHub] [hudi] boneanxs commented on a diff in pull request #6468: [HUDI-4731] Shutdown CloudWatch reporter when query completes

2023-07-03 Thread via GitHub
boneanxs commented on code in PR #6468: URL: https://github.com/apache/hudi/pull/6468#discussion_r1250435457 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -594,6 +595,10 @@ object HoodieSparkSqlWriter {

[GitHub] [hudi] boneanxs commented on a diff in pull request #6468: [HUDI-4731] Shutdown CloudWatch reporter when query completes

2023-07-03 Thread via GitHub
boneanxs commented on code in PR #6468: URL: https://github.com/apache/hudi/pull/6468#discussion_r1250338414 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -594,6 +595,10 @@ object HoodieSparkSqlWriter {