[GitHub] [hudi] bvaradar commented on a diff in pull request #8376: [HUDI-6019] support config minPartitions when reading from kafka

2023-04-26 Thread via GitHub
bvaradar commented on code in PR #8376: URL: https://github.com/apache/hudi/pull/8376#discussion_r1178488660 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestCheckpointUtils.java: ## @@ -57,63 +58,191 @@ public void testStringToOffsets() { @Test

[GitHub] [hudi] bvaradar commented on a diff in pull request #8376: [HUDI-6019] support config minPartitions when reading from kafka

2023-04-25 Thread via GitHub
bvaradar commented on code in PR #8376: URL: https://github.com/apache/hudi/pull/8376#discussion_r1176966023 ## hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestCheckpointUtils.java: ## @@ -57,63 +58,191 @@ public void testStringToOffsets() { @Test

[GitHub] [hudi] bvaradar commented on a diff in pull request #8376: [HUDI-6019] support config minPartitions when reading from kafka

2023-04-25 Thread via GitHub
bvaradar commented on code in PR #8376: URL: https://github.com/apache/hudi/pull/8376#discussion_r1176055401 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java: ## @@ -107,48 +112,119 @@ public static String offsetsToStr(OffsetRange[]

[GitHub] [hudi] bvaradar commented on a diff in pull request #8376: [HUDI-6019] support config minPartitions when reading from kafka

2023-04-15 Thread via GitHub
bvaradar commented on code in PR #8376: URL: https://github.com/apache/hudi/pull/8376#discussion_r1167635549 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java: ## @@ -148,9 +166,58 @@ public static OffsetRange[]

[GitHub] [hudi] bvaradar commented on a diff in pull request #8376: [HUDI-6019] support config minPartitions when reading from kafka

2023-04-13 Thread via GitHub
bvaradar commented on code in PR #8376: URL: https://github.com/apache/hudi/pull/8376#discussion_r1165017510 ## hudi-utilities/src/main/java/org/apache/hudi/utilities/config/KafkaSourceConfig.java: ## @@ -63,6 +63,17 @@ public class KafkaSourceConfig extends HoodieConfig {