[GitHub] [hudi] bvaradar commented on pull request #2084: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly

2020-09-12 Thread GitBox
bvaradar commented on pull request #2084: URL: https://github.com/apache/hudi/pull/2084#issuecomment-690863065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hudi] bvaradar commented on pull request #2084: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly

2020-09-12 Thread GitBox
bvaradar commented on pull request #2084: URL: https://github.com/apache/hudi/pull/2084#issuecomment-690863065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hudi] bvaradar commented on pull request #2084: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly

2020-09-11 Thread GitBox
bvaradar commented on pull request #2084: URL: https://github.com/apache/hudi/pull/2084#issuecomment-691324390 @tooptoop4 : The issue was still there. I added a testcase (testPreCombineWithDelete) which would fail with existing code but passes with this PR.

[GitHub] [hudi] bvaradar commented on pull request #2084: [HUDI-802] AWSDmsTransformer does not handle insert and delete of a row in a single batch correctly

2020-09-10 Thread GitBox
bvaradar commented on pull request #2084: URL: https://github.com/apache/hudi/pull/2084#issuecomment-690863065 @nsivabalan : Can you please review this. Thanks, Balaji.V This is an automated message from the