clownxc commented on PR #8472:
URL: https://github.com/apache/hudi/pull/8472#issuecomment-1537368074
> @clownxc : For failed records, we need to have them logged elsewhere and
so no need to deflate. For exception cases, the write status should be marked
as failure. So, I don't see any reaso
clownxc commented on PR #8472:
URL: https://github.com/apache/hudi/pull/8472#issuecomment-1537272950
According to the suggestion provided by @prashantwason , I did a test as
follows:
```java
WriteStatus status = new WriteStatus(true, 1.0);
String partitionPath =
HoodieTestD
clownxc commented on PR #8472:
URL: https://github.com/apache/hudi/pull/8472#issuecomment-1536940199
> @clownxc If I understand correctly, the memory savings are coming from
dropping the "data" part of the HoodieRecord? I noticed that HoodieRecord has
only 2 additional members - sealed (boo
clownxc commented on PR #8472:
URL: https://github.com/apache/hudi/pull/8472#issuecomment-1536939863
> this interesting optimization
this interesting optimization was reported by @nsivabalan and has not been
implemented for a long time
--
This is an automated message from the Apac
clownxc commented on PR #8472:
URL: https://github.com/apache/hudi/pull/8472#issuecomment-1536932897
> @clownxc If I understand correctly, the memory savings are coming from
dropping the "data" part of the HoodieRecord? I noticed that HoodieRecord has
only 2 additional members -
clownxc commented on PR #8472:
URL: https://github.com/apache/hudi/pull/8472#issuecomment-1518674030
> It is great if we can have numbers to illustrate the gains after the
patch, like the cost reduction for memory or something.
The memory occupied by WriteStatus after optimization is
clownxc commented on PR #8472:
URL: https://github.com/apache/hudi/pull/8472#issuecomment-1518672224
> It is great if we can have numbers to illustrate the gains after the
patch, like the cost reduction for memory or something.
I did a test based on your suggestion:
The number of H
clownxc commented on PR #8472:
URL: https://github.com/apache/hudi/pull/8472#issuecomment-1513964845
> It is great if we can have numbers to illustrate the gains after the
patch, like the cost reduction for memory or something.
I would be happy to do it.
--
This is an automated mes
