[GitHub] [hudi] codope commented on a diff in pull request #6662: [HUDI-4832] Fix drop partition meta sync

2022-09-16 Thread GitBox
codope commented on code in PR #6662: URL: https://github.com/apache/hudi/pull/6662#discussion_r972808396 ## hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieSyncClient.java: ## @@ -83,18 +87,24 @@ public boolean isBootstrap() { return metaClient.g

[GitHub] [hudi] codope commented on a diff in pull request #6662: [HUDI-4832] Fix drop partition meta sync

2022-09-16 Thread GitBox
codope commented on code in PR #6662: URL: https://github.com/apache/hudi/pull/6662#discussion_r972807725 ## hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieSyncClient.java: ## @@ -158,4 +171,23 @@ public List getPartitionEvents(List tablePartitions,

[GitHub] [hudi] codope commented on a diff in pull request #6662: [HUDI-4832] Fix drop partition meta sync

2022-09-15 Thread GitBox
codope commented on code in PR #6662: URL: https://github.com/apache/hudi/pull/6662#discussion_r971980886 ## hudi-sync/hudi-sync-common/src/main/java/org/apache/hudi/sync/common/HoodieSyncClient.java: ## @@ -83,18 +87,24 @@ public boolean isBootstrap() { return metaClient.g

[GitHub] [hudi] codope commented on a diff in pull request #6662: [HUDI-4832] Fix drop partition meta sync

2022-09-15 Thread GitBox
codope commented on code in PR #6662: URL: https://github.com/apache/hudi/pull/6662#discussion_r971978788 ## hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java: ## @@ -88,8 +88,8 @@ public class TestHiveSyncTool { private static final List SY