[GitHub] [hudi] codope commented on a diff in pull request #8076: [HUDI-5884] Support bulk_insert for insert_overwrite and insert_overwrite_table

2023-06-28 Thread via GitHub
codope commented on code in PR #8076: URL: https://github.com/apache/hudi/pull/8076#discussion_r1241710553 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieInternalConfig.java: ## @@ -37,6 +38,13 @@ public class HoodieInternalConfig extends

[GitHub] [hudi] codope commented on a diff in pull request #8076: [HUDI-5884] Support bulk_insert for insert_overwrite and insert_overwrite_table

2023-05-30 Thread via GitHub
codope commented on code in PR #8076: URL: https://github.com/apache/hudi/pull/8076#discussion_r1210061791 ## hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala: ## @@ -850,9 +854,12 @@ object HoodieSparkSqlWriter { if

[GitHub] [hudi] codope commented on a diff in pull request #8076: [HUDI-5884] Support bulk_insert for insert_overwrite and insert_overwrite_table

2023-05-30 Thread via GitHub
codope commented on code in PR #8076: URL: https://github.com/apache/hudi/pull/8076#discussion_r1210058563 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSparkDataSourceDAGExecution.scala: ## @@ -89,7 +89,7 @@ class

[GitHub] [hudi] codope commented on a diff in pull request #8076: [HUDI-5884] Support bulk_insert for insert_overwrite and insert_overwrite_table

2023-05-17 Thread via GitHub
codope commented on code in PR #8076: URL: https://github.com/apache/hudi/pull/8076#discussion_r1196024827 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestInsertTable.scala: ## @@ -599,138 +582,250 @@ class TestInsertTable extends

[GitHub] [hudi] codope commented on a diff in pull request #8076: [HUDI-5884] Support bulk_insert for insert_overwrite and insert_overwrite_table

2023-04-01 Thread via GitHub
codope commented on code in PR #8076: URL: https://github.com/apache/hudi/pull/8076#discussion_r1155233044 ## hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/SparkSingleFileSortExecutionStrategy.java: ## @@ -77,8 +78,11 @@ public