[GitHub] [hudi] danny0405 commented on a change in pull request #3285: [HUDI-1771] Propagate CDC format for hoodie

2021-07-28 Thread GitBox
danny0405 commented on a change in pull request #3285: URL: https://github.com/apache/hudi/pull/3285#discussion_r672894012 ## File path: hudi-flink/src/test/java/org/apache/hudi/table/format/TestInputFormat.java ## @@ -175,13 +176,32 @@ void testReadWithDeletes() throws Except

[GitHub] [hudi] danny0405 commented on a change in pull request #3285: [HUDI-1771] Propagate CDC format for hoodie

2021-07-21 Thread GitBox
danny0405 commented on a change in pull request #3285: URL: https://github.com/apache/hudi/pull/3285#discussion_r674454632 ## File path: hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java ## @@ -615,24 +621,25 @@ public boolean reachedEnd() t

[GitHub] [hudi] danny0405 commented on a change in pull request #3285: [HUDI-1771] Propagate CDC format for hoodie

2021-07-20 Thread GitBox
danny0405 commented on a change in pull request #3285: URL: https://github.com/apache/hudi/pull/3285#discussion_r672894012 ## File path: hudi-flink/src/test/java/org/apache/hudi/table/format/TestInputFormat.java ## @@ -175,13 +176,32 @@ void testReadWithDeletes() throws Except

[GitHub] [hudi] danny0405 commented on a change in pull request #3285: [HUDI-1771] Propagate CDC format for hoodie

2021-07-20 Thread GitBox
danny0405 commented on a change in pull request #3285: URL: https://github.com/apache/hudi/pull/3285#discussion_r672172626 ## File path: hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java ## @@ -624,6 +634,14 @@ public boolean reachedEnd() th

[GitHub] [hudi] danny0405 commented on a change in pull request #3285: [HUDI-1771] Propagate CDC format for hoodie

2021-07-20 Thread GitBox
danny0405 commented on a change in pull request #3285: URL: https://github.com/apache/hudi/pull/3285#discussion_r672894012 ## File path: hudi-flink/src/test/java/org/apache/hudi/table/format/TestInputFormat.java ## @@ -175,13 +176,32 @@ void testReadWithDeletes() throws Except

[GitHub] [hudi] danny0405 commented on a change in pull request #3285: [HUDI-1771] Propagate CDC format for hoodie

2021-07-19 Thread GitBox
danny0405 commented on a change in pull request #3285: URL: https://github.com/apache/hudi/pull/3285#discussion_r672172626 ## File path: hudi-flink/src/main/java/org/apache/hudi/table/format/mor/MergeOnReadInputFormat.java ## @@ -624,6 +634,14 @@ public boolean reachedEnd() th

[GitHub] [hudi] danny0405 commented on a change in pull request #3285: [HUDI-1771] Propagate CDC format for hoodie

2021-07-18 Thread GitBox
danny0405 commented on a change in pull request #3285: URL: https://github.com/apache/hudi/pull/3285#discussion_r672027021 ## File path: hudi-flink/src/main/java/org/apache/hudi/table/format/FormatUtils.java ## @@ -44,6 +46,28 @@ private FormatUtils() { } + public sta