[GitHub] [hudi] danny0405 commented on a diff in pull request #5528: [HUDI-3336][HUDI-FLINK]Support custom hadoop config for flink

2022-05-12 Thread GitBox
danny0405 commented on code in PR #5528: URL: https://github.com/apache/hudi/pull/5528#discussion_r871015960 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java: ## @@ -708,32 +709,45 @@ private FlinkOptions() { // Prefix for Ho

[GitHub] [hudi] danny0405 commented on a diff in pull request #5528: [HUDI-3336][HUDI-FLINK]Support custom hadoop config for flink

2022-05-09 Thread GitBox
danny0405 commented on code in PR #5528: URL: https://github.com/apache/hudi/pull/5528#discussion_r868791833 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java: ## @@ -746,11 +760,11 @@ public static Configuration flatOptions(Config

[GitHub] [hudi] danny0405 commented on a diff in pull request #5528: [HUDI-3336][HUDI-FLINK]Support custom hadoop config for flink

2022-05-08 Thread GitBox
danny0405 commented on code in PR #5528: URL: https://github.com/apache/hudi/pull/5528#discussion_r867610262 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java: ## @@ -746,16 +762,18 @@ public static Configuration flatOptions(Config