[GitHub] [hudi] danny0405 commented on a diff in pull request #6697: [HUDI-3478] Implement CDC Write in Spark

danny0405 commented on code in PR #6697: URL: https://github.com/apache/hudi/pull/6697#discussion_r977092086 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieCDCLogger.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [hudi] danny0405 commented on a diff in pull request #6697: [HUDI-3478] Implement CDC Write in Spark

danny0405 commented on code in PR #6697: URL: https://github.com/apache/hudi/pull/6697#discussion_r977089707 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieSortedMergeHandle.java: ## @@ -93,13 +94,18 @@ public void write(GenericRecord oldRecord) {

[GitHub] [hudi] danny0405 commented on a diff in pull request #6697: [HUDI-3478] Implement CDC Write in Spark

danny0405 commented on code in PR #6697: URL: https://github.com/apache/hudi/pull/6697#discussion_r977087389 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java: ## @@ -292,6 +315,9 @@ protected void writeInsertRecord(HoodieRecord

[GitHub] [hudi] danny0405 commented on a diff in pull request #6697: [HUDI-3478] Implement CDC Write in Spark

danny0405 commented on code in PR #6697: URL: https://github.com/apache/hudi/pull/6697#discussion_r975967811 ## hudi-common/src/main/java/org/apache/hudi/common/table/cdc/HoodieCDCOperation.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [hudi] danny0405 commented on a diff in pull request #6697: [HUDI-3478] Implement CDC Write in Spark

danny0405 commented on code in PR #6697: URL: https://github.com/apache/hudi/pull/6697#discussion_r975967495 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java: ## @@ -360,8 +363,20 @@ private Pair>

[GitHub] [hudi] danny0405 commented on a diff in pull request #6697: [HUDI-3478] Implement CDC Write in Spark

danny0405 commented on code in PR #6697: URL: https://github.com/apache/hudi/pull/6697#discussion_r975966746 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieSortedMergeHandle.java: ## @@ -93,13 +94,18 @@ public void write(GenericRecord oldRecord) {

[GitHub] [hudi] danny0405 commented on a diff in pull request #6697: [HUDI-3478] Implement CDC Write in Spark

danny0405 commented on code in PR #6697: URL: https://github.com/apache/hudi/pull/6697#discussion_r975966610 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java: ## @@ -416,9 +444,12 @@ public List close() { fileWriter = null;

[GitHub] [hudi] danny0405 commented on a diff in pull request #6697: [HUDI-3478] Implement CDC Write in Spark

danny0405 commented on code in PR #6697: URL: https://github.com/apache/hudi/pull/6697#discussion_r975966347 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java: ## @@ -292,6 +315,9 @@ protected void writeInsertRecord(HoodieRecord