[GitHub] [hudi] danny0405 commented on a diff in pull request #7412: [HUDI-5353] Close file readers

2022-12-08 Thread GitBox
danny0405 commented on code in PR #7412: URL: https://github.com/apache/hudi/pull/7412#discussion_r1043976402 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringOperator.java: ## @@ -312,8 +321,8 @@ private Iterator readRecordsForGroupWi

[GitHub] [hudi] danny0405 commented on a diff in pull request #7412: [HUDI-5353] Close file readers

2022-12-08 Thread GitBox
danny0405 commented on code in PR #7412: URL: https://github.com/apache/hudi/pull/7412#discussion_r1043975952 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseMergeHelper.java: ## @@ -54,12 +55,15 @@ public abstract class BaseMergeHelper {