[GitHub] [hudi] danny0405 commented on a diff in pull request #8865: [HUDI-6306] dynamic catalog parameter

2023-06-06 Thread via GitHub
danny0405 commented on code in PR #8865: URL: https://github.com/apache/hudi/pull/8865#discussion_r1219224906 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -63,6 +63,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8865: [HUDI-6306] dynamic catalog parameter

2023-06-02 Thread via GitHub
danny0405 commented on code in PR #8865: URL: https://github.com/apache/hudi/pull/8865#discussion_r1214306618 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -63,6 +63,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8865: [HUDI-6306] dynamic catalog parameter

2023-06-02 Thread via GitHub
danny0405 commented on code in PR #8865: URL: https://github.com/apache/hudi/pull/8865#discussion_r1214039037 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -63,6 +63,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8865: [HUDI-6306] dynamic catalog parameter

2023-06-02 Thread via GitHub
danny0405 commented on code in PR #8865: URL: https://github.com/apache/hudi/pull/8865#discussion_r1213987386 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -63,6 +63,7 @@ public static

[GitHub] [hudi] danny0405 commented on a diff in pull request #8865: [HUDI-6306] dynamic catalog parameter

2023-06-01 Thread via GitHub
danny0405 commented on code in PR #8865: URL: https://github.com/apache/hudi/pull/8865#discussion_r1213858024 ## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/HadoopConfigurations.java: ## @@ -63,6 +63,7 @@ public static