[GitHub] [hudi] danny0405 commented on pull request #2581: [HUDI-1624] The state based index should bootstrap from existing base…

2021-02-22 Thread GitBox
danny0405 commented on pull request #2581: URL: https://github.com/apache/hudi/pull/2581#issuecomment-783951593 > Thanks @danny0405 for the base index patch, maybe there are some points to think about later,  Thanks for the new ideas if you have some and welcome the contribution ~

[GitHub] [hudi] danny0405 commented on pull request #2581: [HUDI-1624] The state based index should bootstrap from existing base…

2021-02-22 Thread GitBox
danny0405 commented on pull request #2581: URL: https://github.com/apache/hudi/pull/2581#issuecomment-783819474 > @danny0405 please check the CI? Should not be caused by this PR, re-trigger to run the tests again.

[GitHub] [hudi] danny0405 commented on pull request #2581: [HUDI-1624] The state based index should bootstrap from existing base…

2021-02-21 Thread GitBox
danny0405 commented on pull request #2581: URL: https://github.com/apache/hudi/pull/2581#issuecomment-783069192 > hi @danny0405 is it necessary to revert `this.bucketAssigner.reset();` to `BucketAssiginFunction#snapshotState` in this patch? : ) I will do it in another patch, thanks.