[GitHub] [hudi] danny0405 commented on pull request #3771: [HUDI-2402] Add Kerberos configuration options to Hive Sync

2022-08-17 Thread GitBox
danny0405 commented on PR #3771: URL: https://github.com/apache/hudi/pull/3771#issuecomment-1218927034 > @test-wangxiaoyu @codope Will the new version support this feature It should be, we have supported the option `hive_sync.conf.dir` to support custom hive configurations, you can de

[GitHub] [hudi] danny0405 commented on pull request #3771: [HUDI-2402] Add Kerberos configuration options to Hive Sync

2022-03-06 Thread GitBox
danny0405 commented on pull request #3771: URL: https://github.com/apache/hudi/pull/3771#issuecomment-1060242636 Seems still conflicts in the PR and the compile fails, can you fix that @test-wangxiaoyu ? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [hudi] danny0405 commented on pull request #3771: [HUDI-2402] Add Kerberos configuration options to Hive Sync

2022-03-02 Thread GitBox
danny0405 commented on pull request #3771: URL: https://github.com/apache/hudi/pull/3771#issuecomment-1057606418 @test-wangxiaoyu can you rebase the master code and force push again, i'm planning to review this PR again ~ the `commands`: `git fetch upstream master` `git rebase

[GitHub] [hudi] danny0405 commented on pull request #3771: [HUDI-2402] Add Kerberos configuration options to Hive Sync

2022-02-28 Thread GitBox
danny0405 commented on pull request #3771: URL: https://github.com/apache/hudi/pull/3771#issuecomment-1055017841 Hi @nsivabalan , many users report this issue so i mark this PR as blocker for release-0.11 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [hudi] danny0405 commented on pull request #3771: [HUDI-2402] Add Kerberos configuration options to Hive Sync

2021-10-29 Thread GitBox
danny0405 commented on pull request #3771: URL: https://github.com/apache/hudi/pull/3771#issuecomment-95483 > > > @test-wangxiaoyu The test you added is failing in CI. Can you please fix that? > > > CI failed because the variable name I named in test does not meet checkstyle check,