danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1330040294
Can you scrash and force push here. I didn't see the Azure CI history, let's
re-trigger it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1329995935
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1328419786
Reviewing now ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1326200670
> @danny0405 @xiarixiaoyao I reworked this PR. Could you pls take a look
>
> * Reverted all changes in InternalSchema
> * Reverted all changes in COWInputFormat and MORInputForms
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1318015825
> is it possible to fetch the original schema when the file was committed if
SE disabled?
There is no need to fetch the original schema if SE is disabled.
> Prepare int[] sele
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1317964637
Thanks, i go over the code quickly and find that there are 2 step that the
input format adapter to schema evolution:
1. fetch the original schema when the file was committed, read th
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1314919173
> Reader schema: the rest cases
What do you mean for the rest cases ? Isn't either schema evolution enabled
or disabled ?
> I don't like this approach and want to revert it
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1314822778
> Moreover, two schema approach still keeps coming in PRs
> https://github.com/apache/hudi/pull/7187/files
Isn't this is a prove that two schema may case bug in corner cases ?
Per
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1314818826
> >
[3981.patch.zip](https://github.com/apache/hudi/files/9977268/3981.patch.zip)
Thanks for the contribution, have reviewed some of the part, and left a local
patch here and some comment
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1314705991
> withInternalSchema(
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1309745375
[3981.patch.zip](https://github.com/apache/hudi/files/9977268/3981.patch.zip)
Thanks for the contribution, have reviewed some of the part, and left a
local patch here and some comments ~
danny0405 commented on PR #5830:
URL: https://github.com/apache/hudi/pull/5830#issuecomment-1308308066
@trushev Can you rebase the code again and i'm planning to review this code
again ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
12 matches
Mail list logo
