danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1525159081
> @danny0405 integrated your patch. Now I need to:
>
> * confirm the test breaks without the change
> * assert not throw npe
Yeah, that makes sense, I run the 2 tests locall
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1524476805
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1522728301
Thanks for the fix, I have reviewed and created a patch:
[6072.patch.zip](https://github.com/apache/hudi/files/11328753/6072.patch.zip)
You can rebase with the latest master, apply t
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1521663805
> @danny0405 added stuff for tests, bug cannot setup intellij to debug/run
tests locally (pain following the
https://hudi.apache.org/contribute/developer-setup)
Could we fix line 19
danny0405 commented on PR #8432:
URL: https://github.com/apache/hudi/pull/8432#issuecomment-1509606563
> Tests based on the spark datasource api (similar to the eg in the OP) or
do you have a better idea?
Either data sorurce api or sql should be fine.
--
This is an automated messag
